maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
docbrown/app/javascript/packs
History
Daniel Uber c5a90173bd
handle getElementById failures in articlePage (#16743) 
* when there is no div for it, don't render CommentSubscription

* Retrigger CI

* Retrigger CI

* don't write an error to the comment div if its gone

This fixes an issue seen in tests, where the page transitioned while
we were running the articlePage async handler, so the article-body
element was gone (can't access dataset of null), and the error handler
catch block tried to access the innerHTML of another getElementById.

* Use existing found element `root` when setting the error message

No need to find a new comment-subscription div to write the error to,
we already named the one we're interested in at the beginning of the function
2022-03-02 09:56:53 -06:00
..
admin Tweaks to the admin flash messages flow (#16582) 2022-02-16 10:07:21 +00:00
actionsPanel.js [deploy] New Feature: Mod Actions Panel (#7777) 2020-06-08 13:24:18 -04:00
admin.js Revise skip link behaviour (#15401) 2021-11-18 13:45:08 +00:00
analyticsArticle.js Updates ESLint rules to error on default imports (#12512) 2021-02-02 10:24:03 -05:00
analyticsDashboard.js add org analytics menu if user has organizations (#13995) 2021-06-23 14:35:23 +02:00
articleForm.jsx ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
articleModerationTools.js Only init mod tools if we're still on article page (#16733) 2022-03-01 16:59:28 +00:00
articlePage.jsx handle getElementById failures in articlePage (#16743) 2022-03-02 09:56:53 -06:00
base.jsx Reworked some webpack aliases as prework for #16174. (#16412) 2022-02-04 06:34:37 -05:00
colorPicker.jsx Use new ColorPicker in tag edit form (#16607) 2022-02-17 14:59:09 +00:00
commentDropdowns.js Admin-configurable display locale (#14620) 2021-09-28 11:04:35 -04:00
commentModPage.js Fix broken experience level button in moderation panel (#11797) 2020-12-08 10:20:35 +01:00
commentsDisplay.js Remove defer attributes from inline scripts - gist embeds (#13407) 2021-06-11 08:22:50 +01:00
confirmationEmail.js Creator Onboarding Confirmation Page (#14259) 2021-08-03 14:21:56 +02:00
contentDisplayPolicy.js Updates ESLint rules to error on default imports (#12512) 2021-02-02 10:24:03 -05:00
dashboardDropdowns.js Optimise dropdowns for accessibility: Dashboard and Manage pages (#13909) 2021-06-04 10:19:56 +01:00
dashboardTagsDisableUnchangedButtons.js [15 Minute Fix] Added the prefer-const eslint rule (#13098) 2021-03-23 16:29:56 -04:00
feedPreviewCards.jsx Add author profile preview cards to feed (#14340) 2021-08-13 10:55:43 +07:00
flagUserModal.jsx Modals fixes (#16310) 2022-01-27 16:24:23 +01:00
followButtons.js Favor using existing variable over re-parsing (#15995) 2022-01-10 12:33:31 -05:00
foremCreatorSignup.js RFC 190: Forem Creator Signup Page (#13875) 2021-08-24 10:33:26 +02:00
fullScreenModeControl.js Updates ESLint rules to error on default imports (#12512) 2021-02-02 10:24:03 -05:00
githubRepos.jsx Upgrade to Preact 10.4.4 (#8739) 2020-06-18 10:07:17 -04:00
homePage.jsx add temporary ahoy stats for tag sidebar clicks (#14688) 2021-09-09 08:31:27 -05:00
homePageFeed.jsx Fix pinned post not showing on feed tabs (#16574) 2022-02-17 15:49:26 +00:00
homePageFeedShortcuts.jsx Provide skip links: Tweak skip link style, refactor main area ID (#12694) 2021-02-17 10:15:31 +00:00
listingDashboard.jsx Upgrade to Preact 10.4.4 (#8739) 2020-06-18 10:07:17 -04:00
listingForm.jsx Updates ESLint rules to error on default imports (#12512) 2021-02-02 10:24:03 -05:00
listings.jsx Upgrade to Preact 10.4.4 (#8739) 2020-06-18 10:07:17 -04:00
modCenter.jsx Mod Center MVP 🎉 (#8744) 2020-06-23 14:58:16 -04:00
notificationPage.js Remove defer attributes from inline scripts - gist embeds (#13407) 2021-06-11 08:22:50 +01:00
notificationSubscriptionHandler.js improve keyboard accessibility of modals 12427 10610 (#12511) 2021-02-24 16:01:10 +00:00
Onboarding.jsx ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
onboardingRedirectCheck.jsx Remove Creator Onboarding Feature Flags from Codebase (#15982) 2022-01-31 11:30:43 -07:00
orgCreditsSelector.js Crayonsification of Listings form (#10429) 2020-09-30 09:14:48 +02:00
postCommentsPage.js Remove defer attributes from inline scripts - gist embeds (#13407) 2021-06-11 08:22:50 +01:00
profileDropdown.js Optimise dropdowns for accessibility - Profile page (#13916) 2021-06-14 12:31:23 +01:00
readingList.jsx Add Snackbar component on reading list (#15235) 2021-11-15 13:06:21 +02:00
responseTemplates.js [deploy] Finalize and add response templates feature (#7068) 2020-04-16 15:53:29 -04:00
runtimeBanner.jsx ForemMobile namespaced functions (#15212) 2021-11-23 15:25:29 -06:00
Search.jsx Crayons: Buttons vs CTAs (#15311) 2021-11-30 20:40:32 +01:00
searchParams.js Spelling (#15702) 2021-12-07 06:59:10 -07:00
sidebarWidget.jsx Updates ESLint rules to error on default imports (#12512) 2021-02-02 10:24:03 -05:00
signupModalShortcuts.jsx Use faster JS selection methods (#11409) 2020-11-16 17:35:50 +01:00
stickySaveFooter.js Use faster JS selection methods (#11409) 2020-11-16 17:35:50 +01:00
storiesList.js stories list script as separate js file - defer attribute (#13993) 2021-06-21 10:59:30 +07:00
userProfileSettings.js fix character limits i18n (#15830) 2021-12-21 07:15:21 -05:00
validateFileInputs.js [deploy] Add valiation for file name length to file uploads (#6918) 2020-03-27 18:54:27 -04:00
webShare.js Use navigator.share on mobile devices (#13809) 2021-06-15 06:39:33 -06:00