docbrown/app
Daniel Uber c5a90173bd
handle getElementById failures in articlePage (#16743)
* when there is no div for it, don't render CommentSubscription

* Retrigger CI

* Retrigger CI

* don't write an error to the comment div if its gone

This fixes an issue seen in tests, where the page transitioned while
we were running the articlePage async handler, so the article-body
element was gone (can't access dataset of null), and the error handler
catch block tried to access the innerHTML of another getElementById.

* Use existing found element `root` when setting the error message

No need to find a new comment-subscription div to write the error to,
we already named the one we're interested in at the beginning of the function
2022-03-02 09:56:53 -06:00
..
assets Removing bootstrap: admin sidebar navigation (#16618) 2022-03-01 15:46:45 +01:00
controllers Ensuring POST api/v0/articles authorizes by policy (#16685) 2022-02-28 08:50:33 -05:00
decorators [Small win] Add display name to campaign settings (#16653) 2022-02-22 10:01:52 -05:00
errors A suspended user returns 403 instead of 500 (#16408) 2022-02-04 09:42:23 -05:00
forms Using a Form Object that will persist for the Creator Settings Form (#15684) 2021-12-10 17:07:40 +02:00
helpers Removing bootstrap: admin sidebar navigation (#16618) 2022-03-01 15:46:45 +01:00
javascript handle getElementById failures in articlePage (#16743) 2022-03-02 09:56:53 -06:00
lib Removing bootstrap: admin sidebar navigation (#16618) 2022-03-01 15:46:45 +01:00
liquid_tags Implement Loom Embed (not merging now) (#16633) 2022-02-22 09:05:55 -05:00
mailers "Reply to" and "From" Email addresses for SMTP Configurations (#16499) 2022-02-16 16:14:54 +02:00
models Removing bootstrap: admin sidebar navigation (#16618) 2022-03-01 15:46:45 +01:00
policies Ensuring VideoPolicy#new? is canonical (#16735) 2022-03-01 11:46:31 -05:00
queries small non-views ruby i18n (#16004) 2022-01-11 10:05:18 +07:00
refinements Drop profile columns from user (#10707) 2020-12-03 08:14:38 +07:00
sanitizers Don't sanitize anchor elements with no href (#16667) 2022-02-22 11:27:38 -06:00
serializers Remove unused methods from User (#16616) 2022-02-18 09:02:17 +07:00
services ✂️ Remove myself from core contributors (#16672) 2022-02-25 09:56:19 -05:00
uploaders small non-views ruby i18n (#16004) 2022-01-11 10:05:18 +07:00
validators Remove the "Getting Started" Section from the Config (#16033) 2022-01-20 07:31:35 -07:00
view_objects Patching ERB rendering of the data-info JSON (#16067) 2022-01-14 08:30:49 -05:00
views Ensuring VideoPolicy#new? is canonical (#16735) 2022-03-01 11:46:31 -05:00
workers Use perform_bulk in Podcasts::EnqueueGetEpisodesWorker (#16325) 2022-01-28 11:32:25 +07:00