docbrown/app/controllers/follows_controller.rb
Gonzalo Ricco dd796aaef3
Fix raising validation if followable already exist(race condition) (#5826)
* Fix raising validation if followable already exist(race condition)

* Change Rails Logger for DataDogStatsClient and remove 'begin' keyword in follow method

Co-authored-by: Gonzalo Ricco <gonzalo.ricco@leniolabs.com>
2020-02-05 12:25:26 -05:00

85 lines
2.8 KiB
Ruby

class FollowsController < ApplicationController
after_action :verify_authorized
def show
skip_authorization
render(plain: "not-logged-in") && return unless current_user
if current_user.id == params[:id].to_i && params[:followable_type] == "User"
render plain: "self"
return
end
following_them_check = FollowChecker.new(current_user, params[:followable_type], params[:id]).cached_follow_check
return render plain: following_them_check unless params[:followable_type] == "User"
following_you_check = FollowChecker.new(User.find_by(id: params[:id]), params[:followable_type], current_user.id).cached_follow_check
if following_them_check && following_you_check
render plain: "mutual"
elsif following_you_check
render plain: "follow-back"
else
render plain: following_them_check
end
end
def create
authorize Follow
followable = if params[:followable_type] == "Organization"
Organization.find(params[:followable_id])
elsif params[:followable_type] == "Tag"
Tag.find(params[:followable_id])
elsif params[:followable_type] == "Podcast"
Podcast.find(params[:followable_id])
else
User.find(params[:followable_id])
end
need_notification = Follow.need_new_follower_notification_for?(followable.class.name)
@result = if params[:verb] == "unfollow"
unfollow(followable, need_notification: need_notification)
else
rate_limiter = RateLimitChecker.new(current_user)
if rate_limiter.limit_by_action("follow_account")
render json: { error: "Daily account follow limit reached!" }, status: :too_many_requests
return
end
follow(followable, need_notification: need_notification)
end
current_user.touch
render json: { outcome: @result }
end
def update
@follow = Follow.find(params[:id])
authorize @follow
redirect_to "/dashboard/following" if @follow.update(follow_params)
end
private
def follow_params
params.require(:follow).permit(policy(Follow).permitted_attributes)
end
def follow(followable, need_notification: false)
user_follow = current_user.follow(followable)
Notification.send_new_follower_notification(user_follow) if need_notification
"followed"
rescue ActiveRecord::RecordInvalid
DataDogStatsClient.increment("users.invalid_follow")
"already followed"
end
def unfollow(followable, need_notification: false)
user_follow = current_user.stop_following(followable)
Notification.send_new_follower_notification_without_delay(user_follow, true) if need_notification
"unfollowed"
end
end