docbrown/spec
Jeremy Friesen 60dc2cc12e
Fixing weighted query hotness grab logic (#15528)
* Fixing weighted query hotness grab logic

Prior to this commit, I carried over (albeit imprecisely) logic from the
LargeForemExperimental.  That logic was to help limit articles to those
that were published since the user's latest page view.

However, I introduced a bug in this transcription.  Now both
LargeForemExperimental and WeightedQueryStrategy use the same logic to
determine the oldest publication date to search for in the feed.

This resolves a bug reported where users were not seeing a large number
of items in their feed.

Incidentally, if a forem has little activity in the 18 hours, there
might be very few items in the feed.

I believe, going forward, we may need to better parameterize how many
hours is considered "stale since last page view".

Related to #15240

* Fixing implementation detail

* Extracting helper method

Prior to this commit, I had introduced a method an put it in a less
ideal module space.  This commit extracts that method to a more readily
shareable module space.

I've added a few more specs to help clarify and verify behavior.

* Updating documentation

* Renaming and documenting variables/constants

* Fixing that which I broke
2021-11-30 12:55:48 -05:00
..
black_box Remove <provider>_created_at columns (#13264) 2021-04-29 10:24:16 -05:00
components/admin/users Refactor Admin Member Detail view - Tools section (#14283) 2021-08-17 18:55:53 +02:00
controllers/concerns 15 minute fix: Add default argument to JsonApiSortParam (#13369) 2021-04-14 10:32:07 +07:00
decorators Refactoring Spam Handler (#15412) 2021-11-30 12:45:12 -05:00
factories ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
fixtures Remove duplicated work display from header / profile work (#14210) 2021-07-30 12:28:40 +02:00
generator Add service generator (#11265) 2020-11-10 09:09:35 +07:00
helpers Enable Forem (Passport) Auth (#15141) 2021-11-23 14:59:00 -06:00
initializers ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
lib Configurable weighted feed strategy (#15240) 2021-11-29 10:46:56 -05:00
liquid_tags complete changes (#15420) 2021-11-18 14:19:45 -05:00
mailers Update the User Invitation email copy (#15501) 2021-11-29 09:29:36 -05:00
models Refactoring Spam Handler (#15412) 2021-11-30 12:45:12 -05:00
policies ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
queries Adds validations to avoid creating unnecessary PNs (#14621) 2021-08-31 15:00:30 -06:00
refinements Update data exporter to handle admin send (#10274) 2020-10-26 18:00:56 -04:00
requests Fixing weighted query hotness grab logic (#15528) 2021-11-30 12:55:48 -05:00
routing ✂✂✂ Remove shop_url from SiteConfig ✂✂✂ (#13773) 2021-05-18 09:03:05 +07:00
serializers/search ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
services Fixing weighted query hotness grab logic (#15528) 2021-11-30 12:55:48 -05:00
support ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
system Configurable weighted feed strategy (#15240) 2021-11-29 10:46:56 -05:00
tasks Create Default Nav Links In New Forem (RFC #237) (#14345) 2021-08-02 12:52:36 -04:00
uploaders ✂✂✂ Remove events (#15062) 2021-10-15 09:31:08 -04:00
validators Updating valid domain registration (#15436) 2021-11-19 10:05:00 -05:00
view_objects [15 min fix] Fallback to the image URL if Cloudinary/Imgproxy are not configured (#13767) 2021-05-19 15:03:20 +02:00
views Let users purchase credits (#15346) 2021-11-10 15:18:52 -06:00
workers Guarding against missing experiments (#15440) 2021-11-22 16:06:32 -05:00
i18n_spec.rb Misc i18n fixes (#14852) 2021-10-05 13:22:33 +02:00
rails_helper.rb Configurable weighted feed strategy (#15240) 2021-11-29 10:46:56 -05:00
spec_helper.rb Theme data update script, remove theme choices from UI (#15225) 2021-11-08 08:38:43 -05:00