docbrown/app/javascript
Julien Maury a2677cc0a9
Remove defer attributes from inline scripts - gist embeds (#13407)
* replace inline attribute defer with external js - show.html.erb

* fix typo in filename

* disable no-undef and bail if not defined

* put js on subfolder utilities

* refactor jsx instead of loading chunk with defer

* fix typo in desc

* better name for global gist helper

* use InstantClick

* working script on preview AND single view, not dynamic import, though

* embed only if gists

* combine all approaches to make dynamic import work

* make gist embeds work on submit comment form

* make gist embeds work on preview comment

* refactor - preview comments and submit

* add pack editComment + helper embedGistsInComments

* comment gist helper

* delete useless file utility

* use new syntax for events

* put code in method embedGistsInComments

* delete older pack gist

* handle edge case 'view full discussion'

* resolve conflict with package ibm-openapi-validator

* resolve conflict with package husky

* empty commit to test random error travis

* better name for class dismiss

* handle future events submit

* delete test code on click toggle form

* delete unused file

* rename pack as js file, not jsx

* Added POC using MutationObserver.

* missing case: notification page

* use custom pack notification page

* add e2e test for comment with embed gist

* add e2e test for preview post with embed gist

* add an extra step in tests to check gist is present

Co-authored-by: Nick Taylor <nick@dev.to>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-06-11 08:22:50 +01:00
..
.storybook Added react aliases in Storybook webpack configuration. (#12825) 2021-02-26 09:25:38 +00:00
actionsPanel Fix a bug with moderator dropdowns and add aria tags (#13623) 2021-05-06 07:56:28 -04:00
admin RFC #74, Pt. 2: Private Forem Landing Page (#13819) 2021-06-10 11:46:24 -06:00
analytics Accessibility enhancements to navigation tabs (#13559) 2021-05-07 15:24:34 +01:00
article-form Remove defer attributes from inline scripts - gist embeds (#13407) 2021-06-11 08:22:50 +01:00
articles Pin posts to feed (#13807) 2021-06-04 10:54:53 +02:00
chat 🚑 Quick fix prevent grammarly from running on chromium based browsers (#13820) 2021-05-25 06:54:32 -04:00
CommentSubscription Fix subscribe to discussion button when user is not logged in (#12837) 2021-03-03 18:50:29 -06:00
common-prop-types Updates ESLint rules to error on default imports (#12512) 2021-02-02 10:24:03 -05:00
contentDisplayPolicy Don't show articles from blocked users in the feed (#13752) 2021-05-14 09:41:50 +02:00
crayons 🚑 Quick fix prevent grammarly from running on chromium based browsers (#13820) 2021-05-25 06:54:32 -04:00
githubRepos Bump eslint-config-preact from 1.1.3 to 1.1.4 (#13516) 2021-04-27 18:54:43 +02:00
icons Storybook: Add DocsPage and test out static content (#11397) 2020-12-02 09:56:38 -08:00
leftSidebar Replace redundant div with Fragment (#12613) 2021-02-09 11:41:46 -06:00
listings Add loading=lazy to image tags (#10888) 2021-05-27 19:01:21 +02:00
modCenter Updates ESLint rules to error on default imports (#12512) 2021-02-02 10:24:03 -05:00
onboarding Add loading=lazy to image tags (#10888) 2021-05-27 19:01:21 +02:00
organization Bump eslint-config-preact from 1.1.3 to 1.1.4 (#13516) 2021-04-27 18:54:43 +02:00
packs Remove defer attributes from inline scripts - gist embeds (#13407) 2021-06-11 08:22:50 +01:00
podcasts Bump eslint-config-preact from 1.1.3 to 1.1.4 (#13516) 2021-04-27 18:54:43 +02:00
profileDropdown Don't show articles from blocked users in the feed (#13752) 2021-05-14 09:41:50 +02:00
readingList Bump eslint-config-preact from 1.1.3 to 1.1.4 (#13516) 2021-04-27 18:54:43 +02:00
responseTemplates [15 minute fix] Fixed bug with templates not being inserted for comments. (#13149) 2021-03-30 13:02:54 +02:00
Search Fix search confusion (#13130) 2021-03-26 11:08:56 +01:00
searchableItemList Fixed Reading List on Mobile + Small Improvements (#12755) 2021-04-08 12:53:43 +01:00
shared/components Fix feed navigation shortcuts when first article is not 100% visible (#11874) 2021-04-13 22:35:50 -04:00
sidebar-widget Refactoring SidebarWidget and sidebarUser (#10887) 2021-02-03 17:47:54 +00:00
Snackbar Bump eslint-config-preact from 1.1.3 to 1.1.4 (#13516) 2021-04-27 18:54:43 +02:00
topNavigation [15 minute fix] Fixed issue with member navigation button only working after full page loads but not InstantClick page transitions (#13402) 2021-04-23 08:06:56 -04:00
utilities Remove defer attributes from inline scripts - gist embeds (#13407) 2021-06-11 08:22:50 +01:00
.eslintrc.js Add prefer object destructuring lint rule (#13183) 2021-05-04 12:10:32 +01:00
netlify.toml Try yarn instead over npm for storybook deploys (#12376) 2021-02-26 10:30:56 -05:00