docbrown/app
Julien Maury a2677cc0a9
Remove defer attributes from inline scripts - gist embeds (#13407)
* replace inline attribute defer with external js - show.html.erb

* fix typo in filename

* disable no-undef and bail if not defined

* put js on subfolder utilities

* refactor jsx instead of loading chunk with defer

* fix typo in desc

* better name for global gist helper

* use InstantClick

* working script on preview AND single view, not dynamic import, though

* embed only if gists

* combine all approaches to make dynamic import work

* make gist embeds work on submit comment form

* make gist embeds work on preview comment

* refactor - preview comments and submit

* add pack editComment + helper embedGistsInComments

* comment gist helper

* delete useless file utility

* use new syntax for events

* put code in method embedGistsInComments

* delete older pack gist

* handle edge case 'view full discussion'

* resolve conflict with package ibm-openapi-validator

* resolve conflict with package husky

* empty commit to test random error travis

* better name for class dismiss

* handle future events submit

* delete test code on click toggle form

* delete unused file

* rename pack as js file, not jsx

* Added POC using MutationObserver.

* missing case: notification page

* use custom pack notification page

* add e2e test for comment with embed gist

* add e2e test for preview post with embed gist

* add an extra step in tests to check gist is present

Co-authored-by: Nick Taylor <nick@dev.to>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-06-11 08:22:50 +01:00
..
assets RFC #74, Pt. 2: Private Forem Landing Page (#13819) 2021-06-10 11:46:24 -06:00
black_box Remove <provider>_created_at columns (#13264) 2021-04-29 10:24:16 -05:00
controllers RFC #74, Pt. 2: Private Forem Landing Page (#13819) 2021-06-10 11:46:24 -06:00
decorators Pin posts to feed (#13807) 2021-06-04 10:54:53 +02:00
errors Replacing granular admin email settings with one default email (#13853) 2021-05-28 12:17:08 +03:00
helpers Replacing granular admin email settings with one default email (#13853) 2021-05-28 12:17:08 +03:00
javascript Remove defer attributes from inline scripts - gist embeds (#13407) 2021-06-11 08:22:50 +01:00
lib Remove :runtime_banner feature flag (#13662) 2021-05-28 15:10:15 -06:00
liquid_tags Bump rubocop from 1.15.0 to 1.16.0 (#13894) 2021-06-02 09:11:38 -04:00
mailers Replacing granular admin email settings with one default email (#13853) 2021-05-28 12:17:08 +03:00
models RFC #74, Pt. 2: Private Forem Landing Page (#13819) 2021-06-10 11:46:24 -06:00
policies Create DiscussionLocks (#13905) 2021-06-10 11:04:33 -04:00
queries Have specs run without Redis and refactor ConsumerApp and Device (#13647) 2021-05-07 08:03:16 +02:00
refinements Drop profile columns from user (#10707) 2020-12-03 08:14:38 +07:00
sanitizers Remove unused attributes from markdown parser (#13484) 2021-04-27 09:33:01 -04:00
serializers Cleanup search classes and serializers (#13645) 2021-05-05 09:20:59 -04:00
services Search results: prioritize articles titles (#13918) 2021-06-09 14:28:19 +02:00
uploaders Change frame limit to match imgproxy (#13265) 2021-04-06 12:28:50 +02:00
validators Pin posts to feed (#13807) 2021-06-04 10:54:53 +02:00
view_objects Rename SiteConfig to Settings::General (#13573) 2021-05-21 14:45:37 +02:00
views Remove defer attributes from inline scripts - gist embeds (#13407) 2021-06-11 08:22:50 +01:00
workers Detect animated images in articles asynchronously (#13766) 2021-06-01 10:34:04 +02:00