e94f2f4e31
* Update PR template with communicating changes section * Combine communicating changes with updating docs section * Add forem core team only tag to communicating changes * Specify team over teams
74 lines
3 KiB
Markdown
74 lines
3 KiB
Markdown
<!--
|
|
For Work In Progress Pull Requests, please use the Draft PR feature,
|
|
see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details.
|
|
|
|
For a timely review/response, please avoid force-pushing additional
|
|
commits if your PR already received reviews or comments.
|
|
|
|
Before submitting a Pull Request, please ensure you've done the following:
|
|
- 📖 Read the Forem Contributing Guide: https://github.com/forem/forem/blob/master/CONTRIBUTING.md#create-a-pull-request.
|
|
- 📖 Read the Forem Code of Conduct: https://github.com/forem/forem/blob/master/CODE_OF_CONDUCT.md.
|
|
- 👷♀️ Create small PRs. In most cases this will be possible.
|
|
- ✅ Provide tests for your changes.
|
|
- 📝 Use descriptive commit messages.
|
|
- 📗 Update any related documentation and include any relevant screenshots.
|
|
|
|
NOTE: Pull Requests from forked repositories will need to be reviewed by
|
|
a Forem Team member before any CI builds will run. Once your PR is approved
|
|
with a `/ci` reply to the PR, it will be allowed to run subsequent builds without
|
|
manual approval.
|
|
-->
|
|
|
|
## What type of PR is this? (check all applicable)
|
|
|
|
- [ ] Refactor
|
|
- [ ] Feature
|
|
- [ ] Bug Fix
|
|
- [ ] Optimization
|
|
- [ ] Documentation Update
|
|
|
|
## Description
|
|
|
|
## Related Tickets & Documents
|
|
|
|
## QA Instructions, Screenshots, Recordings
|
|
|
|
_Please replace this line with instructions on how to test your changes, as well
|
|
as any relevant images for UI changes._
|
|
|
|
### UI accessibility concerns?
|
|
|
|
_If your PR includes UI changes, please replace this line with details on how
|
|
accessibility is impacted and tested. For more info, check out the
|
|
[Forem Accessibility Docs](https://docs.forem.com/frontend/accessibility)._
|
|
|
|
## Added tests?
|
|
|
|
- [ ] Yes
|
|
- [ ] No, and this is why: _please replace this line with details on why tests
|
|
have not been included_
|
|
- [ ] I need help with writing tests
|
|
|
|
## [Forem core team only] How will this change be communicated?
|
|
|
|
_Will this PR introduce a change that impacts Forem members or creators, the
|
|
development process, or any of our internal teams? If so, please note how you
|
|
will share this change with the people who need to know about it._
|
|
|
|
- [ ] I've updated the [Developer Docs](https://docs.forem.com) and/or
|
|
[Admin Guide](https://forem.gitbook.io/forem-admin-guide/), or
|
|
[Storybook](https://storybook.forem.com/) (for Crayons components)
|
|
- [ ] I've updated the README or added inline documentation
|
|
- [ ] I will share this change in a [Changelog](https://forem.dev/t/changelog)
|
|
or in a [forem.dev](http://forem.dev) post
|
|
- [ ] I will share this change internally with the appropriate teams
|
|
- [ ] I'm not sure how best to communicate this change and need help
|
|
- [ ] This change does not need to be communicated, and this is why not: _please
|
|
replace this line with details on why this change doesn't need to be
|
|
shared_
|
|
|
|
## [optional] Are there any post deployment tasks we need to perform?
|
|
|
|
## [optional] What gif best describes this PR or how it makes you feel?
|
|
|
|
|