9ee024f9d0
* Refactor controller validations to model * Update specs and move current email validation back * Refactor #subscribed * Cleanup UserSubscriptions::Create service * Refactor service * Move source inside of call for clarity * Specs for UserSubscription::Create * Cleanup spec * Fix Article spec * Updated for subscriber_email * Add comment for explicitness of subscriber_email * Fix reference in comment...oops! * I know what I'm doing...sometimes...maybe * Rename CachChecker - Subscription to IsSubscribed * Use include vs eq in specs for error messages * attr_accessor --> attr_reader * Don't explicitly set nil * Rename Create service to CreateFromService * Use errors_as_sentence * Rename service to CreateFromControllerParams * Assign Struct to a new constant
88 lines
3.9 KiB
Ruby
88 lines
3.9 KiB
Ruby
require "rails_helper"
|
|
|
|
RSpec.describe UserSubscription, type: :model do
|
|
subject { build(:user_subscription) }
|
|
|
|
let(:subscriber) { create(:user) }
|
|
let(:source) { create(:article, :with_user_subscription_tag_role_user, with_user_subscription_tag: true) }
|
|
|
|
describe "validations" do
|
|
it { is_expected.to validate_presence_of(:user_subscription_sourceable_id) }
|
|
it { is_expected.to validate_presence_of(:user_subscription_sourceable_type) }
|
|
it { is_expected.to validate_presence_of(:subscriber_id) }
|
|
it { is_expected.to validate_presence_of(:subscriber_email) }
|
|
it { is_expected.to validate_presence_of(:author_id) }
|
|
it { is_expected.to validate_inclusion_of(:user_subscription_sourceable_type).in_array(%w[Article]) }
|
|
it { is_expected.to validate_uniqueness_of(:subscriber_id).scoped_to(%i[subscriber_email user_subscription_sourceable_type user_subscription_sourceable_id]) }
|
|
|
|
it "validates the source is active" do
|
|
unpublished_source = create(:article, :with_user_subscription_tag_role_user, with_user_subscription_tag: true, published: false)
|
|
user_subscription = described_class.build(source: unpublished_source, subscriber: subscriber)
|
|
expect(user_subscription).not_to be_valid
|
|
expect(user_subscription.errors[:base]).to include "Source not found."
|
|
end
|
|
|
|
it "validates the tag is enabled in the source" do
|
|
source_without_tag = create(:article, :with_user_subscription_tag_role_user)
|
|
user_subscription = described_class.build(source: source_without_tag, subscriber: subscriber)
|
|
expect(user_subscription).not_to be_valid
|
|
expect(user_subscription.errors[:base]).to include "User subscriptions are not enabled for the source."
|
|
end
|
|
|
|
it "validates the subscriber isn't using an Apple private relay" do
|
|
subscriber_with_apple_relay = create(:user, email: "test@privaterelay.appleid.com")
|
|
user_subscription = described_class.build(source: source, subscriber: subscriber_with_apple_relay)
|
|
expect(user_subscription).not_to be_valid
|
|
expect(user_subscription.errors[:subscriber_email]).to include "Can't subscribe with an Apple private relay. Please update email."
|
|
end
|
|
end
|
|
|
|
describe "#build" do
|
|
it "returns a new UserSubcription with the correct attributes" do
|
|
new_user_subscription = described_class.new(
|
|
user_subscription_sourceable: source,
|
|
author_id: source.user_id,
|
|
subscriber_id: subscriber.id,
|
|
subscriber_email: subscriber.email,
|
|
)
|
|
|
|
factory_user_subscription = described_class.build(source: source, subscriber: subscriber)
|
|
|
|
factory_user_subscription.attributes.each do |name, val|
|
|
expect(new_user_subscription[name]).to eq val
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#make" do
|
|
it "returns a created UserSubcription with the correct attributes" do
|
|
factory_user_subscription = described_class.make(source: source, subscriber: subscriber)
|
|
|
|
expect(factory_user_subscription.user_subscription_sourceable).to eq source
|
|
expect(factory_user_subscription.author_id).to eq source.user_id
|
|
expect(factory_user_subscription.subscriber_id).to eq subscriber.id
|
|
expect(factory_user_subscription.subscriber_email).to eq subscriber.email
|
|
end
|
|
end
|
|
|
|
describe "counter_culture" do
|
|
let(:user) { create(:user) }
|
|
|
|
context "when a UserSubscription is created" do
|
|
it "increments subscribed_to_user_subscriptions_count on user" do
|
|
expect do
|
|
create(:user_subscription, subscriber: user)
|
|
end.to change { user.reload.subscribed_to_user_subscriptions_count }.by(1)
|
|
end
|
|
end
|
|
|
|
context "when a UserSubscription is destroyed" do
|
|
it "decrements subscribed_to_user_subscriptions_count on user" do
|
|
user_subscription = create(:user_subscription, subscriber: user)
|
|
expect do
|
|
user_subscription.destroy
|
|
end.to change { user.reload.subscribed_to_user_subscriptions_count }.by(-1)
|
|
end
|
|
end
|
|
end
|
|
end
|