maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
docbrown/spec/models
History
Alex 9ee024f9d0
UserSubscription backend refactor (#9060) 
* Refactor controller validations to model

* Update specs and move current email validation back

* Refactor #subscribed

* Cleanup UserSubscriptions::Create service

* Refactor service

* Move source inside of call for clarity

* Specs for UserSubscription::Create

* Cleanup spec

* Fix Article spec

* Updated for subscriber_email

* Add comment for explicitness of subscriber_email

* Fix reference in comment...oops!

* I know what I'm doing...sometimes...maybe

* Rename CachChecker - Subscription to IsSubscribed

* Use include vs eq in specs for error messages

* attr_accessor --> attr_reader

* Don't explicitly set nil

* Rename Create service to CreateFromService

* Use errors_as_sentence

* Rename service to CreateFromControllerParams

* Assign Struct to a new constant
2020-07-02 12:08:37 -04:00
..
concerns [deploy] Remove Elasticsearch from Index Worker Names (#7594) 2020-04-29 12:12:29 -05:00
shared_examples UserSubscription backend refactor (#9060) 2020-07-02 12:08:37 -04:00
webhook Improve speed of model tests by around 50/60 seconds (#5016) 2019-12-09 16:33:48 -05:00
api_secret_spec.rb Limit the Number of API Keys a User Can Have (#7870) 2020-05-15 11:33:02 +02:00
application_record_spec.rb Switch decorators to Rails builtin decorations - take 2 (#6125) [deploy] 2020-02-19 15:30:53 -05:00
article_destroy_spec.rb Move Articles::ScoreCalcJob to Sidekiq (#5875) [deploy] 2020-02-04 10:01:46 -08:00
article_spec.rb [deploy] User subscriptions API and backend updates (#8779) 2020-06-23 13:43:32 -04:00
audit_log_spec.rb Nullify audit logs on users delete (#7275) 2020-04-15 18:26:16 +02:00
backup_data_spec.rb Add functionality to remove and recover identity (#3377) 2019-07-03 12:01:16 -04:00
badge_achievement_spec.rb Add unique indexes - part 4 (#8059) 2020-05-27 09:29:20 +02:00
badge_spec.rb [deploy] Improve badge slug generation (#7386) 2020-04-20 15:47:44 +02:00
banished_user_spec.rb Introduce BanishedUser table (#5589) [deploy] 2020-01-21 17:15:58 -05:00
block_spec.rb nothing to see here....except maybe reverting a push to master (#8308) 2020-06-05 20:34:21 -05:00
broadcast_spec.rb Add active_status_updated_at to the Broadcasts Table (#8451) [deploy] 2020-06-16 13:04:14 -06:00
buffer_update_spec.rb [deploy] Limit Suggestions for Social Service Posts (#7811) 2020-05-13 08:38:23 -05:00
chat_channel_membership_spec.rb Add unique indexes - part 4 (#8059) 2020-05-27 09:29:20 +02:00
chat_channel_spec.rb Small ActiveRecord optimizations: begone race conditions and hello bulk insert (#8436) 2020-06-15 17:57:14 +02:00
collection_spec.rb Use Rails 6 new features in the code (#8342) 2020-06-08 16:06:29 -04:00
comment_spec.rb nothing to see here....except maybe reverting a push to master (#8308) 2020-06-05 20:34:21 -05:00
credit_spec.rb [deploy] Rename classified listings (#7910) 2020-05-27 13:35:09 +00:00
data_update_script_spec.rb Small ActiveRecord optimizations: begone race conditions and hello bulk insert (#8436) 2020-06-15 17:57:14 +02:00
display_ad_event_spec.rb Improve speed of model tests by around 50/60 seconds (#5016) 2019-12-09 16:33:48 -05:00
display_ad_spec.rb Sanitisation of Ads (#6361) [deploy] 2020-02-28 13:20:34 -05:00
email_authorization_spec.rb [deploy] Add EmailAuthorization model (#6335) 2020-03-02 12:14:24 -05:00
event_spec.rb Move Events::BustCacheJob to Sidekiq and rename (#5379) 2020-01-06 15:51:46 -05:00
feedback_message_spec.rb [deploy] Enforce Uniq Abuse Reports from Reporters (#7831) 2020-05-14 09:03:10 -04:00
follow_spec.rb Replace peform_enqueued_jobs with sidekiq_perform_enqueued_jobs in specs (#6454) 2020-03-04 11:39:48 -07:00
github_issue_spec.rb [deploy] Decouple GitHub authentication from fetching GitHub issues (#7660) 2020-05-04 16:17:16 -04:00
github_repo_spec.rb Refactor GitHub::Client to extract Github::OauthClient for users (#7848) 2020-05-18 14:23:55 +02:00
html_variant_spec.rb Improve speed of model tests by around 50/60 seconds (#5016) 2019-12-09 16:33:48 -05:00
html_variant_success_spec.rb Unskip all skipped specs (#2941) 2019-05-25 11:04:38 -04:00
html_variant_trial_spec.rb Unskip all skipped specs (#2941) 2019-05-25 11:04:38 -04:00
identity_spec.rb Add email panel to settings/account (#8727) 2020-06-18 13:08:46 +02:00
listing_category_spec.rb [deploy] Rename classified listings (#7910) 2020-05-27 13:35:09 +00:00
listing_spec.rb [deploy] Rename classified listings (#7910) 2020-05-27 13:35:09 +00:00
mention_spec.rb Add Mentions::CreateAllWorker for Sidekiq (#5463) 2020-01-13 13:23:30 -06:00
message_spec.rb [deploy] Small design and functionality touches to /connect (#7234) 2020-04-11 10:56:52 -04:00
note_spec.rb Improve specs (#1693) 2019-02-04 15:56:00 -04:00
notification_spec.rb Replace activerecord-import with Rails 6 insert_all and upsert_all (#8407) 2020-06-12 11:16:06 +02:00
notification_subscription_spec.rb Improve speed of model tests by around 50/60 seconds (#5016) 2019-12-09 16:33:48 -05:00
organization_membership_spec.rb [deploy] Create private group chat channel for orgs (#7270) 2020-04-16 17:02:06 -04:00
organization_spec.rb Upgrade to Rails 6.0 (#7658) 2020-06-04 11:54:25 +02:00
page_spec.rb Add json template to Pages (#8357) 2020-06-10 09:42:15 -05:00
page_view_spec.rb Remove UserHistory Feature and PageViews from Algolia (#6127) [deploy] 2020-02-18 10:06:30 -05:00
path_redirect_spec.rb [deploy] Add path_redirects table and internal view (#8161) 2020-06-05 10:28:33 -04:00
podcast_episode_spec.rb [deploy] Remove Elasticsearch from Index Worker Names (#7594) 2020-04-29 12:12:29 -05:00
podcast_spec.rb nothing to see here....except maybe reverting a push to master (#8308) 2020-06-05 20:34:21 -05:00
poll_option_spec.rb Improve speed of model tests by around 50/60 seconds (#5016) 2019-12-09 16:33:48 -05:00
poll_skip_spec.rb Improve speed of model tests by around 50/60 seconds (#5016) 2019-12-09 16:33:48 -05:00
poll_spec.rb Improve speed of model tests by around 50/60 seconds (#5016) 2019-12-09 16:33:48 -05:00
poll_vote_spec.rb Upgrade Rubocop related gems and fix new violations (#3581) [ci skip] 2019-07-30 14:29:05 -04:00
profile_pin_spec.rb [deploy] Finalize deleting user associations (#5624) 2020-01-23 11:29:47 -05:00
rating_vote_spec.rb Create implicit experience level rating vote upon creating of readinglist reaction (#6522) [deploy] 2020-03-10 10:59:49 -04:00
reaction_spec.rb nothing to see here....except maybe reverting a push to master (#8308) 2020-06-05 20:34:21 -05:00
response_template_spec.rb [deploy] Limit Response Template Count for Users (#7890) 2020-05-15 15:18:28 -05:00
role_spec.rb Remove video_permissions Role Reference From Specs and Code (#8344) 2020-06-08 10:23:53 -05:00
sponsorship_spec.rb Refactored creating sponsorships (#7946) 2020-05-19 18:00:01 -04:00
tag_adjustment_spec.rb nothing to see here....except maybe reverting a push to master (#8308) 2020-06-05 20:34:21 -05:00
tag_spec.rb Stop allowing accented characters in tags (#9006) 2020-07-01 11:48:25 +02:00
tweet_spec.rb [deploy] Decouple Twitter authentication from fetching tweets (#7920) 2020-05-19 18:05:41 -04:00
user_block_spec.rb Improve speed of model tests by around 50/60 seconds (#5016) 2019-12-09 16:33:48 -05:00
user_optional_field_spec.rb [deploy] Add optional fields to user (#7246) 2020-04-28 15:42:41 -04:00
user_spec.rb Add email panel to settings/account (#8727) 2020-06-18 13:08:46 +02:00
user_subscription_spec.rb UserSubscription backend refactor (#9060) 2020-07-02 12:08:37 -04:00