docbrown/spec
Jeremy Friesen 5ec47d99dc
Ensuring we don't track views of author or unpublished (#16143)
* Ensuring we don't track views of author or unpublished

Prior to this commit, I was surprised to learn that we:

1) Tracked an author's view of their article.
2) Tracked views of an unpublished article.

This came up from a Forem creator asking if they could reset the view
counter.  Or trigger the reset on publication.

I think a general business logic policy of don't track views for the
author and don't track views for unpublished articles is a reasonable
default.

Were we to pursue the clear views on publication, we'd need to consider
something that went from unpublished -> published -> unpublished ->
published.  Without a more explicit state machine, triggering a
busineiss logic behavior seems a bit unexpected.

In other words, I wrote an article.  There are 20 views when I realize
that I need to unpublished it.  I make the changes in the unpublished
state, and re-publish.  I'd assume that those 20 views would still be
"recorded" and counted towards my article's view counts.

* Adjusting condition structure

Prior to this commit, the `if` clause was rather far to the right.  This
helps make the if clause more pronounced.
2022-01-18 11:23:18 -05:00
..
black_box Remove <provider>_created_at columns (#13264) 2021-04-29 10:24:16 -05:00
components/admin/users Refactor Admin Member Detail view - Tools section (#14283) 2021-08-17 18:55:53 +02:00
controllers/concerns 15 minute fix: Add default argument to JsonApiSortParam (#13369) 2021-04-14 10:32:07 +07:00
decorators Patching ERB rendering of the data-info JSON (#16067) 2022-01-14 08:30:49 -05:00
factories Patching ERB rendering of the data-info JSON (#16067) 2022-01-14 08:30:49 -05:00
fixtures Remove duplicated work display from header / profile work (#14210) 2021-07-30 12:28:40 +02:00
forms Clear changes to settings after checking form saves them (#15746) 2021-12-14 08:39:14 -06:00
generator Add service generator (#11265) 2020-11-10 09:09:35 +07:00
helpers Update crayons_icon_tag helper (#16099) 2022-01-14 17:14:42 +07:00
initializers ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
lib Launch creator Onboarding with the Feature Flag [ To merge only on January 17 ] (#16090) 2022-01-17 16:46:38 +02:00
liquid_tags Move system tests (#16077) 2022-01-18 08:08:41 -06:00
mailers Update the User Invitation email copy (#15501) 2021-11-29 09:29:36 -05:00
models Feed experiment 4: Final order (#16128) 2022-01-17 17:05:43 -05:00
policies Prevent banished users from updating their profiles (#16122) 2022-01-17 10:54:02 -05:00
queries Fixes a name conflict in Rpush models (#15978) 2022-01-07 09:38:16 -06:00
refinements Update data exporter to handle admin send (#10274) 2020-10-26 18:00:56 -04:00
requests Move work from template to controller (#16092) 2022-01-18 11:21:25 -05:00
routing ✂✂✂ Remove shop_url from SiteConfig ✂✂✂ (#13773) 2021-05-18 09:03:05 +07:00
serializers Refactoring to add helper method (#16064) 2022-01-12 11:21:44 -05:00
services Ensuring we don't track views of author or unpublished (#16143) 2022-01-18 11:23:18 -05:00
support Patching ERB rendering of the data-info JSON (#16067) 2022-01-14 08:30:49 -05:00
system Move system tests (#16077) 2022-01-18 08:08:41 -06:00
tasks Create Default Nav Links In New Forem (RFC #237) (#14345) 2021-08-02 12:52:36 -04:00
uploaders Data Update Script to migrate logo_svg contents to png file (Will be merged and deployed on 10/01) (#15710) 2022-01-10 16:09:34 +02:00
validators Don't raise error when empty community emoji setting submitted (#15723) 2021-12-17 09:29:55 -06:00
view_objects Patching ERB rendering of the data-info JSON (#16067) 2022-01-14 08:30:49 -05:00
views quote localized strings in credits/purchase embedded script (#15623) 2021-12-01 10:07:55 -06:00
workers Ensuring we don't track views of author or unpublished (#16143) 2022-01-18 11:23:18 -05:00
i18n_spec.rb Misc i18n fixes (#14852) 2021-10-05 13:22:33 +02:00
rails_helper.rb Configurable weighted feed strategy (#15240) 2021-11-29 10:46:56 -05:00
spec_helper.rb Theme data update script, remove theme choices from UI (#15225) 2021-11-08 08:38:43 -05:00