58b7906fe6
* GitHub workflow for /ci trigger Add in GitHub workflow for adding the `ci` label to the PR and running Buildkite pipeline(s). The `ci` label will allow the PR to be built on push without havinvg to continuously issue the `/ci` trigger from a Forem team member. ``` build.pull_request.repository.fork != true || build.pull_request.labels includes "ci" ``` Also using the `/ci` trigger will run the initial pipeline builds too. * Fix YAML formatting and typos. * Add note to PR template. * Conditionally add a comment to a new PR when it originates from a third-party fork with a note about having to wait for manual approval for our CI to run on their PR. * Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: Michael Kohl <citizen428@dev.to> * Update .github/workflows/pr.yml Co-authored-by: Michael Kohl <citizen428@dev.to> * Adjust if statement to include OWNERS and do startsWith instead of contains. Co-authored-by: Michael Kohl <citizen428@dev.to>
63 lines
2.2 KiB
Markdown
63 lines
2.2 KiB
Markdown
<!--
|
|
For Work In Progress Pull Requests, please use the Draft PR feature,
|
|
see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details.
|
|
|
|
For a timely review/response, please avoid force-pushing additional
|
|
commits if your PR already received reviews or comments.
|
|
|
|
Before submitting a Pull Request, please ensure you've done the following:
|
|
- 📖 Read the Forem Contributing Guide: https://github.com/forem/forem/blob/master/CONTRIBUTING.md#create-a-pull-request.
|
|
- 📖 Read the Forem Code of Conduct: https://github.com/forem/forem/blob/master/CODE_OF_CONDUCT.md.
|
|
- 👷♀️ Create small PRs. In most cases this will be possible.
|
|
- ✅ Provide tests for your changes.
|
|
- 📝 Use descriptive commit messages.
|
|
- 📗 Update any related documentation and include any relevant screenshots.
|
|
|
|
NOTE: Pull Requests from forked repositories will need to be reviewed by
|
|
a Forem Team member before any CI builds will run. Once your PR is approved
|
|
with a `/ci` reply to the PR, it will be allowed to run subsequent builds without
|
|
manual approval.
|
|
-->
|
|
|
|
## What type of PR is this? (check all applicable)
|
|
|
|
- [ ] Refactor
|
|
- [ ] Feature
|
|
- [ ] Bug Fix
|
|
- [ ] Optimization
|
|
- [ ] Documentation Update
|
|
|
|
## Description
|
|
|
|
## Related Tickets & Documents
|
|
|
|
## QA Instructions, Screenshots, Recordings
|
|
|
|
_Please replace this line with instructions on how to test your changes, as well
|
|
as any relevant images for UI changes._
|
|
|
|
### UI accessibility concerns?
|
|
|
|
_If your PR includes UI changes, please replace this line with details on how
|
|
accessibility is impacted and tested. For more info, check out the
|
|
[Forem Accessibility Docs](https://docs.forem.com/frontend/accessibility)._
|
|
|
|
## Added tests?
|
|
|
|
- [ ] Yes
|
|
- [ ] No, and this is why: _please replace this line with details on why tests
|
|
have not been included_
|
|
- [ ] I need help with writing tests
|
|
|
|
## Added to documentation?
|
|
|
|
- [ ] [Developer Docs](https://docs.forem.com) and/or
|
|
[Admin Guide](https://forem.gitbook.io/forem-admin-guide/)
|
|
- [ ] README
|
|
- [ ] No documentation needed
|
|
|
|
## [optional] Are there any post deployment tasks we need to perform?
|
|
|
|
## [optional] What gif best describes this PR or how it makes you feel?
|
|
|
|
|