Jeremy Friesen 3bdcde6496 Adding indirection for Tag#name to ease future work (#16703) ... * Adding indirection for Tag#name to ease future work In pairing with Arit, we were able to capture a few small wins in regards to favoring an accessible tag name. In other words, where ever you see a tag's name, we want to render it as camel-case. This will greatly help those using a screen reader and frankly visually scanning the tag (idontknowaboutyoubutthisiskindahardtoread). However, as we explored the code base, we found several places that will require further consideration. These revolve around the API and caching of tags for articles and listings as well as the JSON documents we use for populating drop-down lists. So, instead of unleashing a large pull request, we're opting to provide a small non-breaking refactor that demonstrates where we're going and keeps production working as expected while allowing future development/testing to benefit from these captured gains. Our next steps are to revisit the related issue and do a proper task breakdown, becuase there are too many considerations to call this a "small win". I also encourage reviewers to read the comments. This is an emerging mental pattern that I believe helps us conceptually move our codebase forward while also guarding against the mega-PR with oodles of commits and file changes that span numerous contexts. Related to forem/forem-internal-eng#269 * Expanding specs to address feedback		2022-02-28 16:32:04 -05:00
..
ahoy	Favoring delete_all on user relationships (#15443)	2021-11-23 11:50:12 -05:00
articles	Refactoring to add helper method (#16064)	2022-01-12 11:21:44 -05:00
concerns	Remove CustomProfileField (#14286)	2021-07-22 10:05:39 +07:00
liquid_tags	[deploy] Add role and docs for user subscription liquid tag (#9170)	2020-07-08 14:07:53 -04:00
settings	Remove Remaining logo_svg Code (#16291)	2022-02-22 12:05:16 -07:00
users	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
ab_experiment.rb	Refactor AB Experiments and exercise all variants in rspec (#16236)	2022-01-24 17:03:58 -05:00
admin_menu.rb	Removes what appears to be an usused comment from admin_menu.rb (#16644)	2022-02-21 06:52:57 -07:00
announcement.rb	Add Polymorphism to Broadcasts (Part 1) (#9231) [deploy]	2020-07-13 09:36:19 -06:00
api_secret.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
application_record.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
article.rb	✂️ Remove myself from core contributors (#16672)	2022-02-25 09:56:19 -05:00
audit_log.rb	Favoring constant over magic string (#15852)	2021-12-27 11:31:29 -05:00
badge.rb	Refactor cache purging (#12811)	2021-03-02 10:09:05 -05:00
badge_achievement.rb	Extracting container for allowed tags & attrs (#15338)	2021-12-16 12:24:45 -05:00
banished_user.rb	Introduce BanishedUser table (#5589) [deploy]	2020-01-21 17:15:58 -05:00
broadcast.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
campaign.rb	[Small win] Add display name to campaign settings (#16653)	2022-02-22 10:01:52 -05:00
collection.rb	Series count to only include non empty series (#16130)	2022-01-18 10:22:34 +07:00
comment.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
config.rb	Add single resource admin concept (#5069) [deploy]	2019-12-11 13:17:55 -05:00
consumer_app.rb	Fixes a name conflict in Rpush models (#15978)	2022-01-07 09:38:16 -06:00
creator_setting.rb	Creator Onboarding: Creator Setup View (#14728)	2021-11-01 15:50:08 -04:00
credit.rb	Favor repurposing existing scope (#15914)	2022-01-03 09:30:34 -05:00
data_update_script.rb	Navigation Items and Role access for Data Update Scripts (#12292)	2021-02-09 17:41:14 +02:00
device.rb	Spelling (#15702)	2021-12-07 06:59:10 -07:00
discussion_lock.rb	Appeasing Rubocop as it sneaks some changes in (#16085)	2022-01-13 07:48:01 -05:00
display_ad.rb	Extracting container for allowed tags & attrs (#15338)	2021-12-16 12:24:45 -05:00
display_ad_event.rb	Extracting constants and tidying tests (#15946)	2022-01-05 09:19:39 -05:00
email_authorization.rb	Refactor Admin Member Detail view - Tools section (#14283)	2021-08-17 18:55:53 +02:00
email_message.rb	Delete old retained emails after certain period (#14949)	2021-10-12 16:27:13 -04:00
feedback_message.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
follow.rb	Refactoring cached_followed_tags (#16175)	2022-01-24 19:53:48 -05:00
forem_instance.rb	"Reply to" and "From" Email addresses for SMTP Configurations (#16499)	2022-02-16 16:14:54 +02:00
github_issue.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
github_repo.rb	POC: use Sidekiq.perform_bulk for Github repos (#16293)	2022-01-26 09:11:07 +07:00
html_variant.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
html_variant_success.rb	Appeasing Rubocop as it sneaks some changes in (#16085)	2022-01-13 07:48:01 -05:00
html_variant_trial.rb	Appeasing Rubocop as it sneaks some changes in (#16085)	2022-01-13 07:48:01 -05:00
identity.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
invitation.rb	[deploy] Invite users to join and create password (#9294)	2020-07-15 11:37:19 -04:00
listing.rb	More listings refactoring (#16343)	2022-02-23 13:44:30 +07:00
listing_category.rb	[deploy] Manage listing categories in dashboard (#10506)	2020-10-02 11:05:09 -04:00
mention.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
mod.rb	Add single resource admin concept (#5069) [deploy]	2019-12-11 13:17:55 -05:00
moderator_action.rb	[deploy] Moderator and admin actions log (#6797)	2020-03-26 16:59:24 -05:00
navigation_link.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
note.rb	Favoring delete_all on user relationships (#15443)	2021-11-23 11:50:12 -05:00
notification.rb	Ensure arguments to perform_async are json safe (#16285)	2022-01-25 18:07:40 -06:00
notification_subscription.rb	Appeasing Rubocop as it sneaks some changes in (#16085)	2022-01-13 07:48:01 -05:00
organization.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
organization_membership.rb	Appeasing Rubocop as it sneaks some changes in (#16085)	2022-01-13 07:48:01 -05:00
overview.rb	Add admin overview page (#12726)	2021-03-01 18:59:05 -06:00
page.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
page_view.rb	Favoring dependent: :delete_all over :destroy (#15442)	2021-11-24 13:56:16 -05:00
permission.rb	Add single resource admin concept (#5069) [deploy]	2019-12-11 13:17:55 -05:00
pinned_article.rb	Pin posts to feed (#13807)	2021-06-04 10:54:53 +02:00
podcast.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
podcast_episode.rb	Various cleanups (#14616)	2021-08-31 09:17:24 +07:00
podcast_episode_appearance.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
podcast_ownership.rb	Appeasing Rubocop as it sneaks some changes in (#16085)	2022-01-13 07:48:01 -05:00
poll.rb	Refactoring poll/vote/skip logic (#15441)	2021-11-29 10:52:32 -05:00
poll_option.rb	Favoring dependent: :delete_all over :destroy (#15442)	2021-11-24 13:56:16 -05:00
poll_skip.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
poll_vote.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
privileged_reaction.rb	[deploy] New Feature: Mod Actions Panel (#7777)	2020-06-08 13:24:18 -04:00
profile.rb	Remove store_attribute gem (#15923)	2022-01-04 11:15:57 +07:00
profile_field.rb	Require profile fields to belong to a group (#16390)	2022-02-15 09:27:18 -06:00
profile_field_group.rb	[deploy] /profile/settings page rendering (Ridhwana/Michael) (#10733)	2020-10-20 09:18:13 -04:00
profile_pin.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
rating_vote.rb	Removing deprecated User methods (#16435)	2022-02-07 10:32:58 -05:00
reaction.rb	Don't send notification for invalid reactions (#16721)	2022-02-28 12:36:44 -06:00
response_template.rb	Removing deprecated User methods (#16435)	2022-02-07 10:32:58 -05:00
role.rb	✂✂✂ Remove Connect (#14734)	2021-11-18 08:21:00 -06:00
secret.rb	[deploy] Feature: Setup Admin Area to Update Vault Secrets (#8935)	2020-06-29 15:08:09 -05:00
sponsorship.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
tag.rb	Adding indirection for Tag#name to ease future work (#16703)	2022-02-28 16:32:04 -05:00
tag_adjustment.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
timeframe.rb	Remove timeframer from app/labor (#11782)	2020-12-08 12:52:33 +07:00
tool.rb	Add single resource admin concept (#5069) [deploy]	2019-12-11 13:17:55 -05:00
tweet.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
user.rb	Remove unused methods from User (#16616)	2022-02-18 09:02:17 +07:00
user_block.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
user_role.rb	[Search 2.0] Users (#13453)	2021-04-24 19:06:06 +02:00
user_subscription.rb	app/models i18n (#16124)	2022-02-03 13:41:42 -05:00
welcome.rb	Add single resource admin concept (#5069) [deploy]	2019-12-11 13:17:55 -05:00
welcome_notification.rb	Add Polymorphism to Broadcasts (Part 1) (#9231) [deploy]	2020-07-13 09:36:19 -06:00