docbrown/spec
Daniel Uber ba590c1750
Load article before creating a page view for an invalid one (#15898)
* Load article before creating a page view for an invalid one

This should resolve a validation error in PageView.create! when the
article does not exist (perhaps it was deleted, or the user suspended,
or it was invalid data sent from the client).

This had been happening dozens of times per day for the last 10
months.

* Use an intention revealing symbol instead of calculated id

Since we only require that find_by not find anything, pass a symbol
that's not going to be the id for any article under any conditions.

As an added benefit, this provides a clear indication of the purpose
of the symbol, without needing to mentally confirm that

```sql
  SELECT * FROM articles
  WHERE id IN (
    SELECT (1 + MAX(id)) FROM articles
  ) LIMIT 1
```

actually never gives any articles back.
2021-12-29 09:48:34 -06:00
..
black_box Remove <provider>_created_at columns (#13264) 2021-04-29 10:24:16 -05:00
components/admin/users Refactor Admin Member Detail view - Tools section (#14283) 2021-08-17 18:55:53 +02:00
controllers/concerns 15 minute fix: Add default argument to JsonApiSortParam (#13369) 2021-04-14 10:32:07 +07:00
decorators role deprecation cleanup (#15717) 2021-12-09 15:27:45 -06:00
factories Fixed setting Identity#auth_data_dump in seeds and factory (#15874) 2021-12-28 09:02:15 +03:00
fixtures Remove duplicated work display from header / profile work (#14210) 2021-07-30 12:28:40 +02:00
forms Clear changes to settings after checking form saves them (#15746) 2021-12-14 08:39:14 -06:00
generator Add service generator (#11265) 2020-11-10 09:09:35 +07:00
helpers Enable Forem (Passport) Auth (#15141) 2021-11-23 14:59:00 -06:00
initializers ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
lib Refactoring questions asked of user (#15762) 2021-12-21 12:45:12 -05:00
liquid_tags Refactoring questions asked of user (#15762) 2021-12-21 12:45:12 -05:00
mailers Update the User Invitation email copy (#15501) 2021-11-29 09:29:36 -05:00
models Fixed setting Identity#auth_data_dump in seeds and factory (#15874) 2021-12-28 09:02:15 +03:00
policies Refactoring questions asked of user (#15762) 2021-12-21 12:45:12 -05:00
queries Adds validations to avoid creating unnecessary PNs (#14621) 2021-08-31 15:00:30 -06:00
refinements Update data exporter to handle admin send (#10274) 2020-10-26 18:00:56 -04:00
requests Mock omniauth payload before creating identities (#15893) 2021-12-28 09:06:17 -06:00
routing ✂✂✂ Remove shop_url from SiteConfig ✂✂✂ (#13773) 2021-05-18 09:03:05 +07:00
serializers/search ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
services Remove webhooks and related code (#15827) 2021-12-28 10:56:37 +07:00
support Add comment notification test to Cypress, including a11y improvements to notification page (#15842) 2021-12-21 15:42:13 +00:00
system Rubocop fixes (#15892) 2021-12-28 09:11:41 -06:00
tasks Create Default Nav Links In New Forem (RFC #237) (#14345) 2021-08-02 12:52:36 -04:00
uploaders Creator Settings: Removed SVG files as an option for logo upload (#15662) 2021-12-03 10:47:42 -05:00
validators Don't raise error when empty community emoji setting submitted (#15723) 2021-12-17 09:29:55 -06:00
view_objects [15 min fix] Fallback to the image URL if Cloudinary/Imgproxy are not configured (#13767) 2021-05-19 15:03:20 +02:00
views quote localized strings in credits/purchase embedded script (#15623) 2021-12-01 10:07:55 -06:00
workers Load article before creating a page view for an invalid one (#15898) 2021-12-29 09:48:34 -06:00
i18n_spec.rb Misc i18n fixes (#14852) 2021-10-05 13:22:33 +02:00
rails_helper.rb Configurable weighted feed strategy (#15240) 2021-11-29 10:46:56 -05:00
spec_helper.rb Theme data update script, remove theme choices from UI (#15225) 2021-11-08 08:38:43 -05:00