docbrown/spec
Daniel Uber c879c5b3d8
Remove slash characters from user name search term (#15867)
* Remove slash characters from user supplied user search input

Prevents an error when the search term includes '\'

    PG::SyntaxError: ERROR:  syntax error in tsquery

https://app.honeybadger.io/projects/66984/faults/79391397

I had originally thought to add this cleanup to Search::Username but
decided to move it as close to the generated (invalid) query as
possible to prevent alternate paths finding their way here.

* Add spec

Since there's no existing tests for the scope - I put the test code on
the caller (Search::Username) rather than the model (User), this seems reasonable.

* When the term is empty (or only slashes) just return null relation

* Handle nil input (search for nothing) correctly

One of the request specs sends a username search with no query, so we
can't call nil.delete or nil.empty?, use blank? of empty?
2021-12-27 12:30:36 -06:00
..
black_box Remove <provider>_created_at columns (#13264) 2021-04-29 10:24:16 -05:00
components/admin/users Refactor Admin Member Detail view - Tools section (#14283) 2021-08-17 18:55:53 +02:00
controllers/concerns 15 minute fix: Add default argument to JsonApiSortParam (#13369) 2021-04-14 10:32:07 +07:00
decorators role deprecation cleanup (#15717) 2021-12-09 15:27:45 -06:00
factories Remove Doorkeeper gem (#15749) 2021-12-21 12:29:58 +07:00
fixtures Remove duplicated work display from header / profile work (#14210) 2021-07-30 12:28:40 +02:00
forms Clear changes to settings after checking form saves them (#15746) 2021-12-14 08:39:14 -06:00
generator Add service generator (#11265) 2020-11-10 09:09:35 +07:00
helpers Enable Forem (Passport) Auth (#15141) 2021-11-23 14:59:00 -06:00
initializers ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
lib Refactoring questions asked of user (#15762) 2021-12-21 12:45:12 -05:00
liquid_tags Refactoring questions asked of user (#15762) 2021-12-21 12:45:12 -05:00
mailers Update the User Invitation email copy (#15501) 2021-11-29 09:29:36 -05:00
models Refactoring questions asked of user (#15762) 2021-12-21 12:45:12 -05:00
policies Refactoring questions asked of user (#15762) 2021-12-21 12:45:12 -05:00
queries Adds validations to avoid creating unnecessary PNs (#14621) 2021-08-31 15:00:30 -06:00
refinements Update data exporter to handle admin send (#10274) 2020-10-26 18:00:56 -04:00
requests Favoring constant over magic string (#15852) 2021-12-27 11:31:29 -05:00
routing ✂✂✂ Remove shop_url from SiteConfig ✂✂✂ (#13773) 2021-05-18 09:03:05 +07:00
serializers/search ✂✂✂ Remove Connect (#14734) 2021-11-18 08:21:00 -06:00
services Remove slash characters from user name search term (#15867) 2021-12-27 12:30:36 -06:00
support Add comment notification test to Cypress, including a11y improvements to notification page (#15842) 2021-12-21 15:42:13 +00:00
system Refactoring questions asked of user (#15762) 2021-12-21 12:45:12 -05:00
tasks Create Default Nav Links In New Forem (RFC #237) (#14345) 2021-08-02 12:52:36 -04:00
uploaders Creator Settings: Removed SVG files as an option for logo upload (#15662) 2021-12-03 10:47:42 -05:00
validators Don't raise error when empty community emoji setting submitted (#15723) 2021-12-17 09:29:55 -06:00
view_objects [15 min fix] Fallback to the image URL if Cloudinary/Imgproxy are not configured (#13767) 2021-05-19 15:03:20 +02:00
views quote localized strings in credits/purchase embedded script (#15623) 2021-12-01 10:07:55 -06:00
workers Refactoring questions asked of user (#15762) 2021-12-21 12:45:12 -05:00
i18n_spec.rb Misc i18n fixes (#14852) 2021-10-05 13:22:33 +02:00
rails_helper.rb Configurable weighted feed strategy (#15240) 2021-11-29 10:46:56 -05:00
spec_helper.rb Theme data update script, remove theme choices from UI (#15225) 2021-11-08 08:38:43 -05:00