docbrown/spec/system
Jacob Herrington 00dd84f9e1 Add a default message to badge award action (#5160)
* Add a default message to badge award action

Because:
 - The only badges routinely awarded manually use the same message
 - Right now, unfriendly/unsafe UI can result in an error notification

The only badges that are currently awarded manually (afaik) have the
message "Congrats!!!" so for the time being, if a message is not
supplied to the UI, it will simply use the "Congrats!!!" message as a
default.

That being said, I'm not totally convinced this message won't work for
the long term. Generally, if we are awarding badges by hand, I'd imagine
we'd want a specific message explaining why we are doing that, or just
be okay with "Congrats!"

After talking with Peter about it, the longer term goal should be to
move badge messages into the database so they can be modified in the app
and not hardcoded. That also make sense regarding the effort to
genericize the app eventually.

* Test Badge notifications
2019-12-19 10:38:57 -05:00
..
articles Fix pending tests (#5070) [deploy] 2019-12-10 15:10:14 -05:00
comments Migrate to streaming app shell via serviceworkers (#5020) [deploy] 2019-12-16 12:21:33 -05:00
dashboards Add pagination to followers and following page in dashboard (#258) (#4375) [deploy] 2019-11-20 18:21:18 -05:00
homepage Delete a commented out test (#4875) 2019-11-21 15:14:12 -05:00
internal Add a default message to badge award action (#5160) 2019-12-19 10:38:57 -05:00
organization Fix rubocop Rails.root.path complaints (#5114) 2019-12-16 12:13:15 -05:00
podcasts Feat: #3498 Display episode's published_at (#4272) 2019-10-08 17:06:46 -04:00
pro_memberships Pro: memberships (#3461) 2019-09-24 10:38:54 -07:00
user Fix pending tests (#5070) [deploy] 2019-12-10 15:10:14 -05:00
videos Fix community name (#2415) 2019-04-13 16:12:21 -04:00
banned_user_interactions_spec.rb Migrate feature test to system test (#2301) 2019-04-04 12:15:10 -04:00
link_for_tags_in_posts_in_notifications_spec.rb Migrate feature test to system test (#2301) 2019-04-04 12:15:10 -04:00
user_leaves_top_level_comment_spec.rb Migrate feature test to system test (#2301) 2019-04-04 12:15:10 -04:00
user_logs_in_with_twitter_spec.rb Feature/refactored onboarding (#3333) 2019-07-26 15:53:32 -04:00
user_selects_looking_for_work_spec.rb Move user.follow delay calls to ActiveJob (#3136) (#4203) 2019-10-03 11:22:00 -04:00
user_uses_the_editor_spec.rb Unskip all skipped specs (#2941) 2019-05-25 11:04:38 -04:00
user_views_a_reading_list_spec.rb Improve reading list (#2695) 2019-05-05 19:19:30 -04:00
user_visits_a_comments_page_spec.rb Bump capybara from 3.26.0 to 3.27.0 (#3556) 2019-07-30 16:47:08 -04:00
user_visits_downloads_page_spec.rb Fix rubocop lints (#3922) [ci skip] 2019-09-03 10:09:48 -04:00