0771a5cd2e
* feat: add a route to the async_info for display ads * feat: load the billboard asyncronously * feat: move the methods to the display_ads controller * feat: handle params better * feat: cache control headers * feat: test fastly caching headers on display ads * fix: surrogate key test * feat: use safe navigation operator to handle cases where there is no article id * fix: article id present then find the article * feat: add a response test * Fragment caching * feat: update the article decorator * feat: update cache keys for fragment * feat: remove an empty line * feat: add article id * feat: bust cache * feat: setup dropdown for billboard * chore: add chunk to same line * feat: add to safe params for caching * Update app/controllers/display_ads_controller.rb Co-authored-by: Joshua Wehner <joshua@forem.com> * feat: remove the cache deletion * feat: update the routes to follow a new scope * feat: update the cache params --------- Co-authored-by: Joshua Wehner <joshua@forem.com>
69 lines
2.6 KiB
Markdown
69 lines
2.6 KiB
Markdown
<!--
|
|
For Work In Progress Pull Requests, please use the Draft PR feature,
|
|
see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details.
|
|
|
|
For a timely review/response, please avoid force-pushing additional
|
|
commits if your PR already received reviews or comments.
|
|
|
|
Before submitting a Pull Request, please ensure you've done the following:
|
|
- 📖 Read the Forem Contributing Guide: https://developers.forem.com/contributing-guide/forem#create-a-pull-request
|
|
- 📖 Read the Forem Code of Conduct: https://github.com/forem/forem/blob/main/CODE_OF_CONDUCT.md
|
|
- 👷♀️ Create small PRs. In most cases this will be possible.
|
|
- ✅ Provide tests for your changes.
|
|
- 📝 Use descriptive commit messages.
|
|
- 📗 Update any related documentation and include any relevant screenshots.
|
|
|
|
NOTE: Pull Requests from forked repositories will need to be reviewed by
|
|
a Forem Team member before any CI builds will run. Once your PR is approved
|
|
with a `/ci` reply to the PR, it will be allowed to run subsequent builds without
|
|
manual approval.
|
|
-->
|
|
|
|
## What type of PR is this? (check all applicable)
|
|
|
|
- [ ] Refactor
|
|
- [ ] Feature
|
|
- [ ] Bug Fix
|
|
- [ ] Optimization
|
|
- [ ] Documentation Update
|
|
|
|
## Description
|
|
|
|
## Related Tickets & Documents
|
|
|
|
<!--
|
|
For pull requests that relate or close an issue, please include them
|
|
below. We like to follow [Github's guidance on linking issues to pull requests](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue).
|
|
|
|
For example having the text: "closes #1234" would connect the current pull
|
|
request to issue 1234. And when we merge the pull request, Github will
|
|
automatically close the issue.
|
|
-->
|
|
|
|
- Related Issue #
|
|
- Closes #
|
|
|
|
## QA Instructions, Screenshots, Recordings
|
|
|
|
_Please replace this line with instructions on how to test your changes, a note
|
|
on the devices and browsers this has been tested on, as well as any relevant
|
|
images for UI changes._
|
|
|
|
### UI accessibility concerns?
|
|
|
|
_If your PR includes UI changes, please replace this line with details on how
|
|
accessibility is impacted and tested. For more info, check out the
|
|
[Forem Accessibility Docs](https://developers.forem.com/frontend/accessibility)._
|
|
|
|
## Added/updated tests?
|
|
|
|
- [ ] Yes
|
|
- [ ] No, and this is why: _please replace this line with details on why tests
|
|
have not been included_
|
|
- [ ] I need help with writing tests
|
|
|
|
## [optional] Are there any post deployment tasks we need to perform?
|
|
|
|
## [optional] What gif best describes this PR or how it makes you feel?
|
|
|
|
|