Ben Halpern
966f48f9b6
Add watercooler as sidebar tag and watercooler flare ( #3465 )
...
* Add watercooler as sidebar tag and watercooler flare
* Fix black box cached_tag_list_array check
* Adjust blackbox spec
2019-07-12 14:24:33 -04:00
Ben Halpern
0432da190f
Tweak black box so posts won't stick ( #3312 )
2019-06-26 10:15:07 -04:00
Anna Buianova
d57f8eec4a
BlackBox specs #2524 ( #2542 )
...
* Specs for FuctionCaller
* Fix accepting nil values from AWS lambda
* Specs for the black_box #2524
* Spec for BlackBox#comment_quality_score
* Remove vcr cassette usage from the CouponGenerator spec
2019-04-25 10:19:11 -04:00
cyrillefr
4fd66372dc
Enable Layout/AlignParameters ( #2340 )
...
Check if the parameters on a multi-line method call or definition are aligned.
Resolves : #2021
2019-04-08 18:47:34 -04:00
Abraham Williams
9cb40e546b
Enables Rails cops ( #2186 )
...
* Enable Rails cops
* Fix Rails/DynamicFindBy
* Fix Rails/HttpStatus
* Fix Rails/Blank
* Fix Rails/RequestReferer
* Fix Rails/ActiveRecordAliases
* Fix Rails/FindBy
* Fix Rails/Presence
* Fix Rails/Delegate
* Fix Rails/Validation
* Fix Rails/PluralizationGrammar
* Fix Rails/Present
* Fix Rails/Output
* Fix Rails/Blank
* Fix Rails/FilePath
* Fix Rails/InverseOf
* Fix Rails/LexicallyScopedActionFilter
* Add Rails/OutputSafety to TODO
* Add Rails/HasManyOrHasOneDependent to TODO
* Add Rails/SkipsModelValidations to TODO
2019-03-25 09:25:55 -04:00
Keshav Biswa
8d57d45ecc
Rubocop Style cops enabled ( #2056 )
...
* Rubocop enabled style/alias
* Enabled Style/ArrayJoin Cop
* Enabled Style/Attr
* Enabled Case Equality
* Enabled CharacterLiteral
* Enabled ColonMethodCall Cop
* Enabled CommentAnnotation cop
* Enabled PreferredHashMethods Cop
* Enabled DoubleNegation Cop
* Enabled EachWithObject Cop
* Enabled EmptyLiteral Cop
* Enabled EvenOdd Cop
* Enabled IfWithSemicolon Cop
* Enabled Lambda and LambdaCall Cop
* Enabled LineEndConcatenation Cop
* Enabled ModuleFunction Cop;
* Enable NegatedIf and NegatedWhile Cop
* Enabled NilComparison Cop
* Enabled Not Cop
* Enabled NumericLiterals Cop
* Enabled OneLineConditional Cop
* Enabled PercentLiteralDelimiters Cop
* Excluded internal/users_controller from negated_if cop
* Reverted the double negation change from github_issue_tag and github_issue.rb"
* Enabled PerlBackrefs Cop
* Changed Regexp.last_match(1) to Regexp.last_match(0)
* Enabled proc cop
* Enabled RaiseArgs Cop
* Reverted Regexp.last_match(0) to Regexp.last_match(1)
* Enabled SelfAssignment Cop
* Enabled SingleLineMethods Cop
* Enabled SpecialGlobalVars Cop
* Enabled VariableInterpolation Cop
* Enabled WhenThen Cop
* Enabled WhileUntilModifier Cop
* Enabled WordArray Cop
* Enabled IfUnlessModifier Cop
* Enabled GuardClause Cop
2019-03-15 18:33:54 -04:00
Ben Halpern
3f25d52aba
Adjust rankings to squash lingering popular stuff ( #1982 )
2019-03-05 10:43:40 -08:00
Ben Halpern
f36b869228
Adjust article ranking algorithm to use crossposted_at where available ( #1917 )
2019-02-27 07:41:52 -08:00
Ben Halpern
b1f18f5bbc
Improve feed and add more randomness ( #1570 )
...
* Improve feed and add more randomness
* Fix tests
* Fix test score calc
* Modify home page test criteria
2019-01-16 16:01:14 -05:00
rhymes
6553f08d94
Rubocop cleanups ( #1415 )
...
* Update rubocop-todo.yml with new violations
* Fix Layout/EmptyLine* rules
* Fix Layout/Indentation* rules
* Fix remaining Layout/* rules
* Fix Lint/DuplicateMethods by removing unused accessor
* Fix Lint/IneffectiveAccessModifier
* Fix Lint/MissingCopEnableDirective
* Re-run rubocop auto gen config
* Fix Layout/RescueEnsureAlignment
* Fix Naming/* rules
* Fix some RSpec/* rules
* Fix typos
* Fix RSpec/LetBeforeExamples
* Series should only be an attr_writer, not an attr_accessor
* Fix RSpec/InstanceVariable
* Fix RSpec/InstanceVariable
* Fix RSpec/RepeatedDescription and RSpec/RepeatedExample
* Fix Style/ClassAndModuleChildren
* Fix Style/ConditionalAssignment
* Fix some Style/* rules
* Trigger Travis CI build because failing tests are not failing locally
* Revert "Fix Style/ClassAndModuleChildren"
This reverts commit 1686801d8a1516ba1894f79e24401a20dea65f99.
2019-01-02 11:20:02 -05:00
Ben Halpern
61173bede1
Finalize new analytics style ( #1117 )
2018-11-14 10:50:05 -05:00
Ben Halpern
c5807205b5
Adjust dashboard analytics to be more reliable ( #1115 )
...
* Update analytics
* Remove analytics file
* Remove unused files
* Add delete button back in on dashboard
2018-11-13 20:37:29 -05:00
Ben Halpern
302e8f202d
Add HTML variants for cta optimization and other nav bar adjustments ( #970 )
...
* Add HTML variants for cta optimization and other nav bar adjustments
* Fix 1==1 non-random mistake
* Spruce up org call-to-action
* Change default text color
* Add html variant trial and success request specs
* Fix article sidebar caching issue
* One line adjustment
* Modify schema
* Add include ActionView::Helpers::TagHelper to user_tag_spec
* Modify follow_button to remove session context
* Dummy commit
* Change Edit Article to Edit Post
* Dummy commit
* Fix rubocop concerns
* Fix rubocop style
2018-10-22 17:03:57 -04:00
Ben Halpern
8184baed83
Adjust analytics styling and accuracy ( #951 )
...
* Adjust analytics styling and accuracy
* Add video button back in
2018-10-18 12:19:49 -04:00
Ben Halpern
95dacf67fa
Fix feed issue which caused wrong posts to show up sometimes ( #827 )
2018-10-04 19:07:36 -04:00
Ben Halpern
12fee733f7
Change from OR to proper AND ( #816 )
2018-10-04 11:34:20 -04:00
Ben Halpern
4d02005108
Fix query instruction for GoogleAnalytics events ( #812 )
...
* Add tracking for home page featured impressions/clicks
* Change impression event to view in Google Analytics
* Fix typo in GoogleAnalytics object
* Fix query instruction for GoogleAnalytics events
2018-10-04 10:46:45 -04:00
Ben Halpern
6aa6d7f737
Fix typo in GoogleAnalytics object ( #807 )
...
* Add tracking for home page featured impressions/clicks
* Change impression event to view in Google Analytics
* Fix typo in GoogleAnalytics object
2018-10-03 17:55:01 -04:00
Ben Halpern
a0491657dd
Add tracking for home page featured impressions/clicks ( #804 )
2018-10-03 14:05:00 -04:00
Ben Halpern
7e48a23afa
Ben/add more recent posts to home feed ( #775 )
...
* Add meta to sidebar and adjust ranking algo
* Update home feed to show more recent posts from folks you follow
* Only show recent posts on home feed if user signed in
2018-09-30 14:05:59 -04:00
Ben Halpern
be11d8fda1
Add meta to sidebar and adjust ranking algo ( #766 )
2018-09-29 12:58:44 -04:00
Ben Halpern
dffd0218e1
Add user quota to Google Analytics fetch ( #765 )
...
* Add page_views_count to articles and track from analytics
* Modification in google analytics fetch
* Chunk article requests in analytics requests
* Fix test
* Fix test in analytics
* Add user quota to Google Analytics fetch
2018-09-28 18:15:33 -04:00
Ben Halpern
eae8b6332f
Change various admin pages ( #758 )
...
* Change int to float for more granular admin controls
* Change int to float for more granular admin controls
* Add details to /mod for admins
2018-09-27 18:03:49 -04:00
Ben Halpern
dd32580ab1
Make article actions bar sticky ( #648 )
...
* Make article actions bar sticky
* Fix article load edge case
* Fix logic check
2018-09-13 13:52:35 -04:00
Ben Halpern
91f99036df
Update feed for slightly more customized top articles ( #642 )
...
* Update home feed logic and display
* Remove console log
2018-09-12 15:27:54 -04:00
rhymes
e588fa7ece
Code cleanups ( #659 )
...
* Initial automatic cleanup with rubocop
* Fix syntax error introduced by rubocop
* Cleanup seeds file
* Cleanup lib folder
* Exclude bin folder because it contains auto generated files
* Make Rubocop a little bit more chatty
* Block length should not include comments in the count
* Cleanup config folder
* Cleanup specs
* Updated Rubocop version and generated a todo file
* Fix broken ArticlesApi spec
* Fix tests
* Restored rubocop pre-commit hook
2018-08-07 11:00:13 -04:00
Mac Siri
40f488d991
Migrate to Travis CI (part 2) ( #591 )
...
* Update Travis.yml
* Update README
* Update README
* Adjust test to not rely on env vars
* Update encryption
* Refactor
* Update env key
* Stub AWS calls
* Create ApplicationConfig
* Fix specs
* Fix lint
* Update ApplicationConfig
* Remove travis env vars
* Fix lint
* Extend character limit to 100
* Add env to travis
* Take out auto-restart after deploy
* Immediately discarded test cache
* Stub GA in request specs
* Stub Pusher
* Fix broken specs
* Update fixture
* Add CodeClimate id
* Change CodeClimate key
* Remove merge mistakes
* WIP
* Add Envied gem & Change README
* Add missing keys
* Add missing key
* Update fixture
* Fix broken spec
* Add Slack Notification for Travis
* Fix wording
* Fix typo
2018-07-20 20:17:18 -04:00
Ben Halpern
cd33d96e10
Adjust blackbox ( #405 )
2018-06-08 11:00:30 -04:00
Ben Halpern
532c379eff
Adjust recency bonus ( #402 )
2018-06-07 13:02:35 -04:00
Ben Halpern
ab4b4fba6e
Add reaction score to article hotness score
2018-06-07 11:14:11 -04:00
Mac Siri
e3a270d317
Update blackbox's API endpoint ( #259 )
2018-04-30 12:24:32 -04:00
Mac Siri
301c6080e3
Initial commit
2018-02-28 16:11:08 -05:00
