maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix typo in GoogleAnalytics object (#807)

Browse source 
* Add tracking for home page featured impressions/clicks

* Change impression event to view in Google Analytics

* Fix typo in GoogleAnalytics object
This commit is contained in:
Ben Halpern 2018-10-03 17:55:01 -04:00 • committed by GitHub
parent c16e2aa480
commit 6aa6d7f737
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/black_box/google_analytics.rb
View file

@ -24,7 +24,7 @@ class GoogleAnalytics
def get_feed_impression_info
requests = @article_ids.map do |id|
make_report_request("ga:eventAction=~^featured-feed-impression,ga:eventLabel=~^article-#{id}",
make_report_request("ga:eventAction=~^featured-feed-impression,ga:eventLabel=~^articles-#{id}",
"ga:totalEvents")
end
results = fetch_all_results(requests)
@ -33,7 +33,7 @@ class GoogleAnalytics
def get_feed_click_info
requests = @article_ids.map do |id|
make_report_request("ga:eventAction=~^featured-feed-click,ga:eventLabel=~^article-#{id}",
make_report_request("ga:eventAction=~^featured-feed-click,ga:eventLabel=~^articles-#{id}",
"ga:totalEvents")
end
results = fetch_all_results(requests)
@ -59,7 +59,7 @@ class GoogleAnalytics
filters_expression: filters_expression_string,
metrics: [Metric.new(expression: metrics_string)],
date_ranges: [
DateRange.new(start_date: "2012-01-01", end_date: "today"),
DateRange.new(start_date: "2015-01-01", end_date: "today"),
],
)
end