Commit graph

5424 commits

Author SHA1 Message Date
rhymes
fa22f346e4
Add merveilles.town to list of Mastodon instances (#7983) 2020-05-20 17:48:46 -04:00
Vaidehi Joshi
32410d3b9a
Add Percy to Travis yml (#7970) [deploy] 2020-05-20 13:50:22 -07:00
Julianna Tetreault
97c46cfbf8
Refactor User-Specific JSON-LD in the Stories::Controller (#7731)
* Refactor user_same_as_json_ld method to be more readable

* Refactor user JSON-LD to be less verbose in Stories::Controller
  * Removes set_user_same_as_json_ld method
  * Removes set_user_profile_json_ld method
  * Adds user_works_for and user_disambiguating_description
  * Adds inline logic to the data structure
  * Simplifies user_same_as method

* Add documentation around specific data properties

* Add .reject to user_json_ld to remove key, value if value blank
  * Checks for blank values and rejects key,value if blank
  * Accounts for JSON-LD preference for no key,value if blank

* Add reject and compact to worksFor in Stories::Controller
  * Ensures any nil/empty values for worksFor are removed
  * Cleans up existing code within Stories::Controller

* Add test for values that eval to true when .blank? is called
  * Adds test to check that empty key/values are not included
  * Adds test to check that nil key/values are not included
  * Refactors variables to be inline in user_show_spec
  * Refactors existing code in user_show_spec

* Add reject for blank values to user_same_as in Stories::Contrroller
  * Adds a check for email_public to email

* Fix typo within comment in Stories::Controller

* Add ternary operation to email in Stories::Controller
2020-05-20 14:40:34 -06:00
Molly Struve
2b8fc7473d
[deploy] Skip pro memberships for spec (#7988) 2020-05-20 14:10:08 -05:00
Molly Struve
58ff5d44ba
[deploy] Add back ProMembership AR class (#7987) 2020-05-20 13:15:22 -05:00
Molly Struve
16161bfcae
[deploy] Keep Pro Membership Relation Until AR Cache's expire (#7986) 2020-05-20 12:45:04 -05:00
Andy Zhao
e686d63d78
[deploy] Add public reactions count fields to Elasticsearch (#7956)
* Add public_reactions_count field to elasticsearch

* Add new data update scripts and update old ones

* Use BulkIndexWorker to batch indexing

* Use proper search class for handling feed content

* Remove redundant script oops

* Rename data update script and remove old specs

* Combine specs into one file
2020-05-20 13:06:48 -04:00
Molly Struve
1c461f8891
[deploy] Remove Unused Pro Memberships (#7894) 2020-05-20 11:54:30 -05:00
Mac Siri
f65d61c8db
Loosen CodeClimate's method-lines rule (#7980) 2020-05-20 16:44:35 +02:00
Zach Attas
52277ea0ba
Adds csv formatter only in CI and makes screenshot names unique with timestamp (#7838)
* adds csv formatter only in CI and adds --format progress to rspec in CI

* addressing feedback

* adds more functionality to csv reporter, and makes screenshots taken from rspec/retry have unique names

* induces intentional fails (will revert after testing)

* induces intentional fails (will revert after testing)

* makes screenshot timestamp more precise and tweaks intentional fails (again willremove later)

* restores spec files to normal and tweaks screenshot microseconds

* remove the putses at end of CSVFormatter
2020-05-20 10:40:55 +02:00
rhymes
300ba1b33f
[deploy] Decouple Twitter authentication from fetching tweets (#7920)
* Add TwitterClient::Client

* Use TwitterClient::Client for Tweet

* Test retweets

* Test assignment to user

* Fix TweetTag spec

* Remove TwitterBot

* Fix some specs

* Fix RSS Reader specs
2020-05-19 18:05:41 -04:00
Ben Halpern
59765d339f
Remove /new from serviceworkers (#7967)
* Remove /new from serviceworkers

* Use pathname
2020-05-19 18:04:22 -04:00
Anna Buianova
c02a103c7f
Refactored creating sponsorships (#7946)
* Refactored sponsorships levels and purchasing sponsorships

* Fix partnerships tests

* Refactored creating partnerships, removed unused functionality

* Display flashes in /partnerships

* Fix views
2020-05-19 18:00:01 -04:00
Nick Taylor
412f640cb7
Added a search form Storybook story where the search is focused. (#7968) 2020-05-19 17:59:46 -04:00
Andy Zhao
d2d8caa767
[deploy] Use npm for deploying Storybook (#7969) 2020-05-19 17:41:41 -04:00
Molly Struve
ef39860875
Use raw Option When Incrementing Redis Keys (#7959)
* Use raw Option When Incrementing Redis Keys

* include raw option in image upload spec
2020-05-19 17:38:25 -04:00
Mac Siri
2bc06501b5
Resourcify User model (#7966) 2020-05-19 17:15:19 -04:00
ludwiczakpawel
fac1564ac7
Extra Utility Classes (#7964)
* flare tag line height

* .

* .

* .

* add serif font

* whoops

* whoops 2

* whoops 3
2020-05-19 17:14:49 -04:00
Andy Zhao
1cc95e03a3
Add netlify.toml for storybook (#7963) 2020-05-19 16:10:33 -04:00
Nick Taylor
c36f034542
Fixed a copy pasta error in a Storybook story (#7962) 2020-05-19 15:51:17 -04:00
Andy Zhao
0568911ba2
Move netlify.toml to docs folder to prep for multiple TOML files (#7960) 2020-05-19 15:02:17 -04:00
Ben Halpern
97bc5fd8b1
[deploy] Add campaign url for sidebar link (#7943)
* Add campaign url for sidebar link

* Add proper test
2020-05-19 14:31:34 -04:00
Molly Struve
db1df9e078
Only Remove Article Reaction Count Cache Keys (#7937) 2020-05-19 13:57:03 -04:00
Alex
4eba14f150
[deploy] Update safe params for Array params (#7914) 2020-05-19 13:01:50 -04:00
Molly Struve
a326019ba4
[deploy] Use User reactions_count for Reaction Cache Keys (#7939) 2020-05-19 11:34:06 -05:00
rhymes
a5e6555469
Flaky Spec Fix: Hard-code, be happy 😁 (#7951) 2020-05-19 10:19:28 -05:00
Liz Fong-Jones
a6305fd0a3
[deploy] Honeycomb instrumentation: distinguish between literal vs prefix matching for sampling (#7936) 2020-05-19 09:49:41 -05:00
Molly Struve
6a4a99f162
[deploy] Track Deploys In Honeycomb (#7935) 2020-05-19 09:10:41 -05:00
Nick Taylor
7f8bb406c5
Added coverage threshold to jest configuration. (#7948) 2020-05-19 10:00:48 -04:00
icncsx
d15290420f
replace hardcoded twitter hashtag (#7895)
* replace hardcoded DEVCommunity

* make sure # is a part of the string

* set site config explicity in test for twitter hashtag
2020-05-19 14:02:28 +02:00
Molly Struve
16495791d3
Remove Unnecessary User Touch From Strip Controller (#7924) 2020-05-19 12:45:56 +02:00
rhymes
df4681a114
Remove destroy_empty_dm_channels callback (#7911) 2020-05-19 12:44:31 +02:00
rhymes
691efd1f7b
Enable comment liquid tag and alias devcomment to it (#7912)
* Enable comment liquid tag and alias devcomment to it

* Update editor guide

* Add explanation
2020-05-19 10:57:35 +02:00
Hashim Lokasher
713a589f55
Fixed Typo in Docs (#7944)
* Fixed typo in gitdocs 

javascript word is written incorrect in Git Docs

* Fixed Typo in Docs
2020-05-19 10:32:27 +02:00
Mac Siri
830ddf7d04
[deploy] Specify node version in package.json (#7940) 2020-05-18 19:00:17 -04:00
Andy Zhao
91b14d7d4b
[deploy] Add data update script to backfill public reaction count (#7932)
* Add data update script to backfill public rxn count

* Reduce to two transactions instead of three
2020-05-18 17:51:02 -04:00
Vaidehi Joshi
3b9fe2658e
Fix pluralization in FollowUsers component (#7928) [deploy] 2020-05-18 11:38:47 -07:00
Vaidehi Joshi
b1de4cb1cf
Add Percy 🦔 (#7783) [deploy]
* Add Percy to Gemfile, rails helper

* Percy snapshots for using the editor

* Add PERCY_TOKEN to sample_application.yml

* Percy snapshots for visiting the homepage

* Percy snapshots for viewing an article's comments

* Percy snapshots for creating an article

* Percy snapshots for editing an article

* Percy snapshots for logged in/out user

* Remove empty spec file

* Percy snapshots for settings page

* Percy snapshots for reading list

* Percy snapshots for admin view

* Percy snapshots for moderator view

* Percy snapshots for authentication views

* Percy snapshots for article and tag views

* Percy snapshots for editing/deleting comment views

* Percy snapshots for admin views

* Percy snapshots for comment views

* Percy snapshots for organization views

* Percy snapshots for pro membership views

* Percy snapshots for podcast views

* Percy snapshots for user views

* Percy snapshots for dashboard views

* Percy snapshots for homepage views

* Percy snapshots for video views

* Add js: true in tests that require it for Percy

* Percy dependency cleanup

* Add the Percy agent
* Remove the PERCY_TOKEN from sample_application.yml
* Move the Percy gem into the "test" group in the Gemfile

* Remove duplicate snapshots, provide unique names to snapshots

* Set seed on Faker::Config for deterministic Percy snapshots

* Freeze time in js: true tests for determinstic snapshots

* Upgrade Percy to v0.26.3

* Add percy: true flag for Percy snapshotting tests

* Add more percy: true flags
2020-05-18 11:35:53 -07:00
Molly Struve
909f298688
[deploy] Only Count Hot Stories Once Rather Than Every Iteration (#7931) 2020-05-18 13:12:41 -05:00
Liz Fong-Jones
8309e0af2a
[deploy] remove additional cruft (#7929) 2020-05-18 13:11:14 -05:00
Molly Struve
dda2e6aa65
Drop Elasticsearch Indexes When Database is Dropped (#7927) 2020-05-18 13:10:08 -05:00
Molly Struve
d6a71217b0
Update Rails To Fix CVEs (#7930) 2020-05-18 13:03:13 -05:00
rhymes
9ea00dfe53
[deploy] Fix Github::OauthClient access token auth (#7922) 2020-05-18 11:15:14 -05:00
Molly Struve
548fd21768
[deploy] Limit the User Updates (#7892) 2020-05-18 11:13:38 -05:00
Molly Struve
dbb5c752ab
[deploy] Sample Noisy Honeycomb Spans (#7891) 2020-05-18 10:36:01 -05:00
Andy Zhao
45ae42f611
[deploy] Add public reactions count columns (#7919) 2020-05-18 11:34:30 -04:00
Molly Struve
6d6f7086e5
[deploy] Track current_user ID in Honeycomb (#7915) 2020-05-18 09:36:18 -05:00
Michael Kohl
b5885f6c29
Fix internal category filtering for listings (#7908) 2020-05-18 09:26:38 -04:00
rhymes
3130261384
Refactor GitHub::Client to extract Github::OauthClient for users (#7848)
* Introduce Github::OAuthClient and refactor shortcut Github::Client

* Better stubbing and fix specs

* Fix Badge rewarder

* Add dummy values for Travis

* Fix spec?

* Simplify

* Fix spec take 2?

* Is this the right one?

* Hopefully this is the last time, for realz

* Fix spec for the nth time?

* Which deity do I have to offer a sacrifice to?

* This is it

* Fix Honeycomb name
2020-05-18 14:23:55 +02:00
Anna Buianova
c4423adb19
Removed ignored_columns from articles (#7913) 2020-05-18 14:43:37 +03:00