maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
7826 commits 1 branch 0 tags 1.6 GiB
Commit graph

7826 commits

This branch
This branch
All branches
Author SHA1 Message Date
Alex
f70af66258
Update bust to EdgeCache::Bust (#12052) 
* Update bust to EdgeCache::Bust

* Update specs

* Fix more specs

* Fix more specs :)
 2020-12-29 09:53:15 +01:00
Alex
eca7be8201
Update bust_user to EdgeCache::BustUser (#12051) 2020-12-29 09:53:00 +01:00
Alex
2a345d5214
Update bust_listings to service (#12050) 2020-12-29 09:52:34 +01:00
Alex
c7ae198179
Update bust_podcast to EdgeCache::BustPodcast (#12047) 2020-12-29 09:49:59 +01:00
Alex
6195d6cf36
Update bust_podcast_episode to EdgeCache::BustPodcastEpisode (#12049) 
* Update bust_podcast_episode to service

* Update argument checks
 2020-12-29 09:49:13 +01:00
Alex
e0d0fd6c96
Update bust_organization to EdgeCache::BustOrganization (#12048) 
* Update bust_organization to service

* Add spec for nil slug

* Update argument check
 2020-12-29 09:48:36 +01:00
Julianna Tetreault
13f7f9b353
Disable Community Name Data Update Scripts (#12054) 2020-12-28 14:29:42 -05:00
Julianna Tetreault
ac573b446b
Adds a data_update script that removes collective_noun from SiteConfig (#11973) [deploy] 2020-12-28 10:06:05 -07:00
dependabot[bot]
59ce70bf91
Bump rubocop from 1.6.1 to 1.7.0 (#12043) 
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 1.6.1 to 1.7.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v1.6.1...v1.7.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-28 17:57:17 +01:00
Julianna Tetreault
ca6ba1af7d
Replace collective_noun with community_name (#11846) [deploy] 
* Removes collective_noun and collective_noun_disabled from app

* Config Generalization: replaces community_qualified_name with community_name
  - Generalizes SiteConfig after the removal of collective_noun field
  - Updates copy where necessary to be readable with community_name
  - Makes the community_name SiteConfig description more explicit
  - Adds flexibility for Admins by removing appended "community"

* Adds a data_update script to remove collective_noun and collective_noun_disabled

* Removes appended community from stories_controller.rb

* Removes unnecessary quotation marks around SiteConfig.community_name.to_s

* Makes SiteConfig community_name description more explicit

* Removes topic from #email_from and replaces arg with _

* Removes argument from #email_from (facepalm)

* Reverts changes to application_mailer and notify_mailer_spec

* Removes default "Community" topic from application_mailer and makes topic optional

* Refactors #prepopulate_new_form to resolve Code Climate failures

* Refactors #email_from even further by use of a ternary operator per review suggestion

* Simplifies the data_update script used to remove collective_noun per review request

* Adds a data_update script to append community to community_name

* Updates data_update script to correctly append Community to community_name

* Removes RemoveCollectiveNounFromConfig and updates other script

* Removes superfluous false from data_update script

* Updates data_update script to be more idiomatic
 2020-12-28 09:34:17 -07:00
dependabot[bot]
5a384a81a7
Bump oj from 3.10.17 to 3.10.18 (#12042) 
Bumps [oj](https://github.com/ohler55/oj) from 3.10.17 to 3.10.18.
- [Release notes](https://github.com/ohler55/oj/releases)
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ohler55/oj/compare/v3.10.17...v3.10.18)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-28 17:28:20 +01:00
dependabot[bot]
319551b1fe
Bump yard from 0.9.25 to 0.9.26 (#12040) 
Bumps [yard](https://github.com/lsegal/yard) from 0.9.25 to 0.9.26.
- [Release notes](https://github.com/lsegal/yard/releases)
- [Changelog](https://github.com/lsegal/yard/blob/main/CHANGELOG.md)
- [Commits](https://github.com/lsegal/yard/compare/v0.9.25...v0.9.26)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-28 11:26:04 -05:00
dependabot[bot]
301d47496f
Bump start-server-and-test from 1.11.6 to 1.11.7 (#12044) 
Bumps [start-server-and-test](https://github.com/bahmutov/start-server-and-test) from 1.11.6 to 1.11.7.
- [Release notes](https://github.com/bahmutov/start-server-and-test/releases)
- [Commits](https://github.com/bahmutov/start-server-and-test/compare/v1.11.6...v1.11.7)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-28 16:13:40 +01:00
rhymes
3764cd67d5
Use Travis builtin caching (#12045) 2020-12-28 14:41:31 +01:00
Ben Halpern
42026481db
Remove automatic inclusion of Twitter widget.js (#12032) 
* Remove automatic inclusion of Twitter widget.js

* Fix syntax error
 2020-12-27 23:14:10 -05:00
dependabot[bot]
d031248c5e
Bump brakeman from 4.10.0 to 4.10.1 (#12036) 
Bumps [brakeman](https://github.com/presidentbeef/brakeman) from 4.10.0 to 4.10.1.
- [Release notes](https://github.com/presidentbeef/brakeman/releases)
- [Changelog](https://github.com/presidentbeef/brakeman/blob/v4.10.1/CHANGES.md)
- [Commits](https://github.com/presidentbeef/brakeman/compare/v4.10.0...v4.10.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-27 23:00:29 -05:00
Michael Kohl
f98cfb59d2
Move constant from initializer to app/lib/constants (#12034) 2020-12-26 19:19:09 +01:00
Nick Taylor
15601285a5
Add data cleaning pre-test run to end to end tests (#12001) 
* Added the cypress-on-rails gem.

* Removed secret from admin login fixture data and promoted it to Cypress config.

* Created resetData task for tests.

* Now the spec resets data on each test run.

* Removed the cypress-on-rails gem.

* Added node-fetch for e2e testing.

* Move rresetData to async/await.

* Small refactor to resetData Cypress task.

* Now there is a cypress.dev.json config for local dev testing.

* Added rails assets:precompile instead of webpacker:compile.

* Added more explicit error if Elastic Search fails to clear.

* Exposing more explicit error for truncating DB.

* Added better error output for truncating the DB.

* Removed stdout from error logging as it's empty.

* Reworked error message.

* Implemented @rhymes suggestions for fixing trunctation in the test environment.

* Removed unused Cypress configuration file.
 2020-12-26 16:58:12 +01:00
Ben Halpern
839a30c70e
Bust sidebar when display ad is updated (#12025) 
* Bust sidebar when display ad is updated

* Fix test
 2020-12-25 11:02:19 -06:00
dependabot[bot]
eefec99472
Bump @babel/plugin-transform-react-jsx from 7.12.11 to 7.12.12 (#12029) 
* Bump @babel/plugin-transform-react-jsx from 7.12.11 to 7.12.12

Bumps [@babel/plugin-transform-react-jsx](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-react-jsx) from 7.12.11 to 7.12.12.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.12.12/packages/babel-plugin-transform-react-jsx)

Signed-off-by: dependabot[bot] <support@github.com>

* Trigger Travis CI from scratch

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rhymes <rhymes@hey.com>
 2020-12-24 11:07:00 -05:00
Peter Frank
6d3e6a244a
Fix typo on admin page (#12023) 
`Maichimp` to `Mailchimp`
 2020-12-24 13:00:13 +01:00
Fernando Valverde
90aa693204
First working version to integrate native bridge image upload (#11838) 
* First working version to integrate native bridge image upload

* ImageUploader base64 experiment

* Adds message handling

* Adds support for cover image

* Revert pre-commit hook changes

* Revert pre-commit hook changes

* Better native image upload logic + mock Runtime class in tests

* Dont render hidden fields unless necessary

* Better test coverage & inline comments for better context/documentation

* Added an a11y test for when native iOS image upload is available.

* Added more test

Co-authored-by: Nick Taylor <nick@dev.to>
 2020-12-23 10:02:39 -06:00
Michael Kohl
1cb990e87f
Routine Rubocop fixes (#12016) 2020-12-23 10:26:12 -05:00
Michael Kohl
63cf95d811
Split BadgeRewarder into multiple services (#11902) 2020-12-23 09:55:06 -05:00
narender2031
01f7dbd24f
fix mention in chat (#10493) 
* fix mention in chat

* fix mention bug

* fix conflict issue

* fix load channel issue initally render

* add test case

* remove comments and add nitpick
 2020-12-23 06:21:28 -05:00
Michael Kohl
254b8334a5
Remove autofollowing hiring tag (#11722) 2020-12-23 12:11:19 +07:00
Nick Taylor
2925a64eb8
Added webpack bundle analyzer (#12013) 
* Added webpack bundle analyzer.

* Renamed to bundleAnalyzer (no extension)

* Added some documentation.
 2020-12-22 19:13:40 -05:00
Ben Halpern
673b1406be
Allow any admin to publish welcome thread (#11597) 
* Allow any admin to publish welcome thread

* Update app/models/article.rb

Co-authored-by: rhymes <rhymes@hey.com>

* Fix specs by making user for welcome thread an admin

* revert spec changes and update code to include either admin, super_admin, or site mascot

* add specs for scope

* Modify tests and include mascot user

* Fix test

Co-authored-by: rhymes <rhymes@hey.com>
Co-authored-by: mstruve <mollylbs@gmail.com>
 2020-12-22 16:18:32 -05:00
Ben Halpern
68867e9384
Add config post route for admin api (#11698) 
* Add config post route for admin api

* Fix params

* Extract config_params to concern

* Remove print statement

* Some changes

* A couple changes

* Change controller method name and refactor upsert

* Fix tests and method names

* Fix routes and class stuff

* Fix styles

* Fix config params

* Fix styles

* Move regex to constant

* Remove single-use after action callbacks

* Expose success? method

* Fix syntax error

* Fix success? return

* Switch to guard clause

* Final clean ups?
 2020-12-22 15:50:34 -05:00
rhymes
00247bed99
Log error message inline when Feeds::Import fails (#12012) 2020-12-22 20:02:07 +01:00
rhymes
92fdf8d720
Upgrade to SimpleCov 0.20 (#12009) 
* Upgrade to simplecov 0.20

* Upgrade to latest CodeClimate reporter
 2020-12-22 18:46:52 +01:00
dependabot[bot]
05aa9a27fe
Bump rails-settings-cached from 2.5.1 to 2.5.2 (#12006) 
Bumps [rails-settings-cached](https://github.com/huacnlee/rails-settings-cached) from 2.5.1 to 2.5.2.
- [Release notes](https://github.com/huacnlee/rails-settings-cached/releases)
- [Changelog](https://github.com/huacnlee/rails-settings-cached/blob/master/CHANGELOG.md)
- [Commits](https://github.com/huacnlee/rails-settings-cached/compare/v2.5.1...v2.5.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
 2020-12-22 16:01:10 +01:00
dependabot[bot]
7bc50a28ba
Bump ransack from 2.4.0 to 2.4.1 (#12007) 
Bumps [ransack](https://github.com/activerecord-hackery/ransack) from 2.4.0 to 2.4.1.
- [Release notes](https://github.com/activerecord-hackery/ransack/releases)
- [Changelog](https://github.com/activerecord-hackery/ransack/blob/master/CHANGELOG.md)
- [Commits](https://github.com/activerecord-hackery/ransack/compare/2.4.0...2.4.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-22 09:07:30 -05:00
dependabot[bot]
239494a272
Bump cypress from 6.1.0 to 6.2.0 (#12008) 
Bumps [cypress](https://github.com/cypress-io/cypress) from 6.1.0 to 6.2.0.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Changelog](https://github.com/cypress-io/cypress/blob/develop/.releaserc.base.js)
- [Commits](https://github.com/cypress-io/cypress/compare/v6.1.0...v6.2.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-22 07:35:19 -05:00
Mac Siri
ab95635dc6
Filter XSS in navigationLink's title (#12003) 2020-12-22 12:05:41 +01:00
Michael Kohl
bd13d21b4c
Enable paranoid mode for Devise (#11995) 
* Enable paranoid mode for Devise

* Remove two specs

These no longer make sense after enabling Devise's paranoid mode.
 2020-12-22 13:47:28 +07:00
Alex
d0c70e72d7
Update bust_tag to EdgeCache::BustTag (#11953) 2020-12-21 14:43:42 -05:00
Alex
e9886d106c
Update bust_events to EdgeCache::BustEvents (#11955) 2020-12-21 14:43:28 -05:00
dependabot[bot]
7f2f46f64c
Bump node-notifier from 8.0.0 to 8.0.1 (#11998) 
Bumps [node-notifier](https://github.com/mikaelbr/node-notifier) from 8.0.0 to 8.0.1.
- [Release notes](https://github.com/mikaelbr/node-notifier/releases)
- [Changelog](https://github.com/mikaelbr/node-notifier/blob/v8.0.1/CHANGELOG.md)
- [Commits](https://github.com/mikaelbr/node-notifier/compare/v8.0.0...v8.0.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-21 13:28:28 -05:00
Ben Halpern
5cd947336b
Declare winner in update points worker (#11974) 
* Declare winner in update points worker

* Remove tests

* Fix finalized_points style issue
 2020-12-21 12:59:54 -05:00
rhymes
3dae3ff797
Upgrade rubocop* packages to the latest version and fix violations (#11972) 
* Update erb_lint to track newer Rubocop versions

* Update rubocop-rspec to 2.1

* Fix Rails/WhereEquals and Style/RedundantParentheses

* Upgrade rubocop to 1.1.0

* Enable Rubocop 1.1 cops

* Upgrade rubocop to 1.2.0

* Enable Rubocop 1.2 cops

* Upgrade rubocop to 1.3.0

* Enable Rubocop 1.3 cops

* Enable Rubocop 1.4 cops

* Enable Rubocop 1.5 cops

* Upgrade rubocop to 1.6.x

* Restore previous .reject

* Fork the PR to make sure we don't inject unwanted code accidentally
 2020-12-21 18:29:43 +01:00
Peter Frank
97d00780b8
Use default social image on /listings (#11997) 
Following pattern from https://github.com/forem/forem/pull/11961 to generalize the social image on `/listings`
 2020-12-21 18:29:11 +01:00
dependabot[bot]
eba7c522db
Bump webmock from 3.10.0 to 3.11.0 (#11986) 
Bumps [webmock](https://github.com/bblimke/webmock) from 3.10.0 to 3.11.0.
- [Release notes](https://github.com/bblimke/webmock/releases)
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md)
- [Commits](https://github.com/bblimke/webmock/compare/v3.10.0...v3.11.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-21 11:57:13 -05:00
dependabot[bot]
6b11fc4f6c
Bump @storybook/addon-links from 6.1.5 to 6.1.11 (#11988) 
Bumps [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/addons/links) from 6.1.5 to 6.1.11.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.11/addons/links)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-21 16:36:35 +01:00
rhymes
20ecc52bb5
Add rel noopener to footer links (#11994) 2020-12-21 16:24:33 +01:00
dependabot[bot]
5f71697cbf
Bump flipper-ui, flipper-active_record and flipper (#11990) 
Bumps [flipper-ui](https://github.com/jnunemaker/flipper), [flipper-active_record](https://github.com/jnunemaker/flipper) and [flipper](https://github.com/jnunemaker/flipper). These dependencies needed to be updated together.

Updates `flipper-ui` from 0.19.1 to 0.20.0
- [Release notes](https://github.com/jnunemaker/flipper/releases)
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md)
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.19.1...v0.20.0)

Updates `flipper-active_record` from 0.19.1 to 0.20.0
- [Release notes](https://github.com/jnunemaker/flipper/releases)
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md)
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.19.1...v0.20.0)

Updates `flipper` from 0.19.1 to 0.20.0
- [Release notes](https://github.com/jnunemaker/flipper/releases)
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md)
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.19.1...v0.20.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-21 09:21:29 -06:00
dependabot[bot]
4f1e04b6f9
Bump intersection-observer from 0.11.0 to 0.12.0 (#11923) 
Bumps [intersection-observer](https://github.com/w3c/IntersectionObserver) from 0.11.0 to 0.12.0.
- [Release notes](https://github.com/w3c/IntersectionObserver/releases)
- [Commits](https://github.com/w3c/IntersectionObserver/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-21 15:34:01 +01:00
dependabot[bot]
bba592fc06
Bump eslint from 7.15.0 to 7.16.0 (#11987) 
Bumps [eslint](https://github.com/eslint/eslint) from 7.15.0 to 7.16.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v7.15.0...v7.16.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-21 15:33:43 +01:00
dependabot[bot]
9c5f7d956a
Bump eslint-config-prettier from 7.0.0 to 7.1.0 (#11989) 
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 7.0.0 to 7.1.0.
- [Release notes](https://github.com/prettier/eslint-config-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prettier/eslint-config-prettier/compare/v7.0.0...v7.1.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-21 15:33:26 +01:00
Nick Taylor
c24cf73b28
Fixed initial e2e test now that data updates are run. (#11958) 
* Fixed initial e2e test now that data updates are run.

* Clearing any indices created in ES during E2E tests.

* Fixed a typo.

* Fixed env vars not being loaded.

* Prefixed data updates command with bundle exec.

* Promoted setting secret to the global section of the Travis config.

* Stopped sourcing .env and promoted ELASTICSEARCH_URL to global section of Travis configuration.

* Had to fix cc reporter in my PR to get PR to work.
 2020-12-21 08:40:11 -05:00