Commit graph

1743 commits

Author SHA1 Message Date
HKrogstie
2f9e581098 Remove double string escape by removing stip_tags from title (#3531)
* Remove double string escape by removing stip_tags from title

The field is escaped in views/articles/_liquid.html.erb

* Use sanitize for article title in liquid tag spec, add test

* Fix wrong comments

* Add tag to see that they are kept through rendering of liquid tags

* Fix error in test

* Try hack for sanitizing the way rails does it

* Use CGI.escapeHTML to keep tags in liquid tag link titles
2019-07-24 20:48:26 -04:00
Haseeb Elahi
33cb8050e7 Improve milestone notification's language (#3533) [ci skip] 2019-07-24 12:03:11 -04:00
rhymes
1e72749cc0 Remove unnecessary pluck calls (#3534) [ci skip] 2019-07-24 12:01:09 -04:00
Kitten King
6290451273 Fix Typos (#3510) 2019-07-22 12:56:48 -04:00
Andy Zhao
e604bf729c Use each instead of find_each to preserve order (#3519) 2019-07-22 11:24:57 -04:00
Mario See
ed35ab71a5 Open "buy credits" link in new tab in creating listings (#3506)
* open in new tab

* add no opener and no referrer rel to links opening in new tab
2019-07-22 08:08:36 -07:00
Anna Buianova
95a9e13922 Remove logic relying on old podcast status (#3505) 2019-07-19 09:30:51 -04:00
Ali GOREN
36189e94af Add share to hacker news link (#3297) [ci skip] 2019-07-18 11:30:39 -04:00
Anna Buianova
445bb0952c Open a page in a new tab w/o warning when playing a podcast #2958 (#3499) 2019-07-18 09:51:08 -04:00
Andy Zhao
33302d9a0d Use each instead of find_each to keep order (#3501) 2019-07-17 17:01:11 -04:00
Bolarinwa Balogun
cdd8870de5 Add copy button to markdown image upload (#2957) 2019-07-17 11:05:21 -04:00
Mac Siri
9f6cf61911
Update Banisher (#3495) [ci skip] 2019-07-16 19:08:06 -04:00
Elecweb
ebf9208877 Add support for hotkey to toggle article preview (#3308) [ci skip] 2019-07-16 14:35:45 -04:00
Anna Buianova
94ab4e23fe Update podcast episode statuses #2952 (#3450) 2019-07-16 13:36:25 -04:00
Andy Zhao
4da791e5af Cache bust the article's path and add minor improvement for banishing (#3492) 2019-07-16 13:17:29 -04:00
Andy Zhao
b4e493ec30 Redirect to actual latest published thread for /welcome (#3488) 2019-07-15 17:03:47 -04:00
Mac Siri
e28aaecca4
Make xhr request's method dynamic for archiving. (#3335) 2019-07-15 14:40:01 -04:00
andrewrod33
bbc83da539 Fix ampersand not being escaped in Twitter share from the hamburger menu (#3466) 2019-07-15 11:27:32 -04:00
Ben Halpern
47eaa9ece1
Adjust listings social image and add "About Listings" button to show page. (#3468)
* Adjust size and contrast for listings social preview

* Add about listings button and modify listings css
2019-07-12 16:40:39 -04:00
Alexander Sandberg
32ff90d4fe Add missing "dev-badge" class for proper night mode styling (#3467) [ci skip] 2019-07-12 15:32:29 -04:00
Ben Halpern
966f48f9b6
Add watercooler as sidebar tag and watercooler flare (#3465)
* Add watercooler as sidebar tag and watercooler flare

* Fix black box cached_tag_list_array check

* Adjust blackbox spec
2019-07-12 14:24:33 -04:00
Mario See
1fcd6bb77b Fix location link in listing (#3464) 2019-07-12 13:02:12 -04:00
Anna Buianova
135d1ddf2b Don't check url and create podcast episode when there's no enclosure url (#3460)
* Don't check url and create podcast episode when there's no enclosure url

* Keep a couple of records of podcast's rss for test
2019-07-12 12:54:14 -04:00
Anna Buianova
567579daf3 Podcast episodes statuses #2952 (#3386) 2019-07-12 10:03:57 -04:00
Ben Halpern
49eb9c00cb
Fix chat channel details profile pic issue (#3458) 2019-07-12 09:33:40 -04:00
Alexander Sandberg
eea2ec2d21 Add inverted styling for social links in night mode (#3459) 2019-07-12 09:33:26 -04:00
Ben Halpern
f3fc121053
Fix copy on sponsorship page (#3452) 2019-07-11 17:32:46 -04:00
rhymes
d5057f7958 Show sponsorships in ledger (#3447) 2019-07-11 16:06:31 -04:00
rhymes
611f4b8675 Sponsorship: remove old columns (step 3) (#3446)
* Remove old sponsorship columns

* Rename redundant param names
2019-07-11 15:35:24 -04:00
Sushant Bajracharya
01d1d1bcea Make the Preview button dynamic (#3317) 2019-07-10 19:14:14 -04:00
Mario See
699d8703c9 Make listing dashboard sortable (#3421) 2019-07-10 18:24:53 -04:00
Brandon Benefield
d4ff1f39f9 Fix long text code block preview (#3390) [ci skip] 2019-07-10 18:03:41 -04:00
rhymes
cecd1db070 Sponsorship: business logic (step 2) (#3440)
* Add Sponsorship model

* Add Sponsorship to admin

* Add correct relationships between models

* Add temporary script to migrate sponsorship data

* Use constants for enums

* Use Sponsorship model in PartnershipsController

* Use Sponsorship in the views

* Validate sponsorship levels and tag combos

* Replace the rest of the sponsorship code to use Sponsorship
2019-07-10 16:40:56 -04:00
rhymes
ad79116366 Sponsorship: add model (step 1) (#3438)
* Add Sponsorship model

* Add Sponsorship to admin

* Add correct relationships between models

* Add temporary script to migrate sponsorship data
2019-07-10 15:58:37 -04:00
Mario See
11be56f38c Add location to listings (#3370)
* add location to classified_listings

create rails migration and ran rake db:migrate

* add faker city to seed

* add location to index json

* add location as searchable attribute in algolia

* add form text field for adding location to new listing

* add location to dashboard json

* add location field for editing listings

* add location to listing_params in controller

* add location to single listing view

* add location to listing row in dashboard

* add location to dashboard test

* adjust listing dashboard row spacing

* reduce character limit

* reduce lines of conditional html elements

* compress listing card const

* fix form call for location in edit page

* update snapshot in dashboard

* add location length validation in listing model

* shorten limit and update location in edit page
2019-07-10 12:45:41 -04:00
Ben Halpern
b45a55662f
Fix slackbot ping issue and tag copy (#3434) 2019-07-09 23:06:28 -04:00
Ben Halpern
091a0d1087
Add basic pro accounts lander test (#3433) 2019-07-09 22:10:50 -04:00
Ben Halpern
5545246a6a
Update self-serve sponsorship copy/functionality (#3416)
* Transform GET sign in links into POST

* Ignore CVE-2015-9284 for now

* Update app/views/layouts/_signup_modal.html.erb

Co-Authored-By: Mac Siri <krairit.siri@gmail.com>

* Modify sponsorship copy

* Update sponsorship stuff

* Fix spec and add tag sponsorship
2019-07-09 17:49:14 -04:00
Mac Siri
28e5ef1d12 Make RSS's self-referential link an option (#3428)
* Create migration

* Run migration

* Update validations

* Add additional form

* Update RssReader::Assembler#thorough_parsing

* Add spec for referential
2019-07-09 17:34:21 -04:00
Mac Siri
90f54773dc
Fix GistTag & RunkitTag preview issue (#3388) 2019-07-09 15:58:08 -04:00
Ben Halpern
87002e5786
Fix profile pin display limit (#3427) 2019-07-09 15:42:46 -04:00
Ben Halpern
a8ef9663a4
Add internal page for spinning up group chats (and make jokes flare tag) (#3384) 2019-07-09 13:04:58 -04:00
rhymes
1f97669e66 Credits ledger (#3395)
* Add #purchase to Credit

* Assigns spent credits to the listing

* Add Credits::Ledger and use it

* Localize ledger datetimes

* Add organization to the ledger

* Add tests for ledger

* Remove unused class

* Fix scope error

* Compare UTC times

* Fix broken specs

* Wrap listing create in a transaction

* Wrap listings bump into a transaction

* Avoid microseconds issue with datetimes in tests

* Use .detect instead of .select.first

* Fix spec description
2019-07-09 10:11:18 -04:00
Zak Henry
a9acb8642e Add markdown to article api response (#3394)
* Add failing test asserting markdown is returned

* Add markdown to the get article api response
2019-07-09 10:09:20 -04:00
rhymes
5db8b7e1e5 Fix Rubocop lint (#3423) [ci skip] 2019-07-09 09:06:38 -04:00
Mac Siri
1afb572485 Revert "Mitigate CVE 2015-9284 (#3413)"
This reverts commit 002998adc5.
2019-07-08 20:10:12 -04:00
Mario See
42cb72d185 Listing Liquid Tag (#3250)
* init wip

still needs html, styling, and specs

* add more html

similar to singleListing.jsx

* add generate_new_liquid method to spec

* remove unexpected period

* add error handling for invalid slugs and expired listings

* initial styling

* styling for author and tags

* import variables to sass

* more styling and swithc tags and author info

* add specs

* handle error for slug with no category

* add listing tag to editor guide

* reduce complexity

* render expired listing rather than raise error

* update expired listing spec

* import mixins to classified listing tag styling
2019-07-08 18:19:01 -04:00
cyrillefr
3c1d51b836 Move RssReader fetch_user to Active Jobs (#3387)
- add job + spec job
  - refactor call
2019-07-08 18:17:35 -04:00
Ben Halpern
a5ccfb2b32
Add history to sidebar for pro users (#3417)
* Add history to sidebar for pro users

* Add filmstrip image
2019-07-08 18:10:01 -04:00
cyrillefr
5146532c82 Move messages send_push delay calls to ActiveJob (#3314) 2019-07-08 18:00:19 -04:00