maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix ampersand not being escaped in Twitter share from the hamburger menu (#3466)

Browse source
This commit is contained in:
andrewrod33 2019-07-15 08:27:32 -07:00 • committed by Ben Halpern
parent 0bbdb3cc21
commit bbc83da539
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/views/articles/_actions.html.erb
View file

@ -59,7 +59,8 @@
</div>
<web-share-wrapper shareurl="https://dev.to<%= @article.path %>" sharetext="<%= @article.title %>" template="web-share-button">
<div class="dropdown-link-row">
<a target="_blank" href='https://twitter.com/intent/tweet?text="<%= @article.title %>" by <%= @article.user.twitter_username ? "@" + @article.user.twitter_username : @article.user.name %> %23DEVcommunity https://dev.to<%= @article.path %>'>
<a target="_blank"
href='https://twitter.com/intent/tweet?text="<%= u @article.title.strip %>" by <%= @article.user.twitter_username ? "@" + @article.user.twitter_username : @article.user.name %> %23DEVcommunity https://dev.to<%= @article.path %>'>
Share to Twitter
</a>
</div>