Ben Halpern
6131c4f03c
[deploy] Remove hardcoded banner exit code ( #7018 )
...
* Remove hardcoded banner exit code
* Fix issues with html variant name
* Fix html call logic
2020-04-02 12:08:13 -04:00
Molly Struve
eabc51eac1
Revert "set search cache header using the current_user id if present ( #6982 )" ( #6984 )
...
This reverts commit da916ae8e6
2020-03-31 16:24:44 -05:00
Molly Struve
da916ae8e6
[deploy] set search cache header using the current_user id if present ( #6982 )
2020-03-31 15:01:06 -05:00
Ben Halpern
e35d55c422
Add pagination to tag pages for better SEO crawling ( #6771 ) [deploy]
...
* Add pagination to tag pages for better SEO crawling
* Modify system specs
* Add some tests
* Finalize tests
* Fix things up
* Add url helpers
2020-03-27 10:34:42 -04:00
rhymes
47ebd53be8
Add ARel SQL quoting to COALESCE ( #6804 ) [deploy]
2020-03-24 15:44:19 +01:00
rhymes
ff739bb8f8
Fix collection order with cross posted articles ( #6768 ) [deploy]
2020-03-23 16:05:32 +01:00
Ben Halpern
e19a1a43be
Small fixes/adjustments ( #6501 ) [deploy]
2020-03-06 09:28:42 -05:00
Ben Halpern
afc8594dd9
Switch from cookies to localstorage for hero banner ( #6498 ) [deploy]
2020-03-06 08:54:36 -05:00
Josh Puetz
6d7cbfff1f
Restore featured story on timeframe pages for logged out users ( #6427 ) [deploy]
...
* Restore featured story on timeframe pages for logged out users
* Handle arrays and empty collections when finding featured article
2020-03-04 08:01:24 -06:00
Ridhwana
55909afdc7
Make Hero Banner closable ( #6333 ) [deploy]
...
* feat: set up an event handler that will allow close the banner and set a cookie when you've closed it
* feat: return early if the cookie says it shouldn't be shown
* refactor: make the names more general so that they can be applied to other campaigns
2020-02-27 12:06:37 -05:00
Anna Buianova
e2cb359b2d
Change sidebar campaign view ( #6228 ) [deploy]
...
* Changed sidebar campaign view
* feat: update the hml of the campaign sidebar config (do not show broken image if the link has not been set)
* feat: update the html and css to make it look like Figma
* chore: revert the classname change as we use write elsewhere
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2020-02-26 10:36:18 -05:00
Matej Minárik
e9a0efbbf2
Fix broken StoriesController#show article with bad chars ( #6248 ) [deploy]
2020-02-24 13:41:06 -05:00
Ben Halpern
6bcfa73412
Fix algolia paginate issue and other feed problems ( #6281 ) [deploy]
...
* Fix algolia paginate issue and other feed problems
* Remove unnecessary limit
2020-02-24 13:14:50 -05:00
rhymes
bc385ae6d5
Switch decorators to Rails builtin decorations - take 2 ( #6125 ) [deploy]
...
* Revert "Revert "[deploy] Switch decorators from Draper to Rails builtin decorations (#6040 )" (#6122 ) [deploy]"
This reverts commit d438349550
2020-02-19 15:30:53 -05:00
Josh Puetz
35c2800c89
Add json support at stories/index endpoint ( #6070 )
...
* Add json support at stories/index endpoint
* Tweak tests
* Add main image
* Some light refactoring in StoriesController
* Tiny test refactor
* Split feed generation to it's own controller
* Use Jbuilder for article formatting
* Blank lines thanks Rubocop
* Don't cache this response: we want it generated per use each time
* Whoops!
* PR changes and tweaks to Timeframmer constants
* Remove initializer test since arguments aren't required
2020-02-18 15:15:40 -06:00
Ridhwana
39007b4dab
Campaign settings ( #6141 ) [deploy]
...
* feat: port over changes (+ suggestions) from https://github.com/thepracticaldev/dev.to/pull/5892/files
* chore: add query over multiple lines
* refactor: move the sql logic into the controller instead of in the template
* chore: appease code climate
2020-02-18 11:02:09 -06:00
Ridhwana
8641f0a93e
Update the number of Published Posts to match the approved articles where necessary. ( #6098 )
...
* feat: the number of published posts should show up by approved article.
* chore: Do not use spaces between -> and ( in lambda literals
* refactor: use the existing function in order to spawn the one where we need approval
* refactor: move logic to the controller instead of the view :)
* chore: code climate syntax
* chore: more codeclimate
2020-02-17 12:18:33 -05:00
Josh Puetz
38622317b7
Consolidate server side main article feed logic ( #5953 ) [deploy]
...
* Consolidate `.decorate` calls
* Move Activerecord finders out of main stories feed partial
* Add back in decorates to sticky_articles partial
* Combine top and new articles returned from StoriesController
* Extract feed construction logic to a service
* Some PR tweaks (naming)
* Quick test fix
2020-02-12 08:43:20 -06:00
Ben Halpern
ba6c70c2d2
[deploy] Raise not_found for spam-banished users ( #5586 )
...
* Raise not_found for banished users
* Move banished logic to decorator
2020-01-20 14:50:22 -05:00
Ben Halpern
c0a7c17054
Modify podcast design details and functionality ( #5472 ) [deploy]
...
* Modify podcast design details and functionality
* Adjust play button size
* Add heroku slug commit to some cache keys
2020-01-14 13:56:47 -05:00
Anna Buianova
dcfa6d29b8
Fix Rubocop lints ( #5155 )
2019-12-19 10:09:37 -05:00
Duc Nguyen
2ebe70039a
Feat: #3498 Display episode's published_at ( #4272 )
...
* feat: #3498 Display episode's published_at
* feat: #3498 Move methods to decorator
* feat: #3498 Add check if published_at present
* feat: #3498 Add testcase for showing published_at
* Fix build failure #3498
https://travis-ci.com/thepracticaldev/dev.to/builds/130734935
* feat: #3498 Fix testcase failed on Travis 130738295
* feat: #3498 Address comments on PR #4272
* feat: #3498 Delete unused
* feat: #3498 Refactor the use of decorate
2019-10-08 17:06:46 -04:00
Ben Halpern
b1b408e61c
Add more variation to home feed ( #4069 )
...
* Add more variance to home feed
* Fix array typo
* Fix up watercooler spec
* Fix up blackbox spec
2019-09-19 12:58:11 -07:00
Feruz Oripov
0ccc62ffa3
Refactoring possible unprotected redirect. ( #3825 )
...
* Refactoring possible unprotected redirect.
* Security refactoring tag_adjustments_controller.rb.
* Security refactoring tag_adjustments_controller.rb.
* Security refactoring articles_controller.rb.
* Security refactoring internal/welcome_controller.rb
* Security refactoring tags_controller.rb.
* Security refactoring comments_controller.rb.
* Security refactoring stories_controller.rb.
2019-08-27 10:13:38 -04:00
Anna Buianova
fabaeb5461
Introduced published field to podcasts ( #3593 )
...
* Published field for podcasts
* Add podcasts migration
* More specs for podcasts availability
* Show published in podcasts internal
* Update schema.rb with db:migrate
2019-08-01 09:29:13 -04:00
rhymes
1e72749cc0
Remove unnecessary pluck calls ( #3534 ) [ci skip]
2019-07-24 12:01:09 -04:00
Anna Buianova
567579daf3
Podcast episodes statuses #2952 ( #3386 )
2019-07-12 10:03:57 -04:00
Anna Buianova
d6a151703c
Podcasts reachable status #2952 ( #3341 )
...
* Podcasts reachable status #2952
* Specs for podcasts statuses
2019-07-02 09:18:27 -04:00
Ben Halpern
dcbb188cf1
Add pinned articles box to profiles ( #3269 )
...
* Initial pins work
* Add pin box to profiles
* Fix test snapshot spacing and optimize svg
* Fix listings spacing
2019-06-24 15:18:29 -04:00
Ben Halpern
456931f208
Further generalize pages and site Twitter handle ( #3177 )
...
* Further generalize pages and site Twitter handle
* Add footer mod change
* Remove giveaways dead code
2019-06-16 00:59:11 -04:00
Ben Halpern
2aa01d44a2
Add listings to home page ( #2912 )
2019-05-21 10:21:49 -04:00
Ben Halpern
c76abbbdb3
Allow users to follow podcasts ( #2690 )
...
* Allow users to follow podcasts
* Only display podcasts user follows
* Add main_color_hex to factory
* Fix podcast test and modify styles
* Fix tests
* Remove weird test
2019-05-04 15:30:40 -04:00
Ben Halpern
5e64ae874e
Remove includes user from stories query to reduce num queries and memory ( #2662 )
...
* Add profile_image_90 to serialized data on article
* Remove includes user from stories query
2019-05-02 15:58:58 -04:00
Ben Halpern
9578a15579
Remove unnecessary map functions in stories controller ( #2402 )
2019-04-12 01:10:08 -04:00
Ben Halpern
8c740b77ac
Add additional fragment caching to home page ( #2401 )
2019-04-12 00:42:28 -04:00
rhymes
5782ffd7e0
Use published scope for articles ( #2374 )
...
* Use published scope for articles
* Fix variable name
* The sequencing in the union query matters
* Fix spec
* Restore a published: true condition
* This test is actually misleading due to the union
* Revert this change, not sure why it's not a relation
* Fix useless diff
2019-04-11 13:18:26 -04:00
Andy Zhao
8ef611f879
Remove Honeycomb from the app ( #2366 )
...
* Remove Honeycomb related gems
* Remove Honeycomb related code from controllers
* Remove Honeycomb from RSS Reader
* Remove Honeycomb related files
* Remove Honeycomb related tests
* Remove leftover Honeycomb methods
2019-04-11 10:49:35 -04:00
Ben Halpern
bd95c6a8bf
Fix human language detection ( #2338 )
...
* Update language detection
* Modify feed to account for languages
2019-04-08 15:47:29 -04:00
Abraham Williams
b98565a931
Update rubocop to 0.67 ( #2313 ) [ci skip]
2019-04-05 12:55:13 -04:00
Abraham Williams
9cb40e546b
Enables Rails cops ( #2186 )
...
* Enable Rails cops
* Fix Rails/DynamicFindBy
* Fix Rails/HttpStatus
* Fix Rails/Blank
* Fix Rails/RequestReferer
* Fix Rails/ActiveRecordAliases
* Fix Rails/FindBy
* Fix Rails/Presence
* Fix Rails/Delegate
* Fix Rails/Validation
* Fix Rails/PluralizationGrammar
* Fix Rails/Present
* Fix Rails/Output
* Fix Rails/Blank
* Fix Rails/FilePath
* Fix Rails/InverseOf
* Fix Rails/LexicallyScopedActionFilter
* Add Rails/OutputSafety to TODO
* Add Rails/HasManyOrHasOneDependent to TODO
* Add Rails/SkipsModelValidations to TODO
2019-03-25 09:25:55 -04:00
Tim Lange
3494264404
Enabled rubocop/lint ( #2130 )
...
* WIP: Enabled rubocop/lint
* FIX: Fixed failing test
* FIX: Small change to return
* FIX: Changed indent
2019-03-21 10:53:44 -04:00
Jess Lee
9c1e10cd9f
Improve Internal Dashboards features( #2043 )
2019-03-18 16:29:11 -04:00
Keshav Biswa
8d57d45ecc
Rubocop Style cops enabled ( #2056 )
...
* Rubocop enabled style/alias
* Enabled Style/ArrayJoin Cop
* Enabled Style/Attr
* Enabled Case Equality
* Enabled CharacterLiteral
* Enabled ColonMethodCall Cop
* Enabled CommentAnnotation cop
* Enabled PreferredHashMethods Cop
* Enabled DoubleNegation Cop
* Enabled EachWithObject Cop
* Enabled EmptyLiteral Cop
* Enabled EvenOdd Cop
* Enabled IfWithSemicolon Cop
* Enabled Lambda and LambdaCall Cop
* Enabled LineEndConcatenation Cop
* Enabled ModuleFunction Cop;
* Enable NegatedIf and NegatedWhile Cop
* Enabled NilComparison Cop
* Enabled Not Cop
* Enabled NumericLiterals Cop
* Enabled OneLineConditional Cop
* Enabled PercentLiteralDelimiters Cop
* Excluded internal/users_controller from negated_if cop
* Reverted the double negation change from github_issue_tag and github_issue.rb"
* Enabled PerlBackrefs Cop
* Changed Regexp.last_match(1) to Regexp.last_match(0)
* Enabled proc cop
* Enabled RaiseArgs Cop
* Reverted Regexp.last_match(0) to Regexp.last_match(1)
* Enabled SelfAssignment Cop
* Enabled SingleLineMethods Cop
* Enabled SpecialGlobalVars Cop
* Enabled VariableInterpolation Cop
* Enabled WhenThen Cop
* Enabled WhileUntilModifier Cop
* Enabled WordArray Cop
* Enabled IfUnlessModifier Cop
* Enabled GuardClause Cop
2019-03-15 18:33:54 -04:00
Ben Halpern
ecb9f6da3d
Remove some hardcoded shecoded stuff ( #2011 )
2019-03-08 18:08:48 -08:00
Ben Halpern
27662eb924
Ben/shecoded tweaks ( #2007 )
...
* A few shecoded tweaks
* Refactor code
2019-03-08 08:16:10 -08:00
Ben Halpern
532903c688
Add experience level averaging to articles ( #1922 )
...
* Add experience level averaging to articles
* Adjust copy on /mod ratings page
2019-02-28 08:17:29 -08:00
Sean
1acd5b78ef
Display tag moderators on tag page ( #1739 )
2019-02-12 14:58:31 -05:00
Ben Halpern
4bff494adc
Ping comments to pre-warm new comment trees ( #1755 )
2019-02-06 21:45:24 -04:00
Ben Halpern
71a419e5ee
Add profile_updated_at and github_repos_updated_at to avoid extra fet… ( #1754 )
...
* Add profile_updated_at and github_repos_updated_at to avoid extra fetches
* Fix variant_number issue
* Fix test
2019-02-06 20:39:15 -04:00
Ben Halpern
152f4a52ea
Remove unnecessary queries ( #1717 )
...
* filter unnecessary queries
* Adjust article query in a couple places
* Replace tagged_with in main tag query
* Cache_tagged_with additional queries
* Modify test
* Modify cached_tagged_with to account for single tags
* Add cached_tagged_with in a few more places
2019-02-02 21:40:34 -04:00
