maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make Hero Banner closable (#6333) [deploy]

Browse source 
* feat: set up an event handler that will allow close the banner and set a cookie when you've closed it

* feat: return early if the cookie says it shouldn't be shown

* refactor: make the names more general so that they can be applied to other campaigns
This commit is contained in:
Ridhwana 2020-02-27 19:06:37 +02:00 • committed by GitHub
parent da133bcbb5
commit 55909afdc7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/assets/javascripts/initializePage.js.erb
View file

@ -45,8 +45,8 @@ function callInitalizers(){
initializeCreditsPage();
initializeUserProfilePage();
initializePodcastPlayback();
initializeDrawerSliders();
initializeHeroBannerClose();
function freezeScrolling(event){
event.preventDefault();

13
app/assets/javascripts/initializers/initializeHeroBannerClose.js Normal file
View file

@ -0,0 +1,13 @@
'use strict';
function initializeHeroBannerClose() {
let banner = document.getElementById("js-hero-banner");
let closeIcon = document.getElementById("js-hero-banner__x");
if (banner && closeIcon) {
closeIcon.onclick = (e) => {
document.cookie = "heroBanner=false";
banner.style.display = "none";
}
}
}

2
app/controllers/stories_controller.rb
View file

@ -56,7 +56,7 @@ class StoriesController < ApplicationController
private
def assign_hero_html
return if SiteConfig.campaign_hero_html_variant_name.blank?
return if SiteConfig.campaign_hero_html_variant_name.blank? || cookies[:heroBanner] == "false"
@hero_html = HtmlVariant.relevant.select(:html).
find_by(group: "campaign", name: SiteConfig.campaign_hero_html_variant_name)&.html