Commit graph

8659 commits

Author SHA1 Message Date
Jamie Gaskins
e953b67ce5
Fix user_id tag in EDAC traces (#13213) 2021-03-31 15:58:08 -04:00
Molly Struve
8fac1b756c
Optimization:Remove Twitter Counts From User Table in db (#13208) 2021-03-31 14:44:15 -05:00
dependabot[bot]
3b61179515
Bump @storybook/addon-storysource from 6.1.21 to 6.2.1 (#13207)
Bumps [@storybook/addon-storysource](https://github.com/storybookjs/storybook/tree/HEAD/addons/storysource) from 6.1.21 to 6.2.1.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.2.1/addons/storysource)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-31 13:27:00 -06:00
dependabot[bot]
a9c47699e6
Bump @storybook/addon-knobs from 6.1.21 to 6.2.1 (#13205)
Bumps [@storybook/addon-knobs](https://github.com/storybookjs/storybook/tree/HEAD/addons/knobs) from 6.1.21 to 6.2.1.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.2.1/addons/knobs)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-31 12:36:44 -06:00
dependabot[bot]
93c80b35af
Bump @testing-library/user-event from 13.0.16 to 13.1.1 (#13204)
Bumps [@testing-library/user-event](https://github.com/testing-library/user-event) from 13.0.16 to 13.1.1.
- [Release notes](https://github.com/testing-library/user-event/releases)
- [Changelog](https://github.com/testing-library/user-event/blob/master/CHANGELOG.md)
- [Commits](https://github.com/testing-library/user-event/compare/v13.0.16...v13.1.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-31 12:05:16 -06:00
Vaidehi Joshi
52b3d47a04
Remove pro role from users and database (#13176) 2021-03-31 09:34:10 -07:00
Nick Taylor
38aa5bd96c
Added the no-only-tests eslint rule to the cypress eslint config. (#13191) 2021-03-31 12:20:17 -04:00
Molly Struve
20c6b39a30
Optimization:Remove Unused Twitter Counts from User (#13196) 2021-03-31 10:57:03 -05:00
dependabot[bot]
3cebaf1d66
Bump faker from 5.5.1 to 5.5.2 (#13199)
Bumps [faker](https://github.com/Marak/Faker.js) from 5.5.1 to 5.5.2.
- [Release notes](https://github.com/Marak/Faker.js/releases)
- [Changelog](https://github.com/Marak/faker.js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Marak/Faker.js/compare/v5.5.1...v5.5.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-31 09:16:33 -06:00
dependabot[bot]
cf4ccf03c9
Bump listen from 3.5.0 to 3.5.1 (#13197)
Bumps [listen](https://github.com/guard/listen) from 3.5.0 to 3.5.1.
- [Release notes](https://github.com/guard/listen/releases)
- [Commits](https://github.com/guard/listen/compare/v3.5.0...v3.5.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-31 08:11:09 -06:00
dependabot[bot]
5323113f67
Bump @testing-library/dom from 7.30.1 to 7.30.3 (#13203)
Bumps [@testing-library/dom](https://github.com/testing-library/dom-testing-library) from 7.30.1 to 7.30.3.
- [Release notes](https://github.com/testing-library/dom-testing-library/releases)
- [Changelog](https://github.com/testing-library/dom-testing-library/blob/master/CHANGELOG.md)
- [Commits](https://github.com/testing-library/dom-testing-library/compare/v7.30.1...v7.30.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-31 07:52:51 -06:00
Suzanne Aitchison
6f057fc8ce
Add mention autocomplete to posts (#13101)
* WIP - initial exploration into post mentioon autocomplete

* replace the autosize textarea with mention autocomplete, adjusting height

* add cypress tests for mentioning in a post

* fix resizing of text areas

* refactor text area resize hook

* refactoring

* update cypress tests

* remove mergeRefs from utils, extract UserListItemContent

* allow useTextAreaAutoResize elements to have height greater than minimum, apply styles to container

* Trigger Travis CI

* Travis plz

* small refactors

* add comments and constants as per PR feedback

Co-authored-by: Nick Taylor <nick@dev.to>
2021-03-31 14:42:59 +01:00
Ridhwana
4848a8b2e1
User Settings Step 1: Add user_settings and user_notification_settings tables (rfc#32) (#12768)
* feat: add the two new models users_setting and users_notification_setting

* feat: add the settings and notification_settings table to the schema

* feat: add the user and notification models

* feat: add the user_id foreign key to the model

* chore: sneaky indent

* feat: add some fields from the profile attributes

* Revert "feat: add some fields from the profile attributes"

This reverts commit 376828746ded063a243505d317140fa5339227cf.

* chore: add some profile field attributes

* chore: remove language_settings

* chore: update indent

* chore: remove language_settings

* feat: changes to the tables

* chore:  remove validation in favor of the foreign keys

* chore: add default for editor version

* Address PR review suggestions

* setting_spec.rb needs to be fixed; need help

* Working on PR review comments

* Continue with addressing PR review comments

* Remove normalize_config_values method; pass correct values from forms

* Address Travis failures

* revert some unnecessary changes in spec file

Co-authored-by: Arit Amana <msarit@gmail.com>
2021-03-31 14:37:46 +02:00
dependabot[bot]
d77b21b9b5
Bump postcss from 8.2.8 to 8.2.9 (#13198) 2021-03-31 05:59:03 -04:00
Vaidehi Joshi
95055b2a89
Remove pro role + expose analytics to all users via dashboard (#13156)
* Remove pro role on user, expose pro dashboard to all users as analytics

* Remove pro from Elasticsearch mappings

* Update user role docs to use :trusted over :pro

* Remove pro from Role model spec

* Remove more references to pro, as noted by @rhymes
2021-03-30 15:02:18 -07:00
Molly Struve
2534a8aa5f
Doc Update:Remove no longer used tech from overview docs (#13192) 2021-03-30 16:41:38 -05:00
Molly Struve
c410c2a645
Bug Fix:Remove Suggest a Tweet since we no longer have that feature (#13188) 2021-03-30 15:17:25 -05:00
Nick Taylor
b7fb9f0917
[15 Min Fix] Got rid of some E2E test flakiness (#13187)
* Finding this button by role makes the test always pass on my local. CI was fine.

* Fixed another flaky test.
2021-03-30 14:58:12 -04:00
Vaidehi Joshi
7fbbfa0a2d
[15 Min Fix]: Fix template error in badge achievement notification view (#13186)
* Fix template error in badge achievement notification view

Fixes https://app.honeybadger.io/projects/72638/faults/78624140.

* hello travis are you there its me vaidehi

* why arent you building my PR come onnnnn
2021-03-30 10:45:37 -07:00
Suzanne Aitchison
7af30e8bfc
reinstate reply to comment e2e test (#13181)
* reinstate reply to comment e2e test

* refactor selector for reply comment box

* refactor and remove data testid no longer needed
2021-03-30 16:31:07 +01:00
dependabot[bot]
ae51dc0466
Bump @babel/core from 7.13.13 to 7.13.14 (#13178) 2021-03-30 07:39:48 -04:00
dependabot[bot]
fcd5a6fd35
Bump svgo from 2.2.2 to 2.3.0 (#13179) 2021-03-30 07:21:14 -04:00
Nick Taylor
71d7be16b8
[15 minute fix] Now mention auto-complete dynamic imports are cached. (#13146)
* Now mention auto-complete dynamic imports are cached.

* Removed explicit setting of undefined.

* Put back setting window.Forem.mentionAutoCompleteImports to undefined to be explicit.
2021-03-30 13:20:15 +02:00
Nick Taylor
871650053c
[15 minute fix] Fixed bug with templates not being inserted for comments. (#13149)
* Fixed bug with templates not being inserted for comments.

* Removed some trailing white space from a heading.

* Added custom Cypress command to create an article.

* Added E2E tests for creating comments on an article.

* Fixed adding a comment issue caused by mention auto-complete.

* Fixed a selector for the E2E tests.

* Removed some unnecessary white space and also making code climate happy.

* Updated E2E test.

* Added a bit more to the E2E tests.

* Now validation for comment doesn't need to loop through textareas.

* Merge remote-tracking branch 'origin/master' into nickytonline/fix-comment-template-insertion-bug

* Removed a similar spec file and added tests to the other file.

* wip

* Fixed bug where a response template could not be submitted.

* Added/updated E2E tests.

* Reverted a small change to condition for showing the combobox popover.

* Undoing some white space changes as not related to PR.

* Trigger Build

* Put back article seed data as it's used in tests outside of comment tests.
2021-03-30 13:02:54 +02:00
Anna Buianova
40b989ca62
Configure badge credits by admins (#13145)
* Added credits_awarded to /admin/badges forms

* Award credits only if badge has them

* Removed information about credits and listings in the new badge email when not needed

* Specs for number of credits awarded for badges

* Added missing newline

* Fix typo

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>

* Improve new_badge_email.text.erb

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>

* Fixed number of credits in notification

* Added specs for number of credits in notifications

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
2021-03-30 10:58:48 +03:00
dependabot[bot]
624c671fa4
Bump faker from 5.4.0 to 5.5.1 (#13159)
Bumps [faker](https://github.com/Marak/Faker.js) from 5.4.0 to 5.5.1.
- [Release notes](https://github.com/Marak/Faker.js/releases)
- [Changelog](https://github.com/Marak/faker.js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Marak/Faker.js/commits/v5.5.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-29 12:17:39 -06:00
dependabot[bot]
5a15202c21
Bump eslint from 7.22.0 to 7.23.0 (#13168)
Bumps [eslint](https://github.com/eslint/eslint) from 7.22.0 to 7.23.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v7.22.0...v7.23.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-29 11:51:16 -06:00
Alex
1597318db8
[Search 2.0] Listings (#13133)
* Add PgSearch to Listing model

* Working MVP - pre-optimizations

* Remove includes

* Update search_spec

* Add more specs

* Fix specs

* Refactor filter_by_category

* Update block parameter name

* Add published index to classified_listings table

* Preload user, organization, and listing_category

* Working MVP - pre-optimizations

* Refactor filter_by_category

* Update schema

* Fix schema for real

* Remove constant specs and make them private
2021-03-29 13:22:16 -04:00
Mac Siri
b636a2f063
Skip a flaky e2e spec (#13172) 2021-03-29 12:48:02 -04:00
Nick Taylor
d23a5a82e7
[15 Min Fix] Added the custom Cypress command, createResponseTemplate, to create comment templates. (#13167)
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-03-29 12:39:45 -04:00
Mac Siri
b12c6807fb
Update to use Node 14.x (#13136)
* Update to use Node 14.x

Prefer to a more widen node version

* Undo Containerfile changes
2021-03-29 11:27:20 -04:00
dependabot[bot]
680307ff58
Bump @reach/combobox from 0.13.2 to 0.14.0 (#13165)
Bumps [@reach/combobox](https://github.com/reach/reach-ui/tree/HEAD/packages/combobox) from 0.13.2 to 0.14.0.
- [Release notes](https://github.com/reach/reach-ui/releases)
- [Commits](https://github.com/reach/reach-ui/commits/v0.14.0/packages/combobox)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-29 10:42:24 -04:00
Jamie Gaskins
2d972fe394
Enable instrumentation for Heroku scheduler (#13169) 2021-03-29 10:16:19 -04:00
Julien Maury
7c71d1e31e
make clean_fork executable (#13163) 2021-03-29 16:13:23 +02:00
dependabot[bot]
98ac67c012
Bump @testing-library/jest-dom from 5.11.9 to 5.11.10 (#13143)
Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 5.11.9 to 5.11.10.
- [Release notes](https://github.com/testing-library/jest-dom/releases)
- [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md)
- [Commits](https://github.com/testing-library/jest-dom/compare/v5.11.9...v5.11.10)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-29 10:10:41 -04:00
dependabot[bot]
37c40390e4
Bump webmock from 3.12.1 to 3.12.2 (#13161) [deploy]
Bumps [webmock](https://github.com/bblimke/webmock) from 3.12.1 to 3.12.2.
- [Release notes](https://github.com/bblimke/webmock/releases)
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md)
- [Commits](https://github.com/bblimke/webmock/compare/v3.12.1...v3.12.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-29 08:10:19 -06:00
dependabot[bot]
37dbce2c07
Bump cloudinary from 1.19.0 to 1.20.0 (#13160) [deploy]
Bumps [cloudinary](https://github.com/cloudinary/cloudinary_gem) from 1.19.0 to 1.20.0.
- [Release notes](https://github.com/cloudinary/cloudinary_gem/releases)
- [Changelog](https://github.com/cloudinary/cloudinary_gem/blob/master/CHANGELOG.md)
- [Commits](https://github.com/cloudinary/cloudinary_gem/compare/1.19.0...1.20.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-29 08:07:38 -06:00
dependabot[bot]
6246b81dd1
Bump @babel/core from 7.13.10 to 7.13.13 (#13164)
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.13.10 to 7.13.13.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.13.13/packages/babel-core)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-29 15:39:10 +02:00
Jamie Gaskins
5a0a46887c
Instrument EmailDigestArticleCollector (#13153)
* Instrument EmailDigestArticleCollector

On DEV, since we skip this with sidekiq-cron and instead process them
inline using Heroku Scheduler (which is not instrumented), we miss out
on all instrumentation for this process and have no idea how long it
takes to process each user.

With this instrumentation in place, we can see how long it takes to
process each user and aggregate them to see how long it takes to process
all users.

This commit also adds an Instrumentation mixin that we can use to
instrument blocks easily:

    instrument "MyClass.my_method", tags: { article: article.id } do |span|
      # ...
    end

* Add Instrumentation mixin

Oops, completely forgot to commit this file
2021-03-29 09:33:32 -04:00
dependabot[bot]
25c3f79d30
Bump jsdom from 16.5.1 to 16.5.2 (#13157) 2021-03-29 08:29:09 -04:00
dependabot[bot]
2e702f2766
Bump @testing-library/dom from 7.30.0 to 7.30.1 (#13141) 2021-03-29 08:28:05 -04:00
dependabot[bot]
db79e6e37f
Bump ibm-openapi-validator from 0.38.0 to 0.39.0 (#13162) 2021-03-29 08:04:05 -04:00
Nick Taylor
ffff12ddc9
Rename previewArticle.js to previewArticle.spec.js (#13152) 2021-03-29 12:45:58 +02:00
Nick Taylor
d85d327c1d
[15 minute fix] Added custom Cypress command to create an article. (#13151) 2021-03-29 06:00:49 -04:00
dependabot[bot]
d47f4ffab0
Bump @testing-library/user-event from 13.0.10 to 13.0.16 (#13142)
Bumps [@testing-library/user-event](https://github.com/testing-library/user-event) from 13.0.10 to 13.0.16.
- [Release notes](https://github.com/testing-library/user-event/releases)
- [Changelog](https://github.com/testing-library/user-event/blob/master/CHANGELOG.md)
- [Commits](https://github.com/testing-library/user-event/compare/v13.0.10...v13.0.16)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-29 11:41:32 +02:00
dependabot[bot]
65c733ae60
Bump pusher from 2.0.0 to 2.0.1 (#13144)
Bumps [pusher](https://github.com/pusher/pusher-http-ruby) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/pusher/pusher-http-ruby/releases)
- [Changelog](https://github.com/pusher/pusher-http-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/pusher/pusher-http-ruby/compare/2.0.0...2.0.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-26 17:39:55 +01:00
Michael Kohl
1732396abc
Remove ignored Buffer columns (#13139) 2021-03-26 17:37:29 +01:00
Suzanne Aitchison
49c20a0c72
15 min fix - improve reliability of autocomplete cypress test (#13147) 2021-03-26 16:23:19 +00:00
Julianna Tetreault
11f1c9d487
Add a landing_page boolean to the Pages table (#13135) [deploy]
- Adds default: false to landing_page column
 - Adds null: false to landing_page column
 - Adds migration file and updated schema
2021-03-26 08:09:18 -06:00
Suzanne Aitchison
45a291047d
Re-add mention autocomplete to comments, fixing bugs (#13126)
* Revert "Revert "Add (updated) mention autocomplete to post comments (#13061)" (#13116)"

This reverts commit e28bde043c.

* Fix issues with editing comments and arrow key navigation, update tests

* Update app/javascript/crayons/MentionAutocompleteTextArea/MentionAutocompleteTextArea.jsx

Co-authored-by: Nick Taylor <nick@forem.com>

* refactor adding of attributes

* destructure

Co-authored-by: Nick Taylor <nick@forem.com>
2021-03-26 13:43:05 +00:00