Commit graph

8468 commits

Author SHA1 Message Date
Fernando Valverde
e6a2df73bf
Bypass event.respondWith for some paths (#12953) 2021-03-09 16:06:26 -06:00
Vaidehi Joshi
0460f96347
[15 Minute Fix]: Ensure crayons banners are accessible (#12919)
* Add aria-live attribute to crayons banners where necessary

* Add alert role to crayons banners that render error messages
2021-03-09 09:16:26 -08:00
rhymes
a992fcd8b4
Update README core contributors (#12951) 2021-03-09 17:59:38 +01:00
Rafi
dd63fe2bfe
Adding note about crayons design system in forem docs (#12838)
* Adding not about crayon in docs

* Update docs/frontend/styles.md

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

* Fixing wording

* Adding colon

Co-authored-by: Michael Kohl <me@citizen428.net>
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2021-03-09 10:50:14 -06:00
Daniel Uber
3b0029cb08
Add myself as a core contributor in the readme (#12950) 2021-03-09 10:21:14 -06:00
dependabot[bot]
4477d803b9
Bump ibm-openapi-validator from 0.35.0 to 0.35.1 (#12943)
Bumps [ibm-openapi-validator](https://github.com/IBM/openapi-validator) from 0.35.0 to 0.35.1.
- [Release notes](https://github.com/IBM/openapi-validator/releases)
- [Changelog](https://github.com/IBM/openapi-validator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/IBM/openapi-validator/compare/v0.35.0...v0.35.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-09 15:43:00 +01:00
dependabot[bot]
91bbe5eca6
Bump @babel/preset-env from 7.13.9 to 7.13.10 (#12944)
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.13.9 to 7.13.10.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.13.10/packages/babel-preset-env)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-09 15:42:53 +01:00
dependabot[bot]
314d23e058
Bump @babel/core from 7.13.8 to 7.13.10 (#12945)
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.13.8 to 7.13.10.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.13.10/packages/babel-core)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-09 15:42:38 +01:00
Andy Zhao
b83afedbe1
Hide mod button in mobile (#12915)
* Hide mod button in mobile

* Use span and old CSS to hide button appropriately
2021-03-09 09:40:07 -05:00
dependabot[bot]
19fd9832b7
Bump @stoplight/spectral from 5.8.1 to 5.9.0 (#12946)
Bumps [@stoplight/spectral](https://github.com/stoplightio/spectral) from 5.8.1 to 5.9.0.
- [Release notes](https://github.com/stoplightio/spectral/releases)
- [Changelog](https://github.com/stoplightio/spectral/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/stoplightio/spectral/compare/v5.8.1...v5.9.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-09 15:25:54 +01:00
dependabot[bot]
0999ec1c41
Bump elliptic from 6.5.3 to 6.5.4 (#12940)
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.3...v6.5.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-09 07:02:46 -06:00
Michael Kohl
667437ebf2
[15-minute fix] Add ThrottledCall to DisplayAdEventsController (#12924)
* Add ThrottledCall to DisplayAdEventsController

* Update old spec
2021-03-09 09:06:11 +07:00
Jamie Gaskins
c15120b902
Fix ddtrace warnings at app start (#12941)
* Load HTTPClient before Datadog

The instrumentation needs it to be loaded before it can patch the
request methods.

* Don't split HTTPClient traces on domains yet

After the service explosion in Datadog APM last time, let's take a more
cautious approach.

* Turns out, we aren't even using the aws-sdk gems

This was added because we use Fog's AWS adapter, but Fog uses Excon
(which we're already instrumenting) instead of the AWS SDK directly.
2021-03-08 16:27:33 -05:00
dependabot[bot]
6503e5cb62
Bump ibm-openapi-validator from 0.34.4 to 0.35.0 (#12927)
Bumps [ibm-openapi-validator](https://github.com/IBM/openapi-validator) from 0.34.4 to 0.35.0.
- [Release notes](https://github.com/IBM/openapi-validator/releases)
- [Changelog](https://github.com/IBM/openapi-validator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/IBM/openapi-validator/compare/v0.34.4...v0.35.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-08 11:15:01 -06:00
dependabot[bot]
19d729c018
Bump webmock from 3.12.0 to 3.12.1 (#12926)
Bumps [webmock](https://github.com/bblimke/webmock) from 3.12.0 to 3.12.1.
- [Release notes](https://github.com/bblimke/webmock/releases)
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md)
- [Commits](https://github.com/bblimke/webmock/compare/v3.12.0...v3.12.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-08 10:39:12 -06:00
dependabot[bot]
2f8da32732
Bump rspec-rails from 4.0.2 to 4.1.0 (#12929)
Bumps [rspec-rails](https://github.com/rspec/rspec-rails) from 4.0.2 to 4.1.0.
- [Release notes](https://github.com/rspec/rspec-rails/releases)
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md)
- [Commits](https://github.com/rspec/rspec-rails/compare/v4.0.2...v4.1.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-08 09:50:34 -06:00
dependabot[bot]
919675d2f8
Bump svgo from 2.2.0 to 2.2.1 (#12930)
Bumps [svgo](https://github.com/svg/svgo) from 2.2.0 to 2.2.1.
- [Release notes](https://github.com/svg/svgo/releases)
- [Changelog](https://github.com/svg/svgo/blob/master/CHANGELOG-old.md)
- [Commits](https://github.com/svg/svgo/compare/v2.2.0...v2.2.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-08 09:00:22 -06:00
dependabot[bot]
21d1513857
Bump @testing-library/dom from 7.29.6 to 7.30.0 (#12932) 2021-03-08 09:09:39 -05:00
dependabot[bot]
fe8e741b77
Bump jsdom from 16.4.0 to 16.5.0 (#12931)
Bumps [jsdom](https://github.com/jsdom/jsdom) from 16.4.0 to 16.5.0.
- [Release notes](https://github.com/jsdom/jsdom/releases)
- [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md)
- [Commits](https://github.com/jsdom/jsdom/compare/16.4.0...16.5.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-08 08:00:46 -06:00
rhymes
576aceab76
[Hotfix] Restore article content in RSS feed (#12935)
When https://github.com/forem/forem/pull/11268 we didn't test it thoroughly and
thus didn't detect that it wasn't working correctly and that it
resulted in an empty string in the `<description>` field.
2021-03-08 14:53:05 +01:00
Ridhwana
4b902b01c0
RFC#50-P2 Restructuring the sidebar to add nested nav items + tabbed nav items (#12886)
* feat: add the nested sidebar with some elements

* feat: create a tabbed nav item menu

* feat: add the tabbed nav_item partial to the views that need tabbed nav items

* fix: change variable back

* feat: style the sidebar a bit more

* chore: add some more styles

* feat: add a spec for the nested navigational items

* refactor: a more dynamic tabbed admin helper

* feat: add some more nav items

* fix: controller for reports

* refactor: shorthand if statement

* chore: add the whitespace back

* refactor: rubocop fixes

* chore: use any

* chore: remove whitespace

* refactor: rename the variable

* refactor: use a DSL style admin helper

* chore: variable renaming and routes

* rubocop: fixes

* refactor: move files to more apt places

* chore: keep overview as it was previously

* Update app/views/admin/secrets/index.html.erb

Co-authored-by: Michael Kohl <me@citizen428.net>

* Update app/views/admin/shared/_tabbed_navbar.erb

Co-authored-by: Michael Kohl <me@citizen428.net>

* Update app/views/admin/badges/index.html.erb

Co-authored-by: Michael Kohl <me@citizen428.net>

* chore: disable blocklength

* refactor: move the logic to the model instead of in the view

* chore: remove get_ prefix

* chore: move the request mangling to a helper that finds the controller and scope

* Update app/helpers/admin_helper.rb

Co-authored-by: rhymes <rhymes@hey.com>

* Update app/helpers/admin_helper.rb

Co-authored-by: rhymes <rhymes@hey.com>

* refactor: Address feedback

* oops

* oops use tr

* feat: update specs

* fix: badge achievements

Co-authored-by: Michael Kohl <me@citizen428.net>
Co-authored-by: rhymes <rhymes@hey.com>
2021-03-08 13:14:30 +02:00
dependabot[bot]
1169f92053
Bump autoprefixer from 10.2.4 to 10.2.5 (#12928)
Bumps [autoprefixer](https://github.com/postcss/autoprefixer) from 10.2.4 to 10.2.5.
- [Release notes](https://github.com/postcss/autoprefixer/releases)
- [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md)
- [Commits](https://github.com/postcss/autoprefixer/compare/10.2.4...10.2.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-08 09:51:49 +01:00
dependabot[bot]
9c6b69c580
Bump flipper from 0.20.3 to 0.20.4 (#12934)
Bumps [flipper](https://github.com/jnunemaker/flipper) from 0.20.3 to 0.20.4.
- [Release notes](https://github.com/jnunemaker/flipper/releases)
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md)
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.20.3...v0.20.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-08 09:51:37 +01:00
Jamie Gaskins
bd2d90d849
Mitigate service explosion in Datadog (#12918)
Splitting by domain caused an explosion in "services" tracked in Datadog
because it was counting each podcast platform and each blog as being
another service. Noramlly this would be what we want, but that's a lot
to ask for such a broad range of user-supplied domains.

Since each of these requests is made via HTTParty, which uses Net::HTTP
by default, this commit stops splitting in that library.

We'll need to come up with a better way of tracking this.
2021-03-05 17:30:29 -05:00
Jamie Gaskins
125df50a87
Expand Datadog instrumentation (#12908)
Expand Datadog instrumentation

This commit adds extra telemetry in Datadog for:

- Redis
  - We make 3 different Redis connections available, so this change
    shows us _which_ Redis instance a given query goes to
- Split HTTP requests by domain using:
  - net/http - default for Ruby
  - faraday - used by:
    - buffer
    - elasticsearch
    - gibbon
    - oauth2
    - octokit
    - sawyer
    - twilio
  - excon - used by:
    - fog
- AWS
- RestClient
  - Cloudinary
  - Pusher
- concurrent-ruby
  - ActiveSupport
  - brpoplpush-redis_script
  - i18n
  - sidekiq-unique-jobs
  - sprockets (do we even use this?)
- httpclient
  - pusher
- http.rb
  - twitter (omniauth)
  - honeycomb
2021-03-05 10:44:52 -05:00
Alex
619a058314
Setup pg_search (#12905)
* Add pg_search gem

* Add pg_search extensions
2021-03-05 10:30:27 -05:00
Michael Kohl
a6ee6578ca
Remove outdated language from RSS import (#12910) 2021-03-05 16:28:16 +01:00
dependabot[bot]
33df9a8c26
Bump @storybook/addon-docs from 6.1.20 to 6.1.21 (#12911)
Bumps [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/addons/docs) from 6.1.20 to 6.1.21.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.21/addons/docs)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-05 14:57:36 +00:00
Andy Zhao
6a55ad2a8d
Remove mod button from top nav bar in mobile (#12906)
* Hide mod button in mobile nav

* Remove unused CSS

* Add CSS back in since it was being used, and update classes

* Attach class to proper tag sigh

* Order based on screenshot from issue

Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>

Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>
2021-03-05 08:46:20 -05:00
Suzanne Aitchison
494d92d74c
Create mention autocomplete: initial storybook component (#12831)
* initial setup of component

* initial styles applied

* add some initial docs

* small tweaks to story

* add some very initial tests

* tweaks to styles to add border bottom

* add some preact tests

* import default style in jsx, ignore in jest

* WIP - create MentionAutocompleteListener, attempt to position popover

* position dropdown correctly, exit selection in various scenarios

* refactor

* make sure cursor placed correctly after selection

* only import autocomplete when needed

* rename files, add jsdoc

* update tests and story notes

* tidy up scss file

* fix story styling

* fix aria label in story

* fix issue with key event not triggering in mobile

* position dropdown at input left if small screen

* fix issue with deleting and re-entering

* don't trigger search if directly following a letter or number

* stop change event being fired with highihted text

* move regex out of function into constant
2021-03-05 13:18:26 +00:00
Kurnia Muhamad
cdd51ca500
Fix twitter liquid tag buttons misaligned (#12885)
* Fix twitter action buttons

* Fix twitter avatar misaligned
2021-03-05 12:18:45 +01:00
dependabot[bot]
eaf1de2bb2
Bump cloudinary from 1.18.1 to 1.19.0 (#12912)
Bumps [cloudinary](https://github.com/cloudinary/cloudinary_gem) from 1.18.1 to 1.19.0.
- [Release notes](https://github.com/cloudinary/cloudinary_gem/releases)
- [Changelog](https://github.com/cloudinary/cloudinary_gem/blob/master/CHANGELOG.md)
- [Commits](https://github.com/cloudinary/cloudinary_gem/compare/1.18.1...1.19.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-05 12:16:50 +01:00
Alex Timofeev
0ff8284a68
Exclude code highlight panel markup from RSS description (#11268)
* Introduce `plain_html` method with minified article body

* Add corresponding test case
2021-03-05 12:06:50 +01:00
dependabot[bot]
27295ecac2
Bump @storybook/addon-actions from 6.1.20 to 6.1.21 (#12896)
Bumps [@storybook/addon-actions](https://github.com/storybookjs/storybook/tree/HEAD/addons/actions) from 6.1.20 to 6.1.21.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.21/addons/actions)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-05 10:54:10 +07:00
Josh Puetz
87984566df
Disable serviceworkers in Safari part2 (#12909)
* Disable servicework on Safari browsers

* Update app/assets/javascripts/serviceworker-companion.js

Co-authored-by: Jamie Gaskins <jgaskins@hey.com>

* Test for serviceworkers and unregister

Co-authored-by: Jamie Gaskins <jgaskins@hey.com>
2021-03-04 19:14:44 -06:00
Josh Puetz
e83101e388
Disable serviceworkers on Safari browsers (#12907)
* Disable servicework on Safari browsers

* Update app/assets/javascripts/serviceworker-companion.js

Co-authored-by: Jamie Gaskins <jgaskins@hey.com>

Co-authored-by: Jamie Gaskins <jgaskins@hey.com>
2021-03-04 15:12:27 -06:00
dependabot[bot]
03b4f4a95a
Bump ddtrace from 0.45.0 to 0.46.0 (#12892)
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb) from 0.45.0 to 0.46.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases)
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md)
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.45.0...v0.46.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-04 17:22:55 +01:00
dependabot[bot]
87cad86dd2
Bump twilio-video from 2.12.0 to 2.13.0 (#12895)
Bumps [twilio-video](https://github.com/twilio/twilio-video.js) from 2.12.0 to 2.13.0.
- [Release notes](https://github.com/twilio/twilio-video.js/releases)
- [Changelog](https://github.com/twilio/twilio-video.js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/twilio/twilio-video.js/compare/2.12.0...2.13.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-04 09:43:53 -06:00
rhymes
4c44ebd034
Mark flaky specs as flaky (#12898) 2021-03-04 09:27:04 -05:00
dependabot[bot]
0fbba1c873
Bump @storybook/addon-storysource from 6.1.20 to 6.1.21 (#12897)
Bumps [@storybook/addon-storysource](https://github.com/storybookjs/storybook/tree/HEAD/addons/storysource) from 6.1.20 to 6.1.21.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.21/addons/storysource)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-04 10:43:48 +00:00
dependabot[bot]
0a4fb6ad31
Bump postcss from 8.2.6 to 8.2.7 (#12894)
Bumps [postcss](https://github.com/postcss/postcss) from 8.2.6 to 8.2.7.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss/compare/8.2.6...8.2.7)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-04 10:40:33 +00:00
dependabot[bot]
8e3adb4781
Bump @storybook/addon-links from 6.1.20 to 6.1.21 (#12891)
Bumps [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/addons/links) from 6.1.20 to 6.1.21.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.21/addons/links)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-04 09:59:41 +00:00
dependabot[bot]
bc8268b288
Bump @storybook/addon-a11y from 6.1.20 to 6.1.21 (#12890)
Bumps [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/addons/a11y) from 6.1.20 to 6.1.21.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.21/addons/a11y)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-04 10:26:17 +01:00
dependabot[bot]
250b06af24
Bump @storybook/addon-knobs from 6.1.20 to 6.1.21 (#12889)
Bumps [@storybook/addon-knobs](https://github.com/storybookjs/storybook/tree/HEAD/addons/knobs) from 6.1.20 to 6.1.21.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.21/addons/knobs)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-04 10:25:45 +01:00
dependabot[bot]
176570d1ac
Bump @storybook/preact from 6.1.20 to 6.1.21 (#12888)
Bumps [@storybook/preact](https://github.com/storybookjs/storybook/tree/HEAD/app/preact) from 6.1.20 to 6.1.21.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.21/app/preact)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-04 09:23:26 +00:00
Miguel Guardia
364c3a8252
Fix subscribe to discussion button when user is not logged in (#12837)
* Add logic to subscribe button that shows login modal if user is not logged in
Pass in userstatus to CommentSubscription
Remove logic that loads comment subscription button for logged-in users only

* Modify test to account for new userStatus input in CommentSubscription

* Change UserStatus to isLoggedIn
Add propType to isLoggedIn
Remove preventDefault from click event

* Fix indentation and input on commentSubscription test
Create new isLoggedIn variable that returns boolean
Replace all instances of userStatus to isLoggedIn
Create test for showLoginModal when subscribing
2021-03-03 18:50:29 -06:00
Jacob Herrington
90b9cdd532
Update seeds.rb ASCII output to Forem (#12883) 2021-03-03 11:19:11 -06:00
Miguel Guardia
2a50efb936
Fix Markdown parsing of <code> tag (#12797)
* Create a new method that replaces <code> tags to
triple back ticks (```)

* Create unit tests for add_proper_code_tags method

* Rubocop fixes

* Change method name to one that is more descriptive/accurate
Fix method to allow for triple backticks, sameline code tags and multiline codetags in the same post/article
Fix test to match with method name change

* Fix rubocop offenses

* Fix Rubocop offenses

* Add additional assertions to make sure backticks are present
2021-03-03 17:41:56 +01:00
Vaidehi Joshi
7e583be9ed
[15 Minute Fix]: Update email footer copy to account for email authentication (#12877)
* Update email footer copy to account for email authentication

Fixes https://github.com/forem/forem/issues/12546.
2021-03-03 08:36:40 -08:00
Jacob Herrington
3f3d7e8707
Add tech admin to seeded admin user (#12858) 2021-03-03 10:05:23 -06:00