rhymes
e18de615cd
Remove deprecated Sidekiq::Web commands ( #13081 )
2021-03-22 16:22:21 +01:00
Suzanne Aitchison
e870d4ba1f
small fix to import of reach styles ( #13083 )
2021-03-22 15:00:13 +00:00
Julianna Tetreault
945f0bebf4
Re-Add Reporter Email Form to /admin/reports ( #13011 ) [deploy]
...
* Re-add Reporter email form and add heads up banner to admin/reports
* Adjusts spec expectations to read in a nicer way
* Pulls HEREDOCs out into constants and formats email bodys inline
- Additionally, fixes inconsistent grammar within all email bodies
2021-03-22 08:19:05 -06:00
dependabot[bot]
cf8bd89e78
Bump cypress-file-upload from 5.0.2 to 5.0.3 ( #13080 )
...
Bumps [cypress-file-upload](https://github.com/abramenal/cypress-file-upload ) from 5.0.2 to 5.0.3.
- [Release notes](https://github.com/abramenal/cypress-file-upload/releases )
- [Commits](https://github.com/abramenal/cypress-file-upload/compare/v5.0.2...v5.0.3 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-22 14:47:16 +01:00
dependabot[bot]
5dfaf75c23
Bump ibm-openapi-validator from 0.37.1 to 0.38.0 ( #13079 )
...
Bumps [ibm-openapi-validator](https://github.com/IBM/openapi-validator ) from 0.37.1 to 0.38.0.
- [Release notes](https://github.com/IBM/openapi-validator/releases )
- [Changelog](https://github.com/IBM/openapi-validator/blob/main/CHANGELOG.md )
- [Commits](https://github.com/IBM/openapi-validator/compare/v0.37.1...v0.38.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-22 14:47:03 +01:00
dependabot[bot]
a6ca480aa4
Bump bundler-audit from 0.7.0.1 to 0.8.0 ( #13076 )
...
Bumps [bundler-audit](https://github.com/postmodern/bundler-audit ) from 0.7.0.1 to 0.8.0.
- [Release notes](https://github.com/postmodern/bundler-audit/releases )
- [Changelog](https://github.com/rubysec/bundler-audit/blob/master/ChangeLog.md )
- [Commits](https://github.com/postmodern/bundler-audit/compare/v0.7.0.1...v0.8.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-22 09:39:50 -04:00
Suzanne Aitchison
8f9e3a3a55
refactor reach UI style import ( #13082 )
2021-03-22 12:02:53 +00:00
dependabot[bot]
9de020d9b6
Bump @testing-library/user-event from 13.0.2 to 13.0.6 ( #13078 )
...
Bumps [@testing-library/user-event](https://github.com/testing-library/user-event ) from 13.0.2 to 13.0.6.
- [Release notes](https://github.com/testing-library/user-event/releases )
- [Changelog](https://github.com/testing-library/user-event/blob/master/CHANGELOG.md )
- [Commits](https://github.com/testing-library/user-event/compare/v13.0.2...v13.0.6 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-22 10:58:48 +01:00
Suzanne Aitchison
12ccb40e77
change closing tag to a main ( #13065 )
2021-03-22 09:23:34 +00:00
Suzanne Aitchison
a23caead07
Add (updated) mention autocomplete to post comments ( #13061 )
...
* add mention autocomplete functionality to article and notification comments
* add cypress tests
* make sure entry transitions dont replay
* undo change to async useeffect covered in other pr
* move search into dynamic import
* exit search if enter pressed in middle of search term
* refactor button activation code
* add a space after a mention is selected
* tweak cypress test for reply to ensure it awaits combobox
* small refactor
2021-03-22 09:18:13 +00:00
Vaidehi Joshi
3f6600541e
✂️ Remove the approvals gem ✂️ ( #12978 )
...
* Remove approvals fixtures
* Remove approvals initializer
* Remove approvals gem
* Remove approvals step from travis.yml
* Remove approvals from dockerignore and gitignore
* Remove references to approvals gem in docs
* Un-approvals spec/liquid_tags/codepen_tag_spec.rb
* Un-approvals spec/liquid_tags/dotnet_fiddle_tag_spec.rb
* Temporarily skip other approvals tests
We will still need to delete files in /spec/fixtures/approvals after this.
* Revert changes to dotnet_fiddle_tag_spec and codepen_tag_spec, skip those tests instead
* Temporarily skip more approvals based tests
* Attempt at moving html doc inline
* Comment out one more approvals spec
* Update dotnet fiddle and codepen liquid tag specs to not use Approvals
* Update liquid tag specs + system specs to not use Approvals
* Un-approval feed import, github issue, and tweet tag specs
* Re-add .approvals to gitignore and dockerignore
* Use Rspec compound expectations
2021-03-19 13:28:06 -07:00
Fernando Valverde
d6fde3ab89
Change PushNotifications::Send to use user_ids ( #13036 )
...
* Changes PushNotifications::Send to use user_ids
* Changes devices#destroy to use unauthenticated_params
* Fix failing spec - new logic reverses order
* Apply suggestions from code review
Co-authored-by: Jamie Gaskins <jgaskins@gmail.com>
* Only send new_comment PN with Rpush behind FeatureFlag + spec tweak
* Add query order explicitly to avoid flakyness
* Review feedback - remove order clause in query & other tweaks
Co-authored-by: Jamie Gaskins <jgaskins@gmail.com>
2021-03-19 13:50:04 -06:00
dependabot[bot]
6bfe57ddb0
Bump pusher-push-notifications from 1.3.0 to 2.0.1 ( #13070 )
...
* Bump pusher-push-notifications from 1.3.0 to 2.0.1
Bumps [pusher-push-notifications](https://github.com/pusher/push-notifications-ruby ) from 1.3.0 to 2.0.1.
- [Release notes](https://github.com/pusher/push-notifications-ruby/releases )
- [Changelog](https://github.com/pusher/push-notifications-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/pusher/push-notifications-ruby/compare/v1.3.0...2.0.1 )
Signed-off-by: dependabot[bot] <support@github.com>
* Sync vendor with master
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Uber <djuber@gmail.com>
2021-03-19 12:57:44 -05:00
dependabot[bot]
0dc0983042
Bump amazing_print from 1.2.2 to 1.3.0 ( #13069 )
...
Bumps [amazing_print](https://github.com/amazing-print/amazing_print ) from 1.2.2 to 1.3.0.
- [Release notes](https://github.com/amazing-print/amazing_print/releases )
- [Changelog](https://github.com/amazing-print/amazing_print/blob/master/CHANGELOG.md )
- [Commits](https://github.com/amazing-print/amazing_print/compare/v1.2.2...v1.3.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-19 13:18:33 -04:00
dependabot[bot]
b4eb370724
Bump rspec-rails from 5.0.0 to 5.0.1 ( #13063 )
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v5.0.0...v5.0.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-19 13:16:08 -04:00
dependabot[bot]
3d2bb10591
Bump sidekiq-unique-jobs from 7.0.6 to 7.0.7 ( #13068 ) [deploy]
...
Bumps [sidekiq-unique-jobs](https://github.com/mhenrixon/sidekiq-unique-jobs ) from 7.0.6 to 7.0.7.
- [Release notes](https://github.com/mhenrixon/sidekiq-unique-jobs/releases )
- [Changelog](https://github.com/mhenrixon/sidekiq-unique-jobs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/mhenrixon/sidekiq-unique-jobs/compare/v7.0.6...v7.0.7 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-19 10:56:53 -06:00
dependabot[bot]
ca7f1acb0a
Bump vault from 0.15.0 to 0.16.0 ( #13057 )
...
Bumps [vault](https://github.com/hashicorp/vault-ruby ) from 0.15.0 to 0.16.0.
- [Release notes](https://github.com/hashicorp/vault-ruby/releases )
- [Changelog](https://github.com/hashicorp/vault-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/hashicorp/vault-ruby/compare/v0.15.0...v0.16.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-19 17:39:40 +01:00
dependabot[bot]
f2372fcd94
Bump gibbon from 3.3.4 to 3.4.0 ( #13064 )
...
Bumps [gibbon](https://github.com/amro/gibbon ) from 3.3.4 to 3.4.0.
- [Release notes](https://github.com/amro/gibbon/releases )
- [Changelog](https://github.com/amro/gibbon/blob/master/CHANGELOG.md )
- [Commits](https://github.com/amro/gibbon/compare/v3.3.4...v3.4.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-19 17:27:13 +01:00
dependabot[bot]
af4c3173d6
Bump sidekiq from 6.1.3 to 6.2.0 ( #13056 )
...
Bumps [sidekiq](https://github.com/mperham/sidekiq ) from 6.1.3 to 6.2.0.
- [Release notes](https://github.com/mperham/sidekiq/releases )
- [Changelog](https://github.com/mperham/sidekiq/blob/master/Changes.md )
- [Commits](https://github.com/mperham/sidekiq/compare/v6.1.3...v6.2.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-19 10:32:54 -05:00
Alex
eb741029b7
Use serializer over as_json ( #13029 )
2021-03-19 11:16:52 -04:00
Suzanne Aitchison
5f0c89dbfe
add skip link functionality to article page ( #13045 )
2021-03-19 14:43:13 +00:00
Nick Taylor
73aead0e5c
Removed the start-server-and-test npm package as it's no longer used ( #13062 )
2021-03-19 10:17:39 -04:00
dependabot[bot]
50e89e4804
Bump faker from 2.16.0 to 2.17.0 ( #13058 )
...
Bumps [faker](https://github.com/faker-ruby/faker ) from 2.16.0 to 2.17.0.
- [Release notes](https://github.com/faker-ruby/faker/releases )
- [Changelog](https://github.com/faker-ruby/faker/blob/master/CHANGELOG.md )
- [Commits](https://github.com/faker-ruby/faker/compare/v2.16.0...v2.17.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-19 15:09:40 +01:00
Jacob Herrington
8ab31f624f
Add missing CSS class ( #13053 )
2021-03-19 08:55:25 -05:00
dependabot[bot]
d09de8bed9
Bump sidekiq-unique-jobs from 7.0.4 to 7.0.6 ( #13055 ) [deploy]
...
Bumps [sidekiq-unique-jobs](https://github.com/mhenrixon/sidekiq-unique-jobs ) from 7.0.4 to 7.0.6.
- [Release notes](https://github.com/mhenrixon/sidekiq-unique-jobs/releases )
- [Changelog](https://github.com/mhenrixon/sidekiq-unique-jobs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/mhenrixon/sidekiq-unique-jobs/compare/v7.0.4...v7.0.6 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-19 07:53:31 -06:00
Suzanne Aitchison
124620e0e8
change async await back to then ( #13050 )
2021-03-19 12:15:19 +00:00
Michael Kohl
847d8a8590
Add settings model generator ( #13003 )
...
* Add settings model generator
* Obey the CodeClimate overlords
* Update generator
* Update USAGE
* Add Zeitwerk exception
2021-03-19 12:55:31 +01:00
dependabot[bot]
53d8aaa175
Bump @testing-library/user-event from 13.0.1 to 13.0.2 ( #13060 )
...
Bumps [@testing-library/user-event](https://github.com/testing-library/user-event ) from 13.0.1 to 13.0.2.
- [Release notes](https://github.com/testing-library/user-event/releases )
- [Changelog](https://github.com/testing-library/user-event/blob/master/CHANGELOG.md )
- [Commits](https://github.com/testing-library/user-event/compare/v13.0.1...v13.0.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-19 10:02:39 +00:00
dependabot[bot]
777eb41cf1
Bump @testing-library/user-event from 13.0.0 to 13.0.1 ( #13043 )
2021-03-18 21:28:53 -04:00
Daniel Uber
d6b4e83190
When updating article scores, use new score for blackbox ( #13009 )
...
Fixes #13008
Add a test case for blackbox stability
This failed as expected on master and passed on this branch, when a
reaction (which would change the article's calculated score during
update) is added, the hotness should be stable, and not modified
during the second call to `#update_score`.
2021-03-18 14:20:27 -05:00
dependabot[bot]
fdf91eb5f2
Bump oj from 3.11.2 to 3.11.3 ( #13040 )
...
Bumps [oj](https://github.com/ohler55/oj ) from 3.11.2 to 3.11.3.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/compare/v3.11.2...v3.11.3 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-18 19:18:01 +01:00
Daniel Uber
195b202d85
Use normal db transactions around tests ( #13035 )
...
* Use normal db transactions around tests
An unrelated spec failure was observed when this was run before
another test expecting the seed data to be present. It looks like the
specific pain point in https://github.com/forem/forem/pull/8865 was
around an rss reader spec (which is no longer in use) and I'd like to
try reverting this truncation behavior here.
The minimal failing test case I had on master was this
```
rspec ./spec/system/dashboards/user_sorts_dashboard_articles_spec.rb:44 ./spec/lib/data_update_scripts/fix_profile_field_edge_cases_spec.rb
```
The find_by(attribute:...) in the edge case spec returned nil (since
there was no such profile field, the table had been truncated). Tests
pass locally so this might be fine to just leave on the defaults (if
that's the case the truncation support added in #8865 can also be
removed, this is the last caller).
* Reenable transactional feeds imports
rhymes pointed out that a second test uses this db_strategy and that's
the successor to the rss_feed_spec.rb that was the initial issue.
Attempt removal of the truncation strategy, and reenable the
transactional tests, for the feeds import.
* Remove database cleaner
Having removed the last use of it (in the feeds import spec) we no
longer need this gem.
* remove spec support for database cleaner
2021-03-18 12:56:55 -05:00
Andy Zhao
8dd65bd0a3
Get the correct episode by finding the given podcast's episodes ( #13034 )
...
* Only search for the given podcast's episodes
* Make describe value a bit more readable
* Add podcast episode show spec
2021-03-18 12:02:37 -04:00
Suzanne Aitchison
e3c97d18d6
Update storybook mention autocomplete component to take over whole textarea ( #13044 )
...
* Revert "Revert "Update storybook autocomplete component (#12980 )" (#13027 )"
This reverts commit f393dd2bbc
2021-03-18 15:04:59 +00:00
dependabot[bot]
459378d218
Bump jsonapi-serializer from 2.1.0 to 2.2.0 ( #13039 )
...
Bumps [jsonapi-serializer](https://github.com/jsonapi-serializer/jsonapi-serializer ) from 2.1.0 to 2.2.0.
- [Release notes](https://github.com/jsonapi-serializer/jsonapi-serializer/releases )
- [Changelog](https://github.com/jsonapi-serializer/jsonapi-serializer/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jsonapi-serializer/jsonapi-serializer/compare/v2.1.0...v2.2.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-18 09:23:08 -05:00
dependabot[bot]
e36d89c291
Bump honeybadger from 4.7.3 to 4.8.0 ( #13038 ) [deploy]
...
Bumps [honeybadger](https://github.com/honeybadger-io/honeybadger-ruby ) from 4.7.3 to 4.8.0.
- [Release notes](https://github.com/honeybadger-io/honeybadger-ruby/releases )
- [Changelog](https://github.com/honeybadger-io/honeybadger-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/honeybadger-io/honeybadger-ruby/compare/v4.7.3...v4.8.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-18 07:58:44 -06:00
dependabot[bot]
33d0e03dbd
Bump rpush from 5.3.0 to 5.4.0 ( #13041 )
...
Bumps [rpush](https://github.com/rpush/rpush ) from 5.3.0 to 5.4.0.
- [Release notes](https://github.com/rpush/rpush/releases )
- [Changelog](https://github.com/rpush/rpush/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rpush/rpush/compare/v5.3.0...v5.4.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-18 12:47:42 +01:00
dependabot[bot]
47dcf7d20d
Bump cypress from 6.7.1 to 6.8.0 ( #13042 )
...
Bumps [cypress](https://github.com/cypress-io/cypress ) from 6.7.1 to 6.8.0.
- [Release notes](https://github.com/cypress-io/cypress/releases )
- [Changelog](https://github.com/cypress-io/cypress/blob/develop/.releaserc.base.js )
- [Commits](https://github.com/cypress-io/cypress/compare/v6.7.1...v6.8.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-18 10:08:53 +00:00
rhymes
8b9f2d546c
Use faster serializers for Search::Postgres::Tag ( #13022 )
...
* Use faster serializers for Search::Postgres::Tag
* Fix spec
2021-03-18 09:30:56 +01:00
Nick Taylor
f222497913
Disabled 'no default exports' rule for Storybook files and Stimulus controllers ( #13032 )
2021-03-17 21:29:39 -04:00
dependabot[bot]
a7056ab650
Bump counter_culture from 2.7.0 to 2.8.0 ( #13021 )
...
Bumps [counter_culture](https://github.com/magnusvk/counter_culture ) from 2.7.0 to 2.8.0.
- [Release notes](https://github.com/magnusvk/counter_culture/releases )
- [Changelog](https://github.com/magnusvk/counter_culture/blob/master/CHANGELOG.md )
- [Commits](https://github.com/magnusvk/counter_culture/compare/v2.7.0...v2.8.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-17 15:00:18 -05:00
Nick Taylor
f393dd2bbc
Revert "Update storybook autocomplete component ( #12980 )" ( #13027 )
2021-03-17 15:59:38 -04:00
Alex
1e4d4db562
[Search 2.0] Add Search::Postgres::Username behind a feature flag ( #12975 )
...
* Add PostgreSQL FTS for usernames
* Change profile_image_90 logic
* Make search_users private
* Add tsvector index on usernames
* Limit the number of search results
* Update index name
2021-03-17 13:45:58 -04:00
Kurnia Muhamad
51b3a90cbf
Fix github readme liquid tag ( #12836 )
...
* Fix github readme liquid tag
* Update github liquid tag style
2021-03-17 17:16:26 +01:00
Michael Kohl
7c7a8dcd45
Remove experimental /call functionality from Connect ✂️ ✂️ ✂️ ( #12979 )
...
* Remove Twilio gem
* remove VideoChatsController + views and specs
* Remove /call related code
* Update spec
* More JS cleanup
* Restore wrongly deleted files
* Remove obsolete files
* More cleanup
2021-03-17 17:06:15 +01:00
dependabot[bot]
5bd87b93d6
Bump flipper-active_record from 0.20.3 to 0.20.4 ( #13016 )
...
Bumps [flipper-active_record](https://github.com/jnunemaker/flipper ) from 0.20.3 to 0.20.4.
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.20.3...v0.20.4 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-17 17:05:49 +01:00
Rafi
09c645f5a1
Adding aria labels in Suggested people to follow screen during onboarding ( #12384 )
...
Co-authored-by: Nick Taylor <nick@dev.to>
2021-03-17 11:59:50 -04:00
Josh Puetz
80e8129628
Configurre bundler to ignore Rpush install message ( #13025 )
2021-03-17 10:55:11 -05:00
Suzanne Aitchison
76a7ed6dbe
Update storybook autocomplete component ( #12980 )
2021-03-17 11:49:16 -04:00
Daniel Uber
91b99fce7a
Add and document COVERAGE environment variable in the sample ( #13013 )
...
Running coverage is great, but it's definitely something I don't want
to do when interactively using the test suite (running a single file
or single example, this adds 20+ seconds for me).
2021-03-17 10:27:59 -05:00
