Molly Struve
dc7d9d5843
Refactor/Optimization:Use more_comments_minimal_weight_randomized_at_end for Signed In Feed ( #11604 )
2020-11-24 15:36:55 -06:00
Lisa Sy
fc4f6e3b1c
Improve information architecture of Settings ( #11347 )
...
* WIP Rename categories and make consistency card titles
* Add rest of sections to Extensions page
* icons
* Reshuffle Integrations and remove unnecessary Integrations tab in controller
* Update rspec tests
* Fix specs
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
Co-authored-by: rhymes <rhymes@hey.com>
2020-11-24 12:26:06 -08:00
Molly Struve
c3b0103eb1
Bug Fix:Remove Score Filter From Tag Mod Index ( #11599 )
2020-11-24 14:18:14 -06:00
rhymes
1741e52e83
Add missing features to new feed importer ( #11501 )
...
* Add explanatory comment to how RssReaderFetchUserWorker works
* Add Feeds::ImportWorker worker
* Enable Feeds::Import for single user feed fetching behind a feature flag
* Add Feeds::ValidateUrl service
* Add feature flag to user's validate feed URL feature
* Remove todo notices
* Add feature flag to fetch_all_rss task
* Add feature flag to RssReaderWorker
* Bring back short-circuit for Articles::RssReaderWorker
2020-11-24 18:11:13 +01:00
Mac Siri
5ef6106045
Update JS dependencies with yarn upgrade ( #11589 )
2020-11-24 11:17:25 -05:00
rhymes
d49c00aa84
Fix email messages link in admin's user page ( #11595 )
2020-11-24 16:35:14 +01:00
Jacob Herrington
e2f33a37b7
Restore some context in comment ( #11587 )
...
rhymes mentioned that this context might be useful regarding this comment.
I removed some of this info in https://github.com/forem/forem/pull/11480 , so this commit adds that context along with a link that rhymes shared with me.
2020-11-24 16:08:41 +01:00
Julianna Tetreault
2dff7c2877
Rewords Public checkbox warning message in SiteConfig ( #11580 )
2020-11-24 09:52:43 -05:00
Mac Siri
c4fdeeb944
Make Images::Optimizer nil-safe ( #11584 )
2020-11-24 09:39:34 -05:00
Ben Halpern
575449b890
Include core assets in serviceworker cache ( #11559 )
2020-11-24 08:58:06 -05:00
Michael Kohl
2fd724d191
Update empty reading list copy ( #11565 )
...
* Change wording
* Add icon
* Update app/javascript/readingList/readingList.jsx
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2020-11-24 09:40:04 +07:00
Nick Taylor
bf7780cd2c
Ran prettier on *.js, *.jsx and *.md files. ( #11586 )
2020-11-23 20:45:50 -05:00
Nick Taylor
8c22bbd17b
filterXSS is now set up in testSetup.js ( #11579 )
2020-11-23 14:08:13 -05:00
Ben Halpern
7aca8ac337
Add comment about canonical url ( #11574 )
2020-11-23 11:35:30 -05:00
Molly Struve
abbc29dafe
Bug Fix:User >= when filtering by SiteConfig.home_feed_minimum_score ( #11567 )
2020-11-23 09:13:03 -06:00
Michael Kohl
894b1b94c7
Remove UnreadNotificationsEmailer ( #11561 )
2020-11-23 14:15:07 +00:00
Rafi
f88bf5a0b1
Fixing overflow of comment button ( #11562 )
2020-11-23 12:17:30 +01:00
Oskar Janusz
39daa21add
Update Copy for Orgs Call-to-action Box ( #11534 )
2020-11-23 10:15:34 +01:00
Marcy Sutton
b9ae58816f
Accessibility: initial onboarding fixes ( #11408 )
...
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2020-11-20 11:13:39 -05:00
Molly Struve
e454772128
Update trusted role email Subject ( #11519 )
2020-11-20 09:54:21 -06:00
Mac Siri
07287fa2bb
Replace podcast bar helpers with image_tag ( #11502 )
2020-11-20 09:45:56 -05:00
Molly Struve
a07070e8bc
Update copy and links in Mod Sidebar ( #11507 )
2020-11-19 19:15:04 -06:00
Andy Zhao
827c9aa77c
Fix Facebook Login profile image download failure ( #11478 )
...
* Send a new request and use link in response for profile img
* Use fallback option and make method private
* Refactor and use constant template string
* Stub image_url method for tests
* Fix tests and mock response object properly
* Fix tests and mock response object properly
* Stub response for tests
* Refactor a bit and move into helper method
* Undo everything I did. today I will watch facebook burn.
* Use more foolproof string to gsub
2020-11-19 16:18:09 -05:00
Molly Struve
cd0b90c67b
Update Trusted User Email Copy ( #11505 )
2020-11-19 14:54:06 -06:00
Ben Halpern
4ecb7121e8
Fix menu dropdown disable issue ( #11498 )
...
* Fix menu dropdown disable issue
* Initial base work
* Remove wrongfully-included files
2020-11-19 13:55:29 -05:00
Ben Halpern
c837834d6a
Remove under-used growth tab ( #11495 )
2020-11-19 10:53:36 -05:00
Jacob Herrington
77a35b378f
Fix seed values for ProfileFields ( #11481 )
...
These were all defaulting to "left_sidebar" which interfered with my
work some and doesn't really reflect how these will probably be used.
2020-11-19 09:13:49 -06:00
Manasa
b015690f4f
Podcast ownership join table (MLH Fellowship #81 ) ( #11410 )
...
* added podcast_ownership route
* added podcast_ownership table
* added podcast_ownership controller and pundit policy
* fixed codeclimate
* removed controller and pundit policy
* codeclimate
* codeclimate
* schema.rb
* schema.rb
* schema.rb
* user.rb
* made the suggested changes
* added validations
* fixed build error
* changed name to owned_podcasts
* added validation and tests
* added tests
* added tests
* changed spec
* added factory
* added factory
* merge conflict
* factory
* factory
* factory
* modified spec file
* modified spec file
* fix build error
* added class_name
* adjusted m2m relations
* made suggested changes
* fixed build error
* added subject
* schema
* ran migration
* removed index:true from singular fields
* changed schema file
* set index: false
2020-11-19 12:41:17 +01:00
Jacob Herrington
24b47029dd
Fix comment phrasing ( #11480 )
2020-11-18 21:52:33 -06:00
ludwiczakpawel
70706d0a62
Comments UI update ( #11283 )
...
* tooltips 1.0.1
* tooltips 1.0.1
* init
* .
* drop not needed files
* .
* init
* init
* .
* comments
* border
* missing bits
* build comment JS
* .
* .
* specs
* sloan avatar fix
* bunch of fixes
* specs and fixes
* specs
* .
* swap order of links
* contrast
* js for dropdown
* icons
* op-author
* three dots icon
* reverts
* test: capybara- make sure that we click the dropdown before clicking on edit
* permalink --> link
* tiny fixes
* aria-label on form
* proper alt on user's avatar
* aria has popup
* use UL > LI instead of DIV
* add aria-labels to dropdown items
* another aria-label
* better links: nav
* contrast
Co-authored-by: Ridhwana <ridhwana.khan16@gmail.com>
2020-11-18 18:21:19 -05:00
Molly Struve
fd8f83dc7d
Feature:Backend Username Search Endpoint for Mention Completion ( #11479 )
...
* Feature:Backend Username Search Endpoint for Mention Completion
* ensure user is authenticated to use usernames endpoint
* update spec with authaa
2020-11-18 16:43:59 -06:00
Akash Srivastava
2ee5ea69bd
Added published date as editable in admin articles list/show ( #11124 )
...
* Added published date as editable in admin articles list/show
* Added requests spec for articles published date update
2020-11-18 10:40:13 -06:00
Robin Gagnon
4fabc3a5e6
fix: Add hidden navigation link to article HTML ( #11465 )
2020-11-18 14:50:19 +01:00
Nick Taylor
8fabccec4e
Add Preact dev tools to development bundles ( #11459 )
...
* Now Preact dev tools are injected into development bundles.
* Updated frontend debugging documentation.
* Updated frontend debugging documentation wording.
2020-11-18 14:20:58 +01:00
rhymes
cbc461a850
Refactor RssReader and Feeds::Import common parts: take 1 ( #11412 )
...
* Extract Feeds::CheckMediumReplyItem service
* Extract Feeds::CheckItemPreviouslyImported
* Clarified comment on Feeds::CheckItemMediumReply (thanks @maestromac)
* Refactor a bit to be more Rubeyeyey
2020-11-18 14:17:53 +01:00
Nick Taylor
ed7f4561e3
Fixed <Snackbar /> component displayName property. ( #11460 )
2020-11-18 06:41:00 -05:00
Vaidehi Joshi
59ea42a372
Add community_emoji to SiteConfig ( #11450 )
...
* Add optional community_emoji to SiteConfig
* Remove hardcoded emojis, favor community_emoji instead
* Remove remaining hardcoded emojis
* Validate community_emoji field when updated
2020-11-17 14:02:04 -08:00
Fernando Valverde
449cf89737
Uses template literals to more clearly interpolate a complex string in buildArticleHTML.js ( #11457 )
2020-11-17 14:45:32 -06:00
Ben Halpern
f5670e6fa2
Add username to profile more info button ( #11451 )
...
* Add username to profile more info button
* Update spec/requests/user/user_profile_spec.rb
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
Co-authored-by: rhymes <rhymes@hey.com>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-11-17 10:07:47 -05:00
Ben Halpern
f3a69bbd84
Allow Forems to specify which domains are allowed for registration ( #11442 )
...
* Allow authors to restrict which emails can sign up
* Add form and tests
* Check for email presence in allowed email flow
* Fix test domains
* Fix codeclimate issue
2020-11-17 08:43:46 -05:00
Molly Struve
6aa41bfba2
Optimization:Only Check Past Day for DataUpdateScript failures ( #11448 )
2020-11-17 06:39:58 -06:00
Molly Struve
cf619caf70
Refactor: Remove more_tag_weight_more_random_experiment ( #11447 )
2020-11-16 15:48:45 -06:00
Ben Halpern
eaf3403091
Fix document.body.getElementById is not a function ( #11446 )
2020-11-16 16:21:52 -05:00
rhymes
f9506affb5
Use faster JS selection methods ( #11409 )
...
* Add JS tips section to frontend documentation
* Replace document.getElementsByTagName('body') with document.body
* Replace querySelectorAll with faster selecting methods where appropriate
* Replace querySelector with faster selecting methods where appropriate
* Fix typo
* Fix forEach and getElementsByClassName
* Change querySelector* to faster methods in erb files
* Change querySelector* to faster methods in ruby files
* Fix runkit tag
* Various fixes
* Update app/assets/javascripts/initializers/initializeEllipsisMenu.js
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
* Update app/assets/javascripts/utilities/slideSidebar.js
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
* Commenting out flaky spec
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2020-11-16 17:35:50 +01:00
Rafi
eab507604d
Removing data-testid from Article component ( #10249 )
2020-11-16 10:23:44 -05:00
rhymes
700c62c416
Fix small ERB linting issues ( #11438 )
...
* Fix Layout/LineLength
* Fix Style/StringConcatenation and Lint/FloatComparison
* Fix Lint/DuplicateHashKey
2020-11-16 16:15:37 +01:00
Damla Köksal
a7dd143064
Fixed the scroll bar problem in Safari ( #11387 )
...
* Fixed the scroll bar problem in Safari
* #11387 requested changes done
2020-11-16 12:48:51 +01:00
irmela
9af120561c
Make markup for dashboard ellipsis menu more consistent ( #10764 )
...
* Make markup for dashboard ellipsis menu more consistent
* Rename js-dashboard-row-more to js-ellipsis-menu
2020-11-15 14:26:37 +01:00
rhymes
910f79e04e
Remove wrong datadog metric in Feeds::Import ( #11405 )
2020-11-13 16:11:02 -05:00
Jacob Herrington
94fe355dae
Add system spec for profile fields ( #11398 )
...
* Add system spec for profile fields
* Use FeatureFlag wrapper over Flipper
2020-11-13 14:51:42 -06:00
