Commit graph

1192 commits

Author SHA1 Message Date
Andy Zhao
cf36025a16 Fix reactions rendering on notifications (#1362)
* Use more specific find for looking for reactions

* Use basic notification tests

* Test for proper reaction button rendering

* Use the proper user for reaction test
2018-12-18 20:58:31 -05:00
Andy Zhao
8fb35e84c2 Add title to organization profile page (#1355)
* Add test for page title

* Add organization name as title
2018-12-18 17:14:23 -05:00
Mario See
60d38ef787 /connect rerender chat (#1359)
* check element render before scrollingto bottom

* check element render before scrollingto bottom

* remove console logs

* remove accidental quote
2018-12-18 17:13:13 -05:00
Mac Siri
bd4a81f539 Replace flipflop with sail migrations (#1361) 2018-12-18 16:48:17 -05:00
Mac Siri
43280f12ac Add Sail gem (#1356) 2018-12-18 16:24:42 -05:00
Andy Zhao
88cd4c13f3 Remove all flipflop related code (#1358)
* Remove all flipflop related code

* Undo an amend

* Comment out one last test

* Remove last test
2018-12-18 16:01:18 -05:00
Mac Siri
06e0cbabbb Revert "Replace Flipflop with Sail (#841)"
This reverts commit 21870e805a.
2018-12-18 13:44:40 -05:00
Vinicius Stock
21870e805a Replace Flipflop with Sail (#841)
* Replace Flipflop with Sail

* Address PR comments

* Bump sail version to latest

* Bump Sail to latest version

* Move setting creation to config/sail.yml

* Bump Sail to latest version

* Use correct limit for cast_type in schema

* Update Sail's route
2018-12-18 12:42:30 -05:00
Andy Zhao
651a26a514 Use latest admin page views from administrate gem (#1351) 2018-12-17 16:45:12 -05:00
Ben Halpern
28736cda20
Add missing title attribute to user profile page (#1349)
* Add missing title attribute

* Add spec

* Fix test
2018-12-17 15:04:00 -05:00
dependabot[bot]
430b80d3c3 Bump @storybook/addon-actions from 4.0.0 to 4.1.2 (#1335) [ci skip]
Bumps [@storybook/addon-actions](https://github.com/storybooks/storybook) from 4.0.0 to 4.1.2.
- [Release notes](https://github.com/storybooks/storybook/releases)
- [Changelog](https://github.com/storybooks/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybooks/storybook/compare/v4.0.0...v4.1.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-17 13:22:06 -05:00
dependabot[bot]
d322889393 Bump counter_culture from 1.9.0 to 2.1.2 (#1348) [ci skip]
Bumps [counter_culture](https://github.com/magnusvk/counter_culture) from 1.9.0 to 2.1.2.
- [Release notes](https://github.com/magnusvk/counter_culture/releases)
- [Changelog](https://github.com/magnusvk/counter_culture/blob/master/CHANGELOG.md)
- [Commits](https://github.com/magnusvk/counter_culture/compare/v1.9.0...v2.1.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-17 13:21:43 -05:00
dependabot[bot]
55988e67bc Bump @storybook/addon-links from 4.0.0 to 4.1.2 (#1336) [ci skip]
Bumps [@storybook/addon-links](https://github.com/storybooks/storybook) from 4.0.0 to 4.1.2.
- [Release notes](https://github.com/storybooks/storybook/releases)
- [Changelog](https://github.com/storybooks/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybooks/storybook/compare/v4.0.0...v4.1.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-17 12:59:24 -05:00
Mac Siri
5212d6ff16 Revert "Bump cloudinary from 1.9.1 to 1.11.0 (#1341) [ci skip]"
This reverts commit b20ee8b777.
2018-12-17 12:56:30 -05:00
dependabot[bot]
66e463a08e Bump @storybook/addons from 4.0.0 to 4.1.2 (#1338) [ci skip]
Bumps [@storybook/addons](https://github.com/storybooks/storybook) from 4.0.0 to 4.1.2.
- [Release notes](https://github.com/storybooks/storybook/releases)
- [Changelog](https://github.com/storybooks/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybooks/storybook/compare/v4.0.0...v4.1.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-17 12:31:40 -05:00
dependabot[bot]
6463fb43f7 Bump jsdom from 13.0.0 to 13.1.0 (#1334) [ci skip]
Bumps [jsdom](https://github.com/jsdom/jsdom) from 13.0.0 to 13.1.0.
- [Release notes](https://github.com/jsdom/jsdom/releases)
- [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md)
- [Commits](https://github.com/jsdom/jsdom/compare/13.0.0...13.1.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-17 12:13:39 -05:00
dependabot[bot]
bf3a9e5c95 Bump husky from 1.2.0 to 1.2.1 (#1339) [ci skip]
Bumps [husky](https://github.com/typicode/husky) from 1.2.0 to 1.2.1.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](https://github.com/typicode/husky/compare/v1.2.0...v1.2.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-17 12:13:20 -05:00
dependabot[bot]
7e619c8146 Bump jest-fetch-mock from 2.0.1 to 2.1.0 (#1333) [ci skip]
Bumps [jest-fetch-mock](https://github.com/jefflau/jest-fetch-mock) from 2.0.1 to 2.1.0.
- [Release notes](https://github.com/jefflau/jest-fetch-mock/releases)
- [Commits](https://github.com/jefflau/jest-fetch-mock/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-17 11:47:23 -05:00
dependabot[bot]
b921c1d848 Bump octokit from 4.12.0 to 4.13.0 (#1340) [ci skip]
Bumps [octokit](https://github.com/octokit/octokit.rb) from 4.12.0 to 4.13.0.
- [Release notes](https://github.com/octokit/octokit.rb/releases)
- [Changelog](https://github.com/octokit/octokit.rb/blob/master/RELEASE.md)
- [Commits](https://github.com/octokit/octokit.rb/compare/v4.12.0...v4.13.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-17 11:45:35 -05:00
dependabot[bot]
b20ee8b777 Bump cloudinary from 1.9.1 to 1.11.0 (#1341) [ci skip]
Bumps [cloudinary](https://github.com/cloudinary/cloudinary_gem) from 1.9.1 to 1.11.0.
- [Release notes](https://github.com/cloudinary/cloudinary_gem/releases)
- [Changelog](https://github.com/cloudinary/cloudinary_gem/blob/master/CHANGELOG.md)
- [Commits](https://github.com/cloudinary/cloudinary_gem/compare/1.9.1...1.11.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-17 11:40:32 -05:00
dependabot[bot]
9cd2e66213 Bump aws-sdk-lambda from 1.13.0 to 1.16.0 (#1342)
Bumps [aws-sdk-lambda](https://github.com/aws/aws-sdk-ruby) from 1.13.0 to 1.16.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-lambda/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-17 11:39:51 -05:00
dependabot[bot]
d588031b3e Bump recaptcha from 4.12.0 to 4.13.1 (#1337)
Bumps [recaptcha](https://github.com/ambethia/recaptcha) from 4.12.0 to 4.13.1.
- [Release notes](https://github.com/ambethia/recaptcha/releases)
- [Changelog](https://github.com/ambethia/recaptcha/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ambethia/recaptcha/compare/v4.12.0...v4.13.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-17 11:39:33 -05:00
Ben Halpern
7d3da5df35
Fix twitter missing quote text (#1330) 2018-12-17 10:49:16 -05:00
dependabot[bot]
a58c153000 Bump autoprefixer-rails from 9.3.1 to 9.4.3 (#1343)
Bumps [autoprefixer-rails](https://github.com/ai/autoprefixer-rails) from 9.3.1 to 9.4.3.
- [Release notes](https://github.com/ai/autoprefixer-rails/releases)
- [Changelog](https://github.com/ai/autoprefixer-rails/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ai/autoprefixer-rails/compare/9.3.1...9.4.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-17 10:25:58 -05:00
Chinmay Joshi
d39d44ac07 css fix for mixed looking text while rendering articles (#502) 2018-12-15 13:18:01 -05:00
Andrew Bone
db55f871d4 Beginning of css variable implementation (#1307)
Added --theme-top-bar-background leaving the default the same.
This will make no, visible, change to the styles currently.
2018-12-15 12:48:28 -05:00
Richard Kichenama
4b8dffb4c9 Iterate on Night Theme (#1303)
*  implement night theme through css filters

* 🐛 and video

* ♻️ simplify selector

* ♻️ finer targeting and untouched graphics

* 🐛 keep it in the theme

* ♻️ remove styling for 3x inverted elements
2018-12-15 12:46:34 -05:00
Andy Zhao
b3f2789eb2 Check if author_id is nil before querying for author (#1325)
* Check if author_id is nil before querying for author

* Remove some legacy code

* Remove tests that test for unused functionality
2018-12-15 12:44:45 -05:00
rhymes
73ddff4549 Add a descriptive title to the series links (#1329)
It's easy to navigate each part of a series when there only a few of them. It's hard to jump from a part to another if there are many. This change makes it also a little friendlier to accessibility tools.
2018-12-15 12:44:29 -05:00
Andy Zhao
cf060d09e9 Visit a page before visiting the delete confirm page (#1326) 2018-12-13 17:20:01 -05:00
dependabot[bot]
d53fbe22f2 Bump administrate from 0.9.0 to 0.11.0 (#1295)
Bumps [administrate](https://github.com/thoughtbot/administrate) from 0.9.0 to 0.11.0.
- [Release notes](https://github.com/thoughtbot/administrate/releases)
- [Changelog](https://github.com/thoughtbot/administrate/blob/master/CHANGELOG.md)
- [Commits](https://github.com/thoughtbot/administrate/compare/v0.9.0...v0.11.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-13 14:56:50 -05:00
Anna Buyanova
074d50d2b7 Stories views reorganization (#1317)
* Added stories feature specs

* Structure feature specs

* Spec for the articles by tag page

* Spec for clicking "week" button on the tag page

* Reorganize stories views

* Feature spec for displaying sponsors on tag page

* Increase allowed rspec example length

* Spec for the users comments view

* Articles by tag: reeplace view code with rendering partials
2018-12-13 14:54:02 -05:00
Mac Siri
56ec3e55a2 Refactor Reaction (#1320)
* Refactor Reaction's spec

* Create singleton class in Reaction

* Refactor Reaction
2018-12-13 14:24:33 -05:00
Ben Halpern
9b299569cb
Modify style on show page cta (#1324) 2018-12-13 14:23:18 -05:00
Kyle Boe
f82b562cd8 Update member's only sticker pack link (#1301) 2018-12-12 17:53:59 -05:00
Mac Siri
72eb2fc7b6 Revert "Extract background jobs from Reaction (#1312)" [ci skip]
This reverts commit cd54bece92.
2018-12-12 17:10:42 -05:00
Mac Siri
cd54bece92 Extract background jobs from Reaction (#1312)
* Refactor Reaction

* Update reaction_spec

* Extract update_reactable to job class

* Create ApplicationJob

* Rename Engagement::UpdateReactableJob to ReactionCascadeJob

* Rename ReactionCascadeJob to Reaction::UpdateRecordsJob

* Refactor Reaction::UpdateRecordsJob

* Remove unused method

* Change module to class
2018-12-12 16:41:31 -05:00
Mario See
394580b8c8 connect highlight messages (#1311)
* move setstate into cases where activecontent actually changes

* remove unnecessary setstate lines

* rearrange triggerActiveContent
2018-12-12 12:42:42 -05:00
Ben Halpern
14bba5e4d5
Adjust button style/placement on desktop (#1288)
* Adjust button style/placement on desktop

* Change opacity on side comments

* Adjust css for side article actions

* Adjust opacity

* Adjust opacity

* Adjust opacity

* Fix test language

* Remove opacity deal
2018-12-11 13:08:43 -05:00
Brian Kephart
5a4f894e84 Add ruby.social to Mastadon safelist (#1302) 2018-12-11 10:30:01 -05:00
Anant Jain
6bb87b25b2 Fixes #1298: Overflowing User Bio in article sidebar. (#1300) 2018-12-10 18:51:11 -05:00
dependabot[bot]
f115cca714 Bump capybara from 3.10.0 to 3.12.0 (#1294)
* Bump capybara from 3.10.0 to 3.12.0

Bumps [capybara](https://github.com/teamcapybara/capybara) from 3.10.0 to 3.12.0.
- [Release notes](https://github.com/teamcapybara/capybara/releases)
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md)
- [Commits](https://github.com/teamcapybara/capybara/compare/3.10.0...3.12.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Update spec
2018-12-10 16:06:21 -05:00
dependabot[bot]
0672d0a622 Bump preact from 8.3.1 to 8.4.2 (#1290) [ci skip]
Bumps [preact](https://github.com/developit/preact) from 8.3.1 to 8.4.2.
- [Release notes](https://github.com/developit/preact/releases)
- [Commits](https://github.com/developit/preact/compare/8.3.1...8.4.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-10 14:03:23 -05:00
dependabot[bot]
c6c4e8ccc1 Bump honeycomb-rails from 0.8.0 to 0.8.1 (#1293) [ci skip]
Bumps [honeycomb-rails](https://github.com/honeycombio/honeycomb-rails) from 0.8.0 to 0.8.1.
- [Release notes](https://github.com/honeycombio/honeycomb-rails/releases)
- [Commits](https://github.com/honeycombio/honeycomb-rails/compare/v0.8.0...v0.8.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-10 13:42:00 -05:00
dependabot[bot]
3c99c08709 Bump twilio-video from 1.14.1 to 1.14.2 (#1289) [ci skip]
Bumps [twilio-video](https://github.com/twilio/twilio-video.js) from 1.14.1 to 1.14.2.
- [Release notes](https://github.com/twilio/twilio-video.js/releases)
- [Changelog](https://github.com/twilio/twilio-video.js/blob/1.14.2/CHANGELOG.md)
- [Commits](https://github.com/twilio/twilio-video.js/compare/1.14.1...1.14.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-10 13:39:33 -05:00
dependabot[bot]
5a0358bb0f Bump eslint from 5.9.0 to 5.10.0 (#1291) [ci skip]
Bumps [eslint](https://github.com/eslint/eslint) from 5.9.0 to 5.10.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v5.9.0...v5.10.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-10 13:33:59 -05:00
Mark Frost
bb5a999a91 [#339] fixed broken markup on /readinglist page (#435) 2018-12-10 13:23:38 -05:00
dependabot[bot]
339c2ffa62 Bump rubocop-rspec from 1.29.1 to 1.30.0 (#1292) [ci skip]
Bumps [rubocop-rspec](https://github.com/rubocop-hq/rubocop-rspec) from 1.29.1 to 1.30.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-rspec/compare/v1.29.1...v1.30.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-12-10 13:22:32 -05:00
rhymes
96d01b20a2 Use allow/allowed instead of whitelist (#1296)
* Use allow/allowed instead of whitelist

* Remove duplication in comment
2018-12-10 13:16:16 -05:00
Jibran Kalia
f569f33e4f [WIP] Really simple calculate reading time function (#1283)
* Really simple calculate reading time function

* Move parse_it so that the number of methods in MarkdownParser is at 20

* Added test and default value for reading time
2018-12-09 13:42:32 -05:00