maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
8005 commits 1 branch 0 tags 1.6 GiB
Commit graph

8005 commits

This branch
This branch
All branches
Author SHA1 Message Date
dependabot[bot]
ce018b885e
Bump preact from 10.5.7 to 10.5.10 (#12289) 
Bumps [preact](https://github.com/preactjs/preact) from 10.5.7 to 10.5.10.
- [Release notes](https://github.com/preactjs/preact/releases)
- [Commits](https://github.com/preactjs/preact/compare/10.5.7...10.5.10)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-01-19 11:41:02 +01:00
Suzanne Aitchison
516bab133f
Storybook dropdown should be accessible 11724 (#12295) 
* allow keyboard access to dropdown stories

* add accessibility notes to dropdown stories

* manage focus in html example

* Update reference to aria attributes in notes

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

* add focus style to link for keyboard users

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
 2021-01-19 08:51:37 +00:00
Ben Halpern
d7732499b9
Improve cumulative layout shift on comment reactions + optimizations (#12309) 
* Improve content layout shift on comment reactions + optimizations

* Clean ups, tests, and docs

* Fix test typo

* Update app/views/comments/_comment_footer.html.erb

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>

* Update docs/technical-overview/architecture.md

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Update docs/technical-overview/architecture.md

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Update docs/technical-overview/architecture.md

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Refactor and add jsdoc

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
 2021-01-18 19:29:44 -05:00
le-hu
619dd813c7
secure Identity#email in case of missing auth_data_dump hash (#11936) (#12322) 
* secure Identity#email in case of missing auth_data_dump hash (#11936)

* Refactor Identity#email

* Delete wrongly commited debugging line

* extract no email found message into Const

* refactor Identity#email to use || as flow control
 2021-01-18 19:27:07 -05:00
Nick Taylor
425c3072f7
Fix broken test pre-Preact upgrade (#12328) 
* Removed import of xss as it already happens in testSetup.js

* Fixed invalid setting for a the children prop.
 2021-01-18 14:39:17 -05:00
dependabot[bot]
b9d50a77f0
Bump cypress-file-upload from 4.1.1 to 5.0.0 (#12317) 
Bumps [cypress-file-upload](https://github.com/abramenal/cypress-file-upload) from 4.1.1 to 5.0.0.
- [Release notes](https://github.com/abramenal/cypress-file-upload/releases)
- [Commits](https://github.com/abramenal/cypress-file-upload/compare/v4.1.1...v5.0.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-01-18 18:15:55 +01:00
Ben Halpern
472c3d2922
Fix and refactor hide user content (#12307) 2021-01-18 11:08:23 -05:00
dependabot[bot]
0cac61024f
Bump memory_profiler from 0.9.14 to 1.0.0 (#12320) 
Bumps [memory_profiler](https://github.com/SamSaffron/memory_profiler) from 0.9.14 to 1.0.0.
- [Release notes](https://github.com/SamSaffron/memory_profiler/releases)
- [Changelog](https://github.com/SamSaffron/memory_profiler/blob/master/CHANGELOG.md)
- [Commits](https://github.com/SamSaffron/memory_profiler/compare/v0.9.14...v1.0.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-01-18 09:55:09 -05:00
dependabot[bot]
11867b6b04
Bump strong_migrations from 0.7.5 to 0.7.6 (#12321) 
Bumps [strong_migrations](https://github.com/ankane/strong_migrations) from 0.7.5 to 0.7.6.
- [Release notes](https://github.com/ankane/strong_migrations/releases)
- [Changelog](https://github.com/ankane/strong_migrations/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ankane/strong_migrations/compare/v0.7.5...v0.7.6)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-01-18 08:30:41 -06:00
dependabot[bot]
f689d86676
Bump eslint from 7.17.0 to 7.18.0 (#12319) 
Bumps [eslint](https://github.com/eslint/eslint) from 7.17.0 to 7.18.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v7.17.0...v7.18.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-01-18 08:29:49 -06:00
Shilpi Agrawal
92f191445b
Refactored all site config default hardcoded value in rspec test (#12315) 
* Refactored all site config default hardcoded value in rspec test

* Remove Liquid::BlockBody patch (#12313)

* Refactored all site config default hardcoded value in rspec test

* Added seperate function to fetch default site confif value and using it in specs

Co-authored-by: rhymes <rhymes@hey.com>
 2021-01-18 15:23:40 +01:00
dependabot[bot]
65bfc640ce
Bump husky from 4.3.7 to 4.3.8 (#12318) 
Bumps [husky](https://github.com/typicode/husky) from 4.3.7 to 4.3.8.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](https://github.com/typicode/husky/compare/v4.3.7...v4.3.8)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-01-18 12:47:05 +01:00
Anna Buianova
020912264e
Optimize loading partials as collections (#12276) 
* Load events' partials  as collections

* Load /admin/articles partials as collections

* Render sponsorships partial as collection

* Render organization articles partials as collection

* Load users articles partials as collections
 2021-01-18 14:18:33 +03:00
rhymes
3750ea6544
Remove Liquid::BlockBody patch (#12313) 2021-01-18 08:09:28 +01:00
dependabot[bot]
a63ba17b6a
Bump liquid from 4.0.3 to 5.0.0 (#12150) 
* Bump liquid from 4.0.3 to 5.0.0

Bumps [liquid](https://github.com/Shopify/liquid) from 4.0.3 to 5.0.0.
- [Release notes](https://github.com/Shopify/liquid/releases)
- [Changelog](https://github.com/Shopify/liquid/blob/master/History.md)
- [Commits](https://github.com/Shopify/liquid/compare/v4.0.3...v5.0.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Convert ActiveSupport::SafeBuffer to string

* Disable echo and render tags

* Disable liquid tag

* Add issue link

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rhymes <rhymes@hey.com>
 2021-01-15 15:37:42 -06:00
Bogdan Covrig
ad4df246dd
Replace misc :user_settings_path with :customization (#12300) 2021-01-15 15:17:23 -06:00
Julianna Tetreault
d06ee645f8
Improve Error Messaging for Self-Deletion Confirmation Flow (#12266) [deploy] 
* Adds guard clauses and better error messages to UsersController #confirm_destroy

* Adds tests around guard clauses in UsersController #confirm_destroy

* Adds a custom error for invalid tokens in UsersController#confirm_destroy

* Refactor user_destroy_token.rb initialize method to be more succinct

* Removes unnecessary code from user_self_destroy_spec.rb and fixes failing InvalidToken spec

* Reworks code in #confirm_destroy to be consistent with other #destroy methods

* Adjust token mismatch test to use mismatched tokens

* Refactors #confirm_destroy and adds a before_action to Users::Controller
 - Reworks the logic within #confirm_destroy and removes excess code
 - Adds set_or_sign_in_user before_action for #confirm_destroy
 - Removes custom InvalidToken error message

* Cleans up spec and adds an additional test around logged out user edge case

* Fixes failing tests due to changes in #confirm_delete flow

* Adjusts test logic in user_self_destroy_spec.rb

* Refactors code by removing custom before_action and rewriting conditionals
 2021-01-15 11:51:06 -07:00
Ridhwana
65d439e70d
Attempt to fix random test failures when dealing with the ForemInstance class (#12294) 
* fix: set the deployed at to nil

* chore: make sure the heroku env is also set to empty

* Sprinkle more after block

Co-authored-by: Mac Siri <krairit.siri@gmail.com>
 2021-01-15 19:44:18 +02:00
Christina
c0f38b4567
Adding Community to the table of contents. (#12293) 
When I updated the docs with the community section previously I forgot to add the link in the Table of Contents. This adds the link.
 2021-01-15 09:40:16 -06:00
Fernando Valverde
e60159184f
Fixes apple auth creator flow in /admin/config (#12287) 2021-01-15 08:07:34 -06:00
dependabot[bot]
c1ffe3d4e5
Bump derailed_benchmarks from 1.8.1 to 2.0.0 (#12291) 
Bumps [derailed_benchmarks](https://github.com/schneems/derailed_benchmarks) from 1.8.1 to 2.0.0.
- [Release notes](https://github.com/schneems/derailed_benchmarks/releases)
- [Changelog](https://github.com/schneems/derailed_benchmarks/blob/main/CHANGELOG.md)
- [Commits](https://github.com/schneems/derailed_benchmarks/compare/v1.8.1...v2.0.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-01-15 08:57:13 -05:00
dependabot[bot]
7f4f9ac2e8
Bump listen from 3.4.0 to 3.4.1 (#12290) 
Bumps [listen](https://github.com/guard/listen) from 3.4.0 to 3.4.1.
- [Release notes](https://github.com/guard/listen/releases)
- [Commits](https://github.com/guard/listen/compare/v3.4.0...v3.4.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-01-15 12:41:23 +01:00
rhymes
c2c1366a4d
Enable new rules and run Rubocop autocorrect (#12232) 2021-01-14 16:35:27 -05:00
Molly Struve
636f4b0ae1
Bug Fix:Increase Default Rate Limit for User Updates to 15 (#12281) 
* Bug Fix:Increase Default Rate Limit for User Updates to 15

* spec fix
 2021-01-14 12:51:08 -06:00
Ben Halpern
4c6a7ef234
Fix outstanding /pod main image problem (#12280) 2021-01-14 13:18:47 -05:00
dependabot[bot]
49723396c4
Bump fog-aws from 3.7.0 to 3.8.0 (#12275) 
Bumps [fog-aws](https://github.com/fog/fog-aws) from 3.7.0 to 3.8.0.
- [Release notes](https://github.com/fog/fog-aws/releases)
- [Changelog](https://github.com/fog/fog-aws/blob/master/CHANGELOG.md)
- [Commits](https://github.com/fog/fog-aws/compare/v3.7.0...v3.8.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-01-14 11:17:38 -06:00
dependabot[bot]
9b7506d5c5
Bump webmock from 3.11.0 to 3.11.1 (#12274) 
Bumps [webmock](https://github.com/bblimke/webmock) from 3.11.0 to 3.11.1.
- [Release notes](https://github.com/bblimke/webmock/releases)
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md)
- [Commits](https://github.com/bblimke/webmock/compare/v3.11.0...v3.11.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-01-14 11:16:57 -06:00
Fernando Valverde
7f3859a8b4
Workaround for Apple auth problems (still in beta) (#12263) 
* Workaround for Apple auth problems (still in beta)

* Fix spec
 2021-01-14 09:44:56 -06:00
Ben Halpern
444841bb90
Fix domain list bug (#12268) 2021-01-14 10:43:42 -05:00
Alex
31689fd76a
Break MarkdownFixer into MarkdownProcessor::Fixer services (#12241) 
* Create new MarkdownProcessor::Fixer services

* Remove old MarkdownFixer

* Code cleanup

* Capitalize Base in code comments

* Remove comments related to inheritance

* Add fix_methods method to hold METHDOS constant
 2021-01-14 10:26:46 -05:00
Suzanne Aitchison
cb44b31c83
add suzanne to list of core team members (#12277) 2021-01-14 13:39:41 +00:00
Michael Kohl
36714f0352
Update Gemfile.lock for Bundler 2.2 (#12272) 2021-01-14 08:27:58 -05:00
dependabot[bot]
70774d96ee
Bump twilio-ruby from 5.45.1 to 5.46.0 (#12271) 2021-01-14 08:23:48 -05:00
rhymes
c54ee01864
Dependabot: disable language/ecosystem labels attached to PRs (#12260) 2021-01-14 11:21:16 +01:00
dependabot[bot]
d2cfde04fa
Bump webpack-dev-server from 3.11.1 to 3.11.2 (#12273) 
Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server) from 3.11.1 to 3.11.2.
- [Release notes](https://github.com/webpack/webpack-dev-server/releases)
- [Changelog](https://github.com/webpack/webpack-dev-server/blob/v3.11.2/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-dev-server/compare/v3.11.1...v3.11.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-01-14 09:03:00 +01:00
Michael Kohl
cc6edc66b6
Remove contact_consent column from ignore list (#12254) 2021-01-14 12:38:42 +07:00
Molly Struve
5a3ea304ca
Log User Save Error Messages When it Fails (#12267) 2021-01-13 16:14:48 -06:00
Andy Zhao
eed4df0fa4
Add sorting feature to /admin/tags (#12249) 
* Use Ransack for admin/tags

* Update admin tags index to use search with Ransack

* Add feature to sort tags in /admin/tags

* Add test for viewing /admin/tags pages

* Add aria labels for sort links

* Make links a bit more accessible
 2021-01-13 17:03:17 -05:00
ashwin
76894934e9
Fixed punctuation mistakes (#12209) 
* Fixed punctuation mistakes

* Update README.md

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Update README.md

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Update README.md

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Update README.md

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
 2021-01-13 16:27:46 -05:00
Andy Zhao
b45c578ea1
Encode emails properly before sending to /confirm-email (#12211) 
* Refactor test a bit

* Account for URL encoding when redirecting to /confirm-email

* Fix failing spec

* Use correct method to encode + and @

* Fix test

* Don't encode things I don't need to (thanks Nick)
 2021-01-13 15:17:14 -05:00
Alex
27df7ddee5
Remove old MailchimpBot (#12244) 
* Remove old MailchimpBot

* Wake up, Travis

* Wake up, Travis
 2021-01-13 14:33:21 -05:00
Arit Amana
3a984c8ee7
[2020 EOY Issue] Modal alert when enabling Auth Provider without keys (#12135) 
* Start hooking things up

* further generalize adminModal, hook up relevant code

* Complete implementation

* remove comments

* Address QA suggestions

* Address QA suggestions

* Use object parameter for adminModal

* starting the admin cypress tests

* Code review suggestions

* remove incomplete test

* rename data attributes to make more sense

* complete the work

* use destructuring

* edit warning modal text
 2021-01-13 13:54:39 -05:00
Molly Struve
0f2c0c70b1
Log onboarding_checkbox_update Params (#12252) 2021-01-13 12:39:25 -06:00
Alex
01a4b41fed
Fix shell version logic in async info controller (#12262) 
* Add .to_s to ForemInstance.deployed_at

* test: could it possibly be holding onto the cached value across the tests

Co-authored-by: Ridhwana <ridhwana.khan16@gmail.com>
 2021-01-13 13:20:34 -05:00
Alex
a5e6f7942c
Rename MarkdownParser to MarkdownProcessor::Parser (#12248) 
* Rename MarkdownParser to MarkdownProcessor::Parse

* Wake up, Travis

* Fix typo
 2021-01-13 10:39:13 -05:00
Ridhwana
4549144fbb
Refactor deployed_at and latest_commit_id code (#12224) 
* WIP: release footprint in the admin UI

* feat: show the commit ID and the date

* chore: change env optional to empty string

* fix: change the FOREM_BUILD_DATE to RELEASE_FOOTPRINT

* feat: add Not Available as a last option

* test: last deployed time and latest commit id

* feat: update the way we change the env variable!

* fix: we need to set the RELEASE FOOTPRINT so that this clause is not hit - `return path if release_footprint.blank?`

* feat: add a Forem Instance Model

* chore: rename variable

* feat: use the new model that we created

* feat: Update the Forem Instance model to remove Not available from the model method and add it to the view layer

* test: Forem Instance model to return the correct values when present

* feat: use Forem.deployed_at instead of the Application config directly

* chore: remove the initializer

* feat: rename the data keys to reflect what it does

* fix: oops evaluate the var

* refactor: static values that can never change during the lifetime of the app should be constants

* chore: setup the test to have a release footprint before the test gets executed

* chore: remove the methods

* revert to method + cache

* revert to using method

* reset the instance variable
 2021-01-13 16:53:59 +02:00
ludwiczakpawel
0c6c5c55a1
Code snippet fullscreen icon - setting constraints for size. (#12010) 
* tooltips 1.0.1

* tooltips 1.0.1

* initial fix

* .

* .

* test

* Add data update script to re-save published articles

* Approve verified diffs

* Fix Rubocop violation

Co-authored-by: rhymes <rhymes@hey.com>
 2021-01-13 15:17:10 +01:00
dependabot[bot]
34c8b7a55e
Bump strong_migrations from 0.7.4 to 0.7.5 (#12258) 
Bumps [strong_migrations](https://github.com/ankane/strong_migrations) from 0.7.4 to 0.7.5.
- [Release notes](https://github.com/ankane/strong_migrations/releases)
- [Changelog](https://github.com/ankane/strong_migrations/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ankane/strong_migrations/compare/v0.7.4...v0.7.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-01-13 07:49:32 -06:00
dependabot[bot]
19150adcbd
Bump katex from 0.6.0 to 0.6.1 (#12257) 
Bumps [katex](https://github.com/glebm/katex-ruby) from 0.6.0 to 0.6.1.
- [Release notes](https://github.com/glebm/katex-ruby/releases)
- [Changelog](https://github.com/glebm/katex-ruby/blob/master/CHANGES.md)
- [Commits](https://github.com/glebm/katex-ruby/compare/v0.6.0...v0.6.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-01-13 07:48:29 -06:00
Spencer
27648a938b
API: Endpoint to get an organization's articles (#12237) 
* update route

* add controller action

* add article jbuilder/update shared files

* add tests

* update api docs

* add published to query

* render articles index/delete articles jbuilder

* call articles index attributes const

* put back article/flare partials

* bug fix for readinglist index

* bug fix for render partial in jbuilder
 2021-01-13 13:09:58 +01:00