Commit graph

12355 commits

Author SHA1 Message Date
Mac Siri
cb3b12feaa
Expand CI nodes (#19073) 2023-02-06 15:15:26 -05:00
depfu[bot]
2566654f5a
[ruby] Update strong_migrations: 1.4.1 → 1.4.2 (patch) (#19070)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-02-06 15:12:10 -05:00
Fernando Valverde
474eea39e9
👋❤️ 👋🏼 (#19063)
Co-authored-by: Mai Irie <mai.irie@gmail.com>
2023-02-06 10:45:45 +02:00
Ben Halpern
d46b54330e
Revert hidden shell cleanup (#19059) 2023-02-06 10:43:11 +02:00
Fernando Valverde
b2444d032d
/organizations api docs (#19055)
* /organizations api docs

* Remove Listings support
2023-02-03 15:12:03 -06:00
Fernando Valverde
c6419d7300
/tags api docs (#19048)
* /tags api docs

* Merge main
2023-02-03 14:11:38 -06:00
Fernando Valverde
7e9185f48b
Revert "[ruby] Update omniauth-apple: 1.2.2 → 1.3.0 (minor)" (#19060) 2023-02-03 14:47:55 -05:00
Lawrence
3186f7ae2d
CommentDate Migration to Pack tag (#19025)
* migration init

* create an initializers directory

* remove console log

* migrate localDateTime functions and remove comment date from asset pipeline

* add unit test

* add one more

* year test
2023-02-03 13:40:17 -06:00
Fernando Valverde
605ebbfa3b
Bump localstorage key for podcast player (#19057) 2023-02-03 12:03:39 -06:00
Fernando Valverde
bb7e193b3e
/videos api docs (#19049)
* /videos api docs

* Merge main
2023-02-03 10:22:57 -06:00
Fernando Valverde
8341c5a5dd
Fix JS error when window.Forem.runtime is not available yet (#19007)
* Add retry with timeout if window.Forem.runtime is not available

* Refactor asset pipeline initializer into webpack bundle

* Remove leftover comment

* Fix CodeQL issue

* Revert Regexp interpolation

* Revert regexp interpolation without verify

* Remove problematic Regexp marked as dangerous by CodeQL
2023-02-03 05:57:49 -06:00
Fernando Valverde
13288c5626
API V1 Users docs (#19046)
* /users/me api docs

* Updated api_v1.json

* Missing users api docs
2023-02-03 05:43:48 -06:00
Ridhwana
aa305ddcaf
remove some old service worker code (#19036) 2023-02-03 11:51:04 +02:00
Mac Siri
45e292463e
Add proper CodeCov flags (#19044) 2023-02-02 15:41:42 -05:00
Lawrence
df678d2c03
baseTracking Initializer Migration (#19016)
* baseTracking pack

* Define dataLayer

* disable unused var

* disable another unused var

* remove initializer call from base of asset pipeline

* remove asset pipeline baseTracking file
2023-02-02 13:15:36 -06:00
Rajat Talesra
f9a7b93bc1
Multiple reactions - remove circle from active reactions (#19034)
* Reading list toggle issue fix

* Removed circle border for reaction

* Added feature flag
2023-02-02 22:01:58 +05:30
Joshua Wehner
fd7021b001
Pages API: create, update, and delete (#19009)
* Pages API pt 1 (read/get/index+show)

* Update spec/requests/api/v1/docs/pages_spec.rb

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

* Update spec/requests/api/v1/docs/pages_spec.rb

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

* API Key not required for index & show

* API Feature flag has long since been removed

* Page schema

* Fix spec broken by merge

* Temporary bugfix: slug uniqueness not working for Page

* Pages API endpoints for create, update, and destroy

* Fix swagger error

---------

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2023-02-02 17:24:11 +01:00
ktmouk
151a118f57
Fix the last line of editor is not visible (#19023)
Co-authored-by: Lawrence <lawrence@forem.com>
2023-02-02 06:10:24 -06:00
Rajat Talesra
93f73636c7
Post bootstrap changes - remove headings from admin.scss (#19019)
* h1 and h2 design fixes

* h2 redesign fixes

* Removed incorrect code

* Revert incorrect test code

* h3 heading redesign

* h4,h4,h5 headings redesign

* Minor design fixes

* Fixed all heading styles

* Test case fix

* Revert incorrect if condition

* Revert incorrect if condition

* Removed non required div
2023-02-02 15:52:35 +05:30
depfu[bot]
56474f72c1
[ruby] Update bootsnap: 1.15.0 → 1.16.0 (minor) (#19047)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Mac Siri <mac@forem.com>
2023-02-01 16:55:16 -05:00
depfu[bot]
7ca005673c
[js] Update all Yarn dependencies (2023-02-01) (#19022)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Lawrence <lawrence@forem.com>
2023-02-01 15:28:42 -05:00
Rajat Talesra
6204b22094
Reading list toggle issue fix (#19033) 2023-02-02 00:06:36 +05:30
Fernando Valverde
de6a5a0f07
Include Mastodon as social media option with rel=me attribute for verificatiion (#19015)
* Include Mastodon as social media option w/ rel=me attribute

* Extract social media from overloaded partial - admin config
2023-02-01 09:51:51 -06:00
Rajat Talesra
9f04c5501e
Multiple reactions ,minor fixes (#19027) 2023-02-01 21:02:48 +05:30
depfu[bot]
93a8179ae2
[ruby] Update pg_query: 2.2.0 → 2.2.1 (patch) (#19030)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Mac Siri <mac@forem.com>
2023-02-01 09:38:09 -05:00
Ridhwana
686976ced8
Round Robin Notifications Refactor (#19026)
* chore: rubocop

* feat: rename the worker in accordance to our guidelines and to be more verbose

* refactor: move the NotificationsModeration service to be a users query, and move the constants out to new files

* refactor: removed subscribed_to_mod_roundrobin_notifications? which was only being used once in a test

* refactor: remove the aliass from the user method and add them to notification_setting + update references
2023-02-01 15:21:36 +02:00
Mac Siri
59f6118e92
Update Users::ProfileImageGenerator (#19040)
* Update Users::ProfileImageGenerator

* Update other spec
2023-02-01 06:12:26 -05:00
Mac Siri
b77c1ea2e6
Change rake spec setup (#19012) 2023-01-30 10:51:38 -05:00
Ridhwana
2da1b45c32
Move a portion of the Display Ads tests alongside the query (#19017)
* Remove jQuery

* Added jquery back to videos

* Removed jquery code

* Nit fix

* Revert incorrect code

* Updated jquery code to javascript

* Removed jquery from comments

* refactor: move the spec to test the query

---------

Co-authored-by: rt4914 <rajattalesra4914@gmail.com>
Co-authored-by: Rajat Talesra <rajat@forem.com>
2023-01-30 10:57:34 +02:00
depfu[bot]
cde0f92211
[js] Update all Yarn dependencies (2023-01-03) (#18919)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-01-27 12:40:13 -05:00
Mac Siri
db77be4018
Ignore sitemap_generator and generators (#19010) 2023-01-27 10:31:13 -05:00
Mac Siri
8e76bc046b
Refactor CreatorSettingsForm & spec (#19011) 2023-01-27 08:39:07 -05:00
Joshua Wehner
909fd7f103
Try having sync_reactions_count as a background job (#18991)
* Try having sync_reactable as a background job

* Update test

* Fix flakey test (order should not matter)
2023-01-27 12:58:13 +01:00
Rajat Talesra
bbb8985a51
Fixed bookmark flash issue (#18997)
* Fixed bookmark flash issue

* User nil check
2023-01-27 10:31:03 +05:30
Ridhwana
a37d79f8e5
Refactor display_for method in the display_ad model (#18981)
* feat: sample relevant ads display ads

* Remove jQuery

* Added jquery back to videos

* refactor: pass the relevant paramenters to the newly created service, move the code over to the service, pass through display ads, use the display ads parameter for queries, use instance vars

* refactor: approve and published display ads

* feat: tagged post comment ads

* refactor: display_ads for tagged postcomments

* refactor: authenticated ads

* refactor: sample ads

* fix: oops pass teh parameter)

* refactor: use ... to forward and delegate arguments to the method

* feat: use a filtered_display_ads instance variable in the service instead of passing the relation variable around

* feat: make sure that the instance variable stays upto date

* feta: update the header for comment

* feat: remove the service test for now

* refactor: change the names to make it more readable

* feat: use named parameters

* refactor: we are ordering by success rate just before we sample so why order twice

* chore: remove the reader

* refactor: move into two separate functions

* fix: rename placement_area_ads

* refactor: user_authentication_ads

* Update app/services/display_ads/sample_relevant_ads.rb

Co-authored-by: Joshua Wehner <joshua@forem.com>

* Removed jquery code

* Nit fix

* Revert incorrect code

* Updated jquery code to javascript

* Removed jquery from comments

* refactor: move to query and rename

* chore: move params on diff lines

Co-authored-by: rt4914 <rajattalesra4914@gmail.com>
Co-authored-by: Joshua Wehner <joshua@forem.com>
Co-authored-by: Rajat Talesra <rajat@forem.com>
2023-01-26 19:48:22 +02:00
Ridhwana
9ba3df4453
Round Robin Notification Tweaks (#18995)
* Remove jQuery

* Added jquery back to videos

* feat: increase the available moderator count

* Removed jquery code

* Nit fix

* Revert incorrect code

* Updated jquery code to javascript

* Removed jquery from comments

* feat: updates the last_reacted_at value when saving a creation

* feat: update the query for available moderators

* spec: write a test for the available moderators

* fic: update the reaction spec with current time

* fix: add last_reacted_at to the send_spec

* fix: add last_reacted_at to the user

* chore: move the queries around

* fix: change timecop block

* fix: update the last_reacted_at for the user

* chore: try to fix timecop

* Update app/services/notifications/moderation.rb

Co-authored-by: Mac Siri <mac@forem.com>

* feat: update the tests

Co-authored-by: rt4914 <rajattalesra4914@gmail.com>
Co-authored-by: Rajat Talesra <rajat@forem.com>
Co-authored-by: Mac Siri <mac@forem.com>
2023-01-26 19:31:45 +02:00
Mac Siri
ec3971a387
Create FindsBin spec (#18992) 2023-01-26 10:46:18 -05:00
Rajat Talesra
d4d7d8f409
CSS: Dark mode minor fixes (#19014)
* Dark mode fixes

* Bookmark fix
2023-01-26 15:31:46 +05:30
Fernando Valverde
db821a806f
/comments API docs (#18983)
* file

* Comments API
2023-01-25 12:06:43 -06:00
Joshua Wehner
7f41dae631
Pages API: Read (get index+show) (#18970)
* Pages API pt 1 (read/get/index+show)

* Update spec/requests/api/v1/docs/pages_spec.rb

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

* Update spec/requests/api/v1/docs/pages_spec.rb

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

* API Key not required for index & show

* API Feature flag has long since been removed

* Page schema

* Fix spec broken by merge

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2023-01-25 17:15:27 +01:00
Anna Buianova
6524406d1d
Fixed redundant article and comment markdown parsing (#18989)
* Fixed redundant article and comment markdown parsing

* Removed useless comments

* Fixed ContentRenderer specs
2023-01-25 13:56:43 +03:00
Rajat Talesra
7c6f269b14
Onboarding dark mode fixees (#18996) 2023-01-25 10:53:59 +05:30
depfu[bot]
99133a6e56
[ruby] Update omniauth-apple: 1.2.2 → 1.3.0 (minor) (#18994)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
2023-01-24 14:48:16 -05:00
Mac Siri
2218a14fff
Refactor/Improve addTagsToArticle specs (#19006) 2023-01-24 14:48:01 -05:00
Mac Siri
f8469b04fb
Use codecov's automatic flag management (#18927) 2023-01-24 14:47:36 -05:00
Fernando Valverde
8c62f9d6b3
Add the missing API docs for /articles (#18848)
* Progress on more articles API docs

* Some progress

* Broken update article doc spec but some progress

* Fix articles put rswag spec

* Fix spec

* Add missing specs

* Apply PR review feedback
2023-01-24 13:44:29 -06:00
Rajat Talesra
ff790c147e
Removed jQuery usage from admin ( -- now it exists only in views/videos) (#18976)
* Remove jQuery

* Added jquery back to videos

* Removed jquery code

* Nit fix

* Revert incorrect code

* Updated jquery code to javascript

* Removed jquery from comments
2023-01-24 21:03:12 +05:30
Ben Halpern
3aa9aa0b63
Adjust copy in 'trusted' email (#18977)
* Adjust copy in 'trusted' email

* Add trusted email text version
2023-01-24 09:19:35 -05:00
Mac Siri
0a5f1c12f7
Fix broken specs (#18993) 2023-01-23 23:05:42 -05:00
Lawrence
0ac9852663
[API v1 docs] Followed Tags (#18952)
* Followed Tags swag docs

* Update spec/requests/api/v1/docs/followed_tags_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add to swagger helper

* minor tweaks

* more cleanup

* syntax change

* name change

* User doesn't have to be an admin

* Update spec/requests/api/v1/docs/followed_tags_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update spec/requests/api/v1/docs/followed_tags_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* update v1 json structure

* Update spec/swagger_helper.rb

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

* Update spec/requests/api/v1/docs/followed_tags_spec.rb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* re-generate swagger file

* Update spec/requests/api/v1/docs/followed_tags_spec.rb

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

* regenerated swagger file

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2023-01-23 13:28:36 -06:00