Commit graph

1335 commits

Author SHA1 Message Date
rhymes
c989cbf301 Super small queries optimizations (#1586)
* Replace find_by().nil? with exists?

find_by asks the DB and the ORM to load the entire object in memory, then it is discarded just know if it exists or not. Exists will just return true or false

* Use present? in lieu of any? when it is proper

A request for any? followed by each in a most likely full collection results in two SQL queries. present? preloads the objects, so it results in one single connection because the objects are already in memory.
2019-01-19 17:28:02 -05:00
Ben Halpern
de0dc2f2a8
Update procfile (#1590)
* Change worker line in procfile

* mod buildpacks

* Add bin/start-pgbouncer

* Modify procfile

* Remove bin/start-pgbouncer
2019-01-18 11:53:36 -05:00
Ben Halpern
e4217d721f
Remove stunnel (#1589) 2019-01-18 10:26:07 -05:00
Ben Halpern
bc2f905a9d
Update procfile for pgbouncer (#1588) 2019-01-18 10:22:27 -05:00
Andrew Bone
b56865915c Jsfiddle LiquidTag (#1509)
* Create jsfiddle_tag.rb

Add liquid tag for jsfiddle

* Create jsfiddle_tag-spec.rb

Add liquid tag for jsfiddle

* Update _editor_guide_text.html.erb

Add liquid tag for jsfiddle

* Updates for rubocop

* Edit boilerplate

Change some of the boiler plate code.

* rubocop compliance

* Fixed name

Fixed file name

* Fixed boiler plate

Changed codepen to jsfiddle

* Update guide text

Change the Guide Text to be jsfiddle specific.

Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>

* Fixed typo in spec

Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>

* Update Valid Link

* Update jsfiddle_tag.rb

* Add Approved html

* Remove double slash

* Revert change

* Fix XSS error

* Remove extra line

* Remove extra slash

* Remove extra slash

* Make DRY

* rubocop compliance

* Change test logic

* Revert test to Approvals

* Fix HTML approved
2019-01-17 15:44:01 -05:00
Mac Siri
7d98a79b6f
Update .travis.yml
oops
2019-01-17 13:30:40 -05:00
38elements
c6b09939d9 Remove unnecessary CSS property (#1581) 2019-01-17 12:22:24 -05:00
Mac Siri
b2bdb43206
Update .travis.yml [ci skip]
Print out failed approvals spec in detail.
2019-01-17 12:20:11 -05:00
Dave Follett
6c571e8bcd Fixed bug that allows XSS with the codepen embed. (#1578) 2019-01-17 11:38:39 -05:00
Ben Halpern
b8117775e3
Remove puma worker killer (#1575) 2019-01-16 18:14:43 -05:00
Jess Lee
38091ba486 Update twitter validation and internal/articles query (#1571)
* update validation and only show published articles

* update twitter satellite count

Co-Authored-By: jessleenyc <jessleenyc@gmail.com>
2019-01-16 17:15:22 -05:00
rhymes
5ee725410b Replace data with content in export email copy (#1572) 2019-01-16 17:10:06 -05:00
Ben Halpern
b1f18f5bbc
Improve feed and add more randomness (#1570)
* Improve feed and add more randomness

* Fix tests

* Fix test score calc

* Modify home page test criteria
2019-01-16 16:01:14 -05:00
Nathan Sebhastian
5f051d9512 Add maintaining your fork to docs (#742) [ci skip] 2019-01-16 14:48:38 -05:00
rhymes
a0c9576bec Export comments (#1471)
* Use name attribute

* Export comments

* Update copy

* Fix time-dependent test

* Remove reactions_count from the export

* Only select needed attributes from the DB

* Add the path of the commentable to the export

Comments are attached to something but from the export that is not easily identifiable. We add the "commentable_path" to give some context.
2019-01-16 12:54:45 -05:00
Ben Halpern
f1e7f12e1d
Reduce queries in bulk follow (#1568) 2019-01-16 12:21:15 -05:00
Jess Lee
6ca4aec6c8 add spec for invalid captcha (#1569) 2019-01-16 12:20:40 -05:00
Jess Lee
5bacb4e8c1 Removed bug reports from app (#1565)
* remove bug report form and add github link

* update abuse report email templates

* remove bug-report logic

* remove emoji from form

* remove revised500 page
2019-01-16 11:28:59 -05:00
Ben Halpern
9736d411d3
Fix get_all_articles in RssReader (#1566) 2019-01-15 22:25:30 -05:00
rhymes
dee7429883 Replace each with find_each for AR queries (#1557) 2019-01-15 16:38:03 -05:00
dependabot[bot]
a3c6240231 Bump pg from 1.0.0 to 1.1.4 (#1556)
Bumps [pg](https://bitbucket.org/ged/ruby-pg) from 1.0.0 to 1.1.4.
- [Changelog](https://bitbucket.org/ged/ruby-pg/src/default/History.rdoc)
- [Commits](https://bitbucket.org/ged/ruby-pg/branches/compare/v1.1.4..v1.0.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-01-15 16:27:48 -05:00
Ben Halpern
7f7a35048a
Find by title or feed source URL in rss fetch (#1560) 2019-01-15 15:34:13 -05:00
Ben Halpern
47e8fbc9ec
Add feed_fetched_at for users to not refetch unnecessarily (#1555)
* Fix RSS issues by not refetching users as often

* Make rss fetch not forced in rake task

* Remove unnecesary schema line
2019-01-15 13:29:11 -05:00
dependabot[bot]
dbd71b3031 Bump omniauth from 1.8.1 to 1.9.0 (#1529)
Bumps [omniauth](https://github.com/omniauth/omniauth) from 1.8.1 to 1.9.0.
- [Release notes](https://github.com/omniauth/omniauth/releases)
- [Commits](https://github.com/omniauth/omniauth/compare/v1.8.1...v1.9.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-01-15 12:44:47 -05:00
dependabot[bot]
4b31ec23df Bump sdoc from 0.4.2 to 1.0.0 (#1532) [ci skip]
Bumps [sdoc](https://github.com/zzak/sdoc) from 0.4.2 to 1.0.0.
- [Release notes](https://github.com/zzak/sdoc/releases)
- [Changelog](https://github.com/zzak/sdoc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zzak/sdoc/compare/v0.4.2...v1.0.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-01-15 12:42:31 -05:00
rhymes
d09e8e481f Log ActiveRecord queries in development (#1549) [ci skip] 2019-01-15 10:35:55 -05:00
Ben Halpern
0dac3b9662
Fix search page reading time issue (#1544) 2019-01-14 19:04:02 -05:00
Anna Buianova
53e8490e75 Refactor redirect from the old username or organization slug (#1527) 2019-01-14 18:10:57 -05:00
Ben Halpern
d988bc71f9
Add reading time to articles (#1538)
* add comment template

* merge upstream

* Initial work

* make sure the template re-appears for top level comments after submission

* Small fix

* Fix git issues

* Account for missing reading times

* Add minimal score on sidebar

* Test for page to include min read

* rubocop cleanup

* Mess with test

* Add .to_i after score

* Modify search_score var
2019-01-14 15:58:33 -05:00
Andy Zhao
7726acf157 Update notification's request specs (#1450)
Fixes all the notification request specs that were xited. This should help us feel more comfortable making changes to notifications.

Also made a small (performance?) improvement by using an already defined variable.
2019-01-14 15:20:04 -05:00
Mac Siri
f780e5fbc9 Refactor RssReader (#1537)
* Update RssReader::get_all_articles

* Move RssReader to services

* Create RssReader::Assembler

* Improve RssReader's spec
2019-01-14 14:25:49 -05:00
dependabot[bot]
3b967a4a38 Bump google-api-client from 0.25.0 to 0.27.3 (#1533)
Bumps [google-api-client](https://github.com/google/google-api-ruby-client) from 0.25.0 to 0.27.3.
- [Release notes](https://github.com/google/google-api-ruby-client/releases)
- [Changelog](https://github.com/googleapis/google-api-ruby-client/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/google-api-ruby-client/compare/0.25.0...0.27.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-01-14 11:43:27 -05:00
dependabot[bot]
113e86cd97 Bump dalli from 2.7.8 to 2.7.9 (#1531) [ci skip]
Bumps [dalli](https://github.com/petergoldstein/dalli) from 2.7.8 to 2.7.9.
- [Release notes](https://github.com/petergoldstein/dalli/releases)
- [Changelog](https://github.com/petergoldstein/dalli/blob/master/History.md)
- [Commits](https://github.com/petergoldstein/dalli/compare/v2.7.8...v2.7.9)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-01-14 11:43:06 -05:00
dependabot[bot]
a4ce130156 Bump eslint-config-prettier from 3.3.0 to 3.4.0 (#1534) [ci skip]
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/prettier/eslint-config-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prettier/eslint-config-prettier/compare/v3.3.0...v3.4.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-01-14 11:38:20 -05:00
Andy Zhao
e3f9792b21 Add logging info in case sign in fails (#1519)
* Add logging info in case sign in fails

* Use string interpolation instead

* Remove logger from auth service
2019-01-14 10:01:17 -05:00
dependabot[bot]
12d31853de Bump twilio-video from 1.14.2 to 1.15.0 (#1535)
Bumps [twilio-video](https://github.com/twilio/twilio-video.js) from 1.14.2 to 1.15.0.
- [Release notes](https://github.com/twilio/twilio-video.js/releases)
- [Changelog](https://github.com/twilio/twilio-video.js/blob/1.15.0/CHANGELOG.md)
- [Commits](https://github.com/twilio/twilio-video.js/compare/1.14.2...1.15.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-01-14 09:59:44 -05:00
dependabot[bot]
c842b83781 Bump derailed_benchmarks from 1.3.4 to 1.3.5 (#1530)
Bumps [derailed_benchmarks](https://github.com/schneems/derailed_benchmarks) from 1.3.4 to 1.3.5.
- [Release notes](https://github.com/schneems/derailed_benchmarks/releases)
- [Changelog](https://github.com/schneems/derailed_benchmarks/blob/master/CHANGELOG.md)
- [Commits](https://github.com/schneems/derailed_benchmarks/compare/v1.3.4...v1.3.5)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-01-14 09:53:02 -05:00
Anna Buianova
8610d503a4 Rubocop fixes (#1528) 2019-01-14 09:17:01 -05:00
Jess Lee
aecb0409a2 update unmatched mentor query (#1521) 2019-01-13 16:04:12 -05:00
Bogdan Covrig
d6d95024ae Update the installation documentation (#1525)
* Edited Algolia

* Added Algolia sign-up stepts

* Added sign up Twitter doc

* Changed Twitter info

* Added Twitter and Agolia screenshots

* Added Github and Pusher sections

* Added Github and Pusher sections
2019-01-13 16:03:16 -05:00
Arun Kumar
a0d39e15bd Fix braces around hash params Rubocop offense (#1453) 2019-01-11 13:08:45 -05:00
M. Bellucci
a52af3da8b Avoid using meta-programming for solving code duplication. (#1457)
* Add feature spec for twitter login

* Avoid using class eval for solving code duplication.

This change make code easier to change in the future.

* Fix codeclimate issues

* Introduce explanatory methods
2019-01-11 12:00:09 -05:00
Ben Halpern
2fd314e40b
Fix chat css and banish logic (#1515) 2019-01-10 18:09:42 -05:00
Abraham Williams
37ebb5f836 Switch buffer gem to published version (#1507) 2019-01-10 17:27:13 -05:00
Mac Siri
11684331d4
Silence Delayed::Workers in spec [ci skip] 2019-01-10 16:33:58 -05:00
Mario See
6ade962480 connect message spacing fix (#1259)
* style changes

* removed detail already in parent class

* Update chat.scss

width assertions

* mobile
2019-01-10 14:33:25 -05:00
Andy Zhao
68807c6df7 Allow Organizations to Update Slug/Username (#1411)
* Close anchor tag typo

* Remove confusing message in profile

* Fix typo in spec

* Add old_slug and old_old_slug fields to org

* Test for check_for_slug_change method

* Add ability for orgs to change slug

* Update copy to match new org language

* Add redirect for organizations with old slugs

* Use less queries for handling org/user redirect

* Use consistent syntax for user creation

* Test for organization slug redirects

* Refactor user article redirect
2019-01-10 14:16:43 -05:00
Andrew Bone
4673496830 SlideShare Liquid tag (#1485)
* Create slideshare_tag.rb

* Create slideshare_tag_spec.rb

* Add slide share

* rubocop compliance

* Still learning

https://ruby-doc.org/core-2.5.1/Regexp.html

* More secure match

Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>

* Strip whitespace

Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>

* Strip before regex

Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>

* Remove latter strip

Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>
2019-01-10 12:58:16 -05:00
Anna Buianova
8f348f9831 Fix comment cancel button url (#1508) 2019-01-10 12:25:11 -05:00
Ben Halpern
b4384867ad
Remove access_token key for twitter dump (#1510) 2019-01-10 11:48:27 -05:00