Commit graph

7522 commits

Author SHA1 Message Date
Mac Siri
c4fdeeb944
Make Images::Optimizer nil-safe (#11584) 2020-11-24 09:39:34 -05:00
Oskar Janusz
397f426b87
Add Github environments keys to .env_sample file (#11591) 2020-11-24 15:05:17 +01:00
dependabot-preview[bot]
c17ccb4a76
Bump @storybook/addon-knobs from 6.1.2 to 6.1.4 (#11593)
Bumps [@storybook/addon-knobs](https://github.com/storybookjs/storybook/tree/HEAD/addons/knobs) from 6.1.2 to 6.1.4.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.4/addons/knobs)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-24 15:04:59 +01:00
Ben Halpern
575449b890
Include core assets in serviceworker cache (#11559) 2020-11-24 08:58:06 -05:00
dependabot-preview[bot]
e063605600
Bump @storybook/addon-links from 6.0.28 to 6.1.3 (#11573)
Bumps [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/addons/links) from 6.0.28 to 6.1.3.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.3/addons/links)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-24 09:55:29 +01:00
Michael Kohl
2fd724d191
Update empty reading list copy (#11565)
* Change wording

* Add icon

* Update app/javascript/readingList/readingList.jsx

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2020-11-24 09:40:04 +07:00
Nick Taylor
bf7780cd2c
Ran prettier on *.js, *.jsx and *.md files. (#11586) 2020-11-23 20:45:50 -05:00
Joe Doss
44569605d2
Fix container composes w/r/t multistage container builds (#11531)
* Use premade development image.

* Use prebuilt container for podman-compose too!

* Fix bundle bundle_finished path.

* Fix docker-compose to work with the Multistage Containerfile

Add root user for Forem containers, fix bundle_finished path and make
webpacker wait for the bundle to finish.

Switch Redis to redis:6.0.9-alpine

* Remove build steps and fix bundle path.

* Merge dev entrypoint into the main one.

* Use merged entrypoint.sh, remove old entrypoint directives, and fix a dockerize bug.

* Make sure unset BUNDLE_WITHOUT and remove without in bundle config.

* Unset BUNDLE_WITHOUT="development:test" as a global ENV.

Also ensure that we remove the without directives for development and testing.
This will make sure that the right gems are installed for each environment.

Removed some unneeded COPYs and remove a commented out RUN.

* Fix ENTRYPOINT on development and testing containers.

* Fix entrypoint and command on rails container.

* Ignore bundle_finished file.

* Fix REDIS_ env vars and adjust podman-compose file.

* Change bundle_finished path and update Yarn docker-compose command.
2020-11-23 15:15:21 -06:00
Nick Taylor
8c22bbd17b
filterXSS is now set up in testSetup.js (#11579) 2020-11-23 14:08:13 -05:00
dependabot-preview[bot]
bf6a48fe5a
Bump @storybook/addon-a11y from 6.0.27 to 6.1.3 (#11571)
Bumps [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/addons/a11y) from 6.0.27 to 6.1.3.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.3/addons/a11y)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 12:35:29 -05:00
Ben Halpern
7aca8ac337
Add comment about canonical url (#11574) 2020-11-23 11:35:30 -05:00
dependabot-preview[bot]
f860ca8e14
Bump @storybook/addon-storysource from 6.0.28 to 6.1.2 (#11547)
Bumps [@storybook/addon-storysource](https://github.com/storybookjs/storybook/tree/HEAD/addons/storysource) from 6.0.28 to 6.1.2.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.2/addons/storysource)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 17:09:52 +01:00
dependabot-preview[bot]
5bef72ad3d
Bump @storybook/addon-knobs from 6.0.28 to 6.1.2 (#11543)
Bumps [@storybook/addon-knobs](https://github.com/storybookjs/storybook/tree/HEAD/addons/knobs) from 6.0.28 to 6.1.2.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.2/addons/knobs)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:50:40 -05:00
dependabot-preview[bot]
306105b6d9
Bump @storybook/addon-storyshots from 6.0.28 to 6.1.2 (#11549)
Bumps [@storybook/addon-storyshots](https://github.com/storybookjs/storybook/tree/HEAD/addons/storyshots/storyshots-core) from 6.0.28 to 6.1.2.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.2/addons/storyshots/storyshots-core)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:50:15 -05:00
Molly Struve
abbc29dafe
Bug Fix:User >= when filtering by SiteConfig.home_feed_minimum_score (#11567) 2020-11-23 09:13:03 -06:00
dependabot-preview[bot]
392d3ef5c6
Bump elasticsearch from 7.9.0 to 7.10.0 (#11554)
* Bump elasticsearch from 7.9.0 to 7.10.0

Bumps [elasticsearch](https://github.com/elastic/elasticsearch-ruby) from 7.9.0 to 7.10.0.
- [Release notes](https://github.com/elastic/elasticsearch-ruby/releases)
- [Changelog](https://github.com/elastic/elasticsearch-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/elastic/elasticsearch-ruby/compare/v7.9.0...v7.10.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump elasticsearch from 7.9.0 to 7.10.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 09:46:47 -05:00
Michael Kohl
894b1b94c7
Remove UnreadNotificationsEmailer (#11561) 2020-11-23 14:15:07 +00:00
dependabot-preview[bot]
fc1e7442ee
Bump feedjira from 3.1.1 to 3.1.2 (#11552)
* Bump feedjira from 3.1.1 to 3.1.2

Bumps [feedjira](https://github.com/feedjira/feedjira) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/feedjira/feedjira/releases)
- [Changelog](https://github.com/feedjira/feedjira/blob/master/CHANGELOG.md)
- [Commits](https://github.com/feedjira/feedjira/compare/v3.1.1...v3.1.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump feedjira from 3.1.1 to 3.1.2 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 07:45:35 -06:00
dependabot-preview[bot]
cc4a17992a
Bump devise_invitable from 2.0.2 to 2.0.3 (#11553)
* Bump devise_invitable from 2.0.2 to 2.0.3

Bumps [devise_invitable](https://github.com/scambra/devise_invitable) from 2.0.2 to 2.0.3.
- [Release notes](https://github.com/scambra/devise_invitable/releases)
- [Changelog](https://github.com/scambra/devise_invitable/blob/master/CHANGELOG.md)
- [Commits](https://github.com/scambra/devise_invitable/compare/v2.0.2...v2.0.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump devise_invitable from 2.0.2 to 2.0.3 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 13:57:36 +01:00
dependabot-preview[bot]
be8828e72c
Bump ddtrace from 0.42.0 to 0.43.0 (#11538)
* Bump ddtrace from 0.42.0 to 0.43.0

Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb) from 0.42.0 to 0.43.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases)
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md)
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.42.0...v0.43.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump ddtrace from 0.42.0 to 0.43.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 13:17:34 +01:00
Rafi
f88bf5a0b1
Fixing overflow of comment button (#11562) 2020-11-23 12:17:30 +01:00
dependabot-preview[bot]
04aefdf06c
Bump blazer from 2.2.8 to 2.3.0 (#11548)
* Bump blazer from 2.2.8 to 2.3.0

Bumps [blazer](https://github.com/ankane/blazer) from 2.2.8 to 2.3.0.
- [Release notes](https://github.com/ankane/blazer/releases)
- [Changelog](https://github.com/ankane/blazer/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ankane/blazer/compare/v2.2.8...v2.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump blazer from 2.2.8 to 2.3.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 12:16:10 +01:00
dependabot-preview[bot]
9ba251fccb
Bump @babel/plugin-transform-react-jsx from 7.12.5 to 7.12.7 (#11537)
Bumps [@babel/plugin-transform-react-jsx](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-react-jsx) from 7.12.5 to 7.12.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.12.7/packages/babel-plugin-transform-react-jsx)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 05:59:49 -05:00
dependabot-preview[bot]
6f8511466e
Bump rubocop-performance from 1.8.1 to 1.9.0 (#11546)
* Bump rubocop-performance from 1.8.1 to 1.9.0

Bumps [rubocop-performance](https://github.com/rubocop-hq/rubocop-performance) from 1.8.1 to 1.9.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-performance/compare/v1.8.1...v1.9.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump rubocop-performance from 1.8.1 to 1.9.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:31:37 +01:00
dependabot-preview[bot]
fc744eea1e
Bump knapsack_pro from 2.8.0 to 2.9.0 (#11544)
* Bump knapsack_pro from 2.8.0 to 2.9.0

Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/KnapsackPro/knapsack_pro-ruby/releases)
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v2.8.0...v2.9.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump knapsack_pro from 2.8.0 to 2.9.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:16:12 +01:00
Oskar Janusz
39daa21add
Update Copy for Orgs Call-to-action Box (#11534) 2020-11-23 10:15:34 +01:00
dependabot-preview[bot]
f1b00f2376
Bump counter_culture from 2.6.2 to 2.7.0 (#11541)
* Bump counter_culture from 2.6.2 to 2.7.0

Bumps [counter_culture](https://github.com/magnusvk/counter_culture) from 2.6.2 to 2.7.0.
- [Release notes](https://github.com/magnusvk/counter_culture/releases)
- [Changelog](https://github.com/magnusvk/counter_culture/blob/master/CHANGELOG.md)
- [Commits](https://github.com/magnusvk/counter_culture/compare/v2.6.2...v2.7.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump counter_culture from 2.6.2 to 2.7.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:05:27 +01:00
dependabot-preview[bot]
9fe452fdb5
Bump prettier from 2.1.2 to 2.2.0 (#11545)
Bumps [prettier](https://github.com/prettier/prettier) from 2.1.2 to 2.2.0.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prettier/prettier/compare/2.1.2...2.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:04:23 +01:00
dependabot-preview[bot]
8cceb1aaec
Bump eslint from 7.11.0 to 7.14.0 (#11542)
Bumps [eslint](https://github.com/eslint/eslint) from 7.11.0 to 7.14.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v7.11.0...v7.14.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:02:06 +01:00
dependabot-preview[bot]
54bf07a13e
Bump @babel/core from 7.12.3 to 7.12.7 (#11551)
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.12.3 to 7.12.7.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.12.7/packages/babel-core)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 10:01:45 +01:00
dependabot-preview[bot]
93baca9e64
Bump twilio-ruby from 5.42.0 to 5.43.0 (#11550)
* Bump twilio-ruby from 5.42.0 to 5.43.0

Bumps [twilio-ruby](https://github.com/twilio/twilio-ruby) from 5.42.0 to 5.43.0.
- [Release notes](https://github.com/twilio/twilio-ruby/releases)
- [Changelog](https://github.com/twilio/twilio-ruby/blob/main/CHANGES.md)
- [Commits](https://github.com/twilio/twilio-ruby/compare/5.42.0...5.43.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump twilio-ruby from 5.42.0 to 5.43.0 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 09:56:05 +01:00
dependabot-preview[bot]
c26221b025
Bump redis from 4.2.2 to 4.2.5 (#11555)
* Bump redis from 4.2.2 to 4.2.5

Bumps [redis](https://github.com/redis/redis-rb) from 4.2.2 to 4.2.5.
- [Release notes](https://github.com/redis/redis-rb/releases)
- [Changelog](https://github.com/redis/redis-rb/blob/master/CHANGELOG.md)
- [Commits](https://github.com/redis/redis-rb/compare/v4.2.2...v4.2.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Bump redis from 4.2.2 to 4.2.5 (Update vendor/cache)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-23 09:51:44 +01:00
Joe Doss
d7144ce787
Fix bundle issues and a few other things. (#11528)
* Fix bundle issues with the Multistage container
and adjusts a few other things:

- Disable ruby docs on bundler gem install
- Fix the bundle config
- chmod +x on scripts/build_containers.sh

* Add app/assets back into the builder image.

* Looks like running:

yarn install --frozen-lockfile \
&& RAILS_ENV=test NODE_ENV=test bundle exec rails webpacker:compile'

is super busted.

https://buildkite.com/forem/build-containers/builds/48#97451356-6552-40a1-8333-ac6fc0fccc3a

so let's just comment that out for now.
2020-11-21 17:25:09 -06:00
Mac Siri
f061b90316
Suppress Postcss warnings & Re-enable Benhalpern deploy (#11521) 2020-11-20 11:27:49 -05:00
Marcy Sutton
b9ae58816f
Accessibility: initial onboarding fixes (#11408)
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2020-11-20 11:13:39 -05:00
Molly Struve
e454772128
Update trusted role email Subject (#11519) 2020-11-20 09:54:21 -06:00
rhymes
2205f38261
Temporarily disable deploy to BenHalpern server (#11520) 2020-11-20 10:31:32 -05:00
Mac Siri
07287fa2bb
Replace podcast bar helpers with image_tag (#11502) 2020-11-20 09:45:56 -05:00
rhymes
90c12aa824
Attempt at disabling postcss-next warnings (#11518) 2020-11-20 14:19:32 +01:00
Michael Kohl
cd94fb2362
Update README (#11491)
* Update README

* Fix commit activity shield

* 🤦
2020-11-20 09:48:17 +07:00
Molly Struve
a07070e8bc
Update copy and links in Mod Sidebar (#11507) 2020-11-19 19:15:04 -06:00
Pat Hannon
151a2f53a6
Adds phannon as a Core contributor. (#11510) 2020-11-19 16:31:08 -06:00
Andy Zhao
827c9aa77c
Fix Facebook Login profile image download failure (#11478)
* Send a new request and use link in response for profile img

* Use fallback option and make method private

* Refactor and use constant template string

* Stub image_url method for tests

* Fix tests and mock response object properly

* Fix tests and mock response object properly

* Stub response for tests

* Refactor a bit and move into helper method

* Undo everything I did. today I will watch facebook burn.

* Use more foolproof string to gsub
2020-11-19 16:18:09 -05:00
Joe Doss
cd0647c757
Removes this dupe container block since we are going to run this pipeline (#11506)
on master branch pushes only in Buildkite specifically.
2020-11-19 15:05:49 -06:00
Molly Struve
cd0b90c67b
Update Trusted User Email Copy (#11505) 2020-11-19 14:54:06 -06:00
Joe Doss
b485ef2eb9
Jdoss/more buildkite container fixes (#11503)
* Fix bug on creating the testing container for PRs and create a function to
run docker image prune -f that will get run when the script exits cleanly or
uncleanly. This prevent junk containers from building up over time.

* Add in some labels and keys. Add in building containers on master branch.

* Let's also build on main branch for when we eventually move away from master.

* Let's use a previous builder image as a cache as it might speed things up.
2020-11-19 13:34:20 -06:00
Ben Halpern
4ecb7121e8
Fix menu dropdown disable issue (#11498)
* Fix menu dropdown disable issue

* Initial base work

* Remove wrongfully-included files
2020-11-19 13:55:29 -05:00
Joe Doss
3e2876da2c
I guess you can't use env vars for username and server. (#11499) 2020-11-19 12:14:30 -06:00
Joe Doss
1d4685219d
Multistage container builds (#11468)
* WIP multi-stage container build.

* Move to a multistage build process in the Containerfile.

* Enable testing container

* Finalize the multistage build script and Containerfile. Ooof!

I got blocked for a bit with this bugger:

Step 27/32 : COPY --from=builder --chown=${APP_USER}:${APP_USER} ${APP_HOME} ${APP_HOME}
failed to copy files: failed to copy directory: Error processing tar file(exit status 1): Container ID 100999 cannot be mapped to a host ID

but https://github.com/phusion/passenger-docker/issues/235#issuecomment-636318827

was a good shove in the right direction!

* Fix bugs on container build script.

* Adjust compose files to use multistage builds.

* Add in Buildkite pipeline for building containers.

* Update CODEOWNERS to claim ownership over things that Systems Eng cares about
2020-11-19 10:03:35 -06:00
Ben Halpern
c837834d6a
Remove under-used growth tab (#11495) 2020-11-19 10:53:36 -05:00