Commit graph

9028 commits

Author SHA1 Message Date
Nick Taylor
c48e31731d
[15 min fix] Fixed broken share button on article page. (#13688) 2021-05-07 06:33:30 -04:00
Siddharth
5462e0a1f9
Update badge CSS (#13659) 2021-05-07 10:47:25 +02:00
arunkc
47908d7a87
Update format specifiers in readable_publish_date (#13660)
* Update format specifiers in readable_publish_date

* Trigger Travis manually

* Update format specifiers in readable_publish_date

* Update format specifiers in readable_publish_date

Co-authored-by: rhymes <rhymes@hey.com>
2021-05-07 08:51:49 +02:00
rhymes
cf9f6094cd
Have specs run without Redis and refactor ConsumerApp and Device (#13647)
* Add fakeredis gem

* Mock Pusher::PushNotifications in specs

* Remove Redis from Travis

* Add Android tests to ConsumerApp specs

* Use mock for push notification tests and refactor ConsumerApp and Device code

* Fix remaining broken specs

* Use symbols

* Cleanup rpush helpers

* Pusher::PushNotifications is no more

* Use human friendly platform in Admin::ConsumerApps index page
2021-05-07 08:03:16 +02:00
rhymes
de488f331d
Remove inline comments and variable substitution from .env_sample (#13685)
* Remove inline comments from .env_sample

* Remove variable substitution as it's not supported by Foreman
2021-05-06 18:01:52 +02:00
Daniel Uber
8678cd5ae4
Fixes error in seeded navigation link svg icon (#13683)
I was seeing during testing this console error:

"Error: <path> attribute d: Expected path command, "…0-4 2 2 0 000 4z\\".

Removing the \" and leaving just " seems like it corrected that (the
error stops showing, the icon is unchanged since the prior path was
drawn before the error raised).
2021-05-06 10:37:52 -05:00
Daniel Uber
d7f9a18199
Clarify article link copy title (#13682)
Incorporating aitchiss's suggestion from https://github.com/forem/forem/pull/13668/
2021-05-06 09:04:14 -05:00
dependabot[bot]
b4373405f5
Bump rubocop from 1.13.0 to 1.14.0 (#13678)
* Bump rubocop from 1.13.0 to 1.14.0

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.13.0 to 1.14.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop/compare/v1.13.0...v1.14.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Enable Bundler/GemVersion

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rhymes <me@rhymes.dev>
2021-05-06 08:32:42 -05:00
Thomas Bnt
7ad3aeb7ac
Edited the title on id="article-copy-link-input" (#13668) 2021-05-06 08:19:58 -05:00
Ridhwana
449723d8c7
[15-min-fix] Remove/Update the last of the admin hardcoded paths (#13681)
* chore: hardcoded paths

* hardcoded docs path

* Update docs/admin/admin-search.md

Co-authored-by: rhymes <github@rhymes.dev>

Co-authored-by: rhymes <github@rhymes.dev>
2021-05-06 15:12:06 +02:00
Andrew Bone
2a05955092
🐛 Fix new comment dropdown issue (#13661) 2021-05-06 09:06:30 -04:00
dependabot[bot]
c5ca92e289
Bump rubocop-performance from 1.11.2 to 1.11.3 (#13677)
Bumps [rubocop-performance](https://github.com/rubocop/rubocop-performance) from 1.11.2 to 1.11.3.
- [Release notes](https://github.com/rubocop/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-performance/compare/v1.11.2...v1.11.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-06 14:41:30 +02:00
dependabot[bot]
62282868f9
Bump rubocop-rails from 2.10.0 to 2.10.1 (#13676)
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.10.0 to 2.10.1.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.10.0...v2.10.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-06 14:40:56 +02:00
Nick Taylor
d59b8ba0ee
[15-min-fix] Set opacity-0 CSS utility class to 0.00001 for ChromeVox (#13666)
* Set opacity-0 CSS utility class to 0.00001 for ChromeVox.

* Update app/assets/stylesheets/config/_generator.scss

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Added a SASS variable as it's being used in #13435.

* Revert "Added a SASS variable as it's being used in #13435."

This reverts commit ec1eaa17387b8e050ca6dae73b083823bc44f6e9.

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2021-05-06 07:57:22 -04:00
Andrew Bone
38214380dd
Fix a bug with moderator dropdowns and add aria tags (#13623) 2021-05-06 07:56:28 -04:00
Nick Taylor
058c70e9c3
[15 min fix] Fixed app code that was causing flaky E2E test (#13674)
* Fixed app code that was causing flaky E2E test.

* Added a comment about adding the click to the comments container.
2021-05-06 11:30:26 +01:00
Michael Kohl
4b62bb75d4
[15 minute fix] Add data_updates:status rake task (#13653)
* Add data_updates:status rake task

* Disable AR logging
2021-05-06 10:06:32 +07:00
Vaidehi Joshi
94d529e5e4
Bump Rails to 6.1.3.2 (#13675)
Addresses multiple security vulnerabilities and unblocks failing Travis builds.

Please see https://weblog.rubyonrails.org/2021/5/5/Rails-versions-6-1-3-2-6-0-3-7-5-2-4-6-and-5-2-6-have-been-released for more info!
2021-05-05 15:58:33 -07:00
dependabot[bot]
9066de9b65
Bump rubocop-rails from 2.9.1 to 2.10.0 (#13655)
* Bump rubocop-rails from 2.9.1 to 2.10.0

Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.9.1 to 2.10.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.9.1...v2.10.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Add new cops and fix violations

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rhymes <rhymes@hey.com>
2021-05-05 14:16:44 -07:00
Mac Siri
cf538f83c8
Fix invalid form during Creator onboarding. (#13673) 2021-05-05 16:14:48 -04:00
Daniel Uber
d145149de7
Clear the cached settings before testing the rate limiter (#13669)
* Override the Settings::RateLimit.follow_count_daily

An interaction was occurring when the data update script test to move
these settings was run prior to the rate limit test - where the rate
limiter was created with the value 23 for the follow count, but the
settings module was reporting 500.

Stub out the database setting to an explicit value - and allow the
user follow count to be one more (so that we trigger the rate limit
and respond with a 429).

* Clear the settings cache before reading the values

This appears to correct the modification made (and reverted?) in the
data update test without requiring more changes to the context (which
remains as it was).
2021-05-05 14:34:22 -05:00
Nick Taylor
1754f43589
Disabled flaky E2E comment test. (#13671) 2021-05-05 14:10:25 -05:00
Andy Zhao
ebbbcee41a
[15-min-fix] Remove badge slug field b/c auto-gen by title (#13649)
* Make explicit that badge slug is auto generated

* Remove slug from new form

* Remove unused disabled form field

* Remove link and Crayonsify form

* Add badge's path
2021-05-05 13:49:43 -04:00
Ridhwana
27eda9ca3d
chore: uncomment the test (#13658) 2021-05-05 19:00:15 +02:00
Jamie Gaskins
a2da070ca4
Handle GitHub "Repository access blocked" error (#13648)
* Handle GitHub "Repository access blocked" error

We've been seeing a lot of these errors on DEV, and it's a pretty
reasonable expectation that if we're being blocked from seeing them
using the user's OAuth access token that this isn't temporary.

* Re-raise so we don't swallow this error

* Constant name != company name???!?!?!
2021-05-05 12:48:46 -04:00
Andy Zhao
9970b1c2d5
Auto generate profile image for email signups (#13635)
* Add required tooltips and asterisks to fields

* Generate profile image for email signups

* Use be over eq

Co-authored-by: Michael Kohl <citizen428@dev.to>

* Use path helpers over hard-coded paths

Co-authored-by: Michael Kohl <citizen428@dev.to>

* Add labels to make it more accessible

* Stub it all... eek

* stub some more stuff

* stub stub stub

* Move aria label to proper label and fix tests

Co-authored-by: Michael Kohl <citizen428@dev.to>
2021-05-05 12:08:24 -04:00
dependabot[bot]
d1bc35d0d2
Bump rubocop-performance from 1.11.1 to 1.11.2 (#13654)
Bumps [rubocop-performance](https://github.com/rubocop/rubocop-performance) from 1.11.1 to 1.11.2.
- [Release notes](https://github.com/rubocop/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-performance/compare/v1.11.1...v1.11.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-05 16:53:04 +02:00
dependabot[bot]
1b21d90a90
Bump bootsnap from 1.7.4 to 1.7.5 (#13656)
Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.7.4 to 1.7.5.
- [Release notes](https://github.com/Shopify/bootsnap/releases)
- [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.7.4...v1.7.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-05 16:51:22 +02:00
Fernando Valverde
121603a44b
Replace Pusher Beams with Rpush PN delivery ✂️ ✂️ (#13588)
* Remove feature flag

* Remove Pusher Beams implementation

* Remove Pusher Beams require from initializer

* Adds consumer apps to sidebar + consider :admin_restructure

* Fix routes + PN target URL

* Remove old file that sneaked in

* Adds docs

* docs tweaks

* Apply suggestions from code review

Co-authored-by: rhymes <rhymes@hey.com>

Co-authored-by: rhymes <rhymes@hey.com>
2021-05-05 08:37:20 -06:00
Ridhwana
355d510f88
refactor: inline the ERB template instead of passing via a data-path (#13657) 2021-05-05 16:00:39 +02:00
Alex
a0ddb6a848
Cleanup search classes and serializers (#13645) 2021-05-05 09:20:59 -04:00
Rafi
41cc771839
Refactoring help component (and fragmenting it too) (#10895)
* Refactoring Help component

* Fixing typo

* Adding missing prop types

* Removing setCommonProps

* Moving show to parent component

* Renaming Format component

* Converting help component to functional component

* Removing html from state

* Fixing modal toggle and eslint errors

* Adding arria hidden

* Using optional chaining

* Fixing variable names

* Renaming state variable

* Adding jsdoc

Co-authored-by: Nick Taylor <nick@dev.to>
2021-05-05 12:58:40 +07:00
Jacob Herrington
e8df3b0915
Add safe navigation operator to stop 500 errors (#13646) 2021-05-04 11:37:37 -04:00
dependabot[bot]
fc88db1f67
Bump stackprof from 0.2.16 to 0.2.17 (#13643)
Bumps [stackprof](https://github.com/tmm1/stackprof) from 0.2.16 to 0.2.17.
- [Release notes](https://github.com/tmm1/stackprof/releases)
- [Changelog](https://github.com/tmm1/stackprof/blob/master/CHANGELOG.md)
- [Commits](https://github.com/tmm1/stackprof/compare/v0.2.16...v0.2.17)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-04 16:09:19 +02:00
Jamie Gaskins
956ddefbbd
Add M1 architecture to Gemfile.lock (#13636) 2021-05-04 10:00:26 -04:00
Alex
675b5fc5b6
Cleanup unused DataUpdateScripts (#13640) 2021-05-04 09:19:24 -04:00
Suzanne Aitchison
ad43dbe0b3
Add prefer object destructuring lint rule (#13183)
* add prefer object destructuring lint rule

* fix typo

* sweep up lint errors missed in config controller

* Revert "fix typo"

This reverts commit 44f9d57e3f0dc4007ab9020c8c659c2f770230c2.

* Revert "sweep up lint errors missed in config controller"

This reverts commit 3f8d5d782fe110607c2172b713c74c08c883eda3.

* make this a warning rather than error for now

* undo auto change
2021-05-04 12:10:32 +01:00
Michael Kohl
aee05b4597
Retain registration form data on failed submission (#13614)
* Retain registration form data on failed submission

* Remove unnecessary command

* Apply suggestions from code review

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

* Fix e2e test

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-05-04 10:52:20 +07:00
Jacob Herrington
198f778b32
Rename profile header partial (#13639)
This partial is not actually rendered on the user profile, it is only
used by organizations. Moving it to the directory where other
organization-specific partials live!
2021-05-03 18:36:24 -05:00
dependabot[bot]
0e5c680cf8
Bump @babel/core from 7.13.16 to 7.14.0 (#13634)
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.13.16 to 7.14.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.14.0/packages/babel-core)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-03 14:53:56 -07:00
Nick Taylor
eb9fdce52a
Disable Cypress's video feature (#13638)
Co-authored-by: Mac Siri <krairit.siri@gmail.com>
2021-05-03 17:43:19 -04:00
dependabot[bot]
17f2dd187a
Bump @testing-library/user-event from 13.1.5 to 13.1.8 (#13629)
Bumps [@testing-library/user-event](https://github.com/testing-library/user-event) from 13.1.5 to 13.1.8.
- [Release notes](https://github.com/testing-library/user-event/releases)
- [Changelog](https://github.com/testing-library/user-event/blob/master/CHANGELOG.md)
- [Commits](https://github.com/testing-library/user-event/compare/v13.1.5...v13.1.8)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-03 14:23:32 -07:00
Daniel Uber
73529e71eb
Specify body and title of listings that shouldn't match a term (#13633)
Noticed the Faker book title included "No Country for Old Men" which
caused a failure expecting search for "old" to be empty (you can set
the title in the let block to replicate this).

Choose title and body that do not include "old" in order to prevent
false failures.
2021-05-03 15:47:12 -05:00
Mac Siri
25f6b3e9ed
Convert SMTP configs into environments vars (#13542)
Co-authored-by: rhymes <rhymes@hey.com>
2021-05-03 16:32:15 -04:00
Daniel Uber
4225819ae0
Fixes flaky spec (#13637)
When we call Hash.dup the values pointed to by the keys are not
duplicated (the hash is, but the keys and values are the same).

Because the FeatureFlag enabled path is mutating the values, this is
interacting during tests.

`deep_dup` the ITEMS hash before mutating when the either of the two
menu item feature flags are enabled.
2021-05-03 15:06:18 -05:00
dependabot[bot]
e96fad2c14
Bump core-js from 3.11.0 to 3.11.2 (#13625) 2021-05-03 15:29:14 -04:00
Suzanne Aitchison
ef70d1f92b
fix accessible names of sign up options (#13620) 2021-05-03 11:06:45 -07:00
dependabot[bot]
bd7c8b2f12
Bump ibm-openapi-validator from 0.43.0 to 0.44.0 (#13626)
Bumps [ibm-openapi-validator](https://github.com/IBM/openapi-validator) from 0.43.0 to 0.44.0.
- [Release notes](https://github.com/IBM/openapi-validator/releases)
- [Changelog](https://github.com/IBM/openapi-validator/blob/main/CHANGELOG.md)
- [Commits](https://github.com/IBM/openapi-validator/compare/v0.43.0...v0.44.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-03 11:05:54 -07:00
dependabot[bot]
66caddc2e9
Bump @babel/preset-env from 7.13.15 to 7.14.0 (#13618)
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.13.15 to 7.14.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.14.0/packages/babel-preset-env)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-03 11:05:42 -07:00
dependabot[bot]
5752e878ed
Bump sass from 1.32.11 to 1.32.12 (#13615)
Bumps [sass](https://github.com/sass/dart-sass) from 1.32.11 to 1.32.12.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/dart-sass/compare/1.32.11...1.32.12)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-03 11:05:30 -07:00