Commit graph

775 commits

Author SHA1 Message Date
Andy Zhao
bfcc40779a Remove some unnecessary CSS (#1263) 2018-12-05 10:39:21 -05:00
Rozie
37fc82c409 change save button background (#1261) 2018-12-05 09:56:20 -05:00
Martin Riedel
9fb2cd8d16 Add infosec.exchange to mastodon whitelist. (#1262)
* Add infosec.exchange to mastodon whitelist.

* fix codeclimate error

alignment was off;
tab instead of spaces has been used;
2018-12-05 09:55:02 -05:00
Tim Krueger
f016ee3b7f Add two German instances (#1260)
'ruhr.social' and 'chaos.social' are two mastodon instances hosted in Germany.
2018-12-05 09:11:14 -05:00
Ben Halpern
6b96201265
[WIP] Allow mods to remove tags and send user notification (#1252)
* Initial tag adjustments

* Finalize tag adjustments and tag adjustments controller

* Fix schema.rb

* Finalize tag removal logic

* Adjust edge cases/tests for tag adjustment moderation

* Adjust tag adjustments spec
2018-12-04 16:45:32 -05:00
Andrew Bone
aefec87214 Shrink bookmark icon for smaller devices (#1237)
Make the bookmark icon just slightly larger than the font size
2018-12-04 15:30:52 -05:00
Mario See
c5e9f010d4 /connect channel members profile pic fix (#1255)
* update channelDetails, its test, and snapshots

* spacing

* spacing

* spacing

* label spacing

* label spacing

* label spacing

* snapshot update

* refactor implementation

* spacing fix

* styling and small changes

channelDetails
- added small profile image to channel users
- moved "Recently Active Members" below the channel description and above the channel users

Styling
- mostly in relation to channelDetails
- Leave Channel area styled similar to deleting account (lots of red)
- created connect folder in stylesheets where _channel-detials.scss is located
- chat.scss imports _channel-details.scss

* spacing

* update testing and snapshots

* fixed functionality, tests and styling

* leave button update

* show message for empty group

* limit users in channel and show message for empty group

* remove extra period

* change limit from 12 to 11

* show members header

* hide members h3

* increase channel details user limit, increase user object profile pic index

* remove return

* add members header

* Revert "add members header"

This reverts commit 200c6a7f83e3a958cf4199ee295e6a3809249abe.

* limit to 25
2018-12-04 15:00:49 -05:00
Michael Kohl
ffd24f791e Add Mastodon URL to profile (#1137) 2018-12-04 13:24:53 -05:00
Richard Kichenama
7d79b29b6c Night/Dark mode (#1104)
*  implement night theme through css filters

* 🐛 and video

* ♻️ simplify selector
2018-12-04 13:23:25 -05:00
Ty Hopp
39fc832801 Adjust gist embed styles for readability on mobile browsers (#1251)
* Adjust gist embed styles for readability on mobile browsers

* Remove gist embed css from articles.scss

* Add gist embed css to correct gist tag scss file
2018-12-04 08:53:24 -05:00
Brett Stevenson
57f2e40379 Modify user settings notification styling (#994) 2018-12-03 19:38:22 -05:00
Mario See
8b05f6b45b connect channel details (#1247)
* update channelDetails, its test, and snapshots

* spacing

* spacing

* spacing

* label spacing

* label spacing

* label spacing

* snapshot update

* refactor implementation

* spacing fix

* styling and small changes

channelDetails
- added small profile image to channel users
- moved "Recently Active Members" below the channel description and above the channel users

Styling
- mostly in relation to channelDetails
- Leave Channel area styled similar to deleting account (lots of red)
- created connect folder in stylesheets where _channel-detials.scss is located
- chat.scss imports _channel-details.scss

* spacing

* update testing and snapshots

* fixed functionality, tests and styling

* leave button update

* show message for empty group

* limit users in channel and show message for empty group

* remove extra period

* change limit from 12 to 11

* show members header

* hide members h3
2018-12-03 19:29:38 -05:00
Mario See
1ba9c98c5a connect channel invites (#1201)
* update channelDetails, its test, and snapshots

* spacing

* spacing

* spacing

* label spacing

* label spacing

* label spacing

* snapshot update

* refactor implementation

* spacing fix

* styling and small changes

channelDetails
- added small profile image to channel users
- moved "Recently Active Members" below the channel description and above the channel users

Styling
- mostly in relation to channelDetails
- Leave Channel area styled similar to deleting account (lots of red)
- created connect folder in stylesheets where _channel-detials.scss is located
- chat.scss imports _channel-details.scss

* spacing

* update testing and snapshots

* fixed functionality, tests and styling

* leave button update
2018-12-03 13:05:29 -05:00
Andy Zhao
92cea23fcd Fix a few notification bugs (#1232)
* Remove notifications synchronously on unpublish and destroy

* Asynchronously remove reaction notifications for article

* Remove all associated notifications when destroyed

* Fix edge case for reaction notifications

* Load new comment_box file instead of old one

* Delete legacy views

* Remove unused private declaration

* Use casecmp.zero? instead of downcase for speed, and use @user

* Add friendly error message for notifications

* Use delete all and not destroy b/c no callbacks
2018-12-03 12:35:35 -05:00
Ben Halpern
f400b42e38
Add anti-follow language (#1233) 2018-11-30 18:08:51 -05:00
Ben Halpern
651ab3ce35
Add point weights for tag follows (#1229)
* Add point weights for tag follows

* Adjust num articles to initially show up on home page

* Fix schema.rb

* Adjust follow policy spec

* Adjust dashboard styling for follow points form
2018-11-30 15:36:58 -05:00
Ben Halpern
b51042f035
Fix readinglist issue (#1231) 2018-11-30 15:36:20 -05:00
Andrew Bone
f13d9e01a8 Move menu background down 8 pixels (#1227)
Fix for issues #1160 and #1213
2018-11-30 15:26:10 -05:00
Jess Lee
b7dd7d5ce0 update coc for clarity (#1224) 2018-11-30 14:23:22 -05:00
Andy Zhao
32ed3ced11 Fix raw tag (#1215)
* Fix raw tag

* Remove constant first to prevent warning
2018-11-29 15:18:24 -05:00
Jason Yu
3af90f1d0e remove punctuations in header anchor links (#1219)
* remove punctuations in header anchor links

* remove punctuations first

* added test case for punctuation headings
2018-11-29 15:16:09 -05:00
Ben Halpern
011e267769
Update mentor matching page (#1218)
* Update mentor matching page

* Update mentorship relationship spec
2018-11-28 19:02:47 -05:00
Andy Zhao
74e63e2aa4 Add Support Chrome and other browsers for anchor jumps (#1217)
* Support Chrome and other browsers

* Make title div always above article body

* Only show margin when figcaption is used below markdown
2018-11-28 18:37:03 -05:00
Ben Halpern
6f7e5b875f
Check if article.path in resave articles (#1216) 2018-11-28 15:53:29 -05:00
Mike Chen
7ce311834f Fix errant scroll behavior on /new when using keyboard scrolling (#1203)
Disable textarea resize and window scroll method when doing anything
that does not actually modify the textarea contents (e.g. arrow keys,
pgup/pgdn).

Fixes #1109
2018-11-28 14:57:21 -05:00
Francisco Delgado
2d4d469e86 Refactor/onboarding (#1083)
* Refactor Onboarding

- use ternary for simple if-else cases (to reduce lines of code)
- remove unecessary trailing else clause
- destructure state variables
- add a consistent return eg null when nothing is rendered
- use prevState callback when new state depends on previous state
- use switch case when toggling onboarding screens, constants easier to read imo.

* Add rest of refactor

* Remove destructure to meet 25 line minumum from codeclimate.

* Remove duplicate calls to indexOf.

* Remove duplicate calls to indexOf in handleSaveArticle.

* Refactor handleCheckUser

* Update snapshot

* Address PR review comments.

* Revert "Update snapshot"

This reverts commit e17e915286fb621ffca745b28193b7ba63dbc498.

* Update snapshot

* Add back if clause

* Update refactor
2018-11-28 10:21:26 -05:00
Christine Yen
cff6b5d589 Add Honeycomb gem and initial instrumentation (#695)
* Add basic Honeycomb initializers

* Add some basic instrumentation, capture basic IDs

* Correctly alphabetize Gemfile, embed env in dataset names

* Actually reorder Gemfile because I can read

* Add custom tracing instrumentation to RssReader

* Improve timing/tracing info in RssReader

* Even make sure Errors show up in trace if possible

* Make sure we capture this as Rails traffic

* Swap in dev/test Libhoney::Clients as appropriate

* Move context-snagging bits into lib/instrumentation.rb

* Merging Gemfile lines seems to be my Achilles heel
2018-11-28 10:08:27 -05:00
Maksim Litvinov
f2f889af77 Replace long string with array and join (#795) 2018-11-28 09:20:13 -05:00
Ben Halpern
1672098388
Removing clear notifications attempt (#1209)
* Removing clear notifications dealy

* Fix user_id issue
2018-11-27 18:29:50 -05:00
Ben Halpern
db6232adf3
Add initial ios push notifications to server (#1207)
* Add initial push notification logic for iOS

* Adjust notification form css

* Clean up schema.rb

* Add mark-all-as-read functionality for ios notifications

* Update app/models/notification.rb

Fix `find` to `find_by`

Co-Authored-By: benhalpern <bendhalpern@gmail.com>
2018-11-27 17:40:43 -05:00
Ben Halpern
759d7540a7
Add guard to stop negative notifications (#1200) 2018-11-26 12:34:38 -05:00
Phil Nash
0df793a6fe Adds rel='me' to profile links. (#1183)
rel='me' is used on hyperlinks from one page about a person to other pages about that same person. (http://microformats.org/wiki/rel-me)

rel='me' is supported on other social sites, such as Twitter and GitHub. Thought it might have a place here on DEV too.
2018-11-26 10:53:18 -05:00
Anna Buyanova
c1eb30e02a Make less sql queries when loading comments (#1197) 2018-11-26 10:51:38 -05:00
Ben Halpern
73b1616bb5
Fix notification pagination reaction issue (#1181) 2018-11-22 12:48:54 -05:00
Ben Halpern
031a3bd751
Fix parsing error in header tags. (#1180)
* Strip HTML from anchor link in header names

* Skip one test which is not passing for unknown reasons
2018-11-22 12:48:46 -05:00
Ben Halpern
3b94e1d1a6
Quick notifications fix (#1179) 2018-11-22 11:40:05 -05:00
Ben Halpern
eccee11106
Initial basic paginionation-ish for notifications (#1175) 2018-11-21 20:03:56 -05:00
Jess Lee
e36cf51a9e Refine Banish User (#1168)
* add banish user test

* refactor banish user wip

* banish user wip - bust comment cache synchronously

* add more spec scenarios

* Update Banish#strip_user_profile

* Refactor specs
2018-11-21 16:55:26 -05:00
Ben Halpern
b34ee48c1f
Fix hanging /connect notification issue (#1174)
* Adjust channel opened check to mitigate race conditions maybe

* Add fix to jump user straight to apporpriate unopened channel
2018-11-21 12:08:09 -05:00
rhymes
915e2d77b6 Export articles/posts (#576)
* Add EditorConfig file for all editors

* Add article export service

* Add setting to request an export of all articles

* On the outside they are called posts

* Add articles exported email to mailer and service

* Refactor to one public method and test flags

* Trigger the export if it was requested and send the email

* Recreated migration file with generic export fields

* Rename fields and switch to a whitelist

* Refactor ArticleExportService into a more generic structure

* Rename articles_exported_email to export_email

* Fix notify mailer spec

* Rename Exporter::Exporter to Exporter::Service

* Remove commented out line

* Removed body_html, coordinates and updated_at from export

* Invert DJ config

* Update spec
2018-11-21 11:13:36 -05:00
Ben Halpern
86c60307d2
Small notification update (#1169)
* Small notification update

* Rescue errors in notifications
2018-11-20 20:03:55 -05:00
Gabriel Lebec
1e2749be24 feat(markdown): add ids to headers (#713)
* feat(markdown): add anchors for headers

* Fix markdown anchors impl and spec

* Fixes tests for markdown anchors

* Use name for anchors instead of IDs

* Fix approval file

* Remove emojis in links and hyphenate only spaces
2018-11-20 18:17:07 -05:00
Ben Halpern
5ee5c931fc
Fix small details in notification results and add filtering (#1166)
* Fix small details in notification results and add filtering

* Adjust filter styling

* Fix filtering

* Add reaction render to comments
2018-11-20 18:00:11 -05:00
Ben Halpern
0e76bdcd33
Fix typo (#1165) 2018-11-20 15:27:08 -05:00
Ben Halpern
115e52c748
Move follow and reaction aggregation into Notification model to avoid… (#1164)
* Move follow and reaction aggregation into Notification model to avoid re-compute

* Ugh. Fixing schema

* Update tests

* Skip some tests in notifications_spec
2018-11-20 15:00:21 -05:00
Móricz Gergő
79860ee1fa Added series front matter variable to the editor guide, (#1152) 2018-11-20 08:58:03 -05:00
Ben Halpern
b2d46fed65
Lessen amount of notifications queried slightly to improve performance (#1159)
* Lessen amount of notifications queried slightly to improve performance

* Guard for last_user_reaction
2018-11-19 20:36:35 -05:00
Andy Zhao
044de6a8b5 Make reads controller async and sanitize notification titles (#1158) 2018-11-19 19:33:00 -05:00
Andy Zhao
a1010201f2 Notifications part 2 (#1156)
* Remove stream and add new notification views

* Actually remove Stream

* Move followers query to async method

* Remove unused tests and fix query

* Try using without delay instead

* Add without delay and escape HTML

* Make all tests pending for now
2018-11-19 18:14:24 -05:00
Andy Zhao
2db2dd1e5a WIP Refactor/notifications (#1131)
* Add new columns to notifications table

* Remove stream from notifications and add new methods

* Turn off moderation comment notifications

* Add notifiable_type index to migration

* Stop creation of Stream-based notification model instances

* Add notification model create hooks

* Add badge achievement notification creation hook

* Fix some specs

* Add missing @ symbol

* Fix for tests and rename a few things

* forgot to uncomment code sigh
2018-11-19 16:09:02 -05:00