maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix errant scroll behavior on /new when using keyboard scrolling (#1203)

Browse source 
Disable textarea resize and window scroll method when doing anything
that does not actually modify the textarea contents (e.g. arrow keys,
pgup/pgdn).

Fixes #1109
This commit is contained in:
Mike Chen 2018-11-28 11:57:21 -08:00 • committed by Ben Halpern
parent 2d4d469e86
commit 7ce311834f
1 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
app/assets/javascripts/initializers/initEditorResize.js
View file

@ -3,8 +3,12 @@
* It is a slightly modified version of the solution found here.
* stackoverflow.com/questions/18262729/ how-to-stop-window-jumping-when-typing-in-autoresizing-textarea
*/
// eslint-disable-next-line no-unused-vars
function initEditorResize() {
var observe, scrollLeft, scrollTop;
var observe;
var scrollLeft;
var scrollTop;
var lastText;
var textarea = document.getElementById('article_body_markdown');
var oldEditor = document.getElementById('markdown-editor-main');
@ -39,15 +43,26 @@ function initEditorResize() {
}
function resize() {
var len;
var newText = textarea.value;
// Don't resize or scroll if not modifying the text
if (newText === lastText) {
return;
}
lastText = newText;
textarea.style.height = 'auto';
textarea.style.height = textarea.scrollHeight - 29 + 'px';
window.scrollTo(scrollLeft, scrollTop);
if (oldEditor) {
return;
}
var len = textarea.value.length;
len = textarea.value.length;
// If character entered is at the end of the textarea (therefore cursor)
if((textarea.selectionEnd > (len - 15)) && len > 400 && document.activeElement === textarea ) {
if (
textarea.selectionEnd > len - 15 &&
len > 400 &&
document.activeElement === textarea
) {
window.scrollTo(scrollLeft, 10000);
} else {
window.scrollTo(scrollLeft, scrollTop);