Commit graph

74 commits

Author SHA1 Message Date
Ben Halpern
0c910baae1
Move file-level imports to dynamic imports to reduce initial bundle size (#1379) 2018-12-20 12:58:20 -05:00
Ashwin Vaswani
fbdd80d5fc Add headings to header tags (#1003)
* updating all headers to have h* tags, or changing elements

* Remove commented out binding.pry

* Remove unused page

* Use article instead of div for consistency

* Update snapshot with new section tag

* Use h4 tags again for new views
2018-12-19 16:47:44 -05:00
Mario See
60d38ef787 /connect rerender chat (#1359)
* check element render before scrollingto bottom

* check element render before scrollingto bottom

* remove console logs

* remove accidental quote
2018-12-18 17:13:13 -05:00
Mario See
394580b8c8 connect highlight messages (#1311)
* move setstate into cases where activecontent actually changes

* remove unnecessary setstate lines

* rearrange triggerActiveContent
2018-12-12 12:42:42 -05:00
Mario See
b29a155edd Fix lint (#1282) 2018-12-07 14:54:00 -05:00
Mario See
c5e9f010d4 /connect channel members profile pic fix (#1255)
* update channelDetails, its test, and snapshots

* spacing

* spacing

* spacing

* label spacing

* label spacing

* label spacing

* snapshot update

* refactor implementation

* spacing fix

* styling and small changes

channelDetails
- added small profile image to channel users
- moved "Recently Active Members" below the channel description and above the channel users

Styling
- mostly in relation to channelDetails
- Leave Channel area styled similar to deleting account (lots of red)
- created connect folder in stylesheets where _channel-detials.scss is located
- chat.scss imports _channel-details.scss

* spacing

* update testing and snapshots

* fixed functionality, tests and styling

* leave button update

* show message for empty group

* limit users in channel and show message for empty group

* remove extra period

* change limit from 12 to 11

* show members header

* hide members h3

* increase channel details user limit, increase user object profile pic index

* remove return

* add members header

* Revert "add members header"

This reverts commit 200c6a7f83e3a958cf4199ee295e6a3809249abe.

* limit to 25
2018-12-04 15:00:49 -05:00
Mario See
8b05f6b45b connect channel details (#1247)
* update channelDetails, its test, and snapshots

* spacing

* spacing

* spacing

* label spacing

* label spacing

* label spacing

* snapshot update

* refactor implementation

* spacing fix

* styling and small changes

channelDetails
- added small profile image to channel users
- moved "Recently Active Members" below the channel description and above the channel users

Styling
- mostly in relation to channelDetails
- Leave Channel area styled similar to deleting account (lots of red)
- created connect folder in stylesheets where _channel-detials.scss is located
- chat.scss imports _channel-details.scss

* spacing

* update testing and snapshots

* fixed functionality, tests and styling

* leave button update

* show message for empty group

* limit users in channel and show message for empty group

* remove extra period

* change limit from 12 to 11

* show members header

* hide members h3
2018-12-03 19:29:38 -05:00
Mario See
1ba9c98c5a connect channel invites (#1201)
* update channelDetails, its test, and snapshots

* spacing

* spacing

* spacing

* label spacing

* label spacing

* label spacing

* snapshot update

* refactor implementation

* spacing fix

* styling and small changes

channelDetails
- added small profile image to channel users
- moved "Recently Active Members" below the channel description and above the channel users

Styling
- mostly in relation to channelDetails
- Leave Channel area styled similar to deleting account (lots of red)
- created connect folder in stylesheets where _channel-detials.scss is located
- chat.scss imports _channel-details.scss

* spacing

* update testing and snapshots

* fixed functionality, tests and styling

* leave button update
2018-12-03 13:05:29 -05:00
Mario See
faf1c6719b more testing for connect components (#1046)
* adding more tests

- covers article.jsx and elements created from its props and state
- added png as static file that needs stubbing

* video + channelDetails test coverage

* chat + channels tests

* channels cc refactor

* yarn install

* update snapshot and string spacing

* chat.jsx test

mostly tests rendering elements
- does not test imported components, as those are already tested separately
- does not imported functions from actions or utils as those will be tested separately as well

* cleaning up

- mocked response with flush promises for state/component to reflect appropriate changes

* snapshot updates
2018-11-19 15:07:54 -05:00
Mac Siri
4ab0a070ea
Improve Onboarding's spec & Update snapshots (#1111) [ci skip] 2018-11-14 16:18:02 -05:00
Mario See
b5446e18f3 Add tests for Dev Connect (#988) 2018-10-30 13:42:04 -04:00
Ben Halpern
221c363af0
Reduce queries in typical stories#show response + small fixes (#903)
* Reduce queries in typical stories#show response + small fixes

* Change const to git in non-es6 code
2018-10-13 19:38:38 -04:00
Ben Halpern
2545b8d77f
Modify styling and classes for iOS safari /connect (#701) 2018-09-19 18:25:36 -04:00
Nick Taylor
24621b03f2 Restructure pack files part I (#377)
* Renamed pack file from chat.jsx to Chat.jsx.

* refactor

* Missed a js pack where chat.js -> Chat.jsx

* 👷Refactor

* 👷Refactor

* 👷Refactor

* 👷Refactor

* Tests

* Fixed some wording in a test description.
2018-08-29 12:59:20 -04:00
Ben Halpern
95908ddde1
Fix /live styling issues (#519) 2018-08-28 11:50:25 -04:00
Ben Halpern
05789f6ef6
Add client-side /connect maxlength and add badge setting on model only (#660) 2018-08-06 10:45:01 -04:00
Andy Zhao
1dd95b636b Fix old typo (#655) 2018-08-03 10:17:12 -04:00
Ben Halpern
57d1bc48d5
Fix navigation issue in connect and allow leaving channels (#635)
* Fix navigation issue in connect and allow leaving channels

* Fix chat channel memberships request spec
2018-07-30 18:40:30 -04:00
Ben Halpern
e2dbd7cfcc
Remove beta label on /connect and other small changes (#589)
* Remove beta label on /connect and other small changes

* Add better placeholder for narrow screens

* Adjust comma/bracket placement

* Add description to chat channels
2018-07-16 14:48:38 -04:00
Ben Halpern
5a2c549927
Add reactions to /connect content (#585) 2018-07-13 20:05:47 -04:00
Ben Halpern
e995e081ad
Add rich links to /connect and remove auto sidecar opening (#582) 2018-07-13 16:56:26 -04:00
Ben Halpern
926991f5fc
Fix timezone issues and small adjustment to connect features (#548) 2018-07-05 16:39:04 -04:00
Ben Halpern
fcac6575d1 Merge branch 'master' of github.com:thepracticaldev/dev.to_core 2018-07-03 19:06:39 -04:00
Ben Halpern
eaa13a53fb Update serviceworker notficiations 2018-07-03 19:06:23 -04:00
Ben Halpern
4638768d79
Remove channel member count limit (#545)
* check for dataset content in triggeractive

* Remove channel member count limit
2018-07-03 16:50:53 -04:00
Ben Halpern
53c925a148
check for dataset content in triggeractive (#544) 2018-07-03 15:43:36 -04:00
Ben Halpern
84568cd860
Remove video DM limitation (#543) 2018-07-03 15:04:35 -04:00
Ben Halpern
50bc2f259c
Add max channel members (#542)
* Add max channel members

* Change number

* Remove console.log
2018-07-03 13:54:57 -04:00
Ben Halpern
424be43865
Add chat_channel_membership roles and invite functionality (#541) 2018-07-03 13:16:48 -04:00
Ben Halpern
94e5154668
Add initial invitation framework for chat channels (#528)
* Add initial invitation framework for chat channels

* Update chat_channel specs

* Add DIY concept of accepting invite

* Add some js and fix spec

* Add full invite accept functionality

* Remove console.log from chat
2018-07-02 16:31:20 -04:00
Ben Halpern
799aa16378
Fix /live for workshop (#516) 2018-06-28 14:28:24 -04:00
Ben Halpern
441a1ba8b8
Make channels list scroll to top on change (#514) 2018-06-27 22:30:38 -04:00
Ben Halpern
51ddc2f4fa
Track query across filters (#513) 2018-06-27 22:21:18 -04:00
Ben Halpern
62fc45865c
Add sticky activechannel during filtering (#511) 2018-06-27 21:46:58 -04:00
Ben Halpern
5842b73d6c
Add filters (#510) 2018-06-27 21:25:25 -04:00
Ben Halpern
258a6ea74f
Add filter buttons to /connect (#508) 2018-06-27 21:14:06 -04:00
Ben Halpern
b8d2c0033e
Get /connect pagination working (for real in prod I hope) (#507) 2018-06-27 18:47:06 -04:00
Ben Halpern
aaba866b87
Modify /connect to try to get pagination working in prod (#505) 2018-06-27 17:51:38 -04:00
Ben Halpern
a89433596b
Small /connect adjustment (#504) 2018-06-27 16:24:35 -04:00
Ben Halpern
5194c9828c
Add proper pagination and fix small issues with /connect (#503)
* Add proper pagination and fix small issues with /connect
2018-06-27 16:06:15 -04:00
Yechiel Kalmenson
23ee1004be fix grammar in the chat screen (#457) 2018-06-20 10:23:09 -04:00
Ben Halpern
914102f19f Add basic github support to /connect 2018-06-19 13:46:10 -04:00
Ben Halpern
74d098f580 Fix bugs and add video 2018-06-18 12:53:43 -04:00
Ben Halpern
6e35875f2c Adjust location of timestamps 2018-06-14 18:54:40 -04:00
Ben Halpern
51ba78d015
Fix last opened issue on chat channels (#445) 2018-06-14 15:16:58 -04:00
Ben Halpern
da45270c88
Quick possible fix of undefined issue (#444) 2018-06-14 14:57:00 -04:00
Ben Halpern
1366d315a3
Fix typo and modify channels list (#442) 2018-06-14 13:31:17 -04:00
Ben Halpern
115ed2e7f7
Make code work more properly and bind pusher states (#440) 2018-06-14 12:50:50 -04:00
Ben Halpern
e124decabc
Adjust messages_controller to send message before it is persisted if it is valid (#434) 2018-06-13 17:35:17 -04:00
Ben Halpern
a9bb3b0dee
Make sidebar style adjustments (#433) 2018-06-13 17:21:40 -04:00