Commit graph

1402 commits

Author SHA1 Message Date
Ben Halpern
be7fb2cdf0
Fix linting (#1694) 2019-01-30 16:01:23 -05:00
rhymes
f90815fc91 Activate eslint-plugin-jsx-a11y (#1688) 2019-01-30 15:15:25 -05:00
Greg Brimble
2eeb63ef21 Frontend Profile fields match backend maxlength (#1691) 2019-01-30 15:11:34 -05:00
Ben Halpern
d7665fcc3f
Add comment template to post (#1692)
* add myself to the core contributors

* add comment template

* merge upstream

* make sure the template re-appears for top level comments after submission

* make interface admin only

* Adjust comment template form

* Fix merge conflicts

* Remove unnecessary comment template from json
2019-01-30 13:32:34 -05:00
Mac Siri
2b779d15c6 Fix inconsistent specs (#1674)
* Force test colors in Travis

* Fix inconsistent analytic spec

* Fix local inconsistent specs

* Remove JS

*  Remove JS from spec
2019-01-30 11:50:42 -05:00
Andy Zhao
21859700c2 Rename notification arguments (#1684)
* Add a comment about notifiable

* Rename argument from notifiable to comment

* Use badge_achievement as argument

* Use reaction instead of notifiable

* Use mention instead of notifiable

* Add a comment for context

* Use tag adjustment instead of notifiable
2019-01-30 11:47:49 -05:00
Ben Halpern
58c8c6a4b1
Modify cache key for article-sticky-nav-articles (#1683) 2019-01-29 15:19:04 -05:00
Jess Lee
d5b8454738 stop using active record method on a non-active record object (#1676) 2019-01-29 15:02:02 -05:00
Jess Lee
f50247f089 Fix conditional so super admins can ban older spammers (#1651)
* allow superadmins to band old spammers

* enhance flash notification and show all new users

* fix confirm dialog
2019-01-29 15:01:04 -05:00
Ben Halpern
7c7c39149c
Modify cache keys for well-trafficked views. (#1681)
* Add cache to sidebar sticky to make it stick longer

* Add last_article_at and last_comment_at

* Clean up schema.rb
2019-01-29 13:27:22 -05:00
Ben Halpern
043a21494c
Modify sidebar cache (#1675) 2019-01-29 11:52:44 -05:00
Andy Zhao
f5f206e40e Render codespans properly in markdown (#1678)
* Explain test properly

* Add tests for codespan parsing

* Add codespan parsing logic
2019-01-29 11:52:18 -05:00
Anna Buianova
4073b869d6 Add erb_lint (#1657) [ci skip] 2019-01-29 11:47:32 -05:00
Juan Manuel Ramallo
49c9b5bc87 [Emojis in Markdown] (#1653)
- Adds the ability to add emojis using colons 😂 🎉
- The emoji conversion is added to the markdown parser labor
- When no emoji is found with the alias, same text is returned
- No assets added (no emoji images), so this will only be supported when the browser supports emojis (https://blog.getemoji.com/post/57054354336/which-browsers-support-emoji)
- Emoji conversion logic is out of markdown parser labor
- Adds its own spec
2019-01-28 16:28:59 -05:00
Ben Halpern
ea63374408
Add below-article html variant (#1669)
* Add below-article html variant

* Fix tests for variant number

* Fix stories show tests for html_variants
2019-01-28 14:31:43 -05:00
Ben Halpern
1cdbfe3af1
Remove hardcoded values in streak reward (#1671) 2019-01-28 14:14:45 -05:00
Ben Halpern
561882d9d5
Add writing streak badge rewarding algorithm (#1670)
* Add 4 week streak badge rewarding algorithm

* Modify badge message

* Fix typo
2019-01-28 13:46:00 -05:00
dependabot[bot]
55e0c02581 Bump codemirror from 5.42.2 to 5.43.0 (#1664) [ci skip]
Bumps [codemirror](https://github.com/codemirror/CodeMirror) from 5.42.2 to 5.43.0.
- [Release notes](https://github.com/codemirror/CodeMirror/releases)
- [Changelog](https://github.com/codemirror/CodeMirror/blob/master/CHANGELOG.md)
- [Commits](https://github.com/codemirror/CodeMirror/compare/5.42.2...5.43.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-01-28 13:29:45 -05:00
dependabot[bot]
94de21db3d Bump eslint-plugin-import from 2.14.0 to 2.15.0 (#1661) [ci skip]
Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.14.0 to 2.15.0.
- [Release notes](https://github.com/benmosher/eslint-plugin-import/releases)
- [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md)
- [Commits](https://github.com/benmosher/eslint-plugin-import/compare/v2.14.0...v2.15.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-01-28 13:20:58 -05:00
dependabot[bot]
3664af6280 Bump eslint-plugin-jsx-a11y from 6.1.2 to 6.2.0 (#1662) [ci skip]
Bumps [eslint-plugin-jsx-a11y](https://github.com/evcohen/eslint-plugin-jsx-a11y) from 6.1.2 to 6.2.0.
- [Release notes](https://github.com/evcohen/eslint-plugin-jsx-a11y/releases)
- [Changelog](https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/CHANGELOG.md)
- [Commits](https://github.com/evcohen/eslint-plugin-jsx-a11y/compare/v6.1.2...v6.2.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-01-28 12:45:53 -05:00
dependabot[bot]
668fb9ae9a Bump sitemap_generator from 6.0.1 to 6.0.2 (#1658) [ci skip]
Bumps [sitemap_generator](https://github.com/kjvarga/sitemap_generator) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/kjvarga/sitemap_generator/releases)
- [Changelog](https://github.com/kjvarga/sitemap_generator/blob/master/CHANGES.md)
- [Commits](https://github.com/kjvarga/sitemap_generator/compare/v6.0.1...v6.0.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-01-28 12:33:19 -05:00
dependabot[bot]
1087e4f847 Bump web-console from 3.5.1 to 3.7.0 (#1659) [ci skip]
Bumps [web-console](https://github.com/rails/web-console) from 3.5.1 to 3.7.0.
- [Release notes](https://github.com/rails/web-console/releases)
- [Changelog](https://github.com/rails/web-console/blob/master/CHANGELOG.markdown)
- [Commits](https://github.com/rails/web-console/compare/v3.5.1...v3.7.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-01-28 12:25:16 -05:00
dependabot[bot]
8c93e93b35 Bump prettier from 1.16.0 to 1.16.1 (#1665) [ci skip]
Bumps [prettier](https://github.com/prettier/prettier) from 1.16.0 to 1.16.1.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prettier/prettier/compare/1.16.0...1.16.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-01-28 12:24:06 -05:00
dependabot[bot]
7936755cb6 Bump eslint-config-prettier from 3.6.0 to 4.0.0 (#1666) [ci skip]
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 3.6.0 to 4.0.0.
- [Release notes](https://github.com/prettier/eslint-config-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/prettier/eslint-config-prettier/compare/v3.6.0...v4.0.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-01-28 12:23:31 -05:00
dependabot[bot]
9fb592c3b7 Bump jsdom from 13.1.0 to 13.2.0 (#1667) [ci skip]
Bumps [jsdom](https://github.com/jsdom/jsdom) from 13.1.0 to 13.2.0.
- [Release notes](https://github.com/jsdom/jsdom/releases)
- [Changelog](https://github.com/jsdom/jsdom/blob/master/Changelog.md)
- [Commits](https://github.com/jsdom/jsdom/compare/13.1.0...13.2.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-01-28 12:21:35 -05:00
dependabot[bot]
823d0ac8e6 Bump libhoney from 1.10.1 to 1.11.0 (#1660)
Bumps [libhoney](https://github.com/honeycombio/libhoney-rb) from 1.10.1 to 1.11.0.
- [Release notes](https://github.com/honeycombio/libhoney-rb/releases)
- [Commits](https://github.com/honeycombio/libhoney-rb/compare/v1.10.1...v1.11.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-01-28 10:09:39 -05:00
Mario See
1404f0da5e adjust width calculations (#1652) 2019-01-26 13:08:32 -05:00
Andrew Bone
613d3d49c3 Coding style consistency (stackblitz liquid tag) (#1649)
* Style consistancy

Make style more consistent with other liquid tags

* Style consistency

Make style more consistent with other liquid tags

* Style consistency

Make style more consistent with other liquid tags

* rubocop compliance

* rubocop compliance
2019-01-25 12:03:01 -05:00
Andrew Bone
5f5beabcab Make initializeUserSidebar shorter (#1640)
Make initializeUserSidebar() shorter to meet codeclimate requirements.
2019-01-24 18:42:19 -05:00
Ben Halpern
049a7b7b73
Fix article taken redirect issue (#1645) 2019-01-24 18:16:35 -05:00
Ben Halpern
5b77b779a3
Comment muting tweaks (#1646) 2019-01-24 18:16:13 -05:00
Andy Zhao
c4677071a7 Mute notifications for a comment thread (#1636)
* Use idempotent update instead of toggle

* Update editor guide with new comment instructions

* Render the settings button on page load

* Add settings button to comment dropdown

* Update styles to properly render

* Add comment mute function and settings page

* Clean up erb spacing

* Remove unneccessary user_id param

* Add receive_notifications for policy spec

* Update name for accuracy

* Add request spec for comments_mute

* Remove unused permitted attributes

* Add actually used permitted attributes
2019-01-24 17:20:38 -05:00
Jess Lee
9d72091f42 add mailchimp unsub when deleting or banishing user (#1644) 2019-01-24 16:14:10 -05:00
Ben Halpern
a0d90874a9
Move org admin privilege check into controller (#1642) 2019-01-24 13:35:39 -05:00
Ben Halpern
ea2eead9e3
Remove unnecessary save from follows controller (#1638) 2019-01-23 17:58:05 -05:00
Ben Halpern
2e667d0810
Lower number of comments showing on first page of article show (#1637) 2019-01-23 17:57:51 -05:00
Jess Lee
0eb5402926 Delete User Functionality (#1615)
* add full delete route and update banisher

* add user deletion spec

* enhance styling

* remove availability if banned from mentorship

* add specs

* do not show banned mentors

* delete addiional associations

* include more associations for deletion

* simplify activity deletion wtih delete_all
2019-01-23 16:57:32 -05:00
Vinicius Stock
ec2ce5d6e6 Upgrade rubocop and fix offenses (#1635) 2019-01-23 16:12:03 -05:00
Ben Halpern
ae44cc4865
Modify org admin logic for changing article author (#1634)
* Adjust org user_id change logic

* Fix test
2019-01-23 16:10:31 -05:00
Andy Zhao
2ac05b4c9b Use safe navigation for edge cases (#1632) 2019-01-23 15:31:15 -05:00
Jess Lee
d0b17f2a77 Adds internal/articles input to update author (#1628)
* adds input to change article author

* remove link

* remove unnecessary attribute
2019-01-23 11:58:11 -05:00
Mario See
0a1454dc97 quick css hiccup fix (#1523)
* remove max-width cap on .home

* remove max-width cap on .home

* Revert "Merge branch 'master' into article-css-extra-wide"

This reverts commit 3eff6e456e11f5fc74e30d25d6e01c237c3b0d83, reversing
changes made to 5e064676029f9ce630b5580e46b9d64c6f43e838.

* revert max-width and add max-width to article-show

based on andrew bone's suggestion. looks good thus far both on home and article page in various screen sizes

* Removed a modified file from pull request

* Removed a modified file from pull request

* Removed a modified file from pull request

* Removed a modified file from pull request

* Removed a modified file from pull request

* Update article-show.scss
2019-01-22 16:23:15 -05:00
Michał Krzysztof Feiler
73b909a1fd Add "101010.pl" to Mastodon list (#1612) 2019-01-22 15:37:56 -05:00
Mac Siri
338ad0a6b5 Enable require_dependency for Liquid tags in prod (#1613) 2019-01-22 14:57:17 -05:00
Ben Halpern
ff405c0e90
Add occasional random fetches to article page_views_count (#1625) 2019-01-22 14:39:34 -05:00
Andy Zhao
300291ed70 Use proper formats for env hash variables (#1624)
* Use proper formats for env hash variables

* Use .to_s instead of .name
2019-01-22 14:15:50 -05:00
Andy Zhao
9f6d00118f Mute notifications for your own article (#1594)
* Use a slightly faster call for user_id

* Remove unused file

* Test receive notifications functionality

* Notify when receive_notifications is true

* Test receiving reaction notifications

* Do not notify if receive_notifications is false

* Fix test for parent comment notification

* Add article mute notifications feature

* Remove deprecated specs

* Prevent email when receive_notification is false

* Update button messaging

* Use RESTful /article_mutes patch request

* Use parent or root article instead
2019-01-22 13:12:48 -05:00
Ali Spittel
cfd84d73f8 Bug/v2 editor tag typing (#1614)
* Add myself to core contributors

* add myself to the core contributors

* fix to issue 1574 with the V2 editor

* fix tag bug in v2 editor

* fix v2 editor bug

* remove unused code
2019-01-21 18:23:20 -05:00
Andy Zhao
2c2bafa350 Add logging if oauth fails (#1619) 2019-01-21 18:17:36 -05:00
Michał Krzysztof Feiler
5ff204c4ed Add "bsd.network" to Mastodon list (#1611) 2019-01-21 17:39:32 -05:00