maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
8275 commits 1 branch 0 tags 1.6 GiB
Commit graph

8275 commits

This branch
This branch
All branches
Author SHA1 Message Date
Michael Kohl
bdd4bd34aa
Fix infinite redirect loop for articles (#12652) 
* Update logic in handle_possible_redirect

* Rearrange code

* Add spec
 2021-02-17 08:54:54 +07:00
dependabot[bot]
63cf3292f1
Bump front_matter_parser from 0.2.1 to 1.0.0 (#12688) 
* Bump front_matter_parser from 0.2.1 to 1.0.0

Bumps [front_matter_parser](https://github.com/waiting-for-dev/front_matter_parser) from 0.2.1 to 1.0.0.
- [Release notes](https://github.com/waiting-for-dev/front_matter_parser/releases)
- [Changelog](https://github.com/waiting-for-dev/front_matter_parser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/waiting-for-dev/front_matter_parser/commits)

Signed-off-by: dependabot[bot] <support@github.com>

* Trigger Travis CI

* Trigger Travis CI

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rhymes <rhymes@hey.com>
 2021-02-16 14:36:15 -05:00
Julianna Tetreault
71b35f28a0
Remove Roles via Admin (#12582) [deploy] 
* Add the ability to remove a role from a non-super_admin in Admin::UsersController
 - Adds a #destroy action to the Admin::UsersController
 - Adds a destroy route for the action

* Add a removal button to non-super_admin roles on admin user pages
  - Pulls Current Roles out of _activity and into own partial
  - Adds a _current_roles partial to /admin/users/show
  - Adds REMOVE buttons to non-super_admin roles
  - Conditionally renders REMOVE buttons for certain roles only

* Add tests around the removal of roles to users_manage_spec

* Adjust formatting of link_to in _current_roles.html.erb

* Use :aggregate_failures in role-related tests in users_manage_spec.rb

* Refactors Admin::UsersController#destroy and role params

* Update admin/users_spec.rb to take into account _current_roles partial

* Replace REMOVE text with X on role removal buttons

* Add additional elsif to handle single_resource_admin removal
  - Adds resource_type params to Admin::UsersController
  - Adds elsif to handle removal of single_resource_admin roles
  - Adds resource_type to the removal button in _current_roles
  - Adds a spec around removing single_resource_admin roles

* Add .constantize to resource_type in Admin::UsersController

* Move .constantize to resource_type arg rather than params in #destroy

* Use .safe_constantize rather than .constantize for params[:resource_type]

* Remove .safe_constantize from params and onto inline var instead

* Add nil check to removal of :single_resource_admin role in #destroy

* Update users_manage_spec.rb to remove proper role in test

* Add resource_name to current user and super admin _current_roles list

* Add additional test around removing :single_resource_admin role
 2021-02-16 10:50:10 -07:00
Alex
3f02045458
Redirect user to sign up path after deletion (#12696) 2021-02-16 12:15:36 -05:00
Michael Kohl
544030ff2c
Drop language settings columns (#12699) 2021-02-16 23:29:44 +07:00
dependabot[bot]
40e36adbcd
Bump @storybook/addon-knobs from 6.1.17 to 6.1.18 (#12706) 
Bumps [@storybook/addon-knobs](https://github.com/storybookjs/storybook/tree/HEAD/addons/knobs) from 6.1.17 to 6.1.18.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.18/addons/knobs)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-02-16 17:21:43 +01:00
dependabot[bot]
3f1b643c66
Bump @storybook/preact from 6.1.17 to 6.1.18 (#12693) 
* Bump @storybook/preact from 6.1.17 to 6.1.18

Bumps [@storybook/preact](https://github.com/storybookjs/storybook/tree/HEAD/app/preact) from 6.1.17 to 6.1.18.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.18/app/preact)

Signed-off-by: dependabot[bot] <support@github.com>

* Trigger Travis CI

* Trigger Travis CI

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rhymes <rhymes@hey.com>
 2021-02-16 15:58:31 +01:00
ludwiczakpawel
74894fd90e
bugfix (#12703) 2021-02-16 15:50:37 +01:00
dependabot[bot]
fb88d94b39
Bump eslint from 7.19.0 to 7.20.0 (#12691) 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rhymes <rhymes@hey.com>
 2021-02-16 09:34:37 -05:00
dependabot[bot]
d4f4b53131
Bump rubocop from 1.9.1 to 1.10.0 (#12700) 
* Bump rubocop from 1.9.1 to 1.10.0

Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 1.9.1 to 1.10.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v1.9.1...v1.10.0)

Signed-off-by: dependabot[bot] <support@github.com>

* Enable new cops and run rubocop on code base

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rhymes <rhymes@hey.com>
 2021-02-16 09:14:17 -05:00
ludwiczakpawel
3b2480ed0a
CSS size reduce + cleanups. (#12625) 
* tooltips 1.0.1

* tooltips 1.0.1

* fixes and cleanups

* whoops

* aria

* revert
 2021-02-16 13:44:26 +01:00
Michael Kohl
0c3ad5a1b5
Remove language columns (#12685) 2021-02-16 09:30:01 +07:00
dependabot[bot]
824e90ca52
Bump test-prof from 1.0.0 to 1.0.1 (#12687) 2021-02-15 17:59:51 -05:00
Ridhwana
07fcbb6f0e
Parenthesis consistency for add_role and remove_role (#12661) 
* chore: use consistent code styles for the parenthesis around arguments

* Revert "chore: use consistent code styles for the parenthesis around arguments"

This reverts commit 281c899a5cff0480b182fef45b10ef69979166cb.

* chore: add consistent parenthesis
 2021-02-15 20:35:25 +02:00
Molly Struve
4ffd9ca7a5
Refactor:Change Image Article Upload Path to uploads/articles (#12668) 
* Refactor:Change Image Article Upload Path to uploads/articles/

* fix request spec
 2021-02-15 11:52:00 -06:00
Akash Srivastava
8569435b13
Fixed twitter timeline display in comments preview (#12542) 
* Fixed twitter timeline display in comments preview

* Removed shared context for twitter_timeline_tag
 2021-02-15 17:09:18 +01:00
Nick Taylor
c74c9e4331
Move yarn install to after potential bundle check failure in bin/e2e (#12681) 2021-02-15 10:07:45 -05:00
Jacob Herrington
aae592f86c
Add JSDoc comments to Chat components (#12647) 
* Add JSDoc comments to Chat components

* Expand documentation comment on ChannelImage

* Update app/javascript/chat/components/ChannelImage.jsx

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
 2021-02-12 17:21:13 -06:00
ludwiczakpawel
59e24a7a82
hero overflow fix (#12677) 2021-02-12 18:27:05 +01:00
Christina
bcbeb66c98
Update Ruby Section and Add Additional Error (#12669) 
Adding additional information to the Ruby section to help contributors who are not used to Ruby.
Also explicitly stating that the project must be cloned and forked before using rbenv install $(cat .ruby-version)

Also adding a common error Nick and I encountered with a solution.
 2021-02-12 10:45:34 -06:00
dependabot[bot]
a64fffd3b1
Bump twilio-video from 2.11.0 to 2.12.0 (#12660) [deploy] 
Bumps [twilio-video](https://github.com/twilio/twilio-video.js) from 2.11.0 to 2.12.0.
- [Release notes](https://github.com/twilio/twilio-video.js/releases)
- [Changelog](https://github.com/twilio/twilio-video.js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/twilio/twilio-video.js/compare/2.11.0...2.12.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-02-12 08:45:14 -07:00
dependabot[bot]
a2d181fde1
Bump elasticsearch from 7.11.0 to 7.11.1 (#12676) [deploy] 
Bumps [elasticsearch](https://github.com/elastic/elasticsearch-ruby) from 7.11.0 to 7.11.1.
- [Release notes](https://github.com/elastic/elasticsearch-ruby/releases)
- [Changelog](https://github.com/elastic/elasticsearch-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/elastic/elasticsearch-ruby/compare/v7.11.0...v7.11.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-02-12 08:13:51 -07:00
dependabot[bot]
b064c8f5c0
Bump @babel/preset-env from 7.12.13 to 7.12.16 (#12675) 
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.12.13 to 7.12.16.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.12.16/packages/babel-preset-env)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-02-12 12:36:55 +01:00
dependabot[bot]
be371d8520
Bump @babel/core from 7.12.13 to 7.12.16 (#12673) 
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.12.13 to 7.12.16.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.12.16/packages/babel-core)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-02-12 12:36:46 +01:00
dependabot[bot]
c5bfcb46fa
Bump @babel/plugin-transform-react-jsx from 7.12.13 to 7.12.16 (#12672) 2021-02-12 06:08:22 -05:00
Ben Halpern
b61c8b7e6b
Fix edge cases in profile field UI migration (#12665) 
* Fix edge cases in profile field UI migration

* Fix missing statement

* Fix list of attributes
 2021-02-11 17:18:46 -05:00
dependabot[bot]
ef481d07a3
Bump elasticsearch from 7.10.1 to 7.11.0 (#12656) [deploy] 
Bumps [elasticsearch](https://github.com/elastic/elasticsearch-ruby) from 7.10.1 to 7.11.0.
- [Release notes](https://github.com/elastic/elasticsearch-ruby/releases)
- [Changelog](https://github.com/elastic/elasticsearch-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/elastic/elasticsearch-ruby/compare/v7.10.1...v7.11.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-02-11 11:57:56 -07:00
dependabot[bot]
e18a6b68a7
Bump faker from 5.3.1 to 5.4.0 (#12655) [deploy] 
Bumps [faker](https://github.com/Marak/Faker.js) from 5.3.1 to 5.4.0.
- [Release notes](https://github.com/Marak/Faker.js/releases)
- [Changelog](https://github.com/Marak/faker.js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Marak/Faker.js/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-02-11 10:42:20 -07:00
dependabot[bot]
652384a34f
Bump @stoplight/spectral from 5.8.0 to 5.8.1 (#12658) 
Bumps [@stoplight/spectral](https://github.com/stoplightio/spectral) from 5.8.0 to 5.8.1.
- [Release notes](https://github.com/stoplightio/spectral/releases)
- [Changelog](https://github.com/stoplightio/spectral/blob/v5.8.1/CHANGELOG.md)
- [Commits](https://github.com/stoplightio/spectral/compare/v5.8.0...v5.8.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-02-11 17:32:05 +01:00
dependabot[bot]
9745fb86a0
Bump twilio-ruby from 5.46.1 to 5.47.0 (#12659) 
Bumps [twilio-ruby](https://github.com/twilio/twilio-ruby) from 5.46.1 to 5.47.0.
- [Release notes](https://github.com/twilio/twilio-ruby/releases)
- [Changelog](https://github.com/twilio/twilio-ruby/blob/main/CHANGES.md)
- [Commits](https://github.com/twilio/twilio-ruby/compare/5.46.1...5.47.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-02-11 09:29:45 -06:00
dependabot[bot]
a8eef36082
Bump honeybadger from 4.7.2 to 4.7.3 (#12654) [deploy] 
Bumps [honeybadger](https://github.com/honeybadger-io/honeybadger-ruby) from 4.7.2 to 4.7.3.
- [Release notes](https://github.com/honeybadger-io/honeybadger-ruby/releases)
- [Changelog](https://github.com/honeybadger-io/honeybadger-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/honeybadger-io/honeybadger-ruby/compare/v4.7.2...v4.7.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-02-11 08:05:28 -07:00
Ben Halpern
5f92ef7b8f
Fix profile field production display area functionality and remove SiteConfig.dev_to? hacks for better generalization (#12015) 
* Initial work

* Add special exceptions

* Clean up and progress

* Update github url

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

* Add tests and finalize data update script

* Fix test

* Add some tests

* Fix display_area test

* Adjust spec

* Fix svg title

Co-authored-by: Molly Struve <mollylbs@gmail.com>
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
 2021-02-11 10:05:06 -05:00
dependabot[bot]
bb472728d4
Bump sass from 1.32.6 to 1.32.7 (#12639) 
Bumps [sass](https://github.com/sass/dart-sass) from 1.32.6 to 1.32.7.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/dart-sass/compare/1.32.6...1.32.7)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-02-11 15:55:21 +01:00
dependabot[bot]
9a026525a5
Bump @testing-library/user-event from 12.6.3 to 12.7.0 (#12657) 2021-02-11 07:05:34 -05:00
rhymes
456f13aa20
Add feature flags docs (#12646) 
* Fix typo

* Add technical overview on feature flags in docs

* Update docs/technical-overview/feature_flags.md

Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>

* Update docs/technical-overview/feature_flags.md

Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>

* Update docs/technical-overview/feature_flags.md

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

* Update docs/technical-overview/feature_flags.md

Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>

* Incorporate feedback

Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
 2021-02-11 12:46:46 +01:00
Michael Kohl
98ec301a3c
Add guard clause to worker (#12632) 2021-02-11 10:43:48 +07:00
Michael Kohl
0af8fc1866
Prevent suspended users from self-deleting and returning (#12503) 
* Add new table and model

* Store banned user username hash on delete

* Prevent previously banned user from signing up again

* Update method name

* Refactor code and add more specs

* Test improvements

* Don't override existing global flash

* Fix typo

* Update spec description

* Update schema.rb

* More schema.rb fixes

* Simplify spec

* Update migration

* Clean up migration

* Rename method

* Add DataDog counter

* Revisit error handling

* Remove spurious empty line

* Make model name more explicit
 2021-02-11 09:28:59 +07:00
Michael Kohl
82f7b5ea0c
Update to Rails 6.0.3.5 (#12651) 2021-02-11 09:23:33 +07:00
Katie Davis
b30563fa1e
Revert "Bump husky from 4.3.8 to 5.0.9 (#12621)" (#12649) 
This reverts commit 8f636a6db3.
 2021-02-10 16:57:14 -05:00
dependabot[bot]
9d694f16b5
Bump timecop from 0.9.3 to 0.9.4 (#12638) [deploy] 
Bumps [timecop](https://github.com/travisjeffery/timecop) from 0.9.3 to 0.9.4.
- [Release notes](https://github.com/travisjeffery/timecop/releases)
- [Changelog](https://github.com/travisjeffery/timecop/blob/master/History.md)
- [Commits](https://github.com/travisjeffery/timecop/compare/v0.9.3...v0.9.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-02-10 13:16:55 -07:00
dependabot[bot]
8f636a6db3
Bump husky from 4.3.8 to 5.0.9 (#12621) 
* Bump husky from 4.3.8 to 5.0.9

Bumps [husky](https://github.com/typicode/husky) from 4.3.8 to 5.0.9.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](https://github.com/typicode/husky/compare/v4.3.8...v5.0.9)

Signed-off-by: dependabot[bot] <support@github.com>

* migrate

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: katiedavis <katie@forem.com>
 2021-02-10 15:11:46 -05:00
Vaidehi Joshi
e94f2f4e31
Update PR template with communicating changes section (#12603) 
* Update PR template with communicating changes section

* Combine communicating changes with updating docs section

* Add forem core team only tag to communicating changes

* Specify team over teams
 2021-02-10 11:56:56 -08:00
Jacob Herrington
4b9c62e585
Extract ChannelFilterButton from Chat.jsx (#12630) 
* Extract ChannelFilterButton from Chat class
 2021-02-10 11:23:49 -06:00
dependabot[bot]
8558cfe137
Bump derailed_benchmarks from 2.0.0 to 2.0.1 (#12640) [deploy] 
Bumps [derailed_benchmarks](https://github.com/schneems/derailed_benchmarks) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/schneems/derailed_benchmarks/releases)
- [Changelog](https://github.com/schneems/derailed_benchmarks/blob/main/CHANGELOG.md)
- [Commits](https://github.com/schneems/derailed_benchmarks/compare/v2.0.0...v2.0.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-02-10 10:05:21 -07:00
rhymes
740e51fa2b
Remove unused podcast episode related code (#12642) 2021-02-10 17:47:39 +01:00
Rachael Wright-Munn
8301b9f667
The GitHub authentication docs did not include the OAuth url. It has been added and the screenshot updated. (#12598) 2021-02-10 10:47:26 -06:00
dependabot[bot]
00b39a23f5
Bump stripe from 5.29.0 to 5.29.1 (#12636) [deploy] 
Bumps [stripe](https://github.com/stripe/stripe-ruby) from 5.29.0 to 5.29.1.
- [Release notes](https://github.com/stripe/stripe-ruby/releases)
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/stripe/stripe-ruby/compare/v5.29.0...v5.29.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-02-10 09:42:23 -07:00
dependabot[bot]
bae1a58404
Bump faker from 2.15.1 to 2.16.0 (#12637) [deploy] 
Bumps [faker](https://github.com/faker-ruby/faker) from 2.15.1 to 2.16.0.
- [Release notes](https://github.com/faker-ruby/faker/releases)
- [Changelog](https://github.com/faker-ruby/faker/blob/master/CHANGELOG.md)
- [Commits](https://github.com/faker-ruby/faker/compare/v2.15.1...v2.16.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-02-10 09:41:56 -07:00
Ridhwana
a61f88fc16
Adds a feature flag for Data Update Scripts (#12641) 
* feat: add a feature flag for data update scripts

* feat: write some tests for it

* chore: oops

* stub the data update scripts out wherever the profile admin is

* chore: remove some unneeded ones

* refactor: use call_original

* feat: add a feature flag to all the Forems (but not enable it as yet)
 2021-02-10 18:22:27 +02:00
Katie Davis
4e1745ce4a
Revert "fix dropdown-menu not closing on mobile (#12602)" (#12644) 
This reverts commit 063a1d2850.
 2021-02-10 10:56:37 -05:00