Commit graph

4125 commits

Author SHA1 Message Date
dependabot-preview[bot]
bd478fc1eb
Bump strong_migrations from 0.6.1 to 0.6.2 (#6108)
Bumps [strong_migrations](https://github.com/ankane/strong_migrations) from 0.6.1 to 0.6.2.
- [Release notes](https://github.com/ankane/strong_migrations/releases)
- [Changelog](https://github.com/ankane/strong_migrations/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ankane/strong_migrations/compare/v0.6.1...v0.6.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-17 09:43:18 -05:00
dependabot-preview[bot]
4b6cd46bd3
Bump faker from 2.10.1 to 2.10.2 (#6103)
Bumps [faker](https://github.com/faker-ruby/faker) from 2.10.1 to 2.10.2.
- [Release notes](https://github.com/faker-ruby/faker/releases)
- [Changelog](https://github.com/faker-ruby/faker/blob/master/CHANGELOG.md)
- [Commits](https://github.com/faker-ruby/faker/commits/v2.10.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-17 09:42:44 -05:00
dependabot-preview[bot]
3b913f8490
Bump inline_svg from 1.6.0 to 1.7.0 (#6104) 2020-02-17 09:41:40 -05:00
Jacob Herrington
40bc7ecedd
Remove unnecessary eager loading (#6063)
Bullet doesn't seem to like this, and it makes sense because we don't
want to load ALL reactions, just some of them.

Co-authored-by: nspinazz89 <nspinazz89@gmail.com>

Co-authored-by: Nick S <nspinazz89@gmail.com>
2020-02-17 09:39:30 -05:00
rhymes
cc53b55a4a
[deploy] Switch decorators from Draper to Rails builtin decorations (#6040)
* Convert SponsorshipDecorator to Rails decorator

* Remove empty ReactionDecorator

* Rename SponsorshipDecorator#level_color_hex to level_background_color

* Convert CommentDecorator to Rails decorator

* Add specs and fix bugs for NotificationDecorator

* Convert NotificationDecorator to Rails decorator

* Add specs and fix bugs for OrganizationDecorator

* Convert OrganizationDecorator to Rails decorator

* Add specs to PodcastEpisodeDecorator and fix bugs

* Convert PodcastEpisodeDecorator to a Rails decorator

* Add missing specs for ArticleDecorator and fix bugs

* Convert ArticleDecorator to Rails decorator

* Add missing specs to UserDecorator and fix issues

* Convert UserDecorator to Rails decorator

* Add .decorate_collection method

* Add decorator for AR relations and remove Draper

* Rename BaseDecorator back to ApplicationDecorator

* Rename .decorate_ back to .decorate

* Restore decorate_collection (WTH)

* Add decorated?

* Fix bugs and failing specs

* Decoration should always be explicit
2020-02-17 09:32:32 -05:00
dependabot-preview[bot]
361dcff49a
Bump test-prof from 0.10.2 to 0.11.3 (#6105) 2020-02-17 09:23:31 -05:00
dependabot-preview[bot]
31908e84bd
Bump pusher-js from 5.0.3 to 5.1.1 (#6112) 2020-02-17 09:16:35 -05:00
dependabot-preview[bot]
247f4295eb
Bump husky from 4.2.1 to 4.2.3 (#6114) 2020-02-17 09:11:40 -05:00
Michael Kohl
1458b42d18
Add rails data_updates:run to Docker documentation (#6097) 2020-02-17 08:19:40 -05:00
Molly Struve
7ff79f77b8
Search Tags in Elasticsearch from Classified Listing and Post Creation (#6024) [deploy] 2020-02-17 08:16:45 -05:00
Nick Taylor
3a46635c34
Configure husky/lint-staged for *.scss files. (#6089) 2020-02-16 16:55:37 -05:00
Mac Siri
02fc46a3e9
Delete weekly-digest.yml (#6062) 2020-02-14 16:13:52 -05:00
Vaidehi Joshi
76fe99b76a
Add Broadcast seeds + generator service to set up for welcome notifications (#6080)
* Add more Broadcasts to seeds for welcome notification flow

* Remove unnecessary welcoming_user_id from development config

* Add basic service class for generating appropriate broadcast per user

Eventually, this should be called from a rake task that will rely on this service to determine which broadcast, if any, is the appropriate one to send to newly signed-up users, and will enqueue a worker to create/send a welcome notification when appropriate.

* Add a few TODOs, plus some general cleanup

* Add some skipped tests for WelcomeNotification::Generator
2020-02-14 12:30:25 -08:00
Molly Struve
6a277ba10d
remove rake jobs:work references from code (#6082) [deploy] 2020-02-14 15:18:08 -05:00
Michael Kohl
f1aca16a1e
Improve Docker configuration (#6055) 2020-02-14 14:28:27 -05:00
Molly Struve
ef9611d745
Create DataUpdateScript to Index all Tags (#6078) [deploy] 2020-02-14 14:17:52 -05:00
Alex
b81c2e8df3
Remove delayed_job (#6071) [deploy]
* Update adapter to sidekiq

* Remove delayed_jobs routes

* Remove delayd_jobs initializer and references

* Remove delayed_job_spec

* Remove bin/delayed_job

* Remove app/jobs/

* Migration to drop delayed_jobs table

* Remove delayed_job_web & delayed_job_active_record

* Update docs

* Remove reference to delayed_job dashboard

* Remove delayed_job settings from initializers

* Add delayed_job_admin back to reserved words list
2020-02-14 10:00:26 -08:00
Molly Struve
65eba740ab
Document DataUpdateScripts, Add to Deploy Process, Add Development Check (#6068) [deploy] 2020-02-14 11:45:27 -05:00
Alex
2bd2800365
Update queue_adapter to Sidekiq (#6066) [deploy] 2020-02-14 11:07:49 -05:00
Ben Halpern
8837531195
Add additional safeguards for config write access (#6064) [deploy]
* Add additional safeguards for config write access

* Change spec name and confirmation step
2020-02-13 18:39:55 -05:00
Alex
d32dc38bed
Move ClassifiedListing mappings to JSON file (#6061) [deploy] 2020-02-13 14:39:39 -08:00
Molly Struve
7e5a8d59d9
enable bread crumbs for Honeybadger (#6069) 2020-02-13 17:30:36 -05:00
Ridhwana
9da0049fc6
Add the 'approved' attribute to index articles so that we can filter by it later on. (#6032) [deploy]
* feat: add approved as an index or ordered articles and for the algolia search

* oops: added approved to the wrong place, should be on ordered_articles
2020-02-13 15:46:14 -05:00
Michael Kohl
934d0a6cc3
Add placeholder to badge award text area (#6054) 2020-02-13 15:10:38 -05:00
rhymes
59eb367f2c
Fix uniqueness generator when too much data is seeded (#6058) 2020-02-13 12:39:48 -05:00
Alex
4a9e5d2fc9
Remove Reactions::UpdateReactableJob & spec (#6059) [deploy] 2020-02-13 08:59:03 -08:00
Alex
611706f3f2
Remove Reactions::BustReactableCacheJob & spec (#6060) 2020-02-13 08:58:47 -08:00
Jacob Herrington
bc9fc6ee3b
[deploy] Autosize textareas for suggested tweets (#6056) 2020-02-13 11:42:44 -05:00
Molly Struve
9f4dad77da
Move Elasticsearch mappings to config folder as json file (#6051) [deploy] 2020-02-13 11:33:47 -05:00
Molly Struve
0bfbd9bb1f
Set Up Framework For Running Data Update Scripts (#6025) [deploy] 2020-02-13 10:48:23 -05:00
Lucas Hiago
f68bd8bc4f
Change UpdateReactableJob to UpdateReactableWorker and move to sidekiq (#5551) [deploy] 2020-02-13 10:13:11 -05:00
Alex
0f32eb9db0
Add Elasticsearch index for classified_listings (#6031) [deploy] 2020-02-12 18:24:01 -05:00
Vaidehi Joshi
ee5aa1ff1a
Add more paths for team delightful in CODEOWNERS file (#6050) 2020-02-12 14:38:59 -08:00
Vaidehi Joshi
f71c8b16e7
Allow dynamic authoring of welcome notifications (#6045) [deploy]
* Add "Welcome" type to Broadcasts, allow dynamic "authoring" of Broadcasts

This adds a new `type_of` to the Broadcast model: "Welcome". As we begin to create a new "welcome notification" workflow, we'll categorize them by making them all of the same type.

This also adds a concept of a "welcoming user", which can be set via an ENV var. The WELCOMING_USER_ID will allow us to explicitly set (and change) which user in the database is the one that "sends" welcoming notification. In production, we plan for this to be dev.to/sloan.

* Allow WelcomeNotificationWorker to accept + send any kind of broadcast

This abstracts out the logic of deciding which broadcast to send from the woker into the calling method. This will help us send many different kinds of welcome notifications using one, resuable worker class.

* Raise if a Notification can't be created

* Add STAFF_USER_ID as an ENV var

This is in preparation for moving away from SiteConfig.staff_user_id, and replacing it with an ENV var. We will need to set this in production first, and then make a separate PR to replace all instances of staff_user_id with the newly-set ENV var.
2020-02-12 13:50:37 -08:00
Molly Struve
25b1ad4047
Flaky Spec Try 2: Article Decorator properly handles Names (#6048) 2020-02-12 16:32:38 -05:00
Vaidehi Joshi
8a11872472
Add more information about using Elasticsearch to docs (#6046)
It was unclear to me that I explicitly needed Elasticsearch in order for certain tests to run locally. We should specify that in the docs. Also added a note about installing `wget`, which is required to install Elasticsearch in our docs.
2020-02-12 13:23:10 -08:00
Michael Kohl
2a0a89239c
Add health check endpoint for Mailchimp unsubscribe webhook (#6034) [deploy] 2020-02-12 15:55:21 -05:00
rhymes
5037753163
Change error styling from syntax highlighting for a better UI in all themes (#6004) [deploy]
* Remove error styling for a better UI in all themes

* Use text shadow to highlight syntax error
2020-02-12 15:25:00 -05:00
Molly Struve
acfdd11b50
update cluster settings to prevent auto index creation, update destroy to remove ALL indexes (#6042) 2020-02-12 15:21:38 -05:00
Molly Struve
df7b62e2b0
Enforce slashes for file paths with rubocop to ensure it carries over to codeclimate (#6047) 2020-02-12 15:19:52 -05:00
Mac Siri
a31e15f90d
Skips verify_authenticity_token in MailchimpUnsubscribesController (#6038) 2020-02-12 15:18:50 -05:00
Michael Kohl
06d78e3676
Fix API documentation link (#6036) 2020-02-12 15:08:46 -05:00
rhymes
1df24046d8
Small API controllers refactoring (#6021) [deploy]
* TagsController inherits from ApiController
* Let ApiController inherit from ActionController::Base to have its own lifecycle
* Remove unused method
* Use only one respond_to :json for the entire API
* ApiController inherits from ActionController::Base
* Use Pundit only where needed
2020-02-12 11:51:42 -05:00
Lucas Hiago
d0b4ba2648
Change BustReactableCacheJob to BustReactableCacheWorker and move to sidekiq (#5582) [deploy] 2020-02-12 11:50:40 -05:00
Mac Siri
6b481166fe
Add unsubscribe option to badge and connect emails (#6027) 2020-02-12 10:48:51 -05:00
Josh Puetz
38622317b7
Consolidate server side main article feed logic (#5953) [deploy]
* Consolidate `.decorate` calls

* Move Activerecord finders out of main stories feed partial

* Add back in decorates to sticky_articles partial

* Combine top and new articles returned from StoriesController

* Extract feed construction logic to a service

* Some PR tweaks (naming)

* Quick test fix
2020-02-12 08:43:20 -06:00
Michael Kohl
9ea9549e28
Fix spelling of Elastiscsearch in docs (#6033) 2020-02-12 09:28:28 -05:00
Michael Kohl
3f08572306
Update PR template (#5979)
Now questions tests and post-deployment tasks
2020-02-11 18:34:11 -05:00
Nick Taylor
56b7410983
Fix dev shop logos style (#6028) [deploy] 2020-02-11 18:23:45 -05:00
Molly Struve
a39c6a03b0
Remove extra period if name ends with it (#6029) [deploy] 2020-02-11 17:57:02 -05:00