Commit graph

165 commits

Author SHA1 Message Date
Andy Zhao
bb75ee3fc6 WIP Add proper error handling when creating a listing (#2755)
* Add proper error handling when creating a listing

* Remove accidentally committed stylesheet

* Make error text

* Preserve input values if the submission is invalid
2019-05-07 18:25:25 -04:00
Andy Zhao
b33b59ec96 Remove listings' body_markdown's line-breaks (#2742) 2019-05-07 14:54:49 -04:00
Ben Halpern
35fe810b51
Add default tags for listings dropdown and misc other changes (#2719) 2019-05-06 14:52:52 -04:00
Ben Halpern
17cf4133e1
Change number of reactions queried (#2701) 2019-05-05 20:18:32 -04:00
Ben Halpern
1ddef633cc
Improve reading list (#2695)
* Initial readinglist adjustments

* Improve readinglist

* Finalize new reading list

* Fix indexing and final finalizations

* Fix tests

* fix tests
2019-05-05 19:19:30 -04:00
Ben Halpern
9e7dbf8356
Update JS listings form and other tweaks (#2697) 2019-05-05 10:14:07 -04:00
Andy Zhao
e9b4b4b8c8 WIP Add modal for single listings (#2688)
* Add new line at the bottom of the file

* Fix some linter errors

* Add overlay and links to single listings

* Clean up some code

* Add escape key functionality to quit overlay

* Lint some code

* Add modal functionality

* Update styling for modal

* Fix some linter warnings

* Preserve the correct link all the time
2019-05-04 19:39:49 -04:00
Jess Lee
a6d92c702b Add report abuse link to listings (#2684)
* add report abuse link

* add listings category on abuse form

* include listings category
2019-05-04 09:06:42 -04:00
Andy Zhao
5f74ccb01e Make "create listing" button work with InstantClick (#2676)
* Make create listing work with instantclick

* Prevent autocomplete from extensions
2019-05-03 11:33:16 -04:00
Andy Zhao
07796e769a Move new listing form to Preact (#2674)
* Fix typo

* Use preact for new listing form

* Send proper max tag amount in error msg

* Add styles back in for edit page
2019-05-03 10:17:12 -04:00
Jess Lee
5e193fdcd7 Create listings permalink (#2637)
* create listings show route

* add link to listings

* include slug in json

* migrate test environment

* unlink listing title

* fix formatting

* remove slug data from json

* remove auto linting

* fix spacing

* add to algolia index?

* actually add index?

* fix merge conflicts?

* update query
2019-05-02 14:14:40 -04:00
Ben Halpern
bfedee0561
Fix some listing/credit bugs (#2584)
* Fix some listing/credit bugs

* Tack on codepen team link fix

* Fix test

* Actually fix test
2019-04-26 19:01:35 -04:00
Ben Halpern
3f92ac4919
Fix/improve edits for listings (#2555)
* Fix the edit process for listings

* Add category to listing

* Fix issue in listing update
2019-04-25 16:12:50 -04:00
Ben Halpern
78138532c8
Classified Listings (#2545)
* Initial classified listings work

* More work on tags

* Additional work finalizing stripe and getting the listings page along

* Finalize-ish listings 🤞
2019-04-24 16:17:01 -04:00
Nick Taylor
1ca5177044 Disabled no-console for where we currently log an error. (#2502) 2019-04-20 09:20:08 -04:00
Nick Taylor
27ea00e152 Fix some frontend linting issues (#2495) [ci skip] 2019-04-19 10:58:21 -04:00
Ali Spittel
fd20c8e1da Make Cards Change Dynamically and add Reader/Follower Charts (#2488)
* use API data

* Update schema.rb

* work on proCharts

* change to fetch

* remove console log

* add week month infinity dates

* linter tweaks

* change chart labels

* make cards change dynamically as well

* add april 1st disclaimer comment

* add reader and follower charts

* Update schema.rb
2019-04-18 14:59:13 -04:00
Ali Spittel
b374975edd Feature/filtered charts (#2482)
* use API data

* Update schema.rb

* work on proCharts

* change to fetch

* remove console log

* add week month infinity dates

* linter tweaks

* change chart labels
2019-04-18 11:21:25 -04:00
Ben Halpern
583a772d52
Add inbox guidelines to users (#2473) 2019-04-17 15:49:48 -04:00
Mario See
dd78c5eb29 Release Open Inbox (#2468)
* unhide connect and add clearer messages

* update userDetails snapshot
2019-04-17 12:46:12 -04:00
Tim Lange
bf68782374 REF: React eslint (#2432) 2019-04-16 17:28:19 -04:00
Tim Lange
81c28886c8 UX: Several improvements for chat in nightmode (#2430)
* UX: Several improvements for chat in nightmode

* FIX: Some react refactoring

* FIX: Fixed failing react tests
2019-04-14 11:05:58 -04:00
Ben Halpern
5f3fd96960
Modify social share button and functionality (#2316)
* Modify social share button and functionality

* Some nightmode changes tossed in

* Style adjustments and test snapshot fix
2019-04-06 14:49:52 -04:00
Mario See
91968e3860 block/report abuse in dev-connect (#2074)
* block chat method

* block and report buttons

* styling

* more styling

* add id redirect

* remove whitespace

* authorize channel in block_chat method

* remove trailing whitespace

* make variable local

* validate using policy

* check channel direct

* fix comparison in chat_channel model

* fix channel variable
2019-03-26 11:53:30 -04:00
Ali Spittel
ed1906b02e Fix dark theme issues with the pro dashboard (#2178) 2019-03-25 16:02:28 -04:00
rhymes
df2621a8c0 Implement image upload's error handling (#2018) 2019-03-21 12:31:51 -04:00
James Turner
01ee5ab926 Fixed typo on notifications state (#2047) 2019-03-13 15:57:33 -04:00
Andy Zhao
1922a55739 Add initial charts implementation to pro dashboard (#2037)
* Refactor and optimize article ids a bit

* Add chartJS to package.json

* Add new queries for charts

* Add past week charts for rxns and comments

* Use real data oops

* Round followers percent to 2 decimals

Co-Authored-By: Zhao-Andy <andyzhao.zhao@gmail.com>

* Round all percentages to 2 decimals

Co-Authored-By: Zhao-Andy <andyzhao.zhao@gmail.com>
2019-03-12 10:21:12 -07:00
Glenn Carremans
281330fe16 Fix linting issues in app/views/articles (#1848) 2019-02-28 17:23:06 -05:00
Ali Spittel
704b7bce9c Feature/autosave editor (#1633)
* Add myself to core contributors

* add myself to the core contributors

* implement autosave in sessionStorage

* clear sessionstorage on save

* add new changes flag

* add clear  button and css for it

* add clear button functionality

* make clear session storage only run if save is successful

* update jest snapshot for autosave

* add a few tests

* add a few tests

* add test for clear button

* make autosave work for title, tags, and cover image

* remove console.log

* make clear button into a message instead

* move to button with no styling instead of span

* remove warning on refresh

* remove warning on refresh

* move to localstorage so that persists across tabs

* fix blip on change from HTML to JSX

* make confirm work properly

* fix css jump for v2 editor

* fix v2 editor height jump

* remove unused onKeyUp prop

* indent _v2_form.html.erb file

* indent v2 editor erb

* Update package.json with missing package
2019-02-28 07:00:58 -08:00
Ali Spittel
355d97a94d add sanitization to github on chat (#1834)
* add sanitization to github on chat

* formatting
2019-02-20 14:08:46 -04:00
Phil Nash
d8de2b0d14 Use <web-share-wrapper> for article sharing (#1524) 2019-02-11 16:05:52 -05:00
rhymes
f90815fc91 Activate eslint-plugin-jsx-a11y (#1688) 2019-01-30 15:15:25 -05:00
Ben Halpern
d7665fcc3f
Add comment template to post (#1692)
* add myself to the core contributors

* add comment template

* merge upstream

* make sure the template re-appears for top level comments after submission

* make interface admin only

* Adjust comment template form

* Fix merge conflicts

* Remove unnecessary comment template from json
2019-01-30 13:32:34 -05:00
Ali Spittel
cfd84d73f8 Bug/v2 editor tag typing (#1614)
* Add myself to core contributors

* add myself to the core contributors

* fix to issue 1574 with the V2 editor

* fix tag bug in v2 editor

* fix v2 editor bug

* remove unused code
2019-01-21 18:23:20 -05:00
rhymes
7181b37784 Cleanup Image management file (#1390) 2018-12-26 16:19:04 -05:00
Ben Halpern
0c910baae1
Move file-level imports to dynamic imports to reduce initial bundle size (#1379) 2018-12-20 12:58:20 -05:00
Ashwin Vaswani
fbdd80d5fc Add headings to header tags (#1003)
* updating all headers to have h* tags, or changing elements

* Remove commented out binding.pry

* Remove unused page

* Use article instead of div for consistency

* Update snapshot with new section tag

* Use h4 tags again for new views
2018-12-19 16:47:44 -05:00
Mario See
60d38ef787 /connect rerender chat (#1359)
* check element render before scrollingto bottom

* check element render before scrollingto bottom

* remove console logs

* remove accidental quote
2018-12-18 17:13:13 -05:00
Mario See
394580b8c8 connect highlight messages (#1311)
* move setstate into cases where activecontent actually changes

* remove unnecessary setstate lines

* rearrange triggerActiveContent
2018-12-12 12:42:42 -05:00
Mario See
b29a155edd Fix lint (#1282) 2018-12-07 14:54:00 -05:00
Mario See
c5e9f010d4 /connect channel members profile pic fix (#1255)
* update channelDetails, its test, and snapshots

* spacing

* spacing

* spacing

* label spacing

* label spacing

* label spacing

* snapshot update

* refactor implementation

* spacing fix

* styling and small changes

channelDetails
- added small profile image to channel users
- moved "Recently Active Members" below the channel description and above the channel users

Styling
- mostly in relation to channelDetails
- Leave Channel area styled similar to deleting account (lots of red)
- created connect folder in stylesheets where _channel-detials.scss is located
- chat.scss imports _channel-details.scss

* spacing

* update testing and snapshots

* fixed functionality, tests and styling

* leave button update

* show message for empty group

* limit users in channel and show message for empty group

* remove extra period

* change limit from 12 to 11

* show members header

* hide members h3

* increase channel details user limit, increase user object profile pic index

* remove return

* add members header

* Revert "add members header"

This reverts commit 200c6a7f83e3a958cf4199ee295e6a3809249abe.

* limit to 25
2018-12-04 15:00:49 -05:00
Mario See
8b05f6b45b connect channel details (#1247)
* update channelDetails, its test, and snapshots

* spacing

* spacing

* spacing

* label spacing

* label spacing

* label spacing

* snapshot update

* refactor implementation

* spacing fix

* styling and small changes

channelDetails
- added small profile image to channel users
- moved "Recently Active Members" below the channel description and above the channel users

Styling
- mostly in relation to channelDetails
- Leave Channel area styled similar to deleting account (lots of red)
- created connect folder in stylesheets where _channel-detials.scss is located
- chat.scss imports _channel-details.scss

* spacing

* update testing and snapshots

* fixed functionality, tests and styling

* leave button update

* show message for empty group

* limit users in channel and show message for empty group

* remove extra period

* change limit from 12 to 11

* show members header

* hide members h3
2018-12-03 19:29:38 -05:00
Mario See
1ba9c98c5a connect channel invites (#1201)
* update channelDetails, its test, and snapshots

* spacing

* spacing

* spacing

* label spacing

* label spacing

* label spacing

* snapshot update

* refactor implementation

* spacing fix

* styling and small changes

channelDetails
- added small profile image to channel users
- moved "Recently Active Members" below the channel description and above the channel users

Styling
- mostly in relation to channelDetails
- Leave Channel area styled similar to deleting account (lots of red)
- created connect folder in stylesheets where _channel-detials.scss is located
- chat.scss imports _channel-details.scss

* spacing

* update testing and snapshots

* fixed functionality, tests and styling

* leave button update
2018-12-03 13:05:29 -05:00
Francisco Delgado
2d4d469e86 Refactor/onboarding (#1083)
* Refactor Onboarding

- use ternary for simple if-else cases (to reduce lines of code)
- remove unecessary trailing else clause
- destructure state variables
- add a consistent return eg null when nothing is rendered
- use prevState callback when new state depends on previous state
- use switch case when toggling onboarding screens, constants easier to read imo.

* Add rest of refactor

* Remove destructure to meet 25 line minumum from codeclimate.

* Remove duplicate calls to indexOf.

* Remove duplicate calls to indexOf in handleSaveArticle.

* Refactor handleCheckUser

* Update snapshot

* Address PR review comments.

* Revert "Update snapshot"

This reverts commit e17e915286fb621ffca745b28193b7ba63dbc498.

* Update snapshot

* Add back if clause

* Update refactor
2018-11-28 10:21:26 -05:00
Ben Halpern
b34ee48c1f
Fix hanging /connect notification issue (#1174)
* Adjust channel opened check to mitigate race conditions maybe

* Add fix to jump user straight to apporpriate unopened channel
2018-11-21 12:08:09 -05:00
Mario See
faf1c6719b more testing for connect components (#1046)
* adding more tests

- covers article.jsx and elements created from its props and state
- added png as static file that needs stubbing

* video + channelDetails test coverage

* chat + channels tests

* channels cc refactor

* yarn install

* update snapshot and string spacing

* chat.jsx test

mostly tests rendering elements
- does not test imported components, as those are already tested separately
- does not imported functions from actions or utils as those will be tested separately as well

* cleaning up

- mocked response with flush promises for state/component to reflect appropriate changes

* snapshot updates
2018-11-19 15:07:54 -05:00
Mac Siri
4ab0a070ea
Improve Onboarding's spec & Update snapshots (#1111) [ci skip] 2018-11-14 16:18:02 -05:00
Mac Siri
fb231339e5
Addresses similar blocks of lint (#1054) 2018-11-02 14:14:10 -04:00
Ben Halpern
299e6aeb3b
Fix issue where Instantclick navigation fails (#1047) 2018-10-31 16:31:48 -04:00