docbrown/app/javascript
Francisco Delgado 2d4d469e86 Refactor/onboarding (#1083)
* Refactor Onboarding

- use ternary for simple if-else cases (to reduce lines of code)
- remove unecessary trailing else clause
- destructure state variables
- add a consistent return eg null when nothing is rendered
- use prevState callback when new state depends on previous state
- use switch case when toggling onboarding screens, constants easier to read imo.

* Add rest of refactor

* Remove destructure to meet 25 line minumum from codeclimate.

* Remove duplicate calls to indexOf.

* Remove duplicate calls to indexOf in handleSaveArticle.

* Refactor handleCheckUser

* Update snapshot

* Address PR review comments.

* Revert "Update snapshot"

This reverts commit e17e915286fb621ffca745b28193b7ba63dbc498.

* Update snapshot

* Add back if clause

* Update refactor
2018-11-28 10:21:26 -05:00
..
.storybook Nick/task/onboarding article stories (#392) 2018-06-06 10:29:46 -04:00
article-form Add ability for users to publish series (#1034) 2018-10-29 13:04:42 -04:00
chat more testing for connect components (#1046) 2018-11-19 15:07:54 -05:00
githubRepos Improve Onboarding's spec & Update snapshots (#1111) [ci skip] 2018-11-14 16:18:02 -05:00
packs Fix issue where Instantclick navigation fails (#1047) 2018-10-31 16:31:48 -04:00
sidebar-widget Make small style adjustments (#313) 2018-05-14 17:37:08 -04:00
src Refactor/onboarding (#1083) 2018-11-28 10:21:26 -05:00
.eslintrc.js Remove unnecessary code in .eslintrc.js (#672) [ci skip] 2018-09-17 16:24:57 -04:00