Viviane Dias
94c431afb0
[single-article] Refactor class components to be functional component ( #17681 )
...
* refactor(single-article): migrates class to use pure components
* test(single-article): removes repeated test from file
2022-05-26 12:59:06 +01:00
dependabot[bot]
c2659d38df
Bump eslint-config-preact from 1.2.0 to 1.3.0 ( #15834 )
...
* Bump eslint-config-preact from 1.2.0 to 1.3.0
Bumps [eslint-config-preact](https://github.com/preactjs/eslint-config-preact ) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/preactjs/eslint-config-preact/releases )
- [Commits](https://github.com/preactjs/eslint-config-preact/compare/1.2.0...v1.3.0 )
---
updated-dependencies:
- dependency-name: eslint-config-preact
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* apply new lint fixes after version bump
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-12-21 14:42:20 +00:00
Aayush Gupta
71fd773cf3
Add separate section for article link to improve accessibility in the mod center ( #14312 )
...
* Initial structure for article heading insertion
* Fix clashing class names
* Draft: Switch to details element + some logic refactor, some specs failing
* Fix failing specs
* Fix compatibility issues with Safari
* Refactor code
* Shift app logic to id attribute
* Code improvements
2021-08-11 14:30:12 +07:00
dependabot[bot]
a9449501a3
Bump @storybook/addon-a11y from 6.2.9 to 6.3.1 ( #14094 )
...
* Bump @storybook/addon-a11y from 6.2.9 to 6.3.1
Bumps [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/addons/a11y ) from 6.2.9 to 6.3.1.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.3.1/addons/a11y )
---
updated-dependencies:
- dependency-name: "@storybook/addon-a11y"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* add TODOs and exclusions for known a11y issues waiting on bugfixes
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-06-29 14:19:28 +02:00
Katie Davis
76453b41fb
Updates ESLint rules to error on default imports ( #12512 )
...
* add rule
* add named imports
* more missed files
* so many files
2021-02-02 10:24:03 -05:00
rhymes
f9506affb5
Use faster JS selection methods ( #11409 )
...
* Add JS tips section to frontend documentation
* Replace document.getElementsByTagName('body') with document.body
* Replace querySelectorAll with faster selecting methods where appropriate
* Replace querySelector with faster selecting methods where appropriate
* Fix typo
* Fix forEach and getElementsByClassName
* Change querySelector* to faster methods in erb files
* Change querySelector* to faster methods in ruby files
* Fix runkit tag
* Various fixes
* Update app/assets/javascripts/initializers/initializeEllipsisMenu.js
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
* Update app/assets/javascripts/utilities/slideSidebar.js
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
* Commenting out flaky spec
Co-authored-by: Ridhwana <Ridhwana.Khan16@gmail.com>
2020-11-16 17:35:50 +01:00
Molly Struve
330d849759
[deploy] Spec Fix:Add Fragment to test html ( #10963 )
2020-10-20 11:40:42 -05:00
PrimeNoodles
ff68888a04
Mod Center: clicking on article title opens a in new tab ( #9314 )
2020-10-20 11:23:04 -04:00
Rafi
70abb8101b
Fixing broken jest test ( #10162 )
2020-09-02 20:02:27 -04:00
rhymes
cd65273571
Use explicit name for Preact fragments ( #10049 )
2020-08-28 10:01:17 -04:00
Arit Amana
a78ccf2310
[deploy] [ModCenter] Fix "FlagUser" Modal functionality ( #8995 )
...
* Make FlagUserModal show up on click
* Explain extra div
* Make sure "Vomit All" reaction fires accurately
* Make test-file comment clearer
* Fix bug when 2 articles are open and the FlagUser modal does not open for the first article
* Still working it out ...
* Tests broken; need help
* Get rid of debugging alerts
* Fixed broken tests for <SingleArticle />
* Write tests for ModerationArticles component
* Complete tests for ModerationArticles component
* Employ safer Preact testing techniques
* Query all articles using "data-testid"
* Revert changes
* Got it working with portals for non-iframe implementation.
* wip tests
* Got mod tools flag user modal wprking on article page again.
* Added some documentation the code.
* Now confirm is disabled until you select an item in the flag user modal.
* Revert "wip tests"
This reverts commit fb7a0825039fd377cad04d9dedad9d1146b03978.
* test prep
* Fixed broken test.
* Refactored to use useRef hook.
* Rename a variable
* remove unnecessary comments
Co-authored-by: Nick Taylor <nick@dev.to>
2020-07-15 13:54:52 -04:00
Mac Siri
50a7c2ffe0
Rename dir _tests to __tests__ & update .codeclimate.yml ( #8982 )
2020-06-29 15:18:39 -04:00
