Bump @storybook/addon-a11y from 6.2.9 to 6.3.1 (#14094)
* Bump @storybook/addon-a11y from 6.2.9 to 6.3.1 Bumps [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/addons/a11y) from 6.2.9 to 6.3.1. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.3.1/addons/a11y) --- updated-dependencies: - dependency-name: "@storybook/addon-a11y" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * add TODOs and exclusions for known a11y issues waiting on bugfixes Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
This commit is contained in:
dependabot[bot]
GitHub
parent
0063a8be00
commit
a9449501a3
7 changed files with 101 additions and 32 deletions
|
|
@ -21,13 +21,19 @@ describe('<ArticleCoverImage />', () => {
|
|||
});
|
||||
|
||||
it('should have no a11y violations', async () => {
|
||||
// TODO: The axe custom rules here should be removed when the below issue is fixed
|
||||
// https://github.com/forem/forem/issues/13947
|
||||
const customAxeRules = {
|
||||
'nested-interactive': { enabled: false },
|
||||
};
|
||||
|
||||
const { container } = render(
|
||||
<ArticleCoverImage
|
||||
mainImage="/i/r5tvutqpl7th0qhzcw7f.png"
|
||||
onMainImageUrlChange={jest.fn()}
|
||||
/>,
|
||||
);
|
||||
const results = await axe(container);
|
||||
const results = await axe(container, { rules: customAxeRules });
|
||||
expect(results).toHaveNoViolations();
|
||||
});
|
||||
|
||||
|
|
|
|||
|
|
@ -6,11 +6,18 @@ import { Form } from '../Form';
|
|||
let bodyMarkdown;
|
||||
let mainImage;
|
||||
|
||||
// TODO: These image uploader axe custom rules here should be removed when the below issue is fixed
|
||||
// https://github.com/forem/forem/issues/13947
|
||||
const imageUploadAxeRules = {
|
||||
'nested-interactive': { enabled: false },
|
||||
};
|
||||
|
||||
// Axe flags an error for the multi-line combobox we use for Autosuggest, since a combobox should be a single line input.
|
||||
// This is a known issue documented on https://github.com/forem/forem/pull/13044, and these custom rules only apply to the two tests referencing them below.
|
||||
const customAxeRules = {
|
||||
'aria-allowed-role': { enabled: false },
|
||||
'aria-required-children': { enabled: false },
|
||||
...imageUploadAxeRules,
|
||||
};
|
||||
|
||||
describe('<Form />', () => {
|
||||
|
|
|
|||
|
|
@ -21,8 +21,14 @@ describe('<ImageUploader />', () => {
|
|||
});
|
||||
|
||||
it('should have no a11y violations', async () => {
|
||||
// TODO: The axe custom rules here should be removed when the below issue is fixed
|
||||
// https://github.com/forem/forem/issues/13947
|
||||
const customAxeRules = {
|
||||
'nested-interactive': { enabled: false },
|
||||
};
|
||||
|
||||
const { container } = render(<ImageUploader />);
|
||||
const results = await axe(container);
|
||||
const results = await axe(container, { rules: customAxeRules });
|
||||
expect(results).toHaveNoViolations();
|
||||
});
|
||||
|
||||
|
|
@ -106,12 +112,8 @@ describe('<ImageUploader />', () => {
|
|||
}),
|
||||
);
|
||||
|
||||
const {
|
||||
findByTitle,
|
||||
getByDisplayValue,
|
||||
getByLabelText,
|
||||
queryByText,
|
||||
} = render(<ImageUploader />);
|
||||
const { findByTitle, getByDisplayValue, getByLabelText, queryByText } =
|
||||
render(<ImageUploader />);
|
||||
const inputEl = getByLabelText(/Upload an image/i);
|
||||
|
||||
const file = new File(['(⌐□_□)'], 'chucknorris.png', {
|
||||
|
|
@ -119,7 +121,7 @@ describe('<ImageUploader />', () => {
|
|||
});
|
||||
|
||||
fireEvent.change(inputEl, { target: { files: [file] } });
|
||||
let uploadingImage = queryByText(/uploading.../i);
|
||||
const uploadingImage = queryByText(/uploading.../i);
|
||||
|
||||
expect(uploadingImage).toBeDefined();
|
||||
|
||||
|
|
|
|||
|
|
@ -35,11 +35,17 @@ const getLoadingUserData = () => ({
|
|||
describe('<Content />', () => {
|
||||
describe('as loading-user', () => {
|
||||
it('should have no a11y violations', async () => {
|
||||
// TODO: The axe custom rules here should be removed when the below issue is fixed
|
||||
// https://github.com/forem/forem/issues/14101
|
||||
const customAxeRules = {
|
||||
'nested-interactive': { enabled: false },
|
||||
};
|
||||
|
||||
const channelRequestResource = getChannelRequestData();
|
||||
const { container } = render(
|
||||
<Content resource={channelRequestResource} />,
|
||||
);
|
||||
const results = await axe(container);
|
||||
const results = await axe(container, { rules: customAxeRules });
|
||||
|
||||
expect(results).toHaveNoViolations();
|
||||
});
|
||||
|
|
@ -66,9 +72,15 @@ describe('<Content />', () => {
|
|||
|
||||
describe('as channel-request', () => {
|
||||
it('should have no a11y violations', async () => {
|
||||
// TODO: The axe custom rules here should be removed when the below issue is fixed
|
||||
// https://github.com/forem/forem/issues/14101
|
||||
const customAxeRules = {
|
||||
'nested-interactive': { enabled: false },
|
||||
};
|
||||
|
||||
const loadinUserResource = getLoadingUserData();
|
||||
const { container } = render(<Content resource={loadinUserResource} />);
|
||||
const results = await axe(container);
|
||||
const results = await axe(container, { rules: customAxeRules });
|
||||
|
||||
expect(results).toHaveNoViolations();
|
||||
});
|
||||
|
|
|
|||
|
|
@ -18,6 +18,12 @@ const getTestArticle = () => ({
|
|||
|
||||
describe('<SingleArticle />', () => {
|
||||
it('should have no a11y violations', async () => {
|
||||
// TODO: The axe custom rules here should be removed when the below issue is fixed
|
||||
// https://github.com/forem/forem/issues/14100
|
||||
const customAxeRules = {
|
||||
'nested-interactive': { enabled: false },
|
||||
};
|
||||
|
||||
const { container } = render(
|
||||
<Fragment>
|
||||
<SingleArticle {...getTestArticle()} toggleArticle={jest.fn()} />
|
||||
|
|
@ -28,7 +34,7 @@ describe('<SingleArticle />', () => {
|
|||
/>
|
||||
</Fragment>,
|
||||
);
|
||||
const results = await axe(container);
|
||||
const results = await axe(container, { rules: customAxeRules });
|
||||
expect(results).toHaveNoViolations();
|
||||
});
|
||||
|
||||
|
|
@ -83,8 +89,7 @@ describe('<SingleArticle />', () => {
|
|||
id: 2,
|
||||
title:
|
||||
'An article title that is quite very actually rather extremely long with all things considered',
|
||||
path:
|
||||
'an-article-title-that-is-quite-very-actually-rather-extremely-long-with-all-things-considered-fi8',
|
||||
path: 'an-article-title-that-is-quite-very-actually-rather-extremely-long-with-all-things-considered-fi8',
|
||||
publishedAt: '2019-06-24T09:32:10.590Z',
|
||||
cachedTagList: '',
|
||||
user: {
|
||||
|
|
|
|||
|
|
@ -87,7 +87,7 @@
|
|||
"homepage": "https://github.com/thepracticaldev/dev.to#readme",
|
||||
"devDependencies": {
|
||||
"@stoplight/spectral": "5.9.1",
|
||||
"@storybook/addon-a11y": "^6.2.9",
|
||||
"@storybook/addon-a11y": "^6.3.1",
|
||||
"@storybook/addon-actions": "^6.2.9",
|
||||
"@storybook/addon-docs": "^6.3.1",
|
||||
"@storybook/addon-knobs": "^6.2.9",
|
||||
|
|
|
|||
71
yarn.lock
71
yarn.lock
|
|
@ -2101,20 +2101,20 @@
|
|||
"@stoplight/yaml-ast-parser" "0.0.48"
|
||||
tslib "^1.12.0"
|
||||
|
||||
"@storybook/addon-a11y@^6.2.9":
|
||||
version "6.2.9"
|
||||
resolved "https://registry.yarnpkg.com/@storybook/addon-a11y/-/addon-a11y-6.2.9.tgz#8386d73343db03c15d07f6bf927a4030d441d1ff"
|
||||
integrity sha512-wo7nFpEqEeiHDsRKnhqe2gIHZ9Z7/Aefw570kBgReU5tKlmrb5rFAfTVBWGBZlLHWeJMsFsRsWrWrmkf1B52OQ==
|
||||
"@storybook/addon-a11y@^6.3.1":
|
||||
version "6.3.1"
|
||||
resolved "https://registry.yarnpkg.com/@storybook/addon-a11y/-/addon-a11y-6.3.1.tgz#376f380f99855ee7171b97fa92995ad7c723f719"
|
||||
integrity sha512-UFBm4NWHV1tm/DfIjFmZeG2Csfv1rh5vsqbllMiTXnvuKAFSTxMTzyk/mEy4wSDAC58+MAyiJ+x6JM8oQKfUTQ==
|
||||
dependencies:
|
||||
"@storybook/addons" "6.2.9"
|
||||
"@storybook/api" "6.2.9"
|
||||
"@storybook/channels" "6.2.9"
|
||||
"@storybook/client-api" "6.2.9"
|
||||
"@storybook/client-logger" "6.2.9"
|
||||
"@storybook/components" "6.2.9"
|
||||
"@storybook/core-events" "6.2.9"
|
||||
"@storybook/theming" "6.2.9"
|
||||
axe-core "^4.1.1"
|
||||
"@storybook/addons" "6.3.1"
|
||||
"@storybook/api" "6.3.1"
|
||||
"@storybook/channels" "6.3.1"
|
||||
"@storybook/client-api" "6.3.1"
|
||||
"@storybook/client-logger" "6.3.1"
|
||||
"@storybook/components" "6.3.1"
|
||||
"@storybook/core-events" "6.3.1"
|
||||
"@storybook/theming" "6.3.1"
|
||||
axe-core "^4.2.0"
|
||||
core-js "^3.8.2"
|
||||
global "^4.4.0"
|
||||
lodash "^4.17.20"
|
||||
|
|
@ -2694,6 +2694,19 @@
|
|||
qs "^6.10.0"
|
||||
telejson "^5.3.2"
|
||||
|
||||
"@storybook/channel-postmessage@6.3.1":
|
||||
version "6.3.1"
|
||||
resolved "https://registry.yarnpkg.com/@storybook/channel-postmessage/-/channel-postmessage-6.3.1.tgz#a255f89b8fdac62f26b20eec6e95e432db25b2a6"
|
||||
integrity sha512-6+luEe2H/84ZYCfcNgH5WCYtUbSIJiMjKFsV17iRVLECRxX8PtxxH5zB3kzhpAngp9WwKDEAS0T1+lEZoHh2Yw==
|
||||
dependencies:
|
||||
"@storybook/channels" "6.3.1"
|
||||
"@storybook/client-logger" "6.3.1"
|
||||
"@storybook/core-events" "6.3.1"
|
||||
core-js "^3.8.2"
|
||||
global "^4.4.0"
|
||||
qs "^6.10.0"
|
||||
telejson "^5.3.2"
|
||||
|
||||
"@storybook/channels@5.3.21":
|
||||
version "5.3.21"
|
||||
resolved "https://registry.yarnpkg.com/@storybook/channels/-/channels-5.3.21.tgz#53ba622b171d68b3b102983a62aa05149a49497b"
|
||||
|
|
@ -2809,6 +2822,30 @@
|
|||
ts-dedent "^2.0.0"
|
||||
util-deprecate "^1.0.2"
|
||||
|
||||
"@storybook/client-api@6.3.1":
|
||||
version "6.3.1"
|
||||
resolved "https://registry.yarnpkg.com/@storybook/client-api/-/client-api-6.3.1.tgz#a375142b5a49499afa060de10a81ecbbb6904aa1"
|
||||
integrity sha512-LZrJ5zUT88n2VIf4c+3IkWXWmBzpz5DMc9ly2KOPywzgAPkTOwRzaNY6lg2ozMhN262N5meRAST86kYRYG3DKw==
|
||||
dependencies:
|
||||
"@storybook/addons" "6.3.1"
|
||||
"@storybook/channel-postmessage" "6.3.1"
|
||||
"@storybook/channels" "6.3.1"
|
||||
"@storybook/client-logger" "6.3.1"
|
||||
"@storybook/core-events" "6.3.1"
|
||||
"@storybook/csf" "0.0.1"
|
||||
"@types/qs" "^6.9.5"
|
||||
"@types/webpack-env" "^1.16.0"
|
||||
core-js "^3.8.2"
|
||||
global "^4.4.0"
|
||||
lodash "^4.17.20"
|
||||
memoizerific "^1.11.3"
|
||||
qs "^6.10.0"
|
||||
regenerator-runtime "^0.13.7"
|
||||
stable "^0.1.8"
|
||||
store2 "^2.12.0"
|
||||
ts-dedent "^2.0.0"
|
||||
util-deprecate "^1.0.2"
|
||||
|
||||
"@storybook/client-logger@5.3.21":
|
||||
version "5.3.21"
|
||||
resolved "https://registry.yarnpkg.com/@storybook/client-logger/-/client-logger-5.3.21.tgz#912c83b0d358e70acad1ad4abe199de4c38b109f"
|
||||
|
|
@ -5105,10 +5142,10 @@ aws4@^1.8.0:
|
|||
resolved "https://registry.yarnpkg.com/aws4/-/aws4-1.11.0.tgz#d61f46d83b2519250e2784daf5b09479a8b41c59"
|
||||
integrity sha512-xh1Rl34h6Fi1DC2WWKfxUTVqRsNnr6LsKz2+hfwDxQJWmrx8+c7ylaqBMcHfl1U1r2dsifOvKX3LQuLNZ+XSvA==
|
||||
|
||||
axe-core@^4.0.1, axe-core@^4.0.2, axe-core@^4.1.1:
|
||||
version "4.1.3"
|
||||
resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-4.1.3.tgz#64a4c85509e0991f5168340edc4bedd1ceea6966"
|
||||
integrity sha512-vwPpH4Aj4122EW38mxO/fxhGKtwWTMLDIJfZ1He0Edbtjcfna/R3YB67yVhezUMzqc3Jr3+Ii50KRntlENL4xQ==
|
||||
axe-core@^4.0.1, axe-core@^4.0.2, axe-core@^4.2.0:
|
||||
version "4.2.3"
|
||||
resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-4.2.3.tgz#2a3afc332f0031b42f602f4a3de03c211ca98f72"
|
||||
integrity sha512-pXnVMfJKSIWU2Ml4JHP7pZEPIrgBO1Fd3WGx+fPBsS+KRGhE4vxooD8XBGWbQOIVSZsVK7pUDBBkCicNu80yzQ==
|
||||
|
||||
axios@^0.18.0, axios@^0.21.1:
|
||||
version "0.21.1"
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue