Commit graph

1995 commits

Author SHA1 Message Date
Kobe Raypole
bb16b36ca7 Add policy for article manage action (#2643)
* Add policy for article manage action

This commit adds a policy for the articles#manage method. This will
prevent the error that is stopping article owners from managing their
articles.

* Hide manage button if article isnt published

* account for no current_user

* Move button logic to javascript
2019-05-02 19:31:26 -04:00
Ben Halpern
5891b2ea58
Add application "page" model (#2657)
* Generate page model

* Add page model

* Conditionally modify html rendering
2019-05-02 18:24:06 -04:00
Jess Lee
85d8c43657 Update Listings Price (#2660)
* update view

* adjust styling and add fourth price

* update pricing

* adjust styling based on feedback

* update cost per credit

* fix cost per credit numbers
2019-05-02 18:10:42 -04:00
Ben Halpern
4c3a9b483e
Small cached attribute fix (#2663)
* Add profile_image_90 to serialized data on article

* Cached org tweaks
2019-05-02 16:24:49 -04:00
Ben Halpern
5e64ae874e
Remove includes user from stories query to reduce num queries and memory (#2662)
* Add profile_image_90 to serialized data on article

* Remove includes user from stories query
2019-05-02 15:58:58 -04:00
Ben Halpern
f12f00decd
Add profile_image_90 to serialized data on article (#2661) 2019-05-02 15:47:22 -04:00
Ben Halpern
8aa6636a96
Minor cache improvements to tag index (#2659) 2019-05-02 15:00:00 -04:00
Ben Halpern
821d45104a
Create serialized cached user and cached organization for articles (#2658)
* Create cached user and cached organization for articles

* Remove pages table
2019-05-02 14:42:28 -04:00
Jess Lee
5e193fdcd7 Create listings permalink (#2637)
* create listings show route

* add link to listings

* include slug in json

* migrate test environment

* unlink listing title

* fix formatting

* remove slug data from json

* remove auto linting

* fix spacing

* add to algolia index?

* actually add index?

* fix merge conflicts?

* update query
2019-05-02 14:14:40 -04:00
Some-Dood
e3e1a02ad3 [UX] Add hover effect for sidebar-profile-snapshot (#2650) [ci skip] 2019-05-02 13:51:58 -04:00
rhymes
fb9a407b21 Adds Ruby source code documentation to docs.dev.to (#2656)
* Add YARD and plugins to generate source code doc

* Expose yard Ruby doc in gitdocs

* Add yard doc step to Travis

* Tell netlify to build the docs before deploying

* Add Gemfile for Ruby prerequisites and Makefile

* Makefile uses tabs, not spaces

* Build ruby-doc and then gitdocs

* Add recent Ruby version to make sure yard plugins work

* Switch Ruby to a pre-built version inside Netlify

* Add ActiveRecord for the yard-activerecord plugin

* Add Ruby doc header link and info to build it locally
2019-05-02 13:50:58 -04:00
rhymes
0e41a37eb6 Fix saved/unsave alignment (#2653) [ci skip] 2019-05-02 12:53:40 -04:00
rhymes
56e13d00f0 Upgrade Ruby to 2.6.3 (#2649) 2019-05-02 12:06:18 -04:00
Mario See
96a0235168 Change DevComment#render to utilize html.erb (#2554) [ci skip] 2019-05-02 12:05:55 -04:00
Mario See
e90bb2bf53 dev tag liquid tag render utilize html.erb (#2641)
* init refactor

* fix cc issue
2019-05-02 08:53:58 -04:00
Nick Taylor
957d1887b7 More themeable mixin in action (#2646)
* More themeable mixin in action.

* Missed a CSS var to themeable mixin.
2019-05-01 20:33:25 -04:00
Ben Halpern
7100eab636
Fix social image order logic (#2645) 2019-05-01 18:47:10 -04:00
dependabot[bot]
5890542f01 Bump pusher-push-notifications from 1.0.0 to 1.1.0 (#1880) [ci skip] 2019-05-01 17:22:19 -04:00
Westbrook Johnson
e843d9dc96 Add file argument to Stackblitz embed. (#2590) 2019-05-01 16:28:37 -04:00
Ben Halpern
f0663d83ca
Add nightmode image (#2640) 2019-05-01 15:14:18 -04:00
Diogo Mafra
6de9515ec0 [UX] Add on-hover to chronofilter links (#2478) 2019-05-01 15:05:13 -04:00
Kobe Raypole
0b93507da6 Extract comment's async methods to jobs (#2596) 2019-05-01 13:59:50 -04:00
Anna Buianova
065ef29e31 Added unique index to notifications #2124 (#2213)
* Added unique index to notifications #2124

* Fix migration + add index to schema.rb

* Shoulda matcher notification unique validation
2019-05-01 13:15:06 -04:00
Bolarinwa Balogun
ed53191929 Fix Save Changes text spill out of button (#2563) [ci skip] 2019-05-01 13:02:05 -04:00
Jess Lee
011e734ee0 Allow admins to remove credits from internal/users (#2635) 2019-05-01 12:49:42 -04:00
Mike Coutermarsh
4c9959f0ff Social Cards Part 2 (#2188)
* Social Cards Part 2

This is a follow up to part 1: https://github.com/thepracticaldev/dev.to/pull/2090.

This PR updates the og:image URLs to use the new social_preview.png urls
added in Part 1.

So that the already generated/cached images do not need to be recreated,
this sets a MIGRATION_DATETIME. Any object that has been updated after
that date will generate a new image

Objects from before that date will not. They will use the new url.

* Fix weird change made by rubocop autocorrect

* Handle organizations + users

* Run CI

* Use time with zone to be explicit about timezone

* Simplify branching in user_social_image_url method

* Fix param alignment + bump migration date
2019-05-01 11:07:25 -04:00
Bolarinwa Balogun
44b06ea442 Allow embed single file from Gist tag (#2620) 2019-05-01 10:47:52 -04:00
Kobe Raypole
116ddc7089 Add hover to article save button (#2597) 2019-05-01 10:29:09 -04:00
Ben Halpern
5eb8036bad
Fix buffer_updates conditional in /manage (#2636) 2019-05-01 10:17:35 -04:00
Ben Halpern
158f56bc9d
Add page for users to "manage" their posts after publication (distribution, etc.) (#2627)
* Set up basic /manage route

* Add basic article manage page

* Add tips and finalize permissions for /manage

* Add final test and add manage button to article show

* Update failing specs
2019-05-01 09:00:09 -04:00
Nick Taylor
8e6d193d25 Added the themeable mixin. (#2633)
* Added the themeable mixin.

* Fixed a typo, some wording
2019-05-01 08:59:06 -04:00
dependabot[bot]
9ed6606aa3 Bump intersection-observer from 0.5.1 to 0.6.0 (#2603) [ci skip]
Bumps [intersection-observer](https://github.com/w3c/IntersectionObserver) from 0.5.1 to 0.6.0.
- [Release notes](https://github.com/w3c/IntersectionObserver/releases)
- [Commits](https://github.com/w3c/IntersectionObserver/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-30 19:06:27 -04:00
dependabot[bot]
0c93804700 Bump husky from 1.3.1 to 2.1.0 (#2601) [ci skip]
Bumps [husky](https://github.com/typicode/husky) from 1.3.1 to 2.1.0.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](https://github.com/typicode/husky/compare/v1.3.1...v2.1.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-30 19:01:37 -04:00
Anna Buianova
dd11478659 Change format of the user languages_settings #2369 (#2496)
* Change format of user preferred languages

* Make sure user language settings are set by default

* Add missing expect to the user spec

* Fix users/misc template

* Move existing languages to a constant

* Remove commented user code

* Move languages out of User model

* Update preferred languages accordingly to the available languages

* Set user estimated language only if the language is available

* Fix Portuguese spelling #2582
2019-04-30 17:01:19 -04:00
dependabot[bot]
8c5cac241e Bump aws-sdk-lambda from 1.21.0 to 1.22.0 (#2608)
Bumps [aws-sdk-lambda](https://github.com/aws/aws-sdk-ruby) from 1.21.0 to 1.22.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-lambda/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/compare/1.21.0...1.22.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-30 16:15:28 -04:00
Justin Lavoie
804758ce34 Fix typo in seed log information (#2631) [ci skip] 2019-04-30 16:10:15 -04:00
rhymes
50ed146515 Use only fog-aws with carrierwave instead of fog (#2569)
Currently dev.to is including the entire fog library just to support image uploads to AWS S3. carrierwave can be used just with fog-aws.
I preserved the same exact version is currently used now.
2019-04-30 15:22:01 -04:00
Rushaine McBean
6fbfdd02f6 Updates links within repo README for setting up environment variables (#2628) 2019-04-30 14:29:37 -04:00
rhymes
89e986f066 Removes pry and pry-rails from production (#2629)
Closes #2626
2019-04-30 14:29:05 -04:00
dependabot[bot]
fd63db2aa6 Bump bullet from 5.9.0 to 6.0.0 (#2607)
Bumps [bullet](https://github.com/flyerhzm/bullet) from 5.9.0 to 6.0.0.
- [Release notes](https://github.com/flyerhzm/bullet/releases)
- [Changelog](https://github.com/flyerhzm/bullet/blob/master/CHANGELOG.md)
- [Commits](https://github.com/flyerhzm/bullet/compare/5.9.0...6.0.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2019-04-30 09:38:57 -04:00
Anna Buianova
b50c2d333d Add indexes to classified_listings (#2624) 2019-04-30 09:35:30 -04:00
Anna Buianova
d2d405ad37 Add validation to classified_listings user and organization (#2625) 2019-04-30 09:35:08 -04:00
rhymes
9210f6793b Improvements on dev docs (#2616)
* Correct installation documentation

* Add stylized titles

* Add some changes to the getting started documentation

* Add changes for the backend guide

* Add changes for the design guide

* Add testing / Q&A guide improvements

* Minor fixes to contributing docs

* More improvements to the general doc

* Improvements for frontend guide
2019-04-29 18:54:29 -04:00
Ben Halpern
4b91dd5912
Make a couple changes to Twitch MVP before push (#2622) 2019-04-29 18:53:09 -04:00
Corey Alexander
ec388804df Embed Twitch Live Streaming (#2591)
* Get a job created that can create a webhook subscription for a twitch user login

* Remove ngork url

* Refactor add store the access token in the cache

* Get a controller stood up to recieve the webhooks. Now they just need to be processed

* Get User columns added and got webhook controller bones working

* Update the webhook job to use the User

* Add a way for the User to input their Twitch User Name. Plus a linter fix

* Delay webhook registration when profile is updated

* Don't add _ in username

* Use String columns

* Quick fix and add some more requests specs

* Specs for the webhook job

* Get a show page Twitch Live Streams. Just a straight embed of the Twitch Everything Embed UI. Works surprisingly well responsively, and works on all screen sizes

* Fix Gemfile.lock from merge issues

* Add support for expired tokens and add spec

* Add secrets to webhook registration and clean up spec to remove token logic

* Verify webhook secret and spec it

* Add rake task to enqueue webhook registration for all Users. This can be used from Heroku Scheduler

* Update the lease seconds to be for 5 days

* Actually lets do 7 so we can refresh twice a week and try to make sure that we can always miss one

* Hijack the existing Twitch logo instead of making a duplicate one

* Remove comment and replace with log line

* Remove some white space

* Log to Airbrake when webhook errors occur

* Move to passing in an id instead of User object

* Extract logic from Job to Service object

* Capitilize in the view

* Move out of models and into services

* Remove letover stub

* Remove one usage of Faraday

* Use HTTParty for all the HTTP here
2019-04-29 18:11:53 -04:00
Bolarinwa Balogun
5b0340351b Fix non-english characters delete on tags (#2579) 2019-04-29 17:33:14 -04:00
Anna Buianova
2ea6accec1 Fix name resolving error on export (#2612)
* Fix name resolving error on export

* Fix exporter service spec
2019-04-29 15:37:50 -04:00
rhymes
af83bab2d0 Escape range separator (#2593)
The char "-" in regexp defaults a a separator for a range of character, for example: "a-z", Ruby is smart enough to understand "-_" is no range but it does emit a warning, by properly escaping the char "-" we ensure that no warning or issues can arise in the future.
2019-04-29 14:27:26 -04:00
Mac Siri
d1b286a835 Fix inconsistent spec 2019-04-29 13:06:56 -04:00
Bolarinwa Balogun
e04d84bc4c Improve Gist Link Regex (#2592)
* Improve Gist Link Regex

While working with the gist liquid tag, I noticed that valid gist links
were resulting in errors. After looking at `gist_tag.rb`, I noticed
that for a link to be considered valid the gist-id had to be exactly 32
characters which is not always true.

I changed the regex so links with a gist-id of at least one character and
at most 32 characters is considered valid. I decided to continue with
the 32 characters that had previously been used as the upper bound. I
also made a change so links with a github username that starts or ends
with hypens or contains consecutive hypens are considered invalid. The
aforementioned change was based on the validation message from the
create new GitHub account form.

* Change gist_link to gist_links in spec file for Gist tag
2019-04-29 12:24:52 -04:00