Andrew Bone
ba5e55ae44
Update rbenv-doctor location in docs ( #13803 )
...
* Update with best practices
* Remove useCallback
* Update app/javascript/shared/components/useKeyboardShortcuts.js
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Fill out JSDoc
* Follow Prettier rules
* Resolve conflict
* 📝 Update rbenv-doctor location
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-05-19 08:59:22 -06:00
rhymes
a798bd2f7d
[15 min fix] Fallback to the image URL if Cloudinary/Imgproxy are not configured ( #13767 )
...
* Fallback to the image URL if neither Cloudinary nor Imgproxy are configured
* Fix specs
* Cloudinary api_secret is required
* Update spec/models/message_spec.rb
Co-authored-by: Michael Kohl <citizen428@dev.to>
Co-authored-by: Michael Kohl <citizen428@dev.to>
2021-05-19 15:03:20 +02:00
dependabot[bot]
f39b76b865
Bump webpacker from 5.3.0 to 5.4.0 ( #13801 )
...
Bumps [webpacker](https://github.com/rails/webpacker ) from 5.3.0 to 5.4.0.
- [Release notes](https://github.com/rails/webpacker/releases )
- [Changelog](https://github.com/rails/webpacker/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rails/webpacker/compare/v5.3.0...v5.4.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-19 08:38:28 -04:00
dependabot[bot]
1a0604b3e8
Bump sidekiq-unique-jobs from 7.0.10 to 7.0.11 ( #13800 )
...
Bumps [sidekiq-unique-jobs](https://github.com/mhenrixon/sidekiq-unique-jobs ) from 7.0.10 to 7.0.11.
- [Release notes](https://github.com/mhenrixon/sidekiq-unique-jobs/releases )
- [Changelog](https://github.com/mhenrixon/sidekiq-unique-jobs/blob/master/CHANGELOG.md )
- [Commits](https://github.com/mhenrixon/sidekiq-unique-jobs/compare/v7.0.10...v7.0.11 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-19 08:38:02 -04:00
dependabot[bot]
ff244a31ef
Bump rubocop from 1.14.0 to 1.15.0 ( #13791 )
...
* Bump rubocop from 1.14.0 to 1.15.0
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.14.0 to 1.15.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.14.0...v1.15.0 )
Signed-off-by: dependabot[bot] <support@github.com>
* Enable Style/TopLevelMethodDefinition and fix outstanding violations
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rhymes <github@rhymes.dev>
2021-05-18 15:41:14 +02:00
Michael Kohl
b7ff9aadd1
Clean up SiteConfig ( #13738 )
...
* Remove obsolete SiteConfig values
* Remove DUS
* fixup! Remove obsolete SiteConfig values
* fixup! Remove obsolete SiteConfig values
* Add DUS for removing SiteConfig values
* Fix specs
* Fix specs
* Clean up more DUS
* Update DUS
* Fix remaining spec
* Remove leftover spec
* Fix more specs
* Fix spec
* Remove deprecated spec
* Rearrange specs
* Temporarily disable specs
2021-05-18 09:38:31 +07:00
Michael Kohl
5e05f0fd92
✂✂✂ Remove shop_url from SiteConfig ✂✂✂ ( #13773 )
...
* Remove shop_url from SiteConfig
* Add data update script
2021-05-18 09:03:05 +07:00
dependabot[bot]
c5883e68bf
Bump webpack-bundle-analyzer from 4.4.1 to 4.4.2 ( #13787 )
...
* Bump webpack-bundle-analyzer from 4.4.1 to 4.4.2
Bumps [webpack-bundle-analyzer](https://github.com/webpack-contrib/webpack-bundle-analyzer ) from 4.4.1 to 4.4.2.
- [Release notes](https://github.com/webpack-contrib/webpack-bundle-analyzer/releases )
- [Changelog](https://github.com/webpack-contrib/webpack-bundle-analyzer/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/webpack-bundle-analyzer/compare/v4.4.1...v4.4.2 )
Signed-off-by: dependabot[bot] <support@github.com>
* Trigger Travis manually
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rhymes <github@rhymes.dev>
2021-05-17 10:57:09 -06:00
Joe Avila
51969518f5
Change const to var in user_subscription_tag ( #13694 )
2021-05-17 11:40:07 -04:00
dependabot[bot]
e4ecfd2b9e
Bump @babel/core from 7.14.0 to 7.14.2 ( #13788 )
...
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) from 7.14.0 to 7.14.2.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.14.2/packages/babel-core )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-17 09:36:24 -06:00
dependabot[bot]
dd6194b5a9
Bump canvas from 2.7.0 to 2.8.0 ( #13783 )
...
Bumps [canvas](https://github.com/Automattic/node-canvas ) from 2.7.0 to 2.8.0.
- [Release notes](https://github.com/Automattic/node-canvas/releases )
- [Changelog](https://github.com/Automattic/node-canvas/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Automattic/node-canvas/compare/v2.7.0...v2.8.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-17 09:12:20 -06:00
Alex
1a0351c2b0
Remove no-op Search::IndexWorker ( #13632 )
2021-05-17 10:17:58 -04:00
Mac Siri
c22128e0ab
Add .yarnclean ( #13770 )
2021-05-17 10:15:25 -04:00
Michael Kohl
8ff86f6107
Remove mentions of creators.forem.com ( #13774 )
2021-05-17 09:49:36 -04:00
dependabot[bot]
8cedf00f6d
Bump @testing-library/user-event from 13.1.8 to 13.1.9 ( #13784 )
2021-05-17 09:48:50 -04:00
dependabot[bot]
7e3512dcad
Bump eslint-plugin-import from 2.22.1 to 2.23.2 ( #13785 )
2021-05-17 09:47:41 -04:00
dependabot[bot]
b160cb3629
Bump faker from 2.17.0 to 2.18.0 ( #13782 )
...
Bumps [faker](https://github.com/faker-ruby/faker ) from 2.17.0 to 2.18.0.
- [Release notes](https://github.com/faker-ruby/faker/releases )
- [Changelog](https://github.com/faker-ruby/faker/blob/master/CHANGELOG.md )
- [Commits](https://github.com/faker-ruby/faker/compare/v2.17.0...v2.18.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-17 13:57:38 +02:00
dependabot[bot]
09cc60b93e
Bump @babel/preset-env from 7.14.1 to 7.14.2 ( #13778 )
...
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env ) from 7.14.1 to 7.14.2.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.14.2/packages/babel-preset-env )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-17 11:08:05 +02:00
dependabot[bot]
83992af702
Bump webmock from 3.12.2 to 3.13.0 ( #13780 )
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.12.2 to 3.13.0.
- [Release notes](https://github.com/bblimke/webmock/releases )
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.12.2...v3.13.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-17 11:07:27 +02:00
dependabot[bot]
31993d8e9f
Bump nokogiri from 1.11.3 to 1.11.4 ( #13781 )
...
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri ) from 1.11.3 to 1.11.4.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases )
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.11.3...v1.11.4 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-17 11:06:27 +02:00
dependabot[bot]
8b3d78d267
Bump eslint-import-resolver-webpack from 0.13.0 to 0.13.1 ( #13777 )
...
Bumps [eslint-import-resolver-webpack](https://github.com/benmosher/eslint-plugin-import ) from 0.13.0 to 0.13.1.
- [Release notes](https://github.com/benmosher/eslint-plugin-import/releases )
- [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md )
- [Commits](https://github.com/benmosher/eslint-plugin-import/compare/v0.13.0...resolvers/webpack/v0.13.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-17 11:05:04 +02:00
dependabot[bot]
b4646f0574
Bump postcss from 8.2.14 to 8.2.15 ( #13776 )
...
Bumps [postcss](https://github.com/postcss/postcss ) from 8.2.14 to 8.2.15.
- [Release notes](https://github.com/postcss/postcss/releases )
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md )
- [Commits](https://github.com/postcss/postcss/compare/8.2.14...8.2.15 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-17 11:03:11 +02:00
dependabot[bot]
19ae95df2f
Bump sass from 1.32.12 to 1.32.13 ( #13775 )
...
Bumps [sass](https://github.com/sass/dart-sass ) from 1.32.12 to 1.32.13.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.32.12...1.32.13 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-17 11:02:44 +02:00
Karel De Smet
302ccee8e4
Fix typo: 'upsteam' -> 'upstream' ( #13771 )
2021-05-17 11:09:44 +07:00
dependabot[bot]
2801db9ee8
Bump knapsack_pro from 2.15.0 to 2.16.0 ( #13764 )
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 2.15.0 to 2.16.0.
- [Release notes](https://github.com/KnapsackPro/knapsack_pro-ruby/releases )
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v2.15.0...v2.16.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-17 11:09:17 +07:00
dependabot[bot]
7bb07f1c8f
Bump guard from 2.16.2 to 2.17.0 ( #13763 )
...
Bumps [guard](https://github.com/guard/guard ) from 2.16.2 to 2.17.0.
- [Release notes](https://github.com/guard/guard/releases )
- [Commits](https://github.com/guard/guard/compare/v2.16.2...v2.17.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-17 09:12:20 +07:00
dependabot[bot]
75d922c59a
Bump test-prof from 1.0.4 to 1.0.5 ( #13762 )
...
Bumps [test-prof](https://github.com/test-prof/test-prof ) from 1.0.4 to 1.0.5.
- [Release notes](https://github.com/test-prof/test-prof/releases )
- [Changelog](https://github.com/test-prof/test-prof/blob/master/CHANGELOG.md )
- [Commits](https://github.com/test-prof/test-prof/compare/v1.0.4...v1.0.5 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-17 09:11:51 +07:00
Vaidehi Joshi
30d0ea369b
Remove Vaidehi from Forem Core Team ( #13769 )
2021-05-14 12:31:31 -07:00
rhymes
c654157f58
Enable and display test-prof report at the end of a test run ( #13765 )
2021-05-14 17:45:23 +02:00
Mac Siri
5b8b651b67
Allow sign up without email smtp config ( #13650 )
2021-05-14 11:43:49 -04:00
Mac Siri
b25965a779
[Travis] Only cache vendor/bundle and node_modules ( #13758 )
2021-05-14 10:26:10 -04:00
Daniel Uber
af13fcb1f3
Change article factory to include a flare tag "discuss" ( #13760 )
...
* Change article factory to include a flare tag "discuss"
This removed the css tag - keeping the articles tags count
consistent. If we are checking that articles have tag css exactly
there may be one or two specs changing.
If we assert does not have flare then we will want to adapt that as well.
* Change the tag to follow from css to html
Since we removed "css" from the articles factory, use one that we kept.
2021-05-14 07:43:39 -05:00
Alex
795cf7b10a
Don't show articles from blocked users in the feed ( #13752 )
...
* Update element identifier for blocked articles
* Update confirmation wording
* Add specs
2021-05-14 09:41:50 +02:00
dependabot[bot]
3db711db70
Bump test-prof from 1.0.3 to 1.0.4 ( #13754 )
...
Bumps [test-prof](https://github.com/test-prof/test-prof ) from 1.0.3 to 1.0.4.
- [Release notes](https://github.com/test-prof/test-prof/releases )
- [Changelog](https://github.com/test-prof/test-prof/blob/master/CHANGELOG.md )
- [Commits](https://github.com/test-prof/test-prof/compare/v1.0.3...v1.0.4 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-13 12:05:26 -05:00
dependabot[bot]
e71d886991
Bump ddtrace from 0.47.0 to 0.49.0 ( #13755 )
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 0.47.0 to 0.49.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.47.0...v0.49.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-13 13:01:15 -04:00
rhymes
1901ac9573
[15 min fix] Update Publishing from RSS guide with correct instructions ( #13756 )
...
* Update Publishing from RSS guide with correct instructions
* Use colons, not arrows
* Update app/views/pages/publishing_from_rss_guide.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2021-05-13 17:00:35 +02:00
Michael Kohl
f7293c3544
Fix wrong SiteConfig mentions ( #13739 )
2021-05-13 09:36:36 +00:00
Michael Kohl
3c92419311
Remove settings_mascots table ( #13737 )
...
* Remove settings_mascots table
* Remove DUS
2021-05-13 10:03:25 +07:00
Vaidehi Joshi
ba972b2c1d
Remove any preexisting mention notifications when article is unpublished ( #13749 )
...
Also add specs for this behavior, as well as specs for removing preexisting comment notificaitons when an article is unpublished
2021-05-12 11:48:12 -07:00
Alex
e53b6bff85
Auto-subscribe to comments on articles from feed ( #13717 )
...
* Auto-subscribe to comments on articles from feed
* Change specs
* Update spec again
2021-05-12 12:18:32 -04:00
Fernando Valverde
2463ac7194
Expose aasa for non-private Forems ( #13729 )
...
* Expose aasa non-private forems + small tweak to aasa
* Tests
* Update spec/requests/universal_links_spec.rb
Co-authored-by: Michael Kohl <citizen428@dev.to>
* Check empty array with be_empty
* Include Universal Links context
Co-authored-by: Michael Kohl <citizen428@dev.to>
2021-05-12 10:13:46 -06:00
Andrew Bone
f6e222f12e
Fix layout shift on active crayons-tabs change. ( #13300 )
2021-05-12 11:45:36 -04:00
Vaidehi Joshi
5e6aad98e3
Replace MAX_USER_MENTIONS with Settings::RateLimit.mention_creation ( #13736 )
...
* Replace MAX_USER_MENTIONS with Settings::RateLimit.mention_creation
* Remove Vaidehi-specific TODOs
* Remove unnecessary constant stubs
* Remove rate_limit_mention_creation from SiteConfig
2021-05-12 08:16:38 -07:00
Vaidehi Joshi
8f0c24c167
Expand @-mention functionality to posts ( #13367 )
...
* Initial work for @-mention notifications from posts
* Revert article.published changes to article updater, add clarifying comments
* Extract article preview into reusable partial for notification views
* Clean up Article Updater
* Address + remove some FIXMEs
* Add a whole buncha specs for @-mention functionality in posts YAY
* Refactor create all spec to use shared examples, add clarifying comments
* Add guard clause to create all service
* Update new mention and notifiable action specs
* Some additional cleanup
* Add specs + shared examples to SendEmailNotificationWorker spec
* Use aggregate_failures where applicable
Co-authored-by: Michael Kohl <citizen428@dev.to>
* Cleanup and address code review comments
* Add MentionDecorator + relevant specs
* Address comments/issues flagged by @rhymes
* Optimize plucking user_ids when checking for article followers
Co-authored-by: Michael Kohl <citizen428@dev.to>
2021-05-12 07:33:33 -07:00
Suzanne Aitchison
cdcb3b9be3
add accessibility section to editor guide ( #13727 )
...
* add accessibility section to editor guide
* Update app/views/pages/_editor_guide_text.html.erb
Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>
Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>
2021-05-12 10:19:34 +01:00
Madza
cac7fd1c55
Update GitPod setup description ( #13709 )
2021-05-12 10:30:42 +02:00
dependabot[bot]
25bf30ae43
Bump derailed_benchmarks from 2.0.1 to 2.1.0 ( #13743 )
...
Bumps [derailed_benchmarks](https://github.com/schneems/derailed_benchmarks ) from 2.0.1 to 2.1.0.
- [Release notes](https://github.com/schneems/derailed_benchmarks/releases )
- [Changelog](https://github.com/schneems/derailed_benchmarks/blob/main/CHANGELOG.md )
- [Commits](https://github.com/schneems/derailed_benchmarks/compare/v2.0.1...v2.1.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-05-12 10:30:26 +02:00
Michael Kohl
fa2ff578ab
Add documentation for Profiles::Update ( #13723 )
2021-05-12 09:59:39 +07:00
Jamie Gaskins
11bab732c0
Bump Puma to v5.3.1 ( #13731 )
...
This required an explicit `Gemfile` change because `bundle update puma`
did not actually update otherwise:
Bundler attempted to update puma but its version stayed the same
2021-05-11 13:43:18 -04:00
Michael Kohl
867d9a1a2f
Move services from Suggester::Users ( #13699 )
2021-05-11 12:57:12 -04:00
