Commit graph

2989 commits

Author SHA1 Message Date
Molly Struve
ba4b6593bc
JS Bug Fix: Check that bodyClass is present before checking what it includes (#6920)
* check that bodyClass is present before checking what it includes

* refaactor method to return early if bodyClass if not present

* back to simple if statements
2020-03-30 12:07:44 -04:00
rhymes
e6fda5e444
Ignore unused tweets columns (#6950) [deploy] 2020-03-30 17:27:17 +02:00
Nick Taylor
e4fdbd1a30
Restructure Storybook stories in sidebar (#6915)
* Renamed designSystem to crayons.

* Restructured how Storybook stories are laid out in Storybook's sidebar.

* wip

* More folder restructuring for Storybook sidebar.

* Fixed Dropdown description story.

* There no longer is a Dropdown for no padding. Just add additional utility classes.

* Showing dropdowns by default in Storybook as they are hidden by default.
2020-03-30 17:26:04 +02:00
rhymes
466ec8bd17
Ignore unused tags columns (#6947) 2020-03-30 16:57:13 +02:00
Lucas Hiago
bc84c4473f
Refactor method in tweet models (#6929) 2020-03-30 16:10:17 +02:00
rhymes
6e1fabaadb
Ignore unused podcast_episodes columns (#6939) [deploy]
* Ignore unused podcast_episodes columns

* Remove featured from serializer
2020-03-30 15:38:22 +02:00
rhymes
863247049e
Ignore unused pages columns (#6934) 2020-03-30 15:35:12 +02:00
ludwiczakpawel
184e56f216
Buttons Group (#6946)
* crayons-btn-group + crayons-btn--icon-alone

* typos

* better padding on outlined buttons

* make ooutlined button border a variable

* hey, pawel - how about not being an idiot??
2020-03-30 15:19:58 +02:00
Catalin Pit
39d4386c3f
Themes: use default colors for links in notifications (#6912)
* 6907 Fixed the notification color from black to white

* Removed themeable altogether
2020-03-30 11:50:15 +02:00
Alex
efc08d9b74
[deploy] Add valiation for file name length to file uploads (#6918) 2020-03-27 18:54:27 -04:00
Molly Struve
72f04e4a13
Create Reactions Index in Elasticsearch and Serializer (#6899)
* create index for reactions and their reactables, set up serializer

* use respond_to instead of checking type

* remove rubocop change

* add last_indexed_at to reactions index
2020-03-27 18:44:54 -04:00
Molly Struve
974ba032da
Add last_indexed_at Timestamp to all Elasticsearch indexes (#6913)
* add last_indexed_at to all Elasticsearch indexes

* use Time.zone.parse
2020-03-27 18:43:46 -04:00
Mac Siri
2c5e12268f
Implement authentication welcome notification (#6846) 2020-03-27 15:21:40 -04:00
Ben Halpern
d0a5c93684
[deploy] Fix fragment caching bug for SEO tag pagination. (#6917)
* Fix pagination caching and adjust logic

* Adjust range logic
2020-03-27 13:23:54 -04:00
Anna Buianova
ad26176828
Removed unused pages code (#6908) 2020-03-27 13:22:40 -04:00
rhymes
9a0a6fbe8f
Remove unused columns from articles (#6860) [deploy]
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-03-27 17:04:13 +01:00
Ben Halpern
e35d55c422
Add pagination to tag pages for better SEO crawling (#6771) [deploy]
* Add pagination to tag pages for better SEO crawling

* Modify system specs

* Add some tests

* Finalize tests

* Fix things up

* Add url helpers
2020-03-27 10:34:42 -04:00
rhymes
d03c751c65
Rubocop fixes (#6904)
* Run rubocop -a

* Regenerate rubocop todo

* Fix Lint/UselessAssignment

* Fix RSpec/RepeatedDescription

* Fix Style/GuardClause

* Fix Style/NumericPredicate

* Regenerate rubocop todo
2020-03-27 15:30:59 +01:00
rhymes
0374f2d101
Remove unused columns in display_ads (#6859) 2020-03-27 10:05:46 +01:00
Jacob Herrington
38d56542eb
[deploy] Moderator and admin actions log (#6797)
* Add audit logging for negative reactions

This change saves requests that create negative reactions to the audit
log. We need to be monitoring admin and moderator actions throughout the
app to increase visiblity on how our tools are being used and identify
abuse.

Additionally, this will help east concerns about giving elevated users
more powerful tools.

* Add a basic UI for moderator audit logs

* Log experience level ratings

* Log tag adjustments

* UI tweaks for moderator actions log

* Add logging to internal reactions controller

* Add logging for admin actions on users and articles

* Add searching to the moderator actions table

* Move audit instrumentation out of concern

We are able to use a PORO here instead of using a Rails concern. Moving
this also makes syntax to audit something quite a bit more explicit and
obvious to future developers

* Change moderator logs pagination page length

* Move auditing to after action filters

* Add moderator actions to the internal navbar

* Add request spec for internal moderator actions

* Use request params to populate AuditLog slug
2020-03-26 16:59:24 -05:00
Ben Halpern
320c92c759
Further restrict config read permissions (#6880) [deploy] 2020-03-26 17:37:39 -04:00
Ben Halpern
46b80329a9
Make notification hide correctly on click (#6895) [deploy] 2020-03-26 16:33:37 -04:00
Vaidehi Joshi
0cac312f32
Use dynamic community name rather than hardcoding "DEV" (#6893) 2020-03-26 15:38:49 -04:00
Andy Zhao
1a989bef07
[deploy] Add response templates to user settings (#6823)
* Add response templates controller, routes, and view

* Add response templates settings page

* Remove dead code

* Use proper variable oops

* Use proper indentation

* Use before action for checking current_user

* Remove index action temporarily

* Use url helpers for redirects

* Use form_with over form_tag and form_for

* Persist previous content if edit fails

* Use exists for performance

* Remove index spec and add CRUD specs

* Memoize @response_template

* Use workaround for sad paths b/c render doesn't work

* Refactor and extract permitted_attributes into var

* Use present over exists to preload into memory

* Use last over first

* Lint for codeclimate

* Use two redirects for happy and sad create path

* Remove proper index route oops

* Codeclimate comma sigh
2020-03-26 14:48:00 -04:00
Vaidehi Joshi
c12cea9b02
Allow users to opt-out of welcome notifications (#6852) [deploy]
* Update some test descriptions in notifications_spec

The descriptions of these tests didn't actually match the test's assertions!

* Add welcome_notifications column to users table

Also ensures that welcome_notifications cannot be set to `nil`.

* Show an opt-out message for Welcome broadcast notifications

* Add opt-out link to notifications + welcome notification box to settings

* Allow welcome notification subscription to be updated

* Add tests for unsubscribed to welcome notification users

Also refactor generator specs a bit.

* Fix up paths, copy, tests

Use rails path helpers instead of hardcoding paths. Improve copy in a few locations.
2020-03-26 11:26:19 -07:00
Molly Struve
84a14aed0a
handle missing displayed_classified_listing for moderate views (#6881) [deploy] 2020-03-26 12:24:26 -05:00
Molly Struve
1be91d131f
show the nausea emoji when a vomit reaction is displayed (#6882) 2020-03-26 12:21:27 -05:00
ludwiczakpawel
209c01037a
Crayons'ifizing Header (#6780) [deploy]
* add tons of colors

* add tons of colors

* moving cheese around and prepping for new theming system

* documenting

* .

* moving theme code to own files

* replacing some variables

* whitespaces

* replacing another batch of variables

* get rid of another variable

* replace loading animation variable with one-fits-all-sizes

* get rid of theme-anchor-color

* remove code colors variables

* another batch of variables replaced

* mostly bringing in variables for haxor theme

* remove invert-image variable for chat

* remove another inver-image variable

* forgot to remove reaction-background variable

* remove border variable

* series

* .

* remove another variable

* remove another variable..

* another batch of variables

* and more...

* header updates

* i forgot to commits things in my PR....

* fix border

* .

* simplifyuing placeholder

* responsiveness

* responsive

* search fix

* fixing prefix-less classes

* increase clickable area

* small style updates for pink theme

* tests

* Fix test

* responsive dropdown

* tiny fixes

* generator rewritten

* dropdown reworked a little

* adjustments

* fix pwa

Co-authored-by: rhymes <rhymesete@gmail.com>
2020-03-26 12:21:53 -04:00
Nick Taylor
749ee2a946
Added crayon.scss to Storybook. (#6853) 2020-03-26 12:27:54 +01:00
Ben Halpern
bc6a2f14c2
Revert rating_votes_count removal (#6851) 2020-03-25 18:20:09 -04:00
rhymes
30d9acf92e
Ignore unused display_ads columns (#6785) 2020-03-25 17:59:53 -04:00
rhymes
f1167be64c
Ignore unused articles columns (#6781)
* Ignore unused article columns

* Remove usage of ignored columns
2020-03-25 17:48:42 -04:00
rhymes
cf94d0ba98
Remove unused columns from display_ad_events (#6806) [deploy] 2020-03-25 17:47:05 -04:00
Alex
129cd3ba83
Log Elasticsearch index counts to Datadog (#6845) [deploy] 2020-03-25 15:52:54 -05:00
Jacob Herrington
7d30463464
Increase the number of negative reactions per page (#6840)
After looking at this UI in production, I realized that showing only
five negative reactions per page was way too few! Bumping this up to 25
which I feel is more reasonable.
2020-03-25 14:18:24 -04:00
rhymes
cfb64a1c68
Add URL module and article_url, user_url helpers (#6833)
* Add AppURL with .article and .user

* Use URL.url and URL.user

* Add article_url and user_url helpers
2020-03-25 13:54:45 -04:00
Molly Struve
94c7bd3a95
return default aspect ratio of 1 if gif id is not present and refactor (#6837) [deploy] 2020-03-25 11:21:47 -05:00
Molly Struve
3f33d6c376
Allow user, feed, and classified listing searches even when users are not logged in (#6819) 2020-03-25 11:20:13 -05:00
Molly Struve
5e28bbc133
Filter source when returning feed content docs (#6834) 2020-03-25 11:17:24 -05:00
Molly Struve
7724500bc5
notify honeybadger of js error when it occurs selecting a theme template (#6832) [deploy] 2020-03-25 09:28:42 -05:00
rhymes
88aa28eedf
Move App into app/lib (#6830) [deploy]
* Move App into app/lib

* Oops
2020-03-25 09:48:35 -04:00
Thomas Bnt
bac847805c
Edited bottom of .global-signup-modal--inner-a (#6824) [deploy]
More px to bottom on .global-signup-modal--inner-a class for small computers. Better design.
2020-03-24 20:36:33 -04:00
Mac Siri
84e84af8d7
Create Article#admin_published_with scope (#6794) 2020-03-24 18:15:43 -04:00
Ben Halpern
e3f91783c9
Add some margin above onboarding h2 (#6822) 2020-03-24 17:23:22 -04:00
rhymes
22822d448d
Add App.url and use it with Slack messengers (#6818)
* Add App.url

* Use App.url with Slack messengers
2020-03-24 17:22:09 -04:00
Jacob Herrington
c673b2bb6d
Internal: Add a table for negative reactions (#6751) [deploy]
* Add a table for moderator reactions

This is a simplified version of a feature that should be fleshed out
in the near future.

Despite the fact that this project is taking a new direction, I think
this table could be useful in the meantime.

* Add specs for internal mod actions view

* Rename mod actions to negative reactions
2020-03-24 16:08:24 -04:00
Nick Taylor
1de0f6fbab
Fixed onboarding primary button color (#6796) 2020-03-24 15:58:06 -04:00
Nick Taylor
8b82de8118
Replace clearTimeout with clearInterval. (#6820) 2020-03-24 15:55:10 -04:00
rhymes
e9e4059ad3
Add Slack messengers: part 1 (#6748)
* Add Slack::Announcer and SlackClient

* Add Slack::Messengers::Feedback class

* Use Slack::Messengers::Feedback and refactor test

* Should not raise an error if params are nil, let the job fail

* Add Slack::Messengers::Sponsorship

* Rename spec

* Use Slack::Messengers::Sponsorship

* Add Slack::Messengers::PotentialSpammer

* Use Slack::Messengers::PotentialSpammer

* Add Slack::Messengers::RateLimit and use it

* Refactor a bit and improve tests

* Add Slack::Messengers::Note and use it

* Use Slack::Announcer and fix spec

* Fix specs

* Update app/services/slack/announcer.rb

Co-Authored-By: Vaidehi Joshi <vaidehi.sj@gmail.com>

* Implement review suggestions

* Empty commit to trigger Travis

Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
2020-03-24 18:45:40 +01:00
Ben Halpern
ba18f8e481
Include crayons style tag on pages that load direct from css (#6816) 2020-03-24 13:17:54 -04:00