Ignore unused display_ads columns (#6785)
This commit is contained in:
parent
f1167be64c
commit
30d9acf92e
3 changed files with 11 additions and 8 deletions
|
|
@ -18,12 +18,16 @@ class DisplayAdEventsController < ApplicationMetalController
|
|||
return if Rails.env.production? && rand(20) != 1 # We need to do this operation only once in a while.
|
||||
|
||||
@display_ad = DisplayAd.find(display_ad_event_params[:display_ad_id])
|
||||
|
||||
num_impressions = @display_ad.display_ad_events.where(category: "impression").size
|
||||
num_clicks = @display_ad.display_ad_events.where(category: "click").size
|
||||
rate = num_clicks.to_f / num_impressions
|
||||
|
||||
@display_ad.
|
||||
update_columns(success_rate: rate, clicks_count: num_clicks, impressions_count: num_impressions)
|
||||
@display_ad.update_columns(
|
||||
success_rate: rate,
|
||||
clicks_count: num_clicks,
|
||||
impressions_count: num_impressions,
|
||||
)
|
||||
end
|
||||
|
||||
def display_ad_event_params
|
||||
|
|
|
|||
|
|
@ -13,8 +13,6 @@ class DisplayAdDashboard < Administrate::BaseDashboard
|
|||
placement_area: Field::String,
|
||||
body_markdown: Field::Text,
|
||||
processed_html: Field::Text,
|
||||
cost_per_impression: Field::Number.with_options(decimals: 2),
|
||||
cost_per_click: Field::Number.with_options(decimals: 2),
|
||||
impressions_count: Field::Number,
|
||||
clicks_count: Field::Number,
|
||||
success_rate: Field::Number,
|
||||
|
|
@ -47,8 +45,6 @@ class DisplayAdDashboard < Administrate::BaseDashboard
|
|||
placement_area
|
||||
body_markdown
|
||||
processed_html
|
||||
cost_per_impression
|
||||
cost_per_click
|
||||
impressions_count
|
||||
clicks_count
|
||||
success_rate
|
||||
|
|
@ -65,8 +61,6 @@ class DisplayAdDashboard < Administrate::BaseDashboard
|
|||
organization
|
||||
placement_area
|
||||
body_markdown
|
||||
cost_per_impression
|
||||
cost_per_click
|
||||
published
|
||||
approved
|
||||
].freeze
|
||||
|
|
|
|||
|
|
@ -1,4 +1,9 @@
|
|||
class DisplayAd < ApplicationRecord
|
||||
self.ignored_columns = %w[
|
||||
cost_per_click
|
||||
cost_per_impression
|
||||
]
|
||||
|
||||
belongs_to :organization
|
||||
has_many :display_ad_events
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue