Commit graph

7158 commits

Author SHA1 Message Date
Molly Struve
b9000cb6a7
Uncomment Specs and Add additional Logging (#10989) 2020-10-21 15:56:29 -05:00
Mac Siri
fb67f13573
Refactor CarrierWave configuration (#11006) 2020-10-21 16:47:52 -04:00
Ben Halpern
7675379b6b
Fix honeybadger key typo (#10991) 2020-10-21 15:51:12 -04:00
Lisa Sy
a64b85ff5e
Update [Rate Limit] form fields with crayons and add TITLE (#10858) [deploy]
* Update form fields with crayons and add TITLE

* Fix merge conflicts and merge w master
2020-10-21 12:43:01 -07:00
Peter Frank
92f6460ce7
[deploy] Remove "mac" from reserved words (#11003)
Special request for a Forem Admin who wants their first name
2020-10-21 15:35:54 -04:00
Julianna Tetreault
0b2fb08e32
Adds a constant, SVG_PLACEHOLDER, to site_config.rb (#11001) 2020-10-21 15:28:02 -04:00
Andy Zhao
60b18d1a80
Add Mailchimp API Key to Site Config Form (#10995)
* Add Mailchimp API key to config show page

* Update description for newsletter id
2020-10-21 13:19:54 -04:00
Jacob Herrington
35648a696c
Add a link to the Forem Admin Guide to /admin (#11000) 2020-10-21 12:13:41 -05:00
Julianna Tetreault
cfbb5a1763
Standardize Image Placeholder Text in SiteConfig (#10992) [deploy]
* Standardizes image placeholder text in SiteConfig

* Adjusts image placeholder text URL per review suggestion

* Pulls image placeholder text out into a constant, IMAGE_PLACEHOLDER
2020-10-21 10:57:27 -06:00
Josh Puetz
4b33e08003
User better admin detection for blazer and feature flags (#10999) [deploy] 2020-10-21 11:56:07 -05:00
Jacob Herrington
f52aaa3610
[deploy] Add a simple image uploader partial (#10884)
* Add a simple image uploader partial

* Trigger Travis CI

Co-authored-by: rhymes <rhymes@hey.com>
2020-10-21 16:41:50 +02:00
Ben Halpern
5828b8f38d
Fix admin link (#10985) 2020-10-21 10:34:59 -04:00
Ben Halpern
a6923d530b
[deploy] Add interface for feed number config (#10969)
* Add interface for feed number config

* Fix tests

* Allow list values

* Fix lint
2020-10-21 09:01:00 -04:00
Ben Halpern
ae59bedb55
Fix spec that relied on hardcoded number (#10983) 2020-10-21 08:41:06 -04:00
Michael Kohl
87c89d8915
Make profile fields without user columns work (#10978) 2020-10-21 08:17:35 -04:00
ludwiczakpawel
1570d0cf0a
form fix (#10982) 2020-10-21 08:16:55 -04:00
Elliot
6a1f560f65
[deploy] Fix dropdowns breaking after adding comment (#10976)
What was wrong?
`initializeCommentDropdown` is called when a new comment is added.
`initializeCommentDropdown` calls `addDropdownListener(dropdown)` on all
`.dropbtn` elements. Elements with the `.dropbtn` class already exist on
the page so an extra listener is added to it whenever a comment is
added.

How was it fixed?
Whenever a dropdown listener is added to an element with the
`.dropbtn` class, an attribute is set on that element so we know it
already has a dropdown listener. When we add listeners to elements with
the `.dropbtn` class in the future, we don't add them to elements with
the attribute.
2020-10-21 08:15:10 -04:00
benhalpern
3126e508f7 Make basic posts query rely on SitConfig value 2020-10-21 08:11:54 -04:00
Alex Timofeev
ae67e17678
Fill organization userpic background fully to avoid empty corners (#10944)
* Fill organization userpic background fully to avoid empty corners

* Reset `.crayons-logo` ::after pseudo element content

So the barely visible border is hidden for profiles
2020-10-21 12:11:41 +02:00
Ridhwana
dae7565652
feat: add the social media back (#10981) 2020-10-21 11:53:13 +02:00
Molly Struve
84d986a839
Spec Fix:Ensure Nav Link Names are Escaped for Assertion (#10975) 2020-10-21 11:18:29 +02:00
Ben Halpern
7ba7529e4f
Remove social icons from user liquid tag (#10977) 2020-10-20 21:58:22 -04:00
Mac Siri
68c6205534
Prefer inline svg over image_tag in User Liquid (#10970) 2020-10-20 21:35:17 -04:00
Ben Halpern
dc91840a71
Small adjustment to blackbox.rb (#10961) 2020-10-20 21:14:56 -04:00
Ben Halpern
f428aa85fc
[deploy] Remove unnecessary email call-to-action (#10972) 2020-10-20 19:19:50 -04:00
Jacob Herrington
173e79bdfa
Add a button to delete pages (#10971) 2020-10-20 17:49:17 -05:00
Andy Zhao
5d9d1525d2
[deploy] Fix Basic Feed Issues (#10958)
* Add configurable field for tag minimum feed score

* Use basic feed algorithm for Forems w/ basic

* Don't use cached value for Forems w/ basic feeds

* Revert "Use basic feed algorithm for Forems w/ basic"

This reverts commit f07853c2d5b28592aeae57f9f0313cba5aa6526e.

* Use a configurable hotness score

* Add a discussion comment

* Adjust tag feed min score default to 0

* Revert change to use original 7 score

* Use home feed minimum score

* Update app/controllers/stories_controller.rb

* Update app/controllers/stories_controller.rb

* Update app/controllers/stories_controller.rb

* Update app/controllers/stories_controller.rb

* Update app/controllers/stories_controller.rb

* Update app/controllers/stories_controller.rb

Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
2020-10-20 17:42:28 -04:00
Molly Struve
70725665ac
Bug Fix:Fail Release Phase if a Migration Fails (#10968) 2020-10-20 17:41:25 -04:00
Molly Struve
3cc9b20b4f
[deploy] Optimization:Upgrade Puma to 5.0.2 (#10928) 2020-10-20 16:33:52 -05:00
Jacob Herrington
ef90f1c781
Make 404 page generic (#10962) 2020-10-20 16:30:37 -04:00
Ben Halpern
467e99556c
[deploy] Fix tag display bug and crayonsify area (#10868)
* Fix tag display bug and crayonsify

* Fix some specs

* Remove unused tag js

* Adjust to remove crayons card bg

* Adjust padding

* add spacing below nav

* drop unnecessary classname

* cleanup headers

* links

* Finalize style and add hint to eliminate div jump

Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2020-10-20 16:07:17 -04:00
Jacob Herrington
c3a98db026
Make default admin a super admin (#10966) 2020-10-20 13:22:01 -05:00
Tudor Pavel
fa39a7e352
Use matched substring in Spotify liquid tag to avoid trailing whitespace (#10953) 2020-10-20 13:38:33 -04:00
Molly Struve
930e546529
Comment out Flaky User Views Article Date Specs (#10965) 2020-10-20 12:11:46 -05:00
Rafi
e3076a0852
[deploy] Removing hard-coded email (#10125)
* Removing hardcoded email

* Passing email address from siteConfig to react

* Passing modFaqEmail props in tests

* Changing webpacker compiler order
2020-10-20 18:59:51 +02:00
dependabot-preview[bot]
526af8915e
[deploy] [Security] Bump object-path from 0.11.4 to 0.11.5 (#10960)
* [Security] Bump object-path from 0.11.4 to 0.11.5

Bumps [object-path](https://github.com/mariocasciaro/object-path) from 0.11.4 to 0.11.5. **This update includes a security fix.**
- [Release notes](https://github.com/mariocasciaro/object-path/releases)
- [Commits](https://github.com/mariocasciaro/object-path/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Trigger Travis CI

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: rhymes <rhymes@hey.com>
2020-10-20 18:56:14 +02:00
Lisa Sy
422f41c535
Update admin/config fields to use Crayons (#10874)
* Update API tokens

* Update to Crayons on majority of sections in All Site Configuration

* Undo weird linting issues and continue to add crayons styling to Mascot and Images

* Update confirmation box

* Refactor empty state
2020-10-20 12:49:52 -04:00
Molly Struve
330d849759
[deploy] Spec Fix:Add Fragment to test html (#10963) 2020-10-20 11:40:42 -05:00
Julianna Tetreault
a6aabb2149
Give Admins Ability to Delete Invitations (#10959)
* WIP: Gives Admins the ability to delete invitations from /admin/invitations

* Refactors #destroy to properly delete invites, redirect, & display messages

* Adds additional flash message and makes existing messages more explicit

* Adds spec to test the deletion of invitations in admin/invitations
2020-10-20 12:07:36 -04:00
Ridhwana
d2db2f683d
[deploy] Disable ability to upload videos on *some* forems Part 2 (#10955)
* feat: set the showing of the upload button on when enable_video_upload is true

* oops same here

* spec: test that the links shows and hides appropriately with enable_video_upload added

* suggestions

* chore: revert changes and make enabled its own method
2020-10-20 17:33:35 +02:00
PrimeNoodles
ff68888a04
Mod Center: clicking on article title opens a in new tab (#9314) 2020-10-20 11:23:04 -04:00
Ben Halpern
08acaaf19d
Add admin index (#10957)
* Add admin index

* Fix linting

* Fix linting
2020-10-20 11:11:28 -04:00
Julianna Tetreault
2075a021fa
Data update Script: Backfill Created, but Unregistered Users (#10939) [deploy]
* Adds a data_update script to backfill registered for created, unregistered users

* Checks that invitation_accepted_at is nil and modifies return placement

* Removes user.created_at.nil check from data_update script

* Removes gaurd clause and fetches users from DB
2020-10-20 08:47:11 -06:00
Tudor Pavel
65336d6ff3
Fix RSpec unit testing when using Docker dev setup (#10950) 2020-10-20 10:36:41 -04:00
rhymes
1f562783fc
Fix new Rubocop violations (#10808)
* Fix new Rubocop violations

* Use the latest minor version of 0.93
2020-10-20 09:28:53 -04:00
anks
1ca6f56cce
Add notification aliases to user model #6892 (#10892)
Co-authored-by: Anna Anks Nowak <matisnape@users.noreply.github.com>
2020-10-20 09:28:07 -04:00
Tudor Pavel
52cf81624e
Preserve newlines and indentation in <pre> tags from RSS import (#10922) 2020-10-20 09:25:57 -04:00
Michael Kohl
9377eee4f5
[deploy] /profile/settings page rendering (Ridhwana/Michael) (#10733)
* chore: update the profile to be more dynamic. Maps out the group + field name   + value for field

* feat: add the correct input type to the form tying it to the correct method to update

* feat: update the value and the label

* feat: update the profile with a submit

* refactor: ensure we dont show empty groups on the settings/profile

* fix: this shoudl be dribbble

* fix: use attributes! to refresh the cache to ensure that we font run into the case where Profile.attributes is []

* feat: show group description only when it exists

* chore: add some classes

* feat: use the profile update service to update the relevant user information

* chore: rename variable

* chore: use a scope to not return empty groups

* fix: only update user if the profile sync is update is successful. Also capture errors

* feat: style the crayons field checkbox

* refactor: rename the attribute to user instead of profile

* refactor: service object

* Fix CodeClimate warning and rearrange code

* Fix service object, add missing attribute

* Fix flash and add redirect

* Fix service object + spec

* Fix user edits profile spec

* Disable spec

* Fix more specs

* Undo vim fail

* Add data update scripts

* Update where clause in data update script

* Rename method

* Make sync_to_user conditional

* Add after update actions and Honeycomb

* feat: handle checkbox allow chcekbox to check

* Don't set experience cookie in ProfilesController

* Clean up Profiles::Update object

* Fix spec

* Remove Twitch integration (#10732)

* Remove Twitch integration

* Ignore columns

* Change admin password in docs (#10735)

Update default admin password in documentation

* Do not require meta_keywords to be set (#10721)

* Remove extra character from meta_keywords in /listings/index.html.erb

* Remove meta_keywords from MANDATORY_CONFIGS

* Add and use meta_keywords_tag helper

* Use modern tag syntax instead of deprecated syntax

* Add and use meta_keywords_default helper

* Add and use meta_keywords_article helper

* Remove * from meta_keywords_field.label

* Update meta_keyword specs to account for no keywords being set

* Generalizes Connect welcome message and settings nav tab and refactors tests (#10741) [deploy]

* [deploy] fix: Clear chat input after Enter key submit (#10487)

* fix: Clear chat input after Enter key submit

* fix: Rename Composer component

* test: Add integration tests for input value

* After pressing Enter
* After clicking Send
* After clicking Save edit
* After clicking Close edit

* Remove tabindex of -1 on upload image input in the write a post editor (#10543)

* Remove tabindex of -1 on upload image input in the write a post editor

* Remove negative tabindex on image uploader's outer button

* Give tabindex of -1 to outer button on image uploader

* Update buttons.scss

* [deploy] Add recaptcha keys to as site-configurable keys (#10736)

* Add recaptcha keys to as site-configurable keys

* Add recaptcha to site config view

* Use site config key

* Make ReCAPTCHA tag optional if keys are blank

* Use proper capitalization of recaptcha

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>

* Refactor logic for readability

* Use proper capitalization of recaptcha

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>

* Use proper capitalization of recaptcha

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>

* Use proper capitalization of recaptcha

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>

Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>

* Add Section for Series/Collections (#10719)

* Add Section for Series/Collections

I added a small section in this area of the docs to share some information about collections/ series. 

There is not much information in the documentation about collections or series and I felt like this would be beneficial to others looking to help with the Series feature of the website.

* Updated wording of collections section.

* Articles API: filtering by tags (#3654) (#10614)

* Articles API: filtering by tags (#3654)

* Address CR comments (#3654)

* Add test case
* Move tests
* Update docs

* Use _any_ option for querying by tags (#3654)

* Move Imgproxy endpoint config to Images::Optimizer (#10742)

* Link Email Account creation UI to existing Create Account UI (#10746) [deploy]

* Conditional button to link to email accout creation

* Rename email signup state param

* Test for email account creation button scenarios

* Add forem meta tags (#10747)

* Add forem meta tags

* Add docs

* Update docs/technical-overview/compatibility.md

Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>

* Update docs/technical-overview/compatibility.md

Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>

* Update docs/technical-overview/compatibility.md

Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>

* Update docs/technical-overview/compatibility.md

Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>

* Remove Twitch-related columns from users table (#10750)

* [deploy] Long text goes outside cards (#10740)

* Add word-break to crayons-card

Add word-break to crayons-card this will allow words to be broken if the word is too long but will wrap normally otherwise.

* Use overflow-wrap: anywhere;

`break-word` is deprecated though `anywhere` does not work in IE

* Removes superfluous sign_in from users_onboarding_spec.rb (#10757) [deploy]

* [deploy] Allow glitch id starting with ~ (#10544)

* [deploy] crayons prep (#10737)

* Add DEV special case for following hiring tag

* Move image validation to Profiles::Update object

* spec: move over the tests for validating images

* Move follow_hiring_tag into the service object

Co-authored-by: Ridhwana <ridhwana.khan16@gmail.com>
Co-authored-by: Andrew Bone <AndrewB05@gmail.com>
Co-authored-by: Vaidehi Joshi <vaidehi.sj@gmail.com>
Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
Co-authored-by: Robin Gagnon <me@reobin.dev>
Co-authored-by: Manaswini <58681405+Manaswini1832@users.noreply.github.com>
Co-authored-by: Andy Zhao <17884966+Zhao-Andy@users.noreply.github.com>
Co-authored-by: Christopher Wray <53663762+cwray-tech@users.noreply.github.com>
Co-authored-by: Rafal Trojanowski <rt.trojanowski@gmail.com>
Co-authored-by: Mac Siri <mac@dev.to>
Co-authored-by: Josh Puetz <josh@dev.to>
Co-authored-by: Ben Halpern <bendhalpern@gmail.com>
Co-authored-by: Jacob Herrington <jacobherringtondeveloper@gmail.com>
Co-authored-by: irmela <irmela@berlin-coding.de>
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
2020-10-20 09:18:13 -04:00
Ridhwana
14f0f03aba
[deploy] feat: add a config to enable video uploads (#10954) 2020-10-20 14:31:39 +02:00
Tudor Pavel
cb8cb9b1a5
[deploy] Avoid CSS word wrap in video player duration (#10889)
* Avoid CSS word wrap in video player duration

* Trigger Travis CI

Co-authored-by: rhymes <rhymes@hey.com>
2020-10-20 11:20:52 +02:00