Suzanne Aitchison
b4b7d4bd39
Admin member index: invitations responsive layout ( #17278 )
...
* add expandable search control at mobile size
* add invitations smaller layout
* replace missing member image
* tweaks following merge
* minor layout tweaks
* add actions to smaller view, update cypress specs
2022-04-19 10:00:15 +01:00
Takuya N
3eee116104
Enable error tracking on sendFollowUser ( #17328 )
...
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
2022-04-18 22:13:31 -04:00
Takuya N
da06427cb6
Replace Git URL with the new one ( #17321 )
...
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
2022-04-18 22:12:51 -04:00
Takuya N
c36ba7b6de
Avoid redirection by replacing with newer URL ( #17320 )
...
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
2022-04-18 22:12:21 -04:00
Takuya N
1c9bc2d1ef
Replace links to the repo with newer URLs ( #17319 )
...
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
2022-04-18 22:11:31 -04:00
Anna Buianova
05d0464a78
Context Notifications ( #17243 )
...
* ContextNotification model
* Create and destroy context notifications when notifications are sent/unsent
* Added a transaction when creating notifications and context notifications
* Documentation for context notifications
2022-04-18 10:30:30 +03:00
Monica Mateiu
6818ef3ed0
Remove references to article.spaminess_rating ( #17235 )
...
* Remove references to article.spaminess
* Update app/models/article.rb
* Update spec/workers/comments/calculate_score_worker_spec.rb
Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
* remove unnecessary BlackBox spec
* Update spec/workers/comments/calculate_score_worker_spec.rb
Co-authored-by: Jamie Gaskins <jgaskins@hey.com>
* Remove references to calculate_spaminess
* Update app/workers/comments/calculate_score_worker.rb
Co-authored-by: Jamie Gaskins <jgaskins@hey.com>
Co-authored-by: Jeremy Friesen <jeremy.n.friesen@gmail.com>
Co-authored-by: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com>
Co-authored-by: Jamie Gaskins <jgaskins@hey.com>
Co-authored-by: Jamie Gaskins <jamie@forem.com>
2022-04-15 11:43:48 -04:00
Daniel Uber
b05d14dfcd
Update builder spec variable names ( #17302 )
...
* Update article builder spec
In #16536 the tests were updated to match a change in the
logic (rather than "needs authorization" the response was "store
location", and we checked for those values).
In #17294 we re-adjusted the meaning of the second returned value from
Articles::Builder.call, and the call sites now label the second value
as "needs_authorization" again.
Restore the same name to the call sites in the spec, and simplify the
example descriptions (this might be a mistake).
* Restore long example descriptions
This restores the names of the test cases to the original.
2022-04-15 09:44:14 -05:00
Jamie Gaskins
16c49a5df2
Escape user-supplied regex terms ( #17305 )
2022-04-15 10:18:16 -04:00
Takuya N
63c3229e36
Remove use of jQuery on admin config JS ( #17206 )
...
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
2022-04-15 07:13:00 -06:00
Suzanne Aitchison
e2232cd975
Admin member index: style the GDPR requests table ( #17287 )
...
* basic table styles added
* small layout
* Change done to deleted
2022-04-15 14:04:18 +01:00
dependabot[bot]
a25f33c258
Bump async from 2.6.3 to 2.6.4 ( #17300 )
...
Bumps [async](https://github.com/caolan/async ) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases )
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md )
- [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4 )
---
updated-dependencies:
- dependency-name: async
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-14 22:21:09 -04:00
dependabot[bot]
d8a6e98e4e
Bump flipper-ui from 0.24.0 to 0.24.1 ( #17301 )
...
Bumps [flipper-ui](https://github.com/jnunemaker/flipper ) from 0.24.0 to 0.24.1.
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.24.0...v0.24.1 )
---
updated-dependencies:
- dependency-name: flipper-ui
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-14 22:20:43 -04:00
dependabot[bot]
3f4937e01a
Bump flipper-active_support_cache_store from 0.24.0 to 0.24.1 ( #17297 )
...
Bumps [flipper-active_support_cache_store](https://github.com/jnunemaker/flipper ) from 0.24.0 to 0.24.1.
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.24.0...v0.24.1 )
---
updated-dependencies:
- dependency-name: flipper-active_support_cache_store
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-14 14:09:09 -06:00
dependabot[bot]
1c4841de67
Bump flipper-active_record from 0.24.0 to 0.24.1 ( #17299 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-14 14:38:20 -05:00
dependabot[bot]
f381373ede
Bump omniauth from 2.0.4 to 2.1.0 ( #17296 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-14 14:36:18 -05:00
dependabot[bot]
10deca59ea
Bump stripe from 5.49.0 to 5.50.0 ( #17295 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-14 14:34:37 -05:00
dependabot[bot]
4bbc9d43a4
Bump rack-attack from 6.6.0 to 6.6.1 ( #17298 )
...
Bumps [rack-attack](https://github.com/rack/rack-attack ) from 6.6.0 to 6.6.1.
- [Release notes](https://github.com/rack/rack-attack/releases )
- [Changelog](https://github.com/rack/rack-attack/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rack/rack-attack/compare/v6.6.0...v6.6.1 )
---
updated-dependencies:
- dependency-name: rack-attack
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-14 15:32:09 -04:00
Jeremy Friesen
3a37db7b30
Ensuring /new remains a call to action end point for DEV ( #17294 )
...
There are two problems engrained in this:
1. The undocumented expectation of `/new` needed to other sites linking
with prefill information.
2. The prefill parameters being lost during the authentication process.
The first bug was introduced as part forem/forem#16536 . The second is
likely introduced as part of a Rails upgrade (namely `request.path` most
likely once included the query parameters but with our current
implementation it does not).
Closes forem/forem#17292
2022-04-14 14:50:40 -04:00
Jeremy Friesen
f8590a6d84
Correcting public_reactions_count ( #17280 )
...
Prior to this commit, we were looking at trusted user's reaction
counts. This is not the desired column to be testing.
See
f1d6291d00/app/models/reaction.rb (L25-L28)Fixes forem/forem#17260
2022-04-14 13:31:07 -04:00
Ridhwana
2746e77fd5
Adding a modal for the CSV export ( #17259 )
2022-04-14 18:19:28 +02:00
Arit Amana
b08de775e5
implementation ( #17286 )
2022-04-14 10:26:48 -04:00
Ridhwana
2f811463d9
Attempt to fix a flakey test ( #17285 )
2022-04-14 16:02:56 +02:00
Julianna Tetreault
317b066853
Hide Role Badges from the Member Index View (for the time being!) ( #17282 )
...
* Comments out role bages in the Member Index View for the time being
* Further comments out #cascading_high_level_user_roles
2022-04-14 07:18:38 -06:00
Suzanne Aitchison
a903b7c904
commit lock file ( #17284 )
2022-04-14 08:52:30 -04:00
Julien Maury
01c1d44e65
Fix duplicate IDs on homepage ( #17092 )
...
* fix duplicate ID main nav
* fix duplicate ID other nav headings
* fix duplicate ID reading list count
* fix duplicate attribute class
* missing case readingCountList on feed
* missing dot in query selector
* Revert "fix duplicate ID other nav headings"
This reverts commit 4f495962c47e08f0f6c41e33e897b2db176432f5.
* use generic class 'other-nav' for tests
* pass a variable 'context' to the partial nav
* pass var 'context' to partial
* fix unwanted typo in partial sidebar
* Update app/views/admin/navigation_links/index.html.erb
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/assets/javascripts/initializers/initializeReadingListIcons.js
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update app/assets/javascripts/initializers/initializeReadingListIcons.js
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* js-reading-list-count renaming
* use data-testid instead of generic classes for tests
* fix typo in specs
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2022-04-14 10:48:55 +01:00
ludwiczakpawel
3a753cd7f6
one checkbox ( #17212 )
2022-04-14 10:51:40 +02:00
Suzanne Aitchison
a0a4b8a851
Member index (Phase 2) - Invitations actions ( #17213 )
...
* Add actions to invitations table
* table style tweaks
* add specs for cancel and resend actions
* rspec resend test
2022-04-14 08:26:36 +01:00
Suzanne Aitchison
3829e836a2
Admin member index - minor UI/a11y fixes ( #17246 )
...
* apply some missing classes
* sweep up minor UI and a11y issues
* add missing context locals in invitations view
2022-04-14 07:59:31 +01:00
dependabot[bot]
6959a265d6
Bump flipper from 0.24.0 to 0.24.1 ( #17281 )
...
Bumps [flipper](https://github.com/jnunemaker/flipper ) from 0.24.0 to 0.24.1.
- [Release notes](https://github.com/jnunemaker/flipper/releases )
- [Changelog](https://github.com/jnunemaker/flipper/blob/master/Changelog.md )
- [Commits](https://github.com/jnunemaker/flipper/compare/v0.24.0...v0.24.1 )
---
updated-dependencies:
- dependency-name: flipper
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-13 12:27:42 -06:00
Mac Siri
441a76972b
Refactor: Move onboarding routes out of UsersController ( #17189 )
2022-04-13 14:20:16 -04:00
Jeremy Friesen
f1d6291d00
Adding Feed Configuration documentation ( #17248 )
...
* Adding Feed Configuration documentation
This documentation outlines the scope and intention of the Feed
Configuration, it's primary purpose is to:
- Reference the historical context
- Establish a draft glossary
- Introduce high-level constraints
- Serve as a document to help with the task break-down
Closes forem/forem#17244
Relates to forem/forem#17245
Informs forem/forem-internal-eng#435
As a note, I'm looking at this document almost through the lens of
[literate programming][1]. In writing the document, I learned about and
attempted to describe the shape of this internal facing project.
Consider for a moment that we are not adding a new user facing feature
to the Forem code base. Instead we're scoping this project as helping
ease the experimentation process regarding the feed.
In other words the scope of this project is to help name and refine
different feed strategies to understand what each strategy means.
Eventually this could mean that creators and members can have a
future opportunity to select feed strategies that reflect the
aspirational community values of the feed (e.g. we want a feed that
favors comments, or neighborhoods, or the occassional serendipity).
[1]:https://en.wikipedia.org/wiki/Literate_programming
* Update config/feed/README.md
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update config/feed/README.md
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update config/feed/README.md
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
* Update README.md
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2022-04-13 13:04:25 -04:00
dependabot[bot]
8a6bd1076e
Bump @honeybadger-io/js from 3.2.8 to 3.2.9 ( #17257 )
...
Bumps [@honeybadger-io/js](https://github.com/honeybadger-io/honeybadger-js ) from 3.2.8 to 3.2.9.
- [Release notes](https://github.com/honeybadger-io/honeybadger-js/releases )
- [Changelog](https://github.com/honeybadger-io/honeybadger-js/blob/v3.2.9/CHANGELOG.md )
- [Commits](https://github.com/honeybadger-io/honeybadger-js/compare/v3.2.8...v3.2.9 )
---
updated-dependencies:
- dependency-name: "@honeybadger-io/js"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-13 13:01:42 -04:00
dependabot[bot]
3f3b13f382
Bump @testing-library/user-event from 13.5.0 to 14.1.0 ( #17253 )
...
* Bump @testing-library/user-event from 13.5.0 to 14.1.0
Bumps [@testing-library/user-event](https://github.com/testing-library/user-event ) from 13.5.0 to 14.1.0.
- [Release notes](https://github.com/testing-library/user-event/releases )
- [Changelog](https://github.com/testing-library/user-event/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/user-event/compare/v13.5.0...v14.1 )
---
updated-dependencies:
- dependency-name: "@testing-library/user-event"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
* refactor to account for breaking changes
* remove redundant cleanup
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
2022-04-13 10:41:08 -06:00
dependabot[bot]
8efb9f7110
Bump @storybook/addon-controls from 6.4.20 to 6.4.21 ( #17232 )
...
Bumps [@storybook/addon-controls](https://github.com/storybookjs/storybook/tree/HEAD/addons/controls ) from 6.4.20 to 6.4.21.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.4.21/addons/controls )
---
updated-dependencies:
- dependency-name: "@storybook/addon-controls"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-13 15:57:25 +01:00
Suzanne Aitchison
64ed2c6dec
move showModal helper into its own pack file ( #17266 )
2022-04-13 14:15:07 +01:00
Arit Amana
240893401d
Show a "Unable to login" message in browser when a user is unable to login. ( #17261 )
...
* implementation and modify spec
* oops! correct unwanted change
* nudge Travis
* nudge Travis
2022-04-13 09:00:56 -04:00
dependabot[bot]
94ab24ba34
Bump sass from 1.49.9 to 1.50.0 ( #17264 )
...
Bumps [sass](https://github.com/sass/dart-sass ) from 1.49.9 to 1.50.0.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.49.9...1.50.0 )
---
updated-dependencies:
- dependency-name: sass
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-13 06:39:42 -06:00
dependabot[bot]
cd85f2941d
Bump @storybook/addon-storysource from 6.4.20 to 6.4.21 ( #17256 )
...
Bumps [@storybook/addon-storysource](https://github.com/storybookjs/storybook/tree/HEAD/addons/storysource ) from 6.4.20 to 6.4.21.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.4.21/addons/storysource )
---
updated-dependencies:
- dependency-name: "@storybook/addon-storysource"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-13 11:58:02 +01:00
Daniel Uber
e28c130107
These two tests are time zone sensitive ( #17263 )
...
This follows the work in #17165 - the service test and this request
spec are exercising nearly identical timezone sensitive paths.
2022-04-12 18:02:58 -05:00
dependabot[bot]
4cb78aed1c
Bump @storybook/addon-links from 6.4.20 to 6.4.21 ( #17249 )
...
Bumps [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/addons/links ) from 6.4.20 to 6.4.21.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.4.21/addons/links )
---
updated-dependencies:
- dependency-name: "@storybook/addon-links"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-12 18:10:55 -04:00
Daniel Uber
e992d7db83
Add minimal test on rss feed response ( #17221 )
...
* Add minimal test on rss feed response
* Update date to string conversion to avoid deprecation
It wouldn't make sense to use a deprecated method here.
2022-04-12 16:59:40 -05:00
Ridhwana
44c9535d06
chore: typo ( #17258 )
2022-04-12 22:14:59 +02:00
Julianna Tetreault
760a51f5f7
Refactor Member Index View Users Query ( #17251 )
...
* Moves eager loading from _member_index view to Admin::UsersController
* Adds .registered to Admin::UsersQuery
2022-04-12 11:20:28 -06:00
dependabot[bot]
67fb6be5bc
Bump @babel/core from 7.17.8 to 7.17.9 ( #17254 )
...
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) from 7.17.8 to 7.17.9.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.17.9/packages/babel-core )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-12 11:48:48 -04:00
dependabot[bot]
10c47ce48c
Bump prettier from 2.5.1 to 2.6.2 ( #17255 )
...
Bumps [prettier](https://github.com/prettier/prettier ) from 2.5.1 to 2.6.2.
- [Release notes](https://github.com/prettier/prettier/releases )
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md )
- [Commits](https://github.com/prettier/prettier/compare/2.5.1...2.6.2 )
---
updated-dependencies:
- dependency-name: prettier
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-12 11:48:41 -04:00
Julianna Tetreault
471472d0b0
Add Internationalization to Admin::UsersController Success Messages ( #17252 )
...
* Adds internationalization to Admin::UsersController success messages
* Adds a new line at the end of en.yml and fr.yml
* Removes perriod from update_success message
2022-04-12 09:00:55 -06:00
dependabot[bot]
3e08e5ed0b
Bump @storybook/builder-webpack5 from 6.4.20 to 6.4.21 ( #17237 )
...
Bumps [@storybook/builder-webpack5](https://github.com/storybookjs/storybook/tree/HEAD/lib/core ) from 6.4.20 to 6.4.21.
- [Release notes](https://github.com/storybookjs/storybook/releases )
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md )
- [Commits](https://github.com/storybookjs/storybook/commits/v6.4.21/lib/core )
---
updated-dependencies:
- dependency-name: "@storybook/builder-webpack5"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-12 10:59:08 -04:00
dependabot[bot]
d6fdf97ee4
Bump preact from 10.6.6 to 10.7.1 ( #17250 )
...
Bumps [preact](https://github.com/preactjs/preact ) from 10.6.6 to 10.7.1.
- [Release notes](https://github.com/preactjs/preact/releases )
- [Commits](https://github.com/preactjs/preact/compare/10.6.6...10.7.1 )
---
updated-dependencies:
- dependency-name: preact
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-12 10:29:58 -04:00
dependabot[bot]
bdb687c252
Bump eslint from 8.12.0 to 8.13.0 ( #17247 )
...
Bumps [eslint](https://github.com/eslint/eslint ) from 8.12.0 to 8.13.0.
- [Release notes](https://github.com/eslint/eslint/releases )
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eslint/eslint/compare/v8.12.0...v8.13.0 )
---
updated-dependencies:
- dependency-name: eslint
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-12 10:28:07 -04:00
